Commit Graph

25277 Commits (bcaec009587b75e8391b1ca69d4fc1111f0457f3)

Author SHA1 Message Date
Mrugesh Mohapatra b663c39901 fix(donate): fix computed hours donated for monthly donation
Closes #37786
2019-11-20 12:15:00 +05:30
Mrugesh Mohapatra 65e5b26fa1 fix(donate): update default donation amounts
Closes #37787
2019-11-20 12:15:00 +05:30
Randell Dawson c25fa49b5b fix(curriculum): changed test text to use should for Coding Interview Prep - part 1 of 2 (#37765)
* fix: changed test text to use should

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: use singular of verb

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed punctuation

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test text

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-19 20:13:45 -05:00
Lowell Hamilton 301d03df7b Update add-font-awesome-icons-to-all-of-our-buttons.english.md (#37668)
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
2019-11-19 20:12:15 -05:00
Mo Zargham 437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753)
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
2019-11-19 19:54:48 -05:00
mrugesh 62aa54efba fix(donate): apply suggestions from code review
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-20 00:02:07 +05:30
Mrugesh Mohapatra 0bd66eaf82 chore: temporarily remove PayPal components
This commit should be reverted while implementing PayPal integration
2019-11-19 23:09:56 +05:30
Mrugesh Mohapatra f30f8072b0 chore(donate): unify donation config
This commit can be further optimised to DRY out values
2019-11-19 23:09:56 +05:30
Ahmad Abdolsaheb a5969ac0e5 fix(donate): update font to Lato on paragraphs 2019-11-19 23:09:55 +05:30
Mrugesh Mohapatra 1da1f7d0be fix(donate): re-order and scroll to top on processing 2019-11-19 23:09:54 +05:30
Mrugesh Mohapatra aeec1bb9e6 feat(donate): integrate servicebot 2019-11-19 23:09:53 +05:30
Mrugesh Mohapatra 2cb8c16b28 fix(donate): control plan creation with environment variable 2019-11-19 23:09:52 +05:30
Mrugesh Mohapatra 21b09b53cb fix(donate): adjust verbiage and time contibuted 2019-11-19 23:09:48 +05:30
Mrugesh Mohapatra f737b24b6f feat(donate): remove themes from donate pages 2019-11-19 22:28:05 +05:30
Mrugesh Mohapatra ef0a801c90 feat(donate): remove unauthenticated routes 2019-11-19 22:28:05 +05:30
Mrugesh Mohapatra e13f35171c feat(donate): updated donate page and plans
- [x] two column layout for the page.
- [x] amount to learning minutes mapping for contribution impact.
- [x] handle one-time and recurring stripe subscription charges.
- [x] server side validation of donate forms.
- [x] prevent multiple subscriptions and onetime donations per user.
2019-11-19 22:28:04 +05:30
Jefferson Oliveira 6921c3fecc updates text for the location of the button (#37764)
fixes the text describing the location of the logs button, due to the new design of the glitch.com website
2019-11-19 10:54:14 -06:00
Oliver Eyton-Williams febba792e7 fix: allow log in testString, restrict test errors
Console logs from testString get reported and test errors are sent to
the dev console (JS).

challenge building is only attempted if there is a build function to do
so.

Various functions have been renamed to better reflect what they do.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 9194b7731b fix: simplify logging and include console.log
This comes at the cost of creating a flash of the default message when
the preview updates, but significantly simplifies the code.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams beecb04c1a fix: report errors thrown after the frame is ready
Certain challenges involve code that is not run until the user
interacts with the preview (typically via a click listener). This uses
consoleProxy to report those errors.

Error logging has been simplified, reducing the number of places errors
can be reported from.

Some of the redux-saga code has been renamed in an attempt to improve
clarity.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 04d2de96df fix: conditionally log non-assertion errors (JS)
console.logs and errors are only reported during the first evaluation of
the user's code.  This is because the code is evaluated for each test,
but the logs will not change between the build phases of the tests.

Errors thrown during testing (except failing assertions) are always
reported. This is to inform the user that their code is faulty, rather
than that it does not meet the challenge's requirements.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 9a97d639f5 fix: add dynamic output for legacy challenges
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 64fcbbb491 fix: output console.logs as user types (JS) 2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 29641986ab fix: output console.logs as user types (DOM)
Any console.logs inside script tags will be written to the fcc console
as the user types.  DOM challenges only.

Also, DRYed out the main and test frame creation.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 6acab90cb6 fix: report user code evaluation errors
Errors thrown during evaluation of the user's code will now be reported.

JavaScript challenges will only report to the browser console and only
during testing.

DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams 5059d23600 fix: report all build errors to the fcc console
Previously only challenges with previews would inform the user of syntax
errors.  This extends that to all challenges and corrects the output
format so errors are clearer.
2019-11-19 22:23:57 +05:30
Arthur 890ce894cc fix: correct typos in incidence matrix instruction (#37779) 2019-11-18 16:34:23 -08:00
Lowell Hamilton 73943994ff Update add-font-awesome-icons-to-our-buttons.english.md (#37667)
Correct typo in instructions  -- says to add the "fa" class instead of the "fas" class.
2019-11-17 07:55:39 -08:00
Marco Valero fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. (#37772)
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
Tom 5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
bitrixtoday 07b74ab70b Improved translate russian language (#37647) 2019-11-15 22:36:52 +05:30
Randell Dawson 39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699)
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-15 10:14:54 -06:00
HoJeong Im 1fb202b742 fix(curriculum) - Add class box in json apis and ajax (#37725)
* Add class box in json apis and ajax

* Remove .box in id & add .box in seed code
2019-11-15 08:56:28 +01:00
Oliver Eyton-Williams 687c4fdb98 fix(client): add cache-busting hashes to chunks (#37746)
* fix(client): add cache-busting hashes to chunks

* fix: create cache-busting names for the workers

Prior to this PR the first webpack compilation gave the workers static
names.  This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.

In order for Gatsby to find them, the names are added to the
config directory.
2019-11-15 01:43:44 +05:30
Kiara Barias c4dc0b297f Switch statement example updated (#37757)
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
Oliver Eyton-Williams 2d647b1638 fix: reword devops guide (#37759) 2019-11-14 23:58:45 +05:30
Oliver Eyton-Williams c5d4bedda5 feat: add accessibility toggle
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip.  The mode now persists
between challenges.

If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
2019-11-14 22:17:13 +05:30
Oliver Eyton-Williams 265e383705 fix: allow username submission after failure
If the server rejects a username submission, the submit button became
stuck as disabled.  This ensures that new (valid) input will unlock the
button.
2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams e1236a0c15 refactor: use validate util in client 2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams e77408827a feat: add server-side username validation 2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams 7500c370b6 refactor: create common validation function 2019-11-14 22:16:24 +05:30
Randell Dawson 55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715)
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
Rohit Ambre 376b42637a Updated file names required in the challenge (#37737)
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
2019-11-11 22:04:38 -05:00
Quincy Larson e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
allison-strandberg 2c5453e3bd Clarify instructions (#37735)
Closes #37734
2019-11-11 16:48:51 +01:00
Subash Iglesias 385287838e fix(curriculum) - fixed function keyword not misspelled in debugging guide (#37711)
* [ FIXES ] - fixed function keyword not misspelled

* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added comment back into example code
2019-11-11 07:37:11 -06:00
Tom 6ff5e52b2d Improve viewport unit readability (#36673)
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
2019-11-11 10:24:02 +01:00
Matheus Genteluci 67e0f33a89 feat: Add Solution to handle click event - English (#37069) 2019-11-11 09:19:28 +01:00
Marco Valero f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description (#37730)
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
jotagarciaz 84d683940a docs: improving spanish translations (#37593) 2019-11-10 10:42:27 -08:00