* fix(client,server): usernames should not be a http error code
* feat: reject invalid chars first
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Implemented pagination on timeline
* Made requested change and removed outline from button
* fix: PropTypes and off-by-one error
* Keep buttons centered in all cases and give fixed height timeline table rows to prevent jerk while changing pages
* First and last page navigation and margin issue fix.
* Explicitly importing specific lodash functions
* Refactored timeline pagination into a separate file.
* Refactored timeline to have total Pages as prop and made text corrections.
* Added proptypes for total pages
* made changes to setState call for lastPage
* Made a11y changes
This commit updates the layouts and the styles to be consistent with the rest of the application. This also ensures now that the gatsby navigation is used for smoother transtions.
* fix: broken Read-search-ask link now point to correct url
* fix: changed link to original forum link with more views
* fix: changed http links to correct version
* fix: link in help modal
- [x] two column layout for the page.
- [x] amount to learning minutes mapping for contribution impact.
- [x] handle one-time and recurring stripe subscription charges.
- [x] server side validation of donate forms.
- [x] prevent multiple subscriptions and onetime donations per user.
Console logs from testString get reported and test errors are sent to
the dev console (JS).
challenge building is only attempted if there is a build function to do
so.
Various functions have been renamed to better reflect what they do.
Certain challenges involve code that is not run until the user
interacts with the preview (typically via a click listener). This uses
consoleProxy to report those errors.
Error logging has been simplified, reducing the number of places errors
can be reported from.
Some of the redux-saga code has been renamed in an attempt to improve
clarity.
console.logs and errors are only reported during the first evaluation of
the user's code. This is because the code is evaluated for each test,
but the logs will not change between the build phases of the tests.
Errors thrown during testing (except failing assertions) are always
reported. This is to inform the user that their code is faulty, rather
than that it does not meet the challenge's requirements.
Any console.logs inside script tags will be written to the fcc console
as the user types. DOM challenges only.
Also, DRYed out the main and test frame creation.
Errors thrown during evaluation of the user's code will now be reported.
JavaScript challenges will only report to the browser console and only
during testing.
DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
Previously only challenges with previews would inform the user of syntax
errors. This extends that to all challenges and corrects the output
format so errors are clearer.
* fix: make help button use subforum topics
* fix: add test to check that block exists
Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: improve error message
* Update curriculum/test/test-challenges.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix(client): add cache-busting hashes to chunks
* fix: create cache-busting names for the workers
Prior to this PR the first webpack compilation gave the workers static
names. This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.
In order for Gatsby to find them, the names are added to the
config directory.
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip. The mode now persists
between challenges.
If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
* [ FIXES ] - fixed function keyword not misspelled
* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added comment back into example code
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.
We sould be adding comprehensive tests to the components instead.
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.
The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
* feat: download solution as non-json text file
* fix: added missing end of line character
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Derryk Boyd
Oliver Eyton-Williams
mrugesh
Ahmad Abdolsaheb
Tom
Mathew Joseph
Mrugesh Mohapatra
Mo Zargham
Subash Iglesias
jasonranney
lasjorg
Kirankumar Ambati
imgbot[bot]
Abdelrahman Ashraf
Randell Dawson
Kishore Devaraj
Nirvin M