Commit Graph

715 Commits (c49aee9edce27a18d84383f1fca6e637fd350616)

Author SHA1 Message Date
Randell Dawson 8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Tom 52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
SomeDer 5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Oliver Eyton-Williams 3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
sybiljasmine 5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Kaitlin 76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
Ezgi Kaysı Kesler 93360f4e01 fix:Typo in uncomment-html page (#36800)
* fix:Typo in uncomment-html page

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md

removed comma

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-09-18 10:51:55 -07:00
Jasper Pilgrim 191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Huyen Nguyen 087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Tom 91dc86fbf0 fix(curriculum): update debugging challenge (fcc vs browser console) (#36703)
* fix: debugging-challege+difference-in-consoles

* fix: grammar

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-comments-for-first-test
2019-08-30 15:31:57 -07:00
Sahil Bondre 335600d91c fix: change the explanation of splice function (#36721) 2019-08-30 13:59:56 +02:00
Tom 428ab97650 Fix/tests whitespace strictness (#36706)
* fix(tests): make less strict about white space
2019-08-28 10:53:17 +02:00
Tom 46d67deb46 fix(test): make less strict about whitespace (#36705) 2019-08-28 10:48:57 +02:00
Tom 07b38d02b3 fix(challenge-test): make semi-colon optional (#36704) 2019-08-28 06:22:47 +05:30
Tom 742a21345d fix(take-home-projects): Remove paragraphs with bad links (#36702) 2019-08-27 20:02:12 -04:00
Randell Dawson 316503bfaa fix: added forumTopicId to new challenge (#36609) 2019-08-21 11:20:05 -05:00
Lauren Van Sloun 4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
Ai-Lyn Tang 24b3bed83f fix: add link to boilerplate Glitch file (#36340)
* Add link to boilerplate Glitch file

The boilerplate link is hard to see in the previous "introduction" page. I was using the old Glitch project link, and was confused.

When I googled for a solution, it was clear than others had also been quite confused. I believe this additional instruction will help many people.

* Direct people back to introduction page

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove unnecessary indentation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add empty line to fix markdown link

Markdown link needs a blank line to render correctly

* fix: add extra line to prevent linting error

* fix/remove-bullet-points


Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Tom <tmondloch01@gmail.com>
2019-08-18 20:27:54 +05:30
rns350 1ad3abd50f feat(curriculum); added another challenge to help teach recursion (#35966)
* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
2019-08-15 20:07:15 +09:00
Oliver Eyton-Williams 44804abeb5 fix: Remove and update challenges with legacy methods (#36444) 2019-08-15 01:22:41 +01:00
Tiago Salema a305a3df9f componentWillReceiveProps is deprecated (#35894)
* componentWillReceiveProps is deprecated

Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed

* Removed also `componentWillReceiveProps`
2019-08-13 09:14:10 -07:00
SomeDer 01c8554adc 03-render-conditionally-from-props: use const (#36551) 2019-08-12 18:17:39 +05:30
SomeDer 4ff5e6eff6 Add code tag to test in extract-state-logic-to-redux (#36553) 2019-08-12 10:50:13 +02:00
happyhappyyay 7bb6aa7605 Typos fixed for readability (#36577)
* typo fixed

* fixed typos
2019-08-11 12:26:32 -05:00
joelzehring 992fc8f1bf Update generate-an-array-of-all-object-keys-with-object.keys.english.md (#36578)
Method should act on any passed parameter rather than the specific object named in this problem.
2019-08-11 11:42:19 -05:00
enrider 76bd5f4fc3 Issue #36564 update regex for spread operator (#36565)
* Issue #36564 update regex for spread operator

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-the-spread-operator-to-evaluate-arrays-in-place.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-08-06 14:56:48 -07:00
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson 3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
lasjorg 881be7121e fix(challenge): remove type coercion check for true and false return (#36519)
* fix(challenge): remove type coercion check for true and false return

* fix(challenge): use Chai methods for false/true check
2019-07-30 08:33:37 -05:00
mrugesh 91df817cfe
fix(guide) add stubs, update spellings and prepare for move (#36531)
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)

* fix: corrected file path to match curriculum

* fix: renamed to newer challenge name

* fix: added solutions to articles from challenge files

* fix: added missing .english to file name

* fix: added missing title to guide article

* fix: correct solution for guide article

* fix: replaced stub with hint

* fix: added space in Hint headers

* fix: added solution to guide article

* fix: added solution to guide article

* test: replaced stub with hint and solution

* fix: add Problem number: to title

* fix: changed generatorexponential to correct name

* fix: renamed knight's tour to knights-tour

* fix: updated guide article
2019-07-30 00:25:58 +05:30
Oliver Eyton-Williams e23c80a021 fix: remove assert messages from gamma function (#36530) 2019-07-29 17:38:29 +01:00
Randell Dawson 54a65d1bf0 fix: correct titles for 5 challenges (#36527) 2019-07-29 19:44:15 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson a7eb800450 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - Project Euler - 04 (#36418)
* fix: removed assert msg argument-4

* fix: remove double quotes surrounding testString code

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-07-27 07:34:19 -05:00
Randell Dawson 5cf3b458fa fix: removed assert msg argument-7 (#36421) 2019-07-26 21:48:23 -05:00
Randell Dawson 6e40dd2e50 fix: removed assert msg argument-6 (#36420) 2019-07-26 21:45:56 -05:00
Randell Dawson 71e873128a fix: removed assert msg argument-5 (#36419) 2019-07-26 21:41:55 -05:00
Randell Dawson 3e237f43ad fix: removed assert msg argument-3 (#36417) 2019-07-26 21:30:17 -05:00
Randell Dawson 399705a37a fix: removed assert msg argument-2 (#36416) 2019-07-26 21:26:37 -05:00
Randell Dawson 04f18e43f6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 02 (#36412)
* fix: removed assert msg argument

* fix: removed msgs surrounded by 2 single quotes

* fix: removed missing 2 assert msg arguments

* fix: remove msg surrounded by two single quotes

* fix: removed unnecessary assert msg args

* fix; remove msgs surrounded by double quotes

* fix: removed unnecessary assert msg args

* fix: remove unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: Restore expected values to assertions

* fix: remove assertion message

Co-authored-by: Vivek Agrawal <vivekmittalagrawal@gmail.com>
2019-07-26 14:24:52 +02:00
Randell Dawson d73b94133a fix: removed assert msg argument (#36415) 2019-07-25 17:44:15 +02:00
Randell Dawson 61baeb0cd6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 01 (#36410)
* fix: removed assert msg argument

* fix: remove msg surrounded by two single quotes

* fix: remove assert msg surrounded by double quotes

* fix: remove msg surrounded by double quotes
2019-07-25 08:56:32 +02:00
Randell Dawson a53d992613 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 01 (#36408)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed assert msg missed

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: correct indentation
2019-07-25 08:53:37 +02:00
Randell Dawson cbbfc08108 fix: removed more assert msg args (#36441) 2019-07-24 13:13:06 +01:00
Randell Dawson ee97fa4542 fix(curriculum): Remove additional unnecessary assert message argument from English Coding Interview Prep challenges (#36440)
* fix: removed more assert msg args

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-24 13:09:23 +01:00
Randell Dawson f2df76c099 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 (#36409)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed more assert msg args
2019-07-24 13:07:46 +01:00
Randell Dawson d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457)
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson 8e6c26f271 fix: removed assert msg argument (#36407) 2019-07-24 12:54:35 +02:00
Randell Dawson 87615d2a7b fix: removed assert msg argument (#36406) 2019-07-24 11:50:51 +02:00
Randell Dawson e763330fc3 fix: removed assert msg argument (#36405) 2019-07-24 11:42:26 +02:00
Randell Dawson 1fa0dcb1e1 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 04 (#36404)
* fix: rm assert msg OOP

* fix: rm assert msg regular expressions
2019-07-24 11:32:04 +02:00
Randell Dawson d78168f7db fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 03 (#36403)
* fix: rm assert msg basic-data-structures

* fix: rm assert msg intermed-algo-scripting

* fix: rm assert msg data-structures projects
2019-07-24 10:56:38 +02:00
Randell Dawson 5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
Oliver Eyton-Williams 55b5d22d68 fix: use rounding to fix floating point comparison 2019-07-22 17:10:54 +05:30
Oliver Eyton-Williams 6078081a3f feat: Add guide article and update its challenge (#36371)
* feat: Add guide article and update its challenge

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Stop hints from being hidden

* fix: Improve the wording.

* Update index.md

Fixed per suggestion

* Update index.md

Fixed per suggestion
2019-07-19 16:14:28 -05:00
Oliver Eyton-Williams b8593326b0 fix: remove guide linting and fix failing challenges 2019-07-19 15:30:17 +05:30
Oliver Eyton-Williams 7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326)
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Ashrith Reddy 8e9014214a made semi-colon on basic-javascript challenge optional. (#36465)
* made closing operator optional.

* truncated unnecessary regex
2019-07-18 08:07:17 -07:00
Randell Dawson e9212c61d2 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 01 (#36401)
* fix: rm assert msg basic-javascript

* fix: removed more assert msg args

* fix: fixed verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-13 08:07:53 +01:00
moT01 9ce8bbb4c0 fix/add-suggested-grammar-and-punctuation 2019-07-12 22:44:23 +09:00
moT01 d3cf6f42dd fix/grammar+punctuation 2019-07-12 22:44:23 +09:00
moT01 fa365a7f77 fix/capitalization-in-title 2019-07-12 22:44:23 +09:00
moT01 832cbc91b1 fix/the-mess-I-made 2019-07-12 22:44:23 +09:00
moT01 da254743cd feat/new-lessons-on-js-promises 2019-07-12 22:44:23 +09:00
Randell Dawson 73bdff45fd fix(curriculum): Added a Recursion challenge to the Basic JavaScript section (#35968)
* fix: added a recursion challenge

* fix: changed blockquote to triple backtick syntax

* fix: added an extra line to separate code section

* fix: renamed challenge and improved verbiage

* fix: added full path to challenge

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added closing )

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added missing comma and the word at

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing text for test case

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added note regarding startNum and endNum being same

* fix: wrapped parameter names with code tags
2019-07-12 13:40:50 +02:00
Randell Dawson db8098601e fix(curriculum): Remove unnecessary assert message argument from English Data Visualization challenges (#36424)
* fix: removed assert msg argument

* fix: corrected test text
2019-07-11 10:53:41 +02:00
lasjorg f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Greg Fletcher 61588df778 fixed grammar: removed middlewares (#36392)
* fix: Improved grammar

Replaced 'middlewares' to 'middleware functions'.  Middleware is an uncountable noun, just like 'software'.  No such word as 'softwares'

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-09 14:38:25 -04:00
Saad Monem d9cccd6d74 Fixed typos in description of challenge: "Use a Template Engine's Powers" (#36395)
* Fixed typos in template engine challenge

* Incorporated suggestions into updated description

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Incorporated new suggestion

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-07-09 14:36:47 -04:00
Tiago Salema e561953827 Removed deprecated lifecycle methods (#35895)
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
organicdude f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Fabricio Asfora Lira a32f719d3a Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge (#36186)
* fix: add test for input closing tag

* fix: add condintion to final syntax test

This wil test if there's any character after the input tag that isn't a white space

* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
Prashanth Ashok Ramkumar b68f752847 Adding solution for queue class (#36319) 2019-07-02 07:45:42 -07:00
Michał Kozłowski e05e17ce31 fix regexp to match require statement without .js extension (#36293) 2019-07-02 01:51:41 +05:30
Steven Failla 438e7d4c51 fixed testString to disallow any extra characters from passing. Also … (#35987)
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>

* fixed test so it won't pass if datetime attr is left blank

* fixed test so it will not pass if datetime attribute is left empty

* fixed error in testString where test would pass if user runs test right away

* added tear-down div to make test code look cleaner

* fixed merge conflict. added tear-down div to make code look cleaner

* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

improvement to test case where element should have closing tag.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fixed conflict in git

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
Tom 50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01 2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01 9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01 9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01 9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01 d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01 61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom 72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01 3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom 81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom 9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01 d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
moT01 21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
moT01 246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
Kris Koishigawa 1028310819 Changed bold to strong or code tags where possible 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3ce97bbd81 Fixing other problems from comments 2019-06-26 17:34:03 +08:00
Kris Koishigawa 0544554b00 Fix curly quotes 2019-06-26 17:34:03 +08:00
Kris Koishigawa a6ed1e51b7 Change links from http to https 2019-06-26 17:34:03 +08:00
Kris Koishigawa 32b24a3a20 Fixing merge conflicts 2019-06-26 17:34:03 +08:00
Kris Koishigawa ae49dfd376 fix(challenges): Fix merge conflicts convert seconds and towers of hanoi 2019-06-26 17:34:03 +08:00
Kris Koishigawa 14bcbac669 fix(challenges): Added blockquote to department numbers and fixed fractions in fractran 2019-06-26 17:34:03 +08:00
Kris Koishigawa aeb0dccb15 fix(challenges): Added left margin to blockquote footer in Babbage Problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 12d84e83a8 fix(challenges): Y problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 723ee2cfa5 W problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa a0e68a39a7 fix(challenges): V problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 74f70c19d8 fix(challenges): T problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 539e93d01b fix(challenges): The rest of the S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 442c9c291d fix(challenges): More S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa c752d57611 Added sorting algorithms 2019-06-26 17:34:03 +08:00
Kris Koishigawa 2053e99cd5 S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa df88daa482 fix(challenges): J problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 263d2c496b fix(challenges): I problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa a3fd1aa284 fix(challenges): H problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 537d1ed642 fix(challenges): G problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa abbfee1189 fix(challenges): Formatted F challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 1a56a5b0ae fix(challenges): Minor changes to D challenges. Add E challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 461155f7ef fix(challenges): Replaced image with svg in Cut a Rectangle 2019-06-26 17:34:03 +08:00
Kris Koishigawa da4999cb46 fix(challenges): Moved challenge instructions to instructions section 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3a7ac2c0c0 fix(challenges): Forgot to remove the space between the function name and first parenthesis 2019-06-26 17:34:03 +08:00
Kris Koishigawa bc1d2be822 fix(challenges): Added all D problems except Department Numbers 2019-06-26 17:34:03 +08:00
Kris Koishigawa d024b96a92 fix(challenges): Went back and fixed a missing A problem. Fixed C problems. 2019-06-26 17:34:03 +08:00
Kris Koishigawa f9f4048258 fix(challenges): Revert 24 game due to another PR being submitted 2019-06-26 17:34:03 +08:00
Kris Koishigawa 201c383148 fix(challenges): Fixed formatting for numbered and challenges starting with A 2019-06-26 17:34:03 +08:00
Tom 51b5defb7e fix/regex-upper-and-lower-bounds-tests (#36059)
* fix/regex-upper-and-lower-bounds-tests

* fix/add-solution-back

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-25 14:45:20 -07:00
Randell Dawson 3fa14df925 fix: renamed folder without starting dash (#36124) 2019-06-21 18:05:33 -04:00
Randell Dawson f53ca79890 fix: changed tests to allow other valid solutions (#36210) 2019-06-21 18:04:30 -04:00
Randell Dawson 63a0fa745b fix: improved tests to allow more valid solutions (#36193) 2019-06-20 17:09:46 -04:00
Randell Dawson a6afaf1eb6 fix(curriculum) - added new tests to prevent invalid solutions in the Remove Elements from a Linked List by Index challenge (#36168)
* fix: added new tests to prevent invalid solutions

* fix: corrected tests and added solution

* fix: added linked word

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added by one

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: removed duplicate code

* fix: changed verbiage

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:34:08 -04:00
Stan Choi a13d116aab fix(learn): Added solution for invert binary tree data structures challenge (#35922)
* fix: add solution for invert binary tree

* Fixed errors

* Used 2 spaces per request

* deleted images

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:28:37 -04:00
Andrew Zaw 6f4a9ed721 Reorganized instruction text on multiple challenges (#35912)
* Reorganized instruction text on multiple challenges

* Fixed spaces

* Fixed spaces again

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/add-elements-at-a-specific-index-in-a-linked-list.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added code tags
2019-06-20 13:16:31 -04:00
Daniel Simeonov 81d7127a5d Added solution for English/Data-Visualization/Hover-tod3-element (#36220)
* Added solution for English/Data-Visualization/Hover-tod3-element

* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element

* fix: added extra line to prevent linting errors
2019-06-20 09:49:47 -07:00
Stan Choi 204ece1c70 fix: Add Solution in Curriculum/Challenges/English/08/CodingInterviewProblems/DataStructures/CREATE_LINKED_LIST_CLASS.md (#35819)
* fix: add solution create linked list class

* fix: added extra line to avoid linting error

* fix: renamed some variables
2019-06-20 10:11:26 -05:00
Tina Wang f203273e3a Solutions for sorting algorithm challenges in Coding Interview Prep/Algorithms (#35905)
* added bubbleSort solution

* added insertionSort

* fixed spacing in bubbleSort

* added selectionSort

* added a test

* Fixed a reference to the array with the wrong array name in the solution

* fix: added extra lines to avoid linting errors

* fix: added comments back into seed
2019-06-20 10:03:31 -05:00
Oliver Eyton-Williams 2024e238fa feat(curriculum): Add basic recursion lesson (#36200)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
leodaher 0be75e4b39 feat(curriculum): Add fetch challenge to the current curriculum. (#36033)
* Add fetch challenge for the current curriculum
2019-06-18 00:19:33 +02:00
Michał Kozłowski 8b40da02a3 multiple ternary operator challenge - add note about code readability (#36269)
* fix multiple ternary operator challenge

* Fix a typo in multiple ternary operator challenger

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Fix a typo in multiple ternary operator challenge #2

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
adamthahir acbc07e0ff Fixed typo addressed in #36225 (#36227)
* Fixed typo addressed in #36225

* Updated as per discussion.
2019-06-15 13:02:01 +07:00
Mahesh Jaganiya 72aaddfc12 Improve Regex (#36078)
* Updated assert.match() to assert.equal()
2019-06-11 10:43:08 +02:00
anthonykyi 97f6b73a0e Added Binary Search Tree Challenge (#35907)
* Added Binary Search Tree Challenge

* fix yaml, fix solutions, fix tests

* Fixed recommended fixes
2019-06-10 23:35:21 -04:00
RIHANE ZAKARIA d86951f9c1 Added solutions for 3 challenges in English / data-structures (#35825)
* Solution for add-elements-at-a-specific-index-in-a-linked-list.english.md

* Solution check-if-an-element-is-present-in-a-binary-search-tree.english.md

* Solution for remove-elements-from-a-linked-list-by-index.english.md

* change indent level to 2 space for each level

* change indent level to 2 space

* change indent level to 2 space

* delete unnecessary new lines

* keep the same seed format , and delete unnecessary new lines

* delete unnecessary new lines

* fix: added review suggestions

* fix: Added link and code tags
2019-06-10 18:17:11 -04:00
Ugur Yilmaz 2a18b1a308 Consistency Update for label and input elements for last lessons (#36192)
* Updated to reflect the relationship between label and input elements

* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
Weibin Luo 8cb540fe85 fix: use lowercase for 'article' tag (#36222) 2019-06-09 07:47:09 -07:00
Oliver Eyton-Williams 43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00