Commit Graph

915 Commits (ca35f7eba19c79d90aaf605e7d57f2ea36acf1a3)

Author SHA1 Message Date
Mrugesh Mohapatra 0a19bf7d74 Merge pull request #9410 from JamesWorsnop/fix/replacingifelsechains
Fixing if/if else text in replacing if else chains with switch challenge
2016-06-27 17:51:05 +00:00
Arun 89d6edc55c Fix broken challenge links by renaming challenges 2016-06-27 23:11:02 +05:30
Jonathan 9fdeaee56c Merge pull request #9287 from erictleung/translate/palindrome-update
Add Spanish translation to Palindrome update
2016-06-27 16:47:34 +01:00
JamesWorsnop 4bd15acd40 Fixing if/if else text in replacing if else chains with switch challenge 2016-06-27 22:02:37 +09:00
Jonathan 81f1181fec Merge pull request #9230 from sahilkhurana19/fix/arraychallenge-renaming
Modified the challenge description for better understanding
2016-06-24 16:56:52 +01:00
sahilkhurana02 ccab2a41e5 Further explained the challenge with a minor change.
Further explained the challenge.

Modified the challenge description for better understanding

Reverted back previous changes and further explained the terminology.

Minor change
2016-06-24 21:04:58 +05:30
Arun 5d458289a7 Fix tests for getJSON challenge 2016-06-24 19:07:53 +05:30
qdr d1f810e56e Fix broken link to Introducing JavaScript Object Notation (JSON) (#9331)
This commit fixes the broken link to the correct challenge.
2016-06-24 12:05:18 +00:00
Mrugesh Mohapatra 8bf5b9f560 Merge pull request #9204 from vreynolds/fix/8979-record-collection
Add Test Case to Record Collection
2016-06-24 05:09:00 +00:00
Jonathan 0c6d8c5ac9 Merge pull request #9308 from sthodup1/fix/test-clarity
basicJavascript.json - Clarify testing criteria
2016-06-23 15:49:33 +01:00
Arun 89e7b2fb02 Fix redundancy in description 2016-06-23 15:11:12 +05:30
sthodup1 44b93c03d2 basicJavascript.json - Clarify testing criteria 2016-06-22 22:14:46 -05:00
Manish-Giri 74342fbb02 Fixed quotations in Record Collection 2016-06-22 21:54:22 -04:00
Jonathan Wong 3211f8339b Fix/rewrite-instructions (#8944)
Clarify Where Do I Belong to return positive val
2016-06-22 13:09:18 +00:00
Jonathan 965386ce78 Merge pull request #9264 from okputus/fix/camelCase-desc-fix
Improved instructions for understanding camelCase in variables challenge
2016-06-22 08:27:49 +01:00
Eric Leung d1a7365a7d Add Spanish translation to Palindrome update 2016-06-21 23:19:48 -07:00
Eric Leung dd69e3cb4d Add test to check .endsWith() in Confirm Ending 2016-06-21 23:11:29 -07:00
Oscar 81fd19e097 Edited basic-javscript.json to improve camelCase task description
Edited clarification statement with consideration to 'DRY'
2016-06-22 02:33:56 +00:00
Manish-Giri 5c4fe256bb Fixed naming in Where Art Thou 2016-06-21 20:45:34 -04:00
Stuart Taylor 80c40d0025 Merge pull request #9272 from brainyfarm/patch-1
Update basic-bonfires.json
2016-06-21 23:03:54 +01:00
BKinahan f7e9164297 Correct stringify to JSON.stringify 2016-06-21 16:04:35 +00:00
Akinseye Olawale 22245b42c1 Update basic-bonfires.json
Removed unnecessary repetition
2016-06-21 15:24:32 +01:00
Matthew Hargraves 8de734f610 fixed word blank instructions are unclear [challenge] 2016-06-20 18:12:30 +01:00
Eric Leung 3b8f29c9fa Clarify Escape Sequences in Strings challenge
- Add code tags into table
- Rewrite instructions for more applicable coding test
- Add more tests to be more specific on what you need to pass
2016-06-19 14:56:54 -07:00
LindsayBrown81 7504fdd528 fix/disambiguate-property-meaning, make JSON valid in basic-javascript.json #9096
Lines 4322-4323: made links HTML tags instead of markdown in the definitions I added for JSON and property.
Line 4324: added booleans and numbers back into the Data Structures and overall reduced number of words used in explanations.
Lines 4338 and 4343: removed quotes from integer value and boolean value because the JSON is valid without them.
Line 4502: specified what part of property the ID number is to reinforce that a property consists of a key (or name) and a value.
Lines 4505-4508: reworded the conditions to be more consistent and comprehensible, changed their order.
Line 4510: retitled Note to Hints and added two more hints.
Line 4543: changed from my first PR's suggestion of var collectionCopy = JSON.stringify(collection) back to var collectionCopy = JSON.parse(JSON.stringify(collection)).
2016-06-18 14:08:14 -04:00
Arun c5ce31cab6 Fix test for nest anchor within a paragraph 2016-06-18 18:00:20 +05:30
Arun 13aa17732b Add tests for change font-size challenge 2016-06-18 09:29:00 +05:30
Vera Reynolds e2760761fe added a check to record collection about pre-existing elements 2016-06-17 14:48:37 -05:00
sahilkhurana02 9cc127e193 Edited the test cases code to make sure the entire test cases are visible. 2016-06-18 00:56:41 +05:30
Jonathan 4185cce827 Merge pull request #9183 from sahilkhurana19/fix/array-challenge-description
Modified the description to make it a bit more clear.
2016-06-17 19:51:49 +01:00
sahilkhurana02 0c06d003f6 Fixed challenge description.
Modified the description to make it a bit more clear.

Fixed challenge description and moved the example code to its own independent line.
2016-06-17 23:53:00 +05:30
Arun Kumar c078527c84 Fix pop arrays challenge tests (#8959)
* Fix tests for pop arrays challenge
* Fix the first test
2016-06-17 17:30:57 +01:00
Stuart Taylor 2abacc251c Merge pull request #9144 from DealPete/fix/JSON
remove references to JSON.
2016-06-17 16:58:30 +01:00
Jonathan 0883acca06 Merge pull request #8884 from WillySchu/fix
Clarify description of change text inside an element using jquery
2016-06-17 16:11:11 +01:00
DealPete 69d73687a1 remove references to JSON.
change 'allows' to 'allow'
2016-06-17 11:03:26 -02:30
Stuart Taylor a0268372f2 Merge pull request #9098 from DealPete/fix/incorrectOutputChallenge
Fixed 'Write Reusable JavaScript with Functions' head and tail
2016-06-17 13:20:55 +01:00
Jonathan b0c13e0f94 Merge pull request #9174 from sahilkhurana19/fix/golf-code-description
Edited the basic challenge description in order to make the challenge easier t…
2016-06-16 18:21:56 +01:00
Jonathan 1002d9ece9 Merge pull request #9179 from luongthomas/fix/adding-palindrome-test
Add Test Case for Check for Palindromes
2016-06-16 18:20:12 +01:00
Jonathan 7c1b8f74db Merge pull request #9076 from robjloranger/fix__using-array-indices
fix for access array data with indices
2016-06-16 17:10:36 +01:00
luongthomas 42e6ede26f Added Palindrome test for _eye returning true. 2016-06-16 09:03:53 -07:00
sahilkhurana02 690711d21a Edited the basic challenge description to make the challenge easier to understand. 2016-06-16 18:06:33 +05:30
Berkeley Martinez b3189dab0d Revert "Fix/Change the Font Size of an Element" 2016-06-15 18:53:25 -07:00
Stuart Taylor 743bdeba7d Revert "Fix/Prefilter JSON" 2016-06-16 00:00:37 +01:00
Stuart Taylor 75a5e3147d Merge pull request #9086 from Bouncey/Fix/Prefilter-JSON
Fix/Prefilter JSON
2016-06-15 22:42:40 +01:00
Stuart Taylor 792bdf16d8 Merge pull request #9084 from Bouncey/Fix/Change-the-Font-Size-of-an-Element
Fix/Change the Font Size of an Element
2016-06-15 22:40:18 +01:00
Quincy Larson f82c1153ad remove the word simply from a couple challenges 2016-06-15 13:15:31 -07:00
robjloranger b87158f488 adjusted test 2016-06-14 16:41:55 -07:00
Eric Leung a2ae2270a3 Merge pull request #8900 from b2m9/fix/exclude-seven-digit-US-phone-numbers
Fix: exclude 7 digit numbers from US phone challenge
2016-06-14 08:22:19 -07:00
Bob Massarczyk 71d1574dc6 Fix: exclude 7 digit numbers from US phone challenge
- Add assert for 555-5555, expecting false
- Add assert for 5555555, expecting false
- Change RegEx solution to make area code mandatory
- Simplify RegEx matching
- Add test case to catch random, invalid chars
2016-06-14 12:55:06 +00:00
Eric Leung 96e83227c6 Merge pull request #9077 from alayek/fix/palindrome-language
Update Palindrome instructions
2016-06-13 22:34:28 -07:00
Jonathan dafa73b864 Merge pull request #8922 from tianz/fix/mdn-links
Fix MDN links
2016-06-13 19:28:52 +01:00
Kirushna bf40d95b53 Fixed typo for URL 2016-06-13 15:49:27 +05:30
Eric Leung 1ad7fef5d4 Merge pull request #8901 from Bouncey/FIX/Change-Text-Inside-an-Element-Using-jQuery
FIX/Change Text Inside an Element Using jQuery
2016-06-12 16:26:35 -07:00
Eric Leung 912f46ae04 Merge pull request #8896 from Bouncey/FIX-Comparison-with-the-Equality-Operator
FIX Comparison with the Equality Operator
2016-06-12 16:19:49 -07:00
Eric Leung 485b7677e7 Merge pull request #9105 from Bouncey/Fix/Link-to-External-Pages-with-Anchor-Elements
Fix/Link to External Pages with Anchor Elements
2016-06-12 16:10:26 -07:00
Stuart 936607d530 Fix/Link to External Pages with Anchor Elements 2016-06-12 11:42:46 +01:00
Stuart 3b27888abd Fix/Prefilter JSON 2016-06-12 11:26:20 +01:00
Stuart e27be1259a FIX/Change Text Inside an Element Using jQuery 2016-06-12 09:38:03 +01:00
Stuart b924560dba FIX Comparison with the Equality Operator 2016-06-12 09:26:13 +01:00
Brandon Kish 490446d17b Fix missing apostrophe in Basic JavaScript conditional challenge 2016-06-11 22:30:26 -04:00
Pasayadaan 64dd873008 Fix for access array data with indices
This is a buggy challange (#8843)

Updated description in
seed/challenges/01-front-end-development-certification/html5-and-css.json
to instruct "Create second <p> element after the existing <p> element"

fix for access array data with indices

use deep not-equal in first assertion
2016-06-11 11:05:11 -07:00
Stuart e857648f9f Fix/Change the Font Size of an Element 2016-06-11 06:14:33 +01:00
DealPete 84613ac864 Fixed 'Write Reusable JavaScript with Functions' head and tail 2016-06-10 19:30:04 -02:30
alayek 7764862082 Update Palindrome instructions 2016-06-10 23:05:43 +05:30
Jonathan 478997d3e8 Merge pull request #9064 from Pasayadaan/fix/challange-#8843
This is a buggy challange (#8843)
2016-06-10 14:46:13 +01:00
Pasayadaan dbbea5f2c5 This is a buggy challange (#8843)
Updated description in
seed/challenges/01-front-end-development-certification/html5-and-css.json
to instruct "Create second <p> element after the existing <p> element"
2016-06-09 21:59:30 -05:00
Junaid Ahmed aa8750e140 replaced comparison with strict equality operator 2016-06-09 16:26:39 +05:30
Eric Leung 9d19c8dd25 Merge pull request #8890 from Bouncey/FIX/Comparison-with-the-Inequality-Operator
FIX/Comparison-with-the-Inequality-Operator
2016-06-08 21:54:33 -07:00
Eric Leung f2d710c75c Merge pull request #9034 from crashuniverse/fix/challenge-record-collection-instructions
Add challenge instruction for valid array operations
2016-06-08 21:46:59 -07:00
Jonathan 113894e10c Merge pull request #9036 from joechan3/fix/firstTestInvUp
Reword first test description for Inventory Update challenge
2016-06-08 21:04:00 +01:00
Priya Ranjan Singh ac69c02109 add challenge instruction for valid array operations 2016-06-08 22:16:47 +05:30
Joseph Chan 2e50739b5d Reword first test description for Inventory Update challenge 2016-06-08 09:54:10 -06:00
Stuart 2098e49f6c Fix/Comparison with the Inequality Operator. 2016-06-08 16:30:05 +01:00
Jonathan d85464717a Merge pull request #9031 from NicolaFerracin/fix/write-better-instruction
Introducing Else Statement excercise - write clearer instructions
2016-06-08 16:19:19 +01:00
Eric Leung 45b8ec2c70 Merge pull request #8978 from crashuniverse/fix/challenge-jquery-selector-id
Modify regex to match jquery selector for spaces
2016-06-08 07:49:06 -07:00
nicolaferracin 9d924da97b Introducing Else Statement excercise - write clearer instructions 2016-06-08 14:18:28 +02:00
Eric Leung 12a4e46acf Merge pull request #8982 from daniel-chung/fix/assert-message
Clarify error message in basic-javascript challenge
2016-06-07 22:32:58 -07:00
daniel-chung dfb8c93d30 Clarify error message in basic-javascript challenge
Removes the enclosing parentheses in the second assert error message for the basic-javascript challenge 'Escaping Literal Quotes'.

Previous error message was:
Variable myStr should equal to (I am a "double quoted" string inside "double quotes").

The new error message is now:
Variable myStr should contain the string: I am a "double quoted" string inside "double quotes".
2016-06-07 21:16:05 -04:00
daniel-chung ba0798024e Add new test in basic-algorithm challenge
Creates a new test that checks situations where the solution returns 5 chunks (i.e., an array of length 5 whose elements are themselves arrays).
2016-06-07 20:48:20 -04:00
Jackson Kearl 7c3072842c Decrease whitespace dependencies in checkoffs
Change most `\s?` to `\s*\` in tests, to allow for multiple whitespace characters in places where whitespace does not matter.
2016-06-07 15:25:19 -07:00
Eric Leung 9c7d8d592c Merge pull request #8958 from arun1595/fix/remainder-challenge-tests
Fix tests for finding remainder in javascript challenge
2016-06-05 10:20:07 -07:00
Priya Ranjan Singh be21e704d7 modify regex to match jquery selector for spaces 2016-06-05 22:37:22 +05:30
Justin Richardsson 57f61de6af Merge pull request #8911 from Bouncey/Fix/Spinal-Tap-Case-Missing-Parenthesis
Fix/Spinal Tap Case Missing Parenthesis.
2016-06-05 07:35:56 -04:00
Manshant Singh Kohli ea112f7870 Fix typo in challenge:Use RGB values to Color Elements 2016-06-04 17:32:48 -07:00
Arun 54613cff19 Fix tests for finding remainder in javascript challenge 2016-06-05 00:28:13 +05:30
Jacob Bearden 7c5b27e608 fix small typo 2016-06-03 18:29:56 -06:00
Berkeley Martinez 6194182305 Merge pull request #8907 from QuincyLarson/fix/gear-up-challenge-sequence
Update the sequence of gear up challenges and make pledge copy clearer
2016-06-02 23:47:08 -07:00
Tian Zhou aee5d8612f Fix MDN links 2016-06-02 20:36:21 -07:00
Stuart 13f45027a4 Fix/Spinal Tap Case Missing Parenthesis 2016-06-02 11:53:48 +01:00
Quincy Larson beece89e67 Update the sequence of gear up challenges and make pledge copy clearer 2016-06-01 22:32:01 -07:00
Ramon Carroll 8d281f5617 Added further clarification to instructions regarding using templates. 2016-06-01 22:23:05 -05:00
Russ Otto 00d534345c Fixed issue #7015: Access Multi-Dimensional Arrays with Indexes
This commit clarifies the explanation and example for the Basic Javascript challenge "Access Multi-Dimensional Arrays with Indexes." The implemented fix was proposed by @erictleung in https://github.com/FreeCodeCamp/FreeCodeCamp/issues/7015#issuecomment-222345491
2016-06-01 12:24:29 -05:00
malayaleecoder ba9314593c Fix Friendly Date Range issue 2016-06-01 15:54:30 +05:30
Will Schumacher 1adc186abc Clarify description. 2016-05-31 21:36:34 -07:00
Mrugesh Mohapatra 2b0950cec1 Merge pull request #8865 from Salt7900/fix/num0_change
Change wording about a number not being positve
2016-05-31 04:07:50 +00:00
Salt7900 df294b8554 Change wording about a number not being positve 2016-05-30 22:53:07 -05:00
Eric Leung ba611b27b3 Merge pull request #8857 from pranayberry/fix/remainder-challenge
Updated test case for the remainder challenge
2016-05-30 17:01:37 -07:00
Eric Leung 632381d531 Merge pull request #8691 from nishant-tomer/fix/tests-challenge-record-collection
add one more test to Record Collection
2016-05-30 16:11:48 -07:00
Pranay Berry 27e1a833f2 Updated test case 2016-05-31 01:59:22 +05:30
Daksh Shah 4909ce4201 Fix test in Accessing Obj Properties with Vars 2016-05-29 12:47:11 +03:00