* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* fix(coding): uncomment destructuring test and add solution
the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.
* fix: corrected partial solution to full
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* Added description to help understand challenge
I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
Looks good!
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
True, that makes sense..
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
* fix: update text of Write Higher Order Arrow to be more instructive
* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR
* fix: further changes to PR
* fix: checkout old head. Merge later commit with older commits
* fix: add MDN links to arrow-functions guide
* fix: re-add removed log and change working in guide wording
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Yep
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Removing unneeded line for clarity
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* Minor rephrasing of the lesson's description
Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.
* Corrections to conform to style guide
1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.
* Moved challenge instruction to Instructions section
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Correct seed code errors
Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.
* Add single quotes to correct new assertion statements
* Fix incorrect usage of splice
Changed the parameters passed to bookList.splice in the remove function
* Remove extraneous tests
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md
* fix(challenges): Update challenge text and assertion test
* fix(challenges): update assert test regex
* fix(challenges): update regex, fix inline comment in code example
* fix: corrected regex
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update create-a-text-field.english.md
* fix: change language tag and remove wrong comment
* Sample solution for the file
I have updated the sample solution for the challenge seed code.
* Update add-images-to-your-website.english.md
formatted ```html tags
hilliarj
Ruchika Sharma
Greg Smith
Niraj Nandish
Pete
kevindelsh
Randell Dawson
Aditya
Paul Gamble
The Coding Aviator
Dana Ottaviani
Héctor Estéllez
Bannon Tanner
geeseyj
Gökhan Gurbetoğlu
Adam
Ahmed Elbessfy
NITIN BISHT
lasjorg
Chris Del
Chad
Lewis Horwood
Beau Carnes
TristanSeabrook
Almaz Kunpeissov
Fordco
Theodoros Gkortsilas
rupali317
Lee
Randell Dawson
Aditi Joshi
Riyaad Azad
Aashis kumar
Nelson Wu
Melkisedek Hamakali
Kirill Malev
Oliver Eyton-Williams
Leo
Christopher Szczechowicz
Eunice Brackett
Dovid Majowka
Zach
Josh
Anas Salam
Greg Brewton
gokulsg
Luane
Yoelvis Jiménez
Howard T. Chiam
edu san
JustinBen-Tzioni
BurnhamG
lmilliken
SGokul1
Valeriy
Lipis
Steven Torrence
Cryotechnic
Naveen
Julien Galibois Sauvageau
Aditi Joshi
Mahesh Jaganiya
Kristofer Koishigawa
coderlyn
Dom Coleman