Commit Graph

3342 Commits (cf24131967dbd27e7a8fb23909a844250d1c26bd)

Author SHA1 Message Date
Gem ed74dada27
fix(curriculum): grammar in Steps 8 and 10 of Accessibility Quiz Challenge (#48239)
* Update 6140883f74224508174794c0.md

* Update 613e275749ebd008e74bb62e.md
2022-10-26 11:22:29 +02:00
camperbot 9d19ffa66b
chore(i18n,learn): processed translations (#48251) 2022-10-25 16:43:05 -05:00
Andrew Dawes 95561b0cb4
fix(curriculum): several typos and grammar errors (#48210)
* Fixed several typos and grammar errors

* Revert to an because the context is english US

* Fixed some weird wording

* Switch a to an

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-25 13:38:21 +02:00
Viswas Haridas c24b64a641
fix(curriculum): split step 30 of building a quiz (#48175)
* fix(curriculum): split step 30 of building a quiz

* fix: update step 30 - requires the camper to add a specified `id` to each `input`

* fix: add step 31 - requires the camper to add the corresponding `for` attribute to each `label`

* fix(curriculum): split tests in step 31

fix: add separate tests to check whether the `for` attribute exists in each `label`

* fix: rewording in step 31

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

* fix: move `label`-`input` linking instruction to step 31

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-10-25 15:27:02 +09:00
camperbot 7d5f67e384
chore(i18n,learn): processed translations (#48235) 2022-10-24 10:55:50 -07:00
Y Matsuda e4a8bb15b8
fix(curriculum): add ending dots for consistency (Build a Survey Form) (#48218)
fix(curriculum): add ending dots for consistency
2022-10-24 10:57:32 +02:00
Jeremy L Thompson fd34202188
fix(curriculum) - more commas in destructuring (#48176)
fix - support extra commas
2022-10-23 23:03:43 +09:00
Hatim Zahid 874651413a
fix(curriculum): Added description texts about spaces in step 154 #48160 (#48196)
* fix(curriculum):  Added description texts about spaces in step 154 #48160

* fix(curriculum): Added description texts about spaces in step 154 #48160

Used the text as described in  #48087 (comment).

* fix(curriculum): Added description texts about spaces in step 154 #48160

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa226207f33d3ad4c6f546.md

Removed Space in front of Your, as to not confuse future contributors.

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa226207f33d3ad4c6f546.md

Removed space warming text to make description less verbose.

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-23 10:55:59 +02:00
Muhammad Ahsan 6cc767a3bf
fix(curriculum): add descriptive hint for skyline project step 22 (#48179)
* docs: added more descriptive hint for skyline project step 22

* docs(curriculum): add descriptive step title

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/5d822fd413a79914d39e98de.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-10-22 17:30:10 +00:00
Juan Pablo Loaiza e7ffd0367e
fix(learn): check if input has only one type attribute (#47628)
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Juan Pablo Loaiza <jpablo@MacBook-Pro-de-Juan.local>
2022-10-21 21:28:59 +02:00
camperbot e3c137263c
chore(i18n,learn): processed translations (#48171) 2022-10-21 23:34:50 +05:30
Jeremy L Thompson 33a95e4e10
fix(curriculum): Faster Euler tests for prime seive problems (#48158) 2022-10-21 22:55:42 +05:30
camperbot 5f3b6b1807
chore(i18n,learn): processed translations (#48152) 2022-10-20 09:13:17 -07:00
Atir Nayab 242b334517
fix(curriculum): typos in challenge description (#47759)
* fix: typos in challenge description

* fix: remove quotation from code block

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/state-name-puzzle.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-javascript-by-building-a-role-playing-game/62aa2999ec27ec516655eba6.md

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-20 13:40:21 +01:00
camperbot 305b21c30b
chore(i18n,learn): processed translations (#48139) 2022-10-19 12:01:08 -05:00
Florencia d8b7c3feb4
fix(curriculum): Rework Euler Problem 125 (#48015)
* update problem125

* remove accidental change

* Apply suggestions from code review

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Apply suggestions from code review

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Change parameter

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* update

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* revert merge

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-10-19 18:54:21 +02:00
Sai Harvin 3653ff4e18
fix(learn): update JS Algo and DS - New Cert (#48030) 2022-10-19 14:35:29 +05:30
Mayank Prakash 936e11e1b4
fix: typo in js rpg challenge (#48122) 2022-10-19 06:33:17 +02:00
camperbot f659c2d39b
chore(i18n,learn): processed translations (#48111) 2022-10-18 16:21:01 +02:00
camperbot 41bbc30b94
chore(i18n,learn): processed translations (#48105) 2022-10-18 12:59:49 +05:30
Atir Nayab 2a5fae91db
fix(curriculum): build a city skyline instruction updated (#48010)
* fix(curriculum): feedback on Learn Css Variables By Building A City Skyline instruction updated

* skyline instruction updated

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/5d822fd413a79914d39e98d5.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/5d822fd413a79914d39e98d5.md

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/5d822fd413a79914d39e98d5.md

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2022-10-17 23:02:40 +05:30
abe 52b5bba501
fix: test remove element from max heap failing as expected (#47959)
Co-authored-by: kravmaguy <flex4lease@gmail.com>
2022-10-17 23:01:16 +05:30
Nemanja Lekic eef52dcc42
fix(curriculum): change `if` to if to help translation (#48100)
fix(curriculum): change `if` to if

By removing the code tags the implication of the sentence stays the same but it will make translating it easier.
2022-10-17 08:44:36 -07:00
Naomi Carrigan 36c6b73cd6
chore: add untranslated english files (#48047) 2022-10-15 14:22:49 +05:30
Niraj Nandish 441f11db38
feat: mobile curriculum testing (#47586)
* feat: first draft of action and cypress spec

* feat: test all generated challenges

* fix: better identification of block

* action: update cypress config

* action: upload to dashboard

* action: testing js cert challenges

* fix: unnecessary after user code for Make a Person

* feat: capture console log output for assert test

* fix: remove after seed code

* fix: change const to let

* fix: test

* action: disable js certification

* action: stop checking out branch in action

* action: check out right mobile repo

Co-authored-by: sembauke <semboot699@gmail.com>
2022-10-14 16:57:34 -07:00
Saul Blanco Tejero 1ba9624b5c
fix(learn): colored markers - step 5 - validation (#47808) 2022-10-14 12:46:06 +05:30
Piyush Keshari 52b782cd10
chore(curriculum): fix phrase that goes against our challenges guideline (#48017)
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-10-13 10:30:58 +00:00
abe 4ab1dd8926
fix(curriculum): recursion challenges that abuse global space (#47680)
* fix: recursion challenges that abuse global space #43516

* fix challenge phrasing and create separate test

* fix: challenges which pollute/impure functions should not pass

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/javascript-algorithms-and-data-structures-projects/cash-register.md

allow users to ab(use) global space in cash register

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/build-a-roman-numeral-converter-project/roman-numeral-converter.md

allow users to abuse global space in roman numeral converter

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: kravmaguy <flex4lease@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 15:00:24 -05:00
Atir Nayab fdaa149758
fix(curriculum): updated ES5 and ES6 class description (#47935)
* fix(curriculum): updated ES5 and ES6 class description

* fix: es5 example removed

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.md

Co-authored-by: Sem Bauke <semboot699@gmail.com>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Sem Bauke <semboot699@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-10-12 16:20:15 +02:00
Aniket Sinha 7e9aed8327
fix(curriculum): update CatPhotoApp Step 12 instructions (#47988)
Update 5dfa22d1b521be39a3de7be0.md
2022-10-12 10:11:11 +02:00
Jeremy L Thompson d1e65cfafa
fix(curriculum): faster solution for primes (#47990) 2022-10-12 09:05:43 +02:00
Oliver Eyton-Williams 2f6530325d
revert(i18n,learn): processed translations (#47985)
This reverts commit bd21f4b483.
2022-10-11 23:56:51 +05:30
Alekzandriia a02cd6448c
fix(learn): update verbiage to emphasize on `\n` instead of `\r` (#47841)
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-10-11 20:02:47 +02:00
Derryk Boyd 37d2a6d544
refactor(curriculum): Remove header element from cafe-menu practice project (#47970)
Remove header element from menu challenge

Co-authored-by: Derryk Boyd <derryk@redmantech.com>
2022-10-11 17:20:44 +02:00
SoumyadebMisra c8ca831353
fix(curriculum): colored markers - clarify meta tag description (#47281)
* Update 616965351e74d4689eb6de30.md

fixes #47266

Specified that a new `meta` tag is to be added and added the reason for doing so.

* fix: update wording

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-10-11 16:52:56 +02:00
Anuran Das d327f9c821
fix(curriculum): update front end demo project urls (#47894) 2022-10-11 09:37:06 -05:00
camperbot bd21f4b483
chore(i18n,learn): processed translations (#47979) 2022-10-11 16:34:00 +02:00
Kobe Ruado 536362de53
fix(curriculum): instructions and tests for a11y quiz step 56 (#47681) 2022-10-11 16:25:36 +02:00
Ayush-singla27 6ab90b4de2
fix(curriculum): Added definition of vh and rem (#47942) 2022-10-11 16:02:30 +02:00
Juan Pablo Loaiza fd59c177ea
fix(learn): Cafe Menu Step 13 - add checks for more than 1 style element (#47630)
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
Co-authored-by: Juan Pablo Loaiza <jpablo@MacBook-Pro-de-Juan.local>
2022-10-11 02:39:20 +05:30
camperbot 960eb4bb31
chore(i18n,learn): processed translations (#47963) 2022-10-10 12:35:19 -07:00
Derryk Boyd e90ab0c196
fix(curriculum): reconstruct HTML structure in CatPhotoApp and Cafe Menu for accessibility issues (#47790)
* fix: Move h1 element inside main for catPhotoApp

* fix: adjust header position in cafe menu challenge

* Remove console.dir calls

* update RWD project solutions with new header positions

* Move h1 element outside of section

* Remove console log

Co-authored-by: Derryk Boyd <derryk@redmantech.com>
2022-10-10 18:04:34 +02:00
Atir Nayab 898e7701dd
fix(curriculum): survey form descendant typo (#47953) 2022-10-09 20:19:27 +00:00
Paula Isabel a481b9525c
fix(curriculum): correct typos in back end development and apis (#47922) 2022-10-08 13:40:21 +05:30
Rafael Fontenelle 0e42b79b69
fix(curriculum): typos in making RPG game project at new JS (#47909)
fix(curriculum,learn): Fix a few misspellings
2022-10-07 18:15:48 +00:00
camperbot 762adee12b
chore(i18n,learn): processed translations (#47899) 2022-10-07 17:48:40 +02:00
Suraj Rane 023dcd6a25
fix(UI): fixed substring typo in excercise tracker (#47892) 2022-10-07 18:12:37 +05:30
camperbot f2ba8859f2
chore(i18n,learn): processed translations (#47869) 2022-10-06 20:19:26 +05:30
Rajat 4e13b3becc
chore: enabled `MD040` lint rule (#47853)
* enabled `MD040` lint rule

* fix: lint errors

* using `markup` instead of `text`
2022-10-06 16:07:54 +05:30
void-hr 0097b0f031
fix(curriculum): typos in new JavaScript make an RPG game (#47862)
typos fixed
2022-10-06 12:26:42 +02:00