ff20199e63
feat(curriculum): add tests to css variables skyline ( #42067 )
...
* add(tests): parts 1-2
* refactor for multi-file editor, and add temp css tests
* re-re-rebasing
* add link to subsequent challenges
* add test strings to 007-015
* add final tests 001-016
* fix 005-007, add 017-022 tests and test strings
* add: tests 021-030, and formatting
* add: 031-034 tests
* tests: add 035-046
* fix: test in 021
* tests: add 047-050
* format: 009, 051-118 remove css whitespace
* tests: add 051-078
* tests: add 079-105
* tests: add 104-118
* fix: empty -> isEmpty, and include -> match
* fix: correct editable region
* fix: formatting and spelling
* fix: test logic, and add TODO for whitespace
* fix: add final part solution 🤦♂️
* fix typo in part-006
* remove whitespace in prep
* getStyleDeclaration -> getStyle
* remove editable region from solution 🤦♂️
* fix: correct tests to fail on initial
* fix: add missing regex
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* fix: correct tests
* remove commas and stuff 🤷♂️
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* uppercaserise doctype
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* add "the"
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* remove half-colon
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* use more boring form of the word "shoudl"
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* add suggestions to tests
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-015.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-022.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-093.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-098.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-101.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-023.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-024.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-026.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-035.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-076.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-070.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-079.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-085.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-086.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-087.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-074.md
* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-078.md
* fix: the few commits I couldn't add on github
* fix: lesson 41
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 22:46:40 -05:00
28efec9e63
fix: recognize background-image as correct ( #42738 ) ( #42745 )
...
* fix: recognize background-image as correct (#42738 )
The page mentioned in #42738 before would not accept background-image and background, now it should.
* fix: CI build error
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2021-07-05 12:28:49 +02:00
dba157e7c0
Add a period at the end of an ul tag ( #42483 )
2021-06-15 20:44:36 +05:30
d6491a9902
fix(curriculum): Period added to the end of the sentence. ( #42480 )
...
Dot added to the end of the sentence.
2021-06-14 20:44:23 +05:30
35b18829d1
fix(curriculum): use mediaText for CSSHelp ( #42393 )
...
* fix(curriculum): use mediaText in CSSHelp
prevent selection of style elements with class or media attributes
this should avoid picking up some browser extensions
2021-06-07 23:33:58 +02:00
dfe80470c6
fix: require a link element in html ( #42336 )
...
* fix: require a link element in html
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-02 22:38:21 +02:00
f7ca9796c1
Update specify-how-fonts-should-degrade.md ( #42335 )
...
Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif".
2021-06-02 22:28:57 +04:00
d5cc9ba259
feat(dev): add css helper function ( #42148 )
...
* feat(dev): add css helper function
* add media declaration methods
* use a selector to grab styles
* add CSSHelp class with annoying TS warnings (no-verify)
* replace indexing with getPropertyValue
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* connect CSSHelp to helpers, clean up types
* fix: return extended object, not modify prototype
* fix: unnecessary assertion error
* add tests with fixtures
* add afterAll document clean-up
* 'fix' tests
* undo jest transform config
* remove erroneous comments and logs
* reafactor: use existing types and narrow types
* refactor test descriptions
* rename files to appease Mrugesh 😄
* remove probably unnecessary document clean
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-05-25 07:34:55 -07:00
4d024f3e4b
fix(curriculum): css and html test issues ( #42045 )
...
* fix: css and html issues
* fix: issues with css test
* fix: allow spaces in solution css
* fix: css tests for use-rgb-to-mix-colors
2021-05-21 12:18:42 +01:00
607b1c3dbf
fix(curriculum): look for possible www link in regex ( #41955 )
...
* fix(curriculum): look for possible www. link in regex
* Add suggestions from Nick
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-05-06 10:06:33 +05:30
a0463d2c99
fix: insert missing forward-slash in instructions ( #41934 )
...
inserted forward-slash in closing 'sup' tag in instructions section
2021-04-28 08:07:43 +02:00
093325abdf
fix(curriculum): tabindex order lesson ( #41901 )
...
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2021-04-27 00:55:28 +05:30
e45689d495
fix(curriculum): HTML-challenges: links are inconsistent. ( #41900 )
...
Co-authored-by: Ilenia <nethleen@gmail.com>
2021-04-26 22:34:53 +05:30
6be76738b0
fix(curriculum): import a google font lesson regex test ( #41907 )
2021-04-24 12:43:55 +02:00
3fbe1ebc05
fix(curriculum): remove stale video from nest anchor element ( #41914 )
2021-04-24 02:47:35 +07:00
a329eec0a8
fix(curriculum): sanitize css comments on typography lesson ( #41902 )
2021-04-23 16:24:50 +02:00
ec761dbdfa
fix(curriculum): add target in challeges link ( #41876 )
2021-04-22 11:34:23 +07:00
dbdc704271
fix(curriculum): give better instructions on alignment p-tags ( #41859 )
...
* Improve instructions
* Remove unneccessary line break
* Move empty line
2021-04-19 19:42:59 +02:00
9057750727
fix(curriculum): Fix a type `in line` -> `inline` in basic css challenge ( #41847 )
2021-04-18 11:54:17 +02:00
ca3d5d51d6
fix: wrong text in standardize times challenge ( #41842 )
2021-04-17 06:19:52 +02:00
d4aef30ea7
fix(curriculum): regex compatibility issue for Safari ( #41725 )
...
* fix(curriculum) regex compatibility issue for Safari
* fix: escape the dot parameter in regex
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-04-09 06:39:57 +02:00
a962d6afd4
fix(curriculum): cat photo app ( #41768 )
...
Fix a couple of bugs I encountered when running through this
course.
2021-04-08 13:37:18 +05:30
d51460dba8
fix (curriculum): added top level label-input pair to challenge ( #41717 )
...
* fix (curriculum): added top level label-input pair to challenge
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-05 08:41:31 +02:00
87c9c799c6
fix(curriculum): Regex fix for Create a Variable for a Specific Area ( #41501 )
2021-03-29 17:09:52 +05:30
18ac058840
fix(curriculum): Improve wording of test text ( #41606 )
...
Co-authored-by: Ricardo Passos <55499252+dizz-y@users.noreply.github.com>
2021-03-26 13:01:20 -05:00
b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design ( #41519 )
...
* fix(curriculum) replace single-line block with multi-line blocks
* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
d2f4b70ea6
fix: remove end of line chars after code blocks ( #41498 )
2021-03-16 07:49:43 -07:00
c198d508be
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge ( #41456 )
2021-03-12 10:09:22 -07:00
33bd4fb2c4
fix(learn): Change Codepen template link ( #41440 )
2021-03-12 10:41:48 +05:30
53d372c298
fix: update challenge for crowdin in anchor page ( #41450 )
2021-03-11 13:35:34 -07:00
5b760e50a3
fix(curriculum) Improved readability and grammar ( #41340 )
...
* fix(curriculum) Improved readability and grammar
* fix missing tags and grammar
* fix(curriculum) changes to grammar
* fix(curriculum) grammar fixes
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix(curriculum) Grammar fix
* chore: apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-10 09:00:03 -08:00
18068cdeaa
fix: remove forward slash from <source> tag ( #41422 )
...
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
ae79525493
fix(learn): added a missing period and removed single quotes ( #41377 )
...
* Added missing period
On line 24, just before "Note that in your CSS..." a period was missing.
* Removed single quotes and added a missing period
On line 24, just before "Note that in your CSS..." there is a missing period.
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
f328bdb93e
fix(curriculum) fixes for grammar and missing articles ( #41335 )
...
* fix(curriculum) fixes for grammar and missing articles
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-02 12:27:45 -07:00
051a010798
fix(learn): disallow www link from challenge ( #41275 )
...
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges ( #41217 )
2021-02-22 11:21:59 +05:30
aa615763af
fixed tests for link to external pages challenge ( #41191 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-21 11:46:00 +05:30
167f93df76
fix(learn): Add inline code blocks to for i18n ( #40921 )
2021-02-05 14:16:19 +05:30
12658d33fc
fix(i18n, learn): more crowdin fixes ( #40905 )
2021-02-04 13:34:44 +05:30
c21b2a9707
fix(learn): corrected typo ( #40902 )
...
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. ( #40766 )
...
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
b0bd3f5549
fix(learn): abstract comments from code ( #40869 )
2021-02-03 22:28:33 +05:30
4d48fb5ce7
fix(learn, i18n): crowdin issues ( #40884 )
...
Resolves a couple of issues with Crowdin parsing.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-02 14:08:32 -07:00
427444c757
chore(learn): audit files for crowdin ( #40838 )
...
* chore(learn): audit files for crowdin
Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: remove quotes from code
Removes instances of quoted code blocks, or code blocked quotes.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: additional uncaught quote-codes
Thanks Oliver :)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: so many quotes
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: missing punctuation
Noted in a Crowdin comment.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: remove more quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules ( #40473 )
...
* feat(curriculum): add extension tests for css-flexbox curriculum modules
* apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: reorder tests
Moves the test that asserts the presence of the follow button to the
top of the order.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-01 07:57:36 -08:00
8c22432b17
fix(learn): add period for readability ( #40836 )
2021-01-31 13:57:46 +05:30
a5dceb3e7e
Fixed error when changing the default order of css properties ( #40525 )
...
* Bug with psoitioning
Fixed bug with positioning of background-color` property for Selector `.heart::after`
* Trying new changes
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* Tests passing
Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4 )
* fixed typo
* applied suggestions
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00
83e3d93953
fix(learn): Remove strong syntax around code inline code ( #40754 )
2021-01-21 13:40:19 +05:30
bab54ad619
fix(learn): no capital code block ( #40688 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-16 12:54:38 -07:00
3ecdfe87d7
Update create-a-form-element.md ( #40720 )
...
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
Shaun Hamilton
Lorem Ispum
Devesh Rane
Stephan Düsterhöft
Seth Falco
impirios
Sem Bauke
sjc5
Tom
EboranBokaj
GDAD3
Ritesh Arora
Glitchy-Tozier
Evgeny Klimenchenko
Jonathan
Nicholas Carrigan (he/him)
Hassaan Pasha
Randell Dawson
pandacoder7
Emer Conghaile
Ricardo Passos
Ilenia
Keith
Guilherme Dias Simões
Luis H. Ball Jr
Evan Boehs
Mukesh Gurpude
majkelmichel