568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
cbbfc08108
fix: removed more assert msg args ( #36441 )
2019-07-24 13:13:06 +01:00
d0d8282f86
fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections ( #36457 )
...
* fix: remove double quoted assert msg arg - responsive
* fix: remove double quoted assert msg arg - js
* fix: remove double quoted assert msg arg - libraries
* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
8e6c26f271
fix: removed assert msg argument ( #36407 )
2019-07-24 12:54:35 +02:00
87615d2a7b
fix: removed assert msg argument ( #36406 )
2019-07-24 11:50:51 +02:00
e763330fc3
fix: removed assert msg argument ( #36405 )
2019-07-24 11:42:26 +02:00
7d4dc382b4
fix(curriculum): format challenge markdown as per linting rules ( #36326 )
...
* fix: Format challenge markdown according to linting rules
* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
a32f719d3a
Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge ( #36186 )
...
* fix: add test for input closing tag
* fix: add condintion to final syntax test
This wil test if there's any character after the input tag that isn't a white space
* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
438e7d4c51
fixed testString to disallow any extra characters from passing. Also … ( #35987 )
...
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
acbc07e0ff
Fixed typo addressed in #36225 ( #36227 )
...
* Fixed typo addressed in #36225
* Updated as per discussion.
2019-06-15 13:02:01 +07:00
2a18b1a308
Consistency Update for label and input elements for last lessons ( #36192 )
...
* Updated to reflect the relationship between label and input elements
* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
8cb540fe85
fix: use lowercase for 'article' tag ( #36222 )
2019-06-09 07:47:09 -07:00
43fa451a38
fix(curriculum): Change wording to talk about inheritance not cascade ( #36110 )
2019-06-08 19:09:00 -07:00
6feda1badb
Improve capitalization ( #36166 )
2019-06-04 07:52:52 -07:00
8b4fb5a452
fix: imgur to s3 for various files without conflict ( #36057 )
2019-05-20 23:58:20 +05:30
937dc23b5d
fixed typos in custom css-variable challenge #36038 ( #36041 )
...
* fixed typos in custom css-variable challenge
* fix: Remove extra line
2019-05-14 20:31:03 +07:00
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
791e589c93
Remove tag characters ( #36037 )
2019-05-14 00:14:16 +05:30
48884f3a4a
fix: changed to h4 > s in selector ( #36023 )
2019-05-11 19:09:08 -05:00
a40451feaa
Define the Head and Body of an HTML Document for challenge solution ( #35826 )
...
* Define the Head and Body of an HTML Document for challenge solution
* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
409aa30b0a
fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge ( #35893 )
...
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-01 14:08:35 +05:30
5b32e98c4a
fix(curriculum): Add solutions to Applied Visual Design challenges ( #35815 )
...
* fix: add solutions to Applied Visual Design challenges
* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
cf86246866
fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 ( #35809 )
...
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
722b65d80f
fix(curriculum): Add solutions to HTML challenges ( #35766 )
...
* fix(curriculum): Add solutions to HTML challenges
* Remove extra anchor element
2019-04-22 11:37:05 +05:30
e736179720
fix(curriculum): Add solutions to CSS challenges ( #35873 )
2019-04-22 11:27:43 +05:30
ffcb092bf1
Fixed CSS Challenge English version ( #35849 )
2019-04-20 09:49:23 -07:00
f1bcd5f0de
fix/add-full-solutions-to-flexbox ( #35760 )
2019-04-20 09:45:18 -07:00
9ee8b4fa57
fix: minor grammar mistake in 'applied visual design' challenge ( #35839 )
...
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
63fc21f702
Update videoURL for HTML5 Elements challenge ( #35802 )
2019-04-14 09:20:36 -07:00
bddcda5559
added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element ( #35516 )
...
* added html solution for testing
* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
ebdd8632fc
Fix/update challenges for responsive-web-design-principles ( #35804 )
...
* Fix/update challenges for responsive-web-design-principles
* fix/update fix some minor mistakes
* fix/update remove extra line
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
2019-04-10 17:26:56 -04:00
7e522dc473
fix: add new scrimbas ( #35803 )
2019-04-10 09:23:12 -07:00
f74d507434
fix(curriculum): replace js with full solution in accessibility challenge ( #35810 )
...
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
2019-04-10 17:55:16 +02:00
9b9a96234f
fix(curriculum): Add solutions to responsive web design principles ( #35761 )
2019-04-10 07:57:14 -07:00
42bc9fa9b6
fix(curriculum): Made tests not accept invalid HTML ( #35774 )
...
* fix: made tests stricter
* fix: simplify text
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-10 19:21:52 +05:30
f590fecb34
Update reduce-repetition-using-the-repeat-function.english.md ( #35787 )
2019-04-08 20:09:26 +05:30
f91dea9b5c
fix(challenge): update text to give an explanation of wrapping ( #34811 )
...
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
91f4865ab4
Fix typo in curriculum/challanges/english/01-responsive-web-design/applied-visual-design/use-the-css-transform-scale-property-to-scale-an-element-on-hover.english.md ( #35743 )
2019-04-02 21:43:27 -04:00
e84ae45008
Javascript -> JavaScript (English) ( #35183 )
...
* Javascript -> JavaScript (English)
* Update technical documentation page for required change
* Update use-class-syntax-to-define-a-constructor-function.english.md
* Update left-factorials.md
2019-03-28 14:05:41 +05:30
be687977cf
fix(challenge): add .english to file name ( #35687 )
2019-03-27 06:38:25 -07:00
d9213b38cd
fix(challenge): remove child selector from name attribute test ( #35423 )
2019-03-27 11:33:41 +05:30
69d9d522a2
fix(challenge): fix broken regex ( #35632 )
...
* fix(challenge): fix broken regex
* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
a1e853337b
fix(challenge): simplify and cleanup tests ( #35535 )
2019-03-26 21:35:38 -07:00
b10589fadf
fix: Challenge solution added and broken test updated. ( #35526 )
...
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
2019-03-26 21:01:22 -07:00
33edc072b9
Use the correct element name in <code> blocks, gloss it seperately ( #35616 )
...
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9
2019-03-25 10:50:33 -05:00
98e68d04be
feat(curriculum): Add challenge on using the value attribute ( #35301 )
...
* feat(curriculum): Add challenge on using the value attribute
fix(challenge): update file name and add comma
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Apply suggestions from code review
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
bc72c86dc6
fix: updated the note sections for responsive web design english ( #35528 )
2019-03-22 15:02:12 +01:00
Randell Dawson
Randell Dawson
Oliver Eyton-Williams
Fabricio Asfora Lira
Steven Failla
adamthahir
Ugur Yilmaz
Weibin Luo
Val Lipat
Ahmad Abdolsaheb
Kyle Cheung
Huyen Nguyen
RIHANE ZAKARIA
Ian Effendi
Manish Giri
Catalina
Tom
Astrid
Beau Carnes
Paul Gamble
Aditi Joshi
Kyle Scheuerlein
lasjorg
Roberto Ruccia
Lipis
Jean Jordaan
rupali317