44804abeb5
fix: Remove and update challenges with legacy methods ( #36444 )
2019-08-15 01:22:41 +01:00
a305a3df9f
componentWillReceiveProps is deprecated ( #35894 )
...
* componentWillReceiveProps is deprecated
Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed
* Removed also `componentWillReceiveProps`
2019-08-13 09:14:10 -07:00
01c8554adc
03-render-conditionally-from-props: use const ( #36551 )
2019-08-12 18:17:39 +05:30
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
f2df76c099
fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 ( #36409 )
...
* fix: removed assert msg argument
* fix: removed more assert msg args
* fix: removed more assert msg args
2019-07-24 13:07:46 +01:00
7d4dc382b4
fix(curriculum): format challenge markdown as per linting rules ( #36326 )
...
* fix: Format challenge markdown according to linting rules
* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
e561953827
Removed deprecated lifecycle methods ( #35895 )
...
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
933350c148
fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries ( #35994 )
...
* fix: converted blockquotes for react/redux
* fix: converted blockquotes for sass
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:01:32 -05:00
3b5fbe3edb
Improve formatting of Challenge Seed ( #35854 )
2019-05-08 18:32:01 -05:00
20f71fd22e
correct usage of Math.random() to give equal 50/50 results ( #35840 )
...
* Update render-conditionally-from-props.english.md
* Update render-conditionally-from-props.english.md
2019-04-13 18:06:01 -04:00
394ae3d1ce
fix(challenge): check for li and specify elements accepting text ( #35193 )
...
* fix(challenge): check for li and specify elements accepting text
* fix(challenge): revert text
* fix(challenge): remove word added by mistake
* fix(challenge): update test, cleanup assertion text
2019-04-10 20:52:37 +05:30
216e10e2b7
fix: A testing bug in FCC's React Simple Counter Challenge ( #35715 )
2019-04-03 22:24:05 -05:00
4d1d89b1c7
fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge ( #35320 )
...
* fix: only allow valid jsx comments in div elem
* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
e7bc4bd014
fix: Allow trailing commas to be used in challenge ( #35585 )
...
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
2019-03-18 09:56:46 -07:00
64faca718b
Changed the definition of stateful components ( #34837 )
...
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
2019-03-16 19:25:46 +01:00
cd501ee4c5
change wording: React component -> class component ( #34692 )
...
Hi,
I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".
Theo
2019-03-04 01:47:28 -05:00
61a5707ba7
Edit Description ( #34329 )
...
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
cb35d49a21
fix(challenges): Fix broken links in English challenges ( #35125 )
2019-02-21 17:58:31 -05:00
a17b123510
Added curly brackets to comment in JSX element ( #34694 )
...
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
46be1e2ed1
fix: React: Give Sibling Elements a Unique Key Attribute ( #34648 )
...
* feat: added additional test
Added additional test, formatted description and updated instructions and solution
* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
06b3b078a6
Fixed comment closing tag to match comment opening tag spacing and be symmetrical ( #35136 )
2019-02-10 14:29:12 -08:00
4fe2558f99
Edit text string to have the correct case ( #34366 )
...
Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test
2019-02-05 18:51:13 -08:00
cd783c32da
Adding link to React documentation ( #32635 )
...
* Adding link to React documentation
* Modified link to fit github markdown
* Update use-proptypes-to-define-the-props-you-expect.english.md
2018-11-16 11:55:56 -05:00
ebf96cb0b2
Added info about deprecated React method in curriculum ( #19930 )
...
* Update use-the-lifecycle-method-componentwillmount.english.md
* Added correction to deprecation timeline and updated link
2018-10-27 19:49:49 -07:00
e099d6486d
fix: test curriculum challenges ( #24180 )
2018-10-23 18:51:53 +05:30
79d9012432
fix(curriculum): quotes in tests ( #18828 )
...
* fix(curriculum): tests quotes
* fix(curriculum): fill seed-teardown
* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
ee9f6b2d72
chore(meta): Move challenge meta to challenges root
2018-10-11 02:15:05 +05:30
e0e8ab8409
fix: clarify test text in line with test functionality
2018-10-08 11:38:29 +01:00
a859035023
fix(challenge-md): Fix quotes that failed in the transform
2018-10-08 11:38:26 +05:30
8f39bc1288
chore(curriculum): Remove files in wrong format
2018-10-05 15:58:12 +01:00
Oliver Eyton-Williams
Tiago Salema
SomeDer
Randell Dawson
Kyle Scheuerlein
Benjamin Herrchen
lasjorg
chaomt
kevindelsh
Theodoros Gkortsilas
Ahmed Elbessfy
Niraj Nandish
Aditya
Steven Torrence
coderlyn
Tomer Ben-Rachel
The Coding Aviator
Valeriy
Bouncey
petergrainger