* fix: convert data visualization
* fix: reverted to blockquote
* fix: changed js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: cleaned up code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: converted blockquotes
* fix: revert to blockquote
* fix: changed js to http
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: converted blockquotes
* fix: added extra line before triple backtick syntax
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected misc issues
* fix: properly closed em element
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Fix "ReferenceError: url is not defined" in challenge
I fix the challenge because issue #14002
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍
I modified and verify the tests according the new assessment.
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
Minor typo: `<code>` to `</code>`
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
new declared as const
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
* fix: Moved instruction to proper place and removed assert text
* Add suggestion about making note strong
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
* Expand instructions for Chai Assertion challenges
* Seperate instructions/descriptions and remove some quotes
* Add detail to descriptions in truthiness and isOk challenges
* Update formatting in instructions
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
Fixes#35793
I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?
Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
* fix(challenge): check for li and specify elements accepting text
* fix(challenge): revert text
* fix(challenge): remove word added by mistake
* fix(challenge): update test, cleanup assertion text
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
* feat: add solution for font-awesome icon challenge
* feat: add solution to add all button icons challenge
* feat: add solution to add ids to bootstrap elements challenge
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu>
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge
* Fix for issue #35665
Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md
Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>
* fix: added missing ) for assert statement
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Update description of tests pig-latin.english.md
The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md
Co-Authored-By: beansprout <christinegierer@gmail.com>
* fix: update tests for difference on two sets
* fix: update tests for difference on two sets - fix quotes
* fix: reverted testString and reworded text
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed:
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort
This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.
Closes#34776
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* Make link text more descriptive
Make link text more descriptive for improved accessibility.
* Add mention of MDN to link description
As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Adjust link wording
Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
* Update challenge descriptions with code tags
Updates multiple challanges in the category: Information Security with
HelmetJS
* Fix(wording): security with helmetjs
Co-Authored-By: jneidel <github@jneidel.com>
* fix: reformatted code and moved instructions
* fix: replaced code with blockquotes
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/install-and-set-up-mongoose.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: made a few recommended changes of text
* fix: moved </blockquote> to new line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: removed extra space
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added the word The before code tag section
* fix: Formatting for Zig Zag Matrix challenge
* Remove non-breaking spaces and replace them with normal spaces
* Update zig-zag-matrix.english.md
* Move instructions to instructions section from description
* Update zig-zag-matrix.english.md
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
Hi,
I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".
Theo
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
* Basic gramatical changes
Corrected a few typos to improve the wording
* commit suggested changes
Improve line 9 from "before" to "earlier"
Revert line 14
* Added example Input/Output to challenge
Input/Output example will make it clear what the challenge is asking the camper to do.
* Formatting changes made to file
* Made minor changes in formatting
Added <code> tag to single line code.
* Formatting update
* Added requested formatting changes
* Refactored sentence and removed earlier example
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* fix(coding): uncomment destructuring test and add solution
the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.
* fix: corrected partial solution to full
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* Added description to help understand challenge
I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
Looks good!
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
True, that makes sense..
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
* fix: update text of Write Higher Order Arrow to be more instructive
* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR
* fix: further changes to PR
* fix: checkout old head. Merge later commit with older commits
* fix: add MDN links to arrow-functions guide
* fix: re-add removed log and change working in guide wording
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Yep
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Removing unneeded line for clarity
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
Randell Dawson
Matt Schlosser
Huyen Nguyen
Courtney
Tom
Yoelvis Jiménez
duytrinhvn
Kyle Scheuerlein
Deanna Tran
Randell Dawson
RIHANE ZAKARIA
Oliver Eyton-Williams
The Coding Aviator
Manish Giri
Valeriy
Tina Wang
Aly Pilkons
Ian Effendi
BSi
Fordco
Catalina
ranched
Astrid
Beau Carnes
Benjamin Herrchen
Paul Gamble
Aditi Joshi
Guayo Mena
lasjorg
chaomt
Roberto Ruccia
Kristofer Koishigawa
Илья
Dana Ottaviani
Jonathan Lawrence
Amy Lam
lucassorenson
Lipis
NITIN BISHT
Avahe Kellenberger
Justin Hilliard
seanlaing
Hrishit Prasad Biswas
Jean Jordaan
Christine Gierer
Zebulan Stanphill
Aditya
Vikas KM
rupali317
Carol W
Chuck Adams
Hugo
Bhanu Pratap Singh Rathore
Timur
grets311
Shashank Bairy R
Edwin van Meerendonk
Jade Michael Thornton
Yuran Pereira
Roberto Beltran
kevindelsh
Gökhan Gurbetoğlu
Nathan Lakritz
Greg Brewton
Ron Sogueco
Sumer Patel
Lauren Van Sloun
Vedrana_R
Jonathan Neidel
Bannon Tanner
Lewis Horwood
Alan Price
Akshay Tiwari
Aashis kumar
nik
Dan B
Ihor Allin
Theodoros Gkortsilas
Jasmeet Singh
Travis Fantina
Luane
Christopher McCormack
Alan Nguy
hilliarj
Ruchika Sharma
Greg Smith
Niraj Nandish
Pete
Héctor Estéllez
geeseyj
Adam
Ahmed Elbessfy
Chris Del
Chad
TristanSeabrook
Almaz Kunpeissov
Fordco
Lee