Commit Graph

1191 Commits (e2378faf96e80af7b776d9df91fdec76605e0cd5)

Author SHA1 Message Date
lasjorg f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Greg Fletcher 61588df778 fixed grammar: removed middlewares (#36392)
* fix: Improved grammar

Replaced 'middlewares' to 'middleware functions'.  Middleware is an uncountable noun, just like 'software'.  No such word as 'softwares'

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-09 14:38:25 -04:00
Saad Monem d9cccd6d74 Fixed typos in description of challenge: "Use a Template Engine's Powers" (#36395)
* Fixed typos in template engine challenge

* Incorporated suggestions into updated description

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Incorporated new suggestion

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-07-09 14:36:47 -04:00
Tiago Salema e561953827 Removed deprecated lifecycle methods (#35895)
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
organicdude f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Fabricio Asfora Lira a32f719d3a Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge (#36186)
* fix: add test for input closing tag

* fix: add condintion to final syntax test

This wil test if there's any character after the input tag that isn't a white space

* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
Prashanth Ashok Ramkumar b68f752847 Adding solution for queue class (#36319) 2019-07-02 07:45:42 -07:00
Michał Kozłowski e05e17ce31 fix regexp to match require statement without .js extension (#36293) 2019-07-02 01:51:41 +05:30
Steven Failla 438e7d4c51 fixed testString to disallow any extra characters from passing. Also … (#35987)
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>

* fixed test so it won't pass if datetime attr is left blank

* fixed test so it will not pass if datetime attribute is left empty

* fixed error in testString where test would pass if user runs test right away

* added tear-down div to make test code look cleaner

* fixed merge conflict. added tear-down div to make code look cleaner

* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

improvement to test case where element should have closing tag.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fixed conflict in git

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
Tom 50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01 2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01 9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01 c133a6fbd0 fix/remove-duplicate-from-meta 2019-06-28 16:04:59 +08:00
moT01 9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01 9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01 d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01 ffc3a827c2 fix/conflicts 2019-06-28 16:04:59 +08:00
moT01 61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom 72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01 3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom 81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom 9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01 d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
moT01 21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
moT01 246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
Kris Koishigawa 1028310819 Changed bold to strong or code tags where possible 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3ce97bbd81 Fixing other problems from comments 2019-06-26 17:34:03 +08:00
Kris Koishigawa 0544554b00 Fix curly quotes 2019-06-26 17:34:03 +08:00
Kris Koishigawa a6ed1e51b7 Change links from http to https 2019-06-26 17:34:03 +08:00
Kris Koishigawa 32b24a3a20 Fixing merge conflicts 2019-06-26 17:34:03 +08:00
Kris Koishigawa ae49dfd376 fix(challenges): Fix merge conflicts convert seconds and towers of hanoi 2019-06-26 17:34:03 +08:00
Kris Koishigawa 14bcbac669 fix(challenges): Added blockquote to department numbers and fixed fractions in fractran 2019-06-26 17:34:03 +08:00
Kris Koishigawa aeb0dccb15 fix(challenges): Added left margin to blockquote footer in Babbage Problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 12d84e83a8 fix(challenges): Y problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 723ee2cfa5 W problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa a0e68a39a7 fix(challenges): V problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 74f70c19d8 fix(challenges): T problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 539e93d01b fix(challenges): The rest of the S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 442c9c291d fix(challenges): More S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa c752d57611 Added sorting algorithms 2019-06-26 17:34:03 +08:00
Kris Koishigawa 2053e99cd5 S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa df88daa482 fix(challenges): J problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 263d2c496b fix(challenges): I problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa a3fd1aa284 fix(challenges): H problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 537d1ed642 fix(challenges): G problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa abbfee1189 fix(challenges): Formatted F challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 1a56a5b0ae fix(challenges): Minor changes to D challenges. Add E challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 461155f7ef fix(challenges): Replaced image with svg in Cut a Rectangle 2019-06-26 17:34:03 +08:00
Kris Koishigawa da4999cb46 fix(challenges): Moved challenge instructions to instructions section 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3a7ac2c0c0 fix(challenges): Forgot to remove the space between the function name and first parenthesis 2019-06-26 17:34:03 +08:00
Kris Koishigawa bc1d2be822 fix(challenges): Added all D problems except Department Numbers 2019-06-26 17:34:03 +08:00
Kris Koishigawa d024b96a92 fix(challenges): Went back and fixed a missing A problem. Fixed C problems. 2019-06-26 17:34:03 +08:00
Kris Koishigawa f9f4048258 fix(challenges): Revert 24 game due to another PR being submitted 2019-06-26 17:34:03 +08:00
Kris Koishigawa 201c383148 fix(challenges): Fixed formatting for numbered and challenges starting with A 2019-06-26 17:34:03 +08:00
Tom 51b5defb7e fix/regex-upper-and-lower-bounds-tests (#36059)
* fix/regex-upper-and-lower-bounds-tests

* fix/add-solution-back

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-25 14:45:20 -07:00
Randell Dawson 3fa14df925 fix: renamed folder without starting dash (#36124) 2019-06-21 18:05:33 -04:00
Randell Dawson f53ca79890 fix: changed tests to allow other valid solutions (#36210) 2019-06-21 18:04:30 -04:00
Randell Dawson 63a0fa745b fix: improved tests to allow more valid solutions (#36193) 2019-06-20 17:09:46 -04:00
Randell Dawson a6afaf1eb6 fix(curriculum) - added new tests to prevent invalid solutions in the Remove Elements from a Linked List by Index challenge (#36168)
* fix: added new tests to prevent invalid solutions

* fix: corrected tests and added solution

* fix: added linked word

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added by one

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: removed duplicate code

* fix: changed verbiage

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:34:08 -04:00
Stan Choi a13d116aab fix(learn): Added solution for invert binary tree data structures challenge (#35922)
* fix: add solution for invert binary tree

* Fixed errors

* Used 2 spaces per request

* deleted images

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:28:37 -04:00
Andrew Zaw 6f4a9ed721 Reorganized instruction text on multiple challenges (#35912)
* Reorganized instruction text on multiple challenges

* Fixed spaces

* Fixed spaces again

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/add-elements-at-a-specific-index-in-a-linked-list.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added code tags
2019-06-20 13:16:31 -04:00
Daniel Simeonov 81d7127a5d Added solution for English/Data-Visualization/Hover-tod3-element (#36220)
* Added solution for English/Data-Visualization/Hover-tod3-element

* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element

* fix: added extra line to prevent linting errors
2019-06-20 09:49:47 -07:00
Stan Choi 204ece1c70 fix: Add Solution in Curriculum/Challenges/English/08/CodingInterviewProblems/DataStructures/CREATE_LINKED_LIST_CLASS.md (#35819)
* fix: add solution create linked list class

* fix: added extra line to avoid linting error

* fix: renamed some variables
2019-06-20 10:11:26 -05:00
Tina Wang f203273e3a Solutions for sorting algorithm challenges in Coding Interview Prep/Algorithms (#35905)
* added bubbleSort solution

* added insertionSort

* fixed spacing in bubbleSort

* added selectionSort

* added a test

* Fixed a reference to the array with the wrong array name in the solution

* fix: added extra lines to avoid linting errors

* fix: added comments back into seed
2019-06-20 10:03:31 -05:00
Oliver Eyton-Williams 2024e238fa feat(curriculum): Add basic recursion lesson (#36200)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
leodaher 0be75e4b39 feat(curriculum): Add fetch challenge to the current curriculum. (#36033)
* Add fetch challenge for the current curriculum
2019-06-18 00:19:33 +02:00
Michał Kozłowski 8b40da02a3 multiple ternary operator challenge - add note about code readability (#36269)
* fix multiple ternary operator challenge

* Fix a typo in multiple ternary operator challenger

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Fix a typo in multiple ternary operator challenge #2

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
adamthahir acbc07e0ff Fixed typo addressed in #36225 (#36227)
* Fixed typo addressed in #36225

* Updated as per discussion.
2019-06-15 13:02:01 +07:00
Ahmad Abdolsaheb d24778ceb8
fix: replace imgur URLs with s3 URLs for files with potential conflict (#36049)
* fix: replace imgur with s3 for files with potential conflict

(cherry picked from commit 4ec62c0e29a64b0288eade45fb510f25c622945a)

* fix/remote extra link

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: revert change
2019-06-12 11:19:43 +03:00
Mahesh Jaganiya 72aaddfc12 Improve Regex (#36078)
* Updated assert.match() to assert.equal()
2019-06-11 10:43:08 +02:00
anthonykyi 97f6b73a0e Added Binary Search Tree Challenge (#35907)
* Added Binary Search Tree Challenge

* fix yaml, fix solutions, fix tests

* Fixed recommended fixes
2019-06-10 23:35:21 -04:00
RIHANE ZAKARIA d86951f9c1 Added solutions for 3 challenges in English / data-structures (#35825)
* Solution for add-elements-at-a-specific-index-in-a-linked-list.english.md

* Solution check-if-an-element-is-present-in-a-binary-search-tree.english.md

* Solution for remove-elements-from-a-linked-list-by-index.english.md

* change indent level to 2 space for each level

* change indent level to 2 space

* change indent level to 2 space

* delete unnecessary new lines

* keep the same seed format , and delete unnecessary new lines

* delete unnecessary new lines

* fix: added review suggestions

* fix: Added link and code tags
2019-06-10 18:17:11 -04:00
Ugur Yilmaz 2a18b1a308 Consistency Update for label and input elements for last lessons (#36192)
* Updated to reflect the relationship between label and input elements

* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
Weibin Luo 8cb540fe85 fix: use lowercase for 'article' tag (#36222) 2019-06-09 07:47:09 -07:00
Oliver Eyton-Williams 43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00
Kristofer Koishigawa 8f633299ef fix(challenges): Replace camper leaderboard project (#35763) 2019-06-09 05:23:28 +05:30
Siddhant Shekhar c1d3817732 fix : replaced test cases' string to make more sense (#36170) 2019-06-06 15:53:31 -07:00
Fabricio Asfora Lira 2da9d631ef fix: update "Note" formatting in "Remove Elements from a Linked List" challenge (#36173)
* fix: update note format

* fix: moved note to same line
2019-06-06 14:27:58 -05:00
Courtney Landau f70bcce463 spelling and grammar fixes (#36061)
* spelling and grammar fixes

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/send-and-display-chat-messages.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-06-04 16:22:23 -04:00
Randell Dawson 5a06b71ac4 fix: modified tests text (#36169) 2019-06-04 16:14:52 -04:00
Randell Dawson da610150ad fix(curriculum): added new test and corrected existing solution for Remove Elements from a Linked List challenge (#36121)
* fix: added new test and corrected solution

* fix: corrected test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: allow last element to be removed

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-04 14:55:50 -04:00
Val Lipat 6feda1badb Improve capitalization (#36166) 2019-06-04 07:52:52 -07:00
Randell Dawson 0303da3677 fix(curriculum): Convert blockquote elements to triple backtick syntax for Coding Interview Prep (#35998)
* fix: converted blockquotes

* fix: reverted several code blocks to blockquotes
2019-06-04 08:07:22 +01:00
Niraj Nandish c1bb01da31 Fix broken links in Portuguese challenges (#35127)
* fix(challenges): Fix broken links in Portuguese challenges

* fix: corrected link
2019-06-03 13:51:23 -07:00
Niraj Nandish 82b340d429 Fix broken links in Russian challenges (#35128)
* fix(challenges): Fix broken links in Russian challenges

* fix: corrected link
2019-06-03 13:51:09 -07:00
nataly 70cfa581ab fix some sentences (#35286) 2019-06-03 13:33:16 -07:00
elcodex a251c9dd57 [Rus] Improved the translation of Redux challenges (#34311)
Updated file "create-a-redux-store.russian.md"
2019-06-03 13:19:05 -07:00
Sergey Lebedev 46a6a112f2 Improved Russian translation. (#34194) 2019-06-03 13:18:04 -07:00
gmal1 f04701bba8 fix grammar/readability (#34299) 2019-06-03 13:17:35 -07:00
Sergey Lebedev 685a80d41b Improved Russian translation. (#34192) 2019-06-03 13:15:12 -07:00