Commit Graph

51 Commits (e55aa5c7bba520b2e210e3512fab7075aed3a462)

Author SHA1 Message Date
gikf 9669e39b85
fix(learn): make tests and test descriptions more explicit (#41281)
* fix: make tests and descriptions more explicit

* fix: add example to description

* fix: replace pre tags with markdown

* fix: move test data to seed code for convenience

* fix: correct grammar from review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Revert "fix: move test data to seed code for convenience"

This reverts commit 7a9c4723d6.

* fix: small corrections

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-12 07:29:03 -08:00
Luca 5589c37804
fix(learn): remove wrong spaces and make quotes consistent (#41434)
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)

Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)

* Consistent spacing after commas

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-11 07:19:07 -08:00
Nicholas Carrigan (he/him) c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
gikf bd02249a23
fix(learn): rework Rosetta Code Count the Coins (#41282)
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-09 08:34:10 -06:00
gikf 93495ef6db
fix(learn): correct tests description (#41280)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 11:48:12 +05:30
gikf 5332628e6d
fix(learn): rework Rosetta Code Hailstone Sequence (#41279)
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-04 13:28:47 -08:00
lusc 8a5711dda7
Fix: remove a colon in rosetta-code/happy-numbers (#41349)
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-04 09:25:55 -07:00
Randell Dawson 57f3c80345
fix(learn): Clarify date format expectations for the Date Format challenge (#41327)
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-02 15:46:30 -08:00
gikf f5a905b7c2
fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf 70c4d82068
fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf c8db838754
fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf a91444d3d4
fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
gikf 6ae3735979
fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
Kim Leung 082b269dce
fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
gikf 313b345611
fix: correct Rosetta Code Knight's tour solution (#40830)
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
Kim Leung a37d5f5817
fix(learn): add output type verbiage (#40589)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 19:41:15 +05:30
Mainak Debnath d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
Nicholas Carrigan (he/him) 062b1cd424
fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Kim Leung e57f32438c
fix(learn): correct LCG equation in description (#40615)
* fix(learn): correct LCG equation in description

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert LCG equation in Chinese file

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:05:37 -08:00
Randell Dawson dd4c7e0097
fix(learn): Update text as code for vector-dot-product (#40460)
* fix: implemented suggestted changes

* fix: correct last test expected return value

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add test to return null if more than 2 vectors

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: added correct solution

* fix: removed extra brackets

Co-authored-by: Yuval Levental <yhl3051@rit.edu>

Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Yuval Levental <yhl3051@rit.edu>
2021-01-20 21:23:10 -08:00
Nicholas Carrigan (he/him) 8d8d25e9f2
fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Jeremy L Thompson a5840f57a4
Update Description of Stern-Brocot Challenge (#40686)
* fix: update description of target function

* fix: include note about 1 based indexing
2021-01-16 12:57:38 -07:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
miyaliu666 9770cd0f81
translated some Chinese curriculum files (#40531)
* translate task #1 - #4

* add translation of zhang-suen-thinning and markov algorithm

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2021-01-08 11:59:18 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
sreekumar menon dec4b2180f
Scalar addition issue on Element-wise operations (#40013)
* Scalar addition issue on Element-wise operations

* remove chinese from PR

Co-authored-by: Sreekumar Menon <sreekumar@roofstock.com>
2020-10-19 11:29:23 -07:00
Bobby BuffaloBoy 71659b7c94
fix(learn): Date corrected the example description from Sunday, to Friday, in the date-format Rosetta Code Challenge (English) (#39998) 2020-10-17 23:01:18 +02:00
Ke Cleveland 13e7251ed9
fix(learn): Update findXmasSunday function arguments from (2008,2121) to (1970, 2017) to match expected return. (#39996)
Co-authored-by: keiveland <keivelanddev@gmail.com>
2020-10-17 22:46:03 +02:00
Oliver Eyton-Williams 35c4020f4d
fix(curriculum): test typos (#39984) 2020-10-15 14:49:57 -04:00
Oliver Eyton-Williams a71150074d
fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Jeremy A Gray 0e3c3e2ff7
fix(learn): avoid conflict with spring forward EST to EDT (#39681)
March 8, 2009 is the weekend of spring forward to EDT in the US.  This change moves the example date and test back one day to add twelve hours to a time on March 6, 2009, resulting in a time on March 7, 2009.
2020-09-29 20:47:26 +05:30
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson 876d9f3994
fix(learn): Consolidated comments for Coding Interview Prep challenges - part 2 of 2 (#39576)
* fix: consolidate comments for use with the translation dictionary

* fix: added blank line between comments

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed unneeded comment

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 01:01:21 +05:30
Randell Dawson 8788ad946b
fix: remove Good luck! comment from challenge seed code (#39575) 2020-09-15 22:27:40 +05:30
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Tom 6ce2db7bb2
feat(learn): add word frequency challenge to rosetta section (#39424)
* feat(learn): add word frequency challenge to rosetta section

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: tests

* fix: revert challenge so it can have multiple solutions

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-03 06:30:57 -07:00
Pyi Theim Kyaw faf426bb40
PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Joseph Mawa fccc436e23
Fixed test description for Rosetta Code: Euler method challenge. (#39452)
* Update greatest-subsequential-sum.english.md

Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.

* Update euler-method.english.md

* Update euler-method.english.md

* Update euler-method.english.md

Added parameter description  fixing the suggested changes.

* Update euler-method.english.md

Removed some formatting from the added text.

* Update euler-method.english.md

Moved seed function parameter description to instructions section.
2020-08-25 08:37:10 -07:00
Joseph Mawa fc1200ae2c
Update greatest-subsequential-sum.english.md (#39422)
Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.
2020-08-19 08:04:47 -07:00
Oliver Eyton-Williams c40eab94b7 fix(curriculum): add missing .english extensions 2020-08-16 04:45:17 +05:30
Kartik Soneji f813dfff87
fix: Replace Array.prototype.sort and update old isSorted method. (#39360)
* fix: Replace Array.prototype.sort and update old isSorted method.

* fix: Change name of function from 'checkInBuiltSort' to 'checkBuilitInSort'.

* fix: Change name of function from 'checkBuilitInSort' to 'isBuiltInSortUsed'.
2020-08-10 13:31:18 -07:00
Amy Gurski 8996fa7502
fix: rosetta day of week typos (#39380)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-08 19:00:29 -07:00
Kartik Soneji f844ea3620
fix(learn): Add arguments to test case titles. (#39248) 2020-07-23 23:39:17 -07:00
Kartik Soneji 7a51540127
fix(learn): Add arguments to test case titles. (#39247) 2020-07-23 23:36:37 -07:00
Kartik Soneji df3322eb97
Add descriptive titles for Extensible Prime Generator challenge (#39246)
* fix(learn): Add descriptive titles to tests.

* fix: Add missing word.

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* fix: Display expected output to user.

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-07-23 23:28:16 -07:00
Bhanu Pratap Singh Rathore fbdba9edb1
feat(interview-prep): Converting and Tranfering Rosetta challenges (#38754)
* feat(interview-prep): Converting and Tranfering Rosetta challenges
2020-07-20 12:02:06 +09:00
c-logan ca2b97f11e
commit 7/8 Rosetta tokenize (#39213) 2020-07-08 17:21:01 -05:00
Rajat Gupta fd2ca5cf40
Add: forumTopicId for rosetta code (#38855) 2020-06-08 20:07:41 +05:30
Mrugesh Mohapatra 8248d704ce fix: move around new CIP challenges
Move newly added rosetta code challenges
2020-05-27 13:19:15 +05:30