f6196b0c7d
Improve test cases of Record Collection challenge
2016-02-12 19:15:28 +05:30
858546e3ec
Migrate invalid Challenge IDs
2016-02-10 15:18:48 -08:00
b5e8f84dae
Fix test for Iterate Through An Array With For Loop
2016-02-10 06:29:11 +07:00
4def4278ef
Clarify "Nest one Array..." challenge to include multiple arrays
2016-02-06 11:27:54 -08:00
bf2c944b87
Merge pull request #6729 from alistermada/fix/test-for-loop-challenge-too-strict
...
Fix test for Iterate Through an Array with a For Loop
2016-02-05 20:35:57 -08:00
ed66e1c060
Make Iterate Through Array for loop test less strict
2016-02-05 14:21:49 +07:00
0a33d45368
Fix Range Error : Maximum Call Stack Size Exceeded
...
This commit fixes the `capture` console.log, with an alternate logic
to resolve the objects with correct scope.
Refer the PR FreeCodeCamp/FreeCodeCamp#6681 discussion for details.
Tested locally.
Updated fix to resolve broken CI
2016-02-04 14:51:37 +05:30
2d63a3d5fa
Merge pull request #6562 from SaintPeter/fix/restore-es-translations
...
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
6b8c2bb220
Add Instructions Clarification to Using Objects for Lookups
...
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
4feae4a768
Changed 'will gives' to 'will give'
...
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
b4e35cb535
Clarify escape literal quotes instructions
...
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
you do not actually need to print it
2016-01-31 01:39:47 -08:00
29e50b4bc5
Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
...
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
3e6b2f34f5
Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
...
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
42ec641645
Fix the test case for Comparison with operators
...
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.
I intentionally, changed the assert for one case and message for other
Tested locally.
2016-01-30 11:45:40 +05:30
a3c9d1fce6
Add a hint to Return Early Pattern for Functions
...
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.
Tested locally.
2016-01-30 11:34:11 +05:30
a04fa02d7c
Fix for "Multiple Identical Options in Switch Statements"
...
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
317b27b614
Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
...
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
cee3b691ef
Fix test case in Comparisons with the Logical And Operator
...
This fixes the test case to do the correct assert as per the message.
tested locally.
2016-01-29 13:55:59 +00:00
6094a9da12
Fix the release year for Billy Joel - Piano Man
...
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!
Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
6af6091793
Restore Prior Spanish Translations to basic-javascript.json
...
Tested Locally
Please review, @vtamara
2016-01-28 20:07:34 -08:00
a006e48738
Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
...
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
85637d0ba7
Fix test for Comparison with the Equality Operator
2016-01-28 11:15:52 +07:00
81d514a8ca
fixing regex asserts
...
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*
Mistakenly had strict comparisons changed, reverted those.
fixed typo
one last typo
how did i miss so many errors
last error i hope
..last .. one ..
2016-01-28 03:15:13 +00:00
a890c1de07
Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value
...
Assignment with a Returned Value - Improved Challenge Seed
2016-01-27 10:58:27 -08:00
95995b4731
Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript
...
Add more tests for Basic JavaScript challenges
2016-01-27 10:55:59 -08:00
a5096f9523
Improved Challenge Seed
...
Assignment with a Returned Value .
2016-01-26 21:36:55 +06:00
aaba9283ac
Adds spaces between paragraphs
...
Tested locally. Closes #6374
2016-01-26 07:36:55 -08:00
e5aff5d451
Remove extra spaces from Basic Javascript challenge description
2016-01-26 17:24:21 +07:00
a707a77af9
Add more tests for Basic JavaScript challenges
2016-01-26 16:37:26 +07:00
ee0feee70f
Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json
...
Fix the instruction text in the Accessing Nested objects challenge
2016-01-25 11:53:24 -08:00
4c00a60331
Removed double quotes
...
closes #5825
2016-01-25 21:19:59 +06:00
02cff5f6ab
Fix the instruction text in the Accessing Nested objects challenge
...
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.
closes #6422
2016-01-25 12:13:50 +00:00
1185447c12
Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor
...
Remove unnecessary spaces in the editor
2016-01-25 11:11:25 +04:00
588bc3ecd6
Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links
...
Added "target='_blank'" to links missing them
2016-01-25 11:09:56 +04:00
05c0322a19
Added "target='_blank'" to links missing them
2016-01-24 12:46:30 -08:00
cdc3f52b0c
Remove extra word of 'use' in range challenge
2016-01-24 12:24:41 -08:00
211ef7fec3
Remove unnecessary spaces in the editor
2016-01-24 12:19:26 -08:00
218b8e2f5b
fixed an issue #6380 .... basic-javascript.json
...
added 'or' in between greater than equal to.
2016-01-23 01:43:22 +06:00
ef73666a62
fixed typo in seed/challenges/01-front-end-development-certification/basic-javascript.json, removed extra , at the end of the array
2016-01-22 08:16:38 -06:00
dc014baac9
Remove extra parenthesis in unshift challenge
2016-01-21 22:17:05 -08:00
f4ce9f2a22
Merge pull request #6337 from SaintPeter/fix/record-collection-description
...
Update Record Collection with Bracket Notation Note
2016-01-21 22:02:35 +04:00
cbb75aeeac
Merge pull request #6357 from ChristianLapinig/fix/basic_js-comparison_eqaulity_operator-correct_instructions
...
Grammar fix for Comparison with the Equality Operator
2016-01-21 08:56:33 -08:00
ec148ea5e1
Update Record Collection with Bracket Notation Note
2016-01-21 08:53:59 -08:00
3b7c4ed0e5
Correct grammar for instructions
2016-01-20 23:23:57 -08:00
f9c2da7d6a
Normalize Challenges for COM1000
2016-01-20 15:45:32 -08:00
9e9de2fa2a
Merge pull request #6341 from erictleung/fix/clarify-instructions-for-dot-operator
...
Clarify instructions for dot operator challenge
2016-01-20 12:42:26 -08:00
3e9bd8500f
Clarify instructions for dot operator challenge
2016-01-19 23:36:36 -08:00
c0cbba6efe
Be more specific on what decimal number is needed
2016-01-19 21:15:28 -08:00
04fd94e2cd
Merge pull request #6316 from raisedadead/fix/remove-typeof-error-basic-javascript
...
Remove unnecessary parentheses around the typeof
2016-01-19 12:56:08 -08:00
9ae52adc89
Remove unnecessary parentheses around the typeof
...
This commit:
* removes unnecessary parentheses around the typeof
* certain cases were ignored, to prevent a test case failure for example as in:
- assert(typeof(runSlots($(\".slot\"))[0]) ...
This PR is an additional fix in relation to code review comments on FreeCodeCamp/FreeCodeCamp#6181
2016-01-19 14:17:43 +00:00
Ankit Aggarwal
Rex Schrader
Alister N. Mada
Joshua Henson
Mrugesh Mohapatra
Quincy Larson
BKinahan
Eric Leung
Hallaathrad
robjloranger
Tahmid ul karim
Eric Leung
Arsen Melikyan
greyhammer
Christian Lapinig