Commit Graph

16540 Commits (f85a6f7f2eef001e9e7c675de5cdacfb55e6ac9e)

Author SHA1 Message Date
Felix Yan 2dd7249057 Fix typos in seed/challenges/06-information-security-and-quality-assurance/information-security-with-helmetjs.json 2017-08-05 03:23:45 +08:00
Felix Yan 308304d36c
Fix typos in seed/challenges/06-information-security-and-quality-assurance/information-security-with-helmetjs.json 2017-08-05 03:23:45 +08:00
Berkeley Martinez c547c26bba Fix: map should redirect to current challenge (#15723)
* fix(routes): /map redirects to current challenge

* fix(map): Normalize server map building

Localize all server code dealing with the map

* refactor(server): Remove unused services

* feat(Nav): Show Map button when no panes

This gives user the ability to quickly return to their challenge using a
known feature

* fix(server.map): Add caching to nameIdMap

Add caching to nameIdMap on the server

* fix(services.map): Fix map service

Move map building utils to map util. Fix bad import. Normalize challenge
lookup
2017-08-03 22:45:36 -05:00
Usman Hussain 655366692f fix(seed): Function name findLongestWord changed
The function name findLongestWord is a little misleading as the
challenge asks to return the length of the word not the word itself.
Name findLongestWordLength is perfect.

BREAKING CHANGE: Function name changed
2017-08-03 11:25:45 +05:00
Usman Hussain e20916f9b0 fix(seed): Function name findLongestWord changed
The function name findLongestWord is a little misleading as the
challenge asks to return the length of the word not the word itself.
Name findLongestWordLength is perfect.

BREAKING CHANGE: Function name changed
2017-08-03 11:25:45 +05:00
Dylan dc048c21c8 Merge pull request #15670 from prateekgoel/fix/move-fahrenheit-variable
Move Fahrenheit Variable Below Comment Line
2017-08-01 11:22:23 -05:00
Dylan f92294bbda Merge pull request #15670 from prateekgoel/fix/move-fahrenheit-variable
Move Fahrenheit Variable Below Comment Line
2017-08-01 11:22:23 -05:00
Dylan b5f4924e6b Merge pull request #15679 from Manish-Giri/fix/allow-shorthand-hex-values
Allow shorthand Hex values in challenge
2017-08-01 10:09:06 -05:00
MANISH-GIRI c681897bd2 Allow shorthand Hex values in challenge 2017-08-01 01:22:56 -04:00
MANISH-GIRI a4946902a6 Allow shorthand Hex values in challenge 2017-08-01 01:22:56 -04:00
Berkeley Martinez 42bfa2e64d feat(app): new layout (#14707)
* feat(app): Restructure app to be more flexible and redux idiomatic

BREAKING CHANGE: Lots of breaking changes

* refactor(challenges): Redux to started file structure

* fix(app): lint issues due to refactor

* fix(settings): Refactor settings to use folder structure

* refactor(challenges): Move step redux stuff into step folder

* fix(challenges): Remove fetchchallenges actions

* refactor(challenges): Move project redux logic into project view subdirectory

* refactor(app): %s/sagas/epics/g

* refactor(redux): Use new redux-epic with combineEpic and ofType

* refactor(app): Move challenge selector to app level

* fix(app): Move loading challenge info into challenge route

This moves a lot of the logic needed to load challenge info into the challenge app. This decouples
the main app from the challenge route

* refactor(map): Map is now decoupled from challenges

* refactor(challenges): Use selectors everywhere instead of guessing state shape

* refactor(client): refactor client epics to use selectors

* refactor(app): Refactor userSelector to return user object instead of object.user

* refactor(entities): Move entities logic into it's own file

* fix(redux): combineTypes should be combineActions

* fix(app): reducer namespacing and import

* fix(Map): Fix undefined type and update redux-action

* fix(redux): Refactor fetchUser to be more declarative

Use rxjs methods instead of imperative if/else. Also prevent non-actions from being emitted

* fix(redux): toString multi phase action types

* fix(redux): typecast multiphase type, fix typo in reducer

toString multiphase types in fetch challenge epic. Add epic to epics lists. Fix type in fetch
challenge complete handler

* fix(redux): updateCurrentChallengelogic should be centerlized

Move route changes to one location.

* fix(Nav): Prevent event object from hanging around

closeDropDown/openDropDown where handing on to the event object. This was causing issues with react
since event objects are recycled in React.

* fix(Map.Challenge): decouple map selector

* fix(Map): Decouple panel selectors from props

Panel Selectors no longer need to know the shape of a components props. Refactored component
selectors to decouple them entities state shape

* fix(Map.redux): Add select challenge epic and connect map epics

* fix(redux.analytics): Fix meta creator and nav/map events

* fix(redux): Update current challenge ajax

* fix(challenges): ssr fetch challenge should update challenge ui

Was using an epic to update challenge ui on fetch complete, but this was not working on ssr due to
the way ssr disables epics to wait for completion. This commit fixes this by causing the complete to
directly update state in the challenge ui

* fix(challenges): wrong import of types, refactor epic name

* fix(redux): Prevent fetch challenge epic from emitting null to dispatch

* fix(redux): prevent executechallenge from emitting null

* fix(challenges.redux): testsSelector returns just tests

* fix(challenges.redux): Prevent completion challenge from emitting null

* refactor(Challenges.Step): Refactor step challenge to release event object

* fix(redux): wrap reducers in factories
reducers exported from features need to be factories
this helps avoid cyclic requires messing up reducer creation
We end up with exports from files being undefined as node tries
to resolve cyclic dependencies.
This prevents that by wrapping the `handleActions` call so that the ref
to types imported from parent features are closures and can be resolved
by node before we need them.

* fix(Map): createUi not working correctly

map utils should receive just map ui state, createMapUi needs to add title to challenge

* feat(Challenges): Adds Panes and panes backend challenge

* fix: Create child container to wrap children

Create a ChildContainer comp' to wrap all children that represent the view for the current route.
This let's the child route define if they want a full width view or if they want the standard
max-width view.

* feat(Panes): panes now render dividers

* feat(Panes): Get divider to move currectly

* fix(Nav): Add top margin to contained childs

Move margin-bottom from nav to child container as margin top. This let's the jsbin style views fit
snug with navbar

* fix(Panes): Should be contained within their borders

* feat(Panes): Update navbar height of pane on app mount

* feat(Panes): Toggle map on map nav btn click

* fix(gulpfile): Ensure nodemon exits on restart

On process exit, wait for nodemon to shutdown before process.exit

* feat(Panes): Make Panes redux first

* fix(Panes): Fix divider positioning

* fix(Panes): Update divider moved handler

dividerMoved action now uses new panesByName structure

* feat(Panes): Pane nav button will hide panes

* chore(package-lock): Update package lock

* feat(Panes.redux): Recaculate dividers on pane toggle

* fix(Challenges): Update challenge on dashedName change

This fixes backwards navigation not updating the redux state current
challenge

* feat(Panes.redux): Clear panes on unmount

Clearing panes on unmount will clear bin buttons in nav

* refactor(Map): Colocate styles

* feat(Map): New map layout

* fix(Map): No longer has it's own page

* fix: FetchChallenges on appMounted

* feat: Normalize fetchChallenge(s) results

This allows superblocks to be sent with both fetchChallenge and
fetchChallenges so the map is always populated on first load

* feat(Map): Show blocks on first load

* fix(less): Remove old css

* feat(Nav): Reduce nav height

* fix(Nav): Render nav after content

Render nav after content and use css to reverse again on screen. We do
this so the panes can render first and update redux panes state which
will then update the nav ui state before nav has a chance to render

* fix(Panes): Add container

This adds a Panes Container that will allow it to udpate redux state so
Panes Component will have redux state ready to actually render panes

* feat(Challenges.Classic): Add panes

* fix(Challenge.Classic): Editor onchange should not need to know about file

* fix(Panes): Index on panes hide should account for hidden pane

* fix(Challanges.Classic): Fix panes types

* fix(Challenges): Add completion modal to all challenges

Change classic modal to completion modal

* fix(Panes): Dividers live on top of planes

* fix(Challenges): Remove codemirror theme

Remove codemirror theme and remove borders from preview frame

* fix(Challenges.Classic): Remove old component

* feat(Challenges.Step): Add panes to step challenge

* feat(Challenges.Project): Add panes to projects

* fix(Challenges.Projects): Remove row

* fix(Modals): Move modal text color to challenge less

This text color is dependent on the actual header color

* fix(Map): Use Superblock title for ui

* fix(Map): Reduce panel header height

* fix(app): Capitalize Toasts folder

Feature folders should be campitalized

* chore(Map): Remove unused epic file

* fix(Step): Fix tests

* test(Map): Update createMapUi tests input
2017-07-31 22:04:01 -05:00
Berkeley Martinez 7a75e25475 Merge pull request #15671 from dhcodes/fix/modal-title-color
fix(styles): Change modal title color
2017-07-31 13:50:14 -07:00
Prateek c06fd79f87 Changes post review again 2017-08-01 01:31:51 +05:30
Prateek ca32658c70 Changes post review again 2017-08-01 01:31:51 +05:30
Prateek 380491784e Changes post review 2017-08-01 01:30:24 +05:30
Prateek 56c81c86f1 Changes post review 2017-08-01 01:30:24 +05:30
Shubham Sharma 763f570d13 fix(challenges): Change hyperdev link to glitch (#15694)
Closes #15691
2017-07-31 14:33:42 -05:00
Shubham Sharma 791b16860d fix(challenges): Change hyperdev link to glitch (#15694)
Closes #15691
2017-07-31 14:33:42 -05:00
Dylan 989816be1e Merge pull request #15682 from marigerr/fix/anchor-link-to-internal-section-challenge
internal link lesson - remove obsolete name attribute
2017-07-28 10:42:06 -05:00
Dylan 8dd2c899ff Merge pull request #15682 from marigerr/fix/anchor-link-to-internal-section-challenge
internal link lesson - remove obsolete name attribute
2017-07-28 10:42:06 -05:00
Markus Englund b96c4d39f5 docs(contributing): Add correct commands for installing and running mo (#15686)
Closes #15648
2017-07-28 19:13:29 +05:30
marigerr 85cbbc87f5 interal link lesson - remove obsolete name attribute 2017-07-28 07:54:12 +02:00
marigerr 43bb6272d6 interal link lesson - remove obsolete name attribute 2017-07-28 07:54:12 +02:00
Manish Giri d2d38f6db7 Edit test to ensure opacity at 50% in keyframes (#14390) 2017-07-25 21:37:24 -04:00
Manish Giri 880f092a3f Edit test to ensure opacity at 50% in keyframes (#14390) 2017-07-25 21:37:24 -04:00
dhcodes bc46368750 fix(styles): Change modal title color
Closes #15588
2017-07-25 09:07:03 -05:00
Dylan b3e0d96b7c Merge pull request #15676 from Manish-Giri/fix/check-function-invocation
Add check for function invocation
2017-07-22 21:10:02 -05:00
MANISH-GIRI e9f141ed44 Add check for function invocation 2017-07-22 16:18:30 -04:00
MANISH-GIRI b28c4869aa Add check for function invocation 2017-07-22 16:18:30 -04:00
Jonathan Meier 074869d5c2 refactor(seed): Add break; to default statement on switch challeng (#15673)
Closes #15131
2017-07-22 01:30:22 -05:00
Jonathan Meier 14bcb00323 refactor(seed): Add break; to default statement on switch challeng (#15673)
Closes #15131
2017-07-22 01:30:22 -05:00
Prateek Goel 27262eb9f7 Move Fahrenheit Variable Below Comment Line
Challenge URL: https://www.freecodecamp.org/challenges/convert-celsius-to-fahrenheit
2017-07-20 16:37:36 +01:00
Prateek Goel 51d7514992 Move Fahrenheit Variable Below Comment Line
Challenge URL: https://www.freecodecamp.org/challenges/convert-celsius-to-fahrenheit
2017-07-20 16:37:36 +01:00
Berkeley Martinez f61cc28751 Merge pull request #15637 from raisedadead/fix/update-snyk-config
chore(snyk): Update snyk config
2017-07-17 16:34:20 -07:00
Berkeley Martinez 9d90c3f9d8 Merge pull request #15187 from raisedadead/fix/placeholder-project-view
fix(frontend-projects): replace video with image thumbnail
2017-07-17 16:33:41 -07:00
Berkeley Martinez de0101328f Merge pull request #15187 from raisedadead/fix/placeholder-project-view
fix(frontend-projects): replace video with image thumbnail
2017-07-17 16:33:41 -07:00
Dylan cf49d5eefa tweak description on nest many elements ch. (#15597) 2017-07-17 22:21:19 +05:30
Dylan 59433eefda tweak description on nest many elements ch. (#15597) 2017-07-17 22:21:19 +05:30
Dylan 190fa94c54 Merge pull request #15098 from charlesBak/fix/arrow-function-with-param
Add test to Arrow functions with input parameters
2017-07-16 21:21:27 -05:00
Dylan ffa03c9483 Merge pull request #15098 from charlesBak/fix/arrow-function-with-param
Add test to Arrow functions with input parameters
2017-07-16 21:21:27 -05:00
Mrugesh Mohapatra 7acb1db632 fix(snyk): Remove snyk config 2017-07-16 23:53:43 +05:30
Dylan 90f8b0adb1 Merge pull request #15647 from MiloATH/fix/linked-list-size
Rename length() as size()
2017-07-15 22:13:16 -05:00
Dylan 08bcc6ce5c Merge pull request #15647 from MiloATH/fix/linked-list-size
Rename length() as size()
2017-07-15 22:13:16 -05:00
Shubham Sharma 5baec5e56a fix(challenges): Change "loop" to "function" (#15649) 2017-07-15 22:42:00 +05:30
Shubham Sharma 7d3313a1fa fix(challenges): Change "loop" to "function" (#15649) 2017-07-15 22:42:00 +05:30
Milo Hartsoe 1a1002fc0f Rename length() as size() because the solution and future challenges use size() 2017-07-14 23:50:54 -04:00
Milo Hartsoe c478f30997 Rename length() as size() because the solution and future challenges use size() 2017-07-14 23:50:54 -04:00
Berkeley Martinez 4334c8115d Merge pull request #15643 from raisedadead/feat/enforce-conventional-commit-messages
feat: Enforce conventional commit messages
2017-07-13 12:55:07 -07:00
Berkeley Martinez 67dcf7f42c Merge pull request #15641 from raisedadead/fix/remove-varci-bot
fix(Var-CI): Remove the Var-CI bot integration
2017-07-13 12:44:33 -07:00
Mrugesh Mohapatra 54d88eca82 feat: enforce conventional commit messages 2017-07-14 00:23:34 +05:30