Commit Graph

108 Commits (fe90c136c3dac734d5199cd132a7d1e268f7b15c)

Author SHA1 Message Date
Bannon Tanner 9ebaa10eea added clarification in test text (#26458)
* added clarification in test text

fix to issue #17490

* moved the note from the test text to description

* fix: updated note sytnax
2019-03-08 14:01:47 +05:30
nik 304d36ab47 fix(challenge): decrease opacity testString (#34711) 2019-03-05 12:11:27 -05:00
Randell Dawson b7fee2848c fix(curriculum): Corrected test which allowed wrong solution to pass (#35394)
* fix: corret-wrong-checks-in-test

* fix: improved robustness of test

* fix: added a full working solution for challenge

* fix: added && to asssert
2019-03-04 12:33:02 -06:00
Randell Dawson 6db2e12e9e fix: Removed unnecessary note from instructions (#35502) 2019-03-03 23:56:22 -06:00
lasjorg 25ea44edf5 fix(challenge): allow new line in linear-gradient formatting (#35435)
* fix(challenge): allow new line in linear-gradient formatting

* fix(challenge): update test with suggested changes

* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
Dana Ottaviani 3d1fd805e6 feat: add solution to accessibility challenge (#35484) 2019-03-01 20:03:38 -05:00
Alan Nguy 1957b1f636 fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. (#35177)
* fix: added test case for empty li elements

* fix: added error message in test case of empty li elements.

* fix: corrected error in test case.

* fix: added valid working solution

* fix: migrated test case to challenge: create-an-ordered-list (working solution included)

* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
kevindelsh e40909b055 Corrected minor spelling error (#34750)
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson ab456a9a94 fix: changed js to html in solution section (#35414) 2019-02-25 22:50:58 -05:00
Paul Gamble 0c652e3ace feat: curriculum-basic-html-form-element-solution (#34956) 2019-02-25 22:23:08 -05:00
The Coding Aviator cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00
Dana Ottaviani 30fd0aa78e fix: add solution for accessibility challenge (#35366) 2019-02-25 21:58:35 -05:00
Bannon Tanner fe07433d0e fixed typo with instructions and preview (#26088)
* fixed typo with instructions and preview

Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes #18034

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md

suggested change by @thecodingaviator

Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>

* possible fix for solution

* apply my suggestioned changes
2019-02-25 15:50:00 -08:00
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
Chad a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Beau Carnes 2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Dana Ottaviani 9562bf0baa Solution to implementing an accessible date picker (#35262)
* feat: add challenge solution

* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Aditi Joshi 2e388035ca Fix/update challenges for basic html and html5 (#35234)
* fix: challenge for basic html and html5 - test

* Delete use-if-and-else-to-add-logic-to-your-styles.english.md

* fix: Resolving merge conflict

* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
Riyaad Azad 2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
The Coding Aviator 54264157ee Added more clarification on how to use z-index (#34934)
* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md
2019-02-18 00:46:14 +05:30
Bannon Tanner 4734ff4154 nest anchor within paragraph instructions modification (#26441)
* modified wording to be more clear

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear

* fix: removed change not needed
2019-02-17 23:54:13 +05:30
Nelson Wu 6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
Gökhan Gurbetoğlu 16eb18954e Small change: remove unintentional whitespace (#34418)
On other challenges, only the affected places would have a placeholder whitespace, if there is one. Removed the unnecessary ones from this challenge.
2019-02-17 04:52:52 -05:00
Melkisedek Hamakali a0c00de32b Use correct spelling of navigable (#34817) 2019-02-17 01:52:19 -08:00
Almaz Kunpeissov 79af29dd2b Adding code styling to property value. (#34463)
Adding <code> styling for property value infinite in the ## Instructions.
2019-02-16 22:02:33 -08:00
Oliver Eyton-Williams ba9e45023d fix: make border radius challenge Firefox compatible (#35009)
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
2019-02-16 17:17:11 +00:00
Leo db63a354ee Deleted comma and removed first person (#35034) 2019-02-16 08:50:46 -08:00
The Coding Aviator 99ac0b6938 Update use-grid-area-without-creating-an-areas-template.english.md (#34852) 2019-02-16 20:52:20 +05:30
Eunice Brackett 21f5427c14 Media query solution for Responsive Web Design (#33991)
* Media query solution for Responsive Web Design

This is in response to the required solution for the challenge solution section.

* fix: solution
2019-02-16 19:13:54 +05:30
Randell Dawson 9c3145ea49 fix: improved the grammar and readability (#35133) 2019-02-16 18:02:35 +05:30
Dana Ottaviani bad8846e04 feat: add solution to accessibility challenge (#35131) 2019-02-16 18:00:42 +05:30
Dovid Majowka 16ef2639c0 Updated wrong guideUrl to correct one (#35066)
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md

* Use standard link for guide URLs

* fix: corrected guideUrl

* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
Zach 2fea8d89f4 Update add-columns-with-grid-template-columns.english.md (#33544)
Fixed wording order for 'each' when asking to set column width.
2019-02-15 17:40:32 -08:00
Anas Salam ec9fffb222 solution to Challenge ID:bad87fee1348bd9aedd08835 (#33391)
* solution to Challenge ID:bad87fee1348bd9aedd08835

solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default

* fix: solution
2019-02-15 11:19:03 -08:00
Greg Brewton 7687f26c56 Information correction (#28582)
Eliminated the line  (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
2019-02-15 14:13:32 -05:00
gokulsg 63c5a94321 Expected solution for the challenge seed code (#32532)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
2019-02-15 12:48:30 -05:00
Howard T. Chiam c08ba2f654 Empty line not needed. (#34812) 2019-02-15 00:32:40 -08:00
JustinBen-Tzioni ba0d4fb15f Improved grammar and message (#28795)
* Improved grammar and message

* Update import-a-google-font.english.md
2019-02-14 13:38:58 -08:00
JustinBen-Tzioni 7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
gokulsg 2b91676e72 Expected solution for the challenge seed code (#32523)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution section syntax
2019-02-14 14:35:21 -05:00
SGokul1 08b9c3c7fb I have updated the solution for this file. (#31749)
* I have updated the solution for this file.

I have added the expected output of the  challenge seed code.

* Update add-a-submit-button-to-a-form.english.md

Placed solution in ```html tags

* Update add-a-submit-button-to-a-form.english.md
2019-02-14 11:28:40 -08:00
gokulsg 60c93a8300 Expected solution for the challenge seed code (#32522)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution syntax
2019-02-12 08:19:56 -08:00
gokulsg a589042f88 Expected solution for the challenge seed code (#32537)
I have updated the expected output for the challenge seed code.
2019-02-11 23:45:55 -08:00
Bannon Tanner b24f606847 added example to make description clear (#26492)
Added example in the description for understanding that the width of the element is still set using the width property in CSS.
fixes issue #17617
2019-02-11 18:28:07 -08:00
The Coding Aviator 9c881dcc6e Fixed issue with accessibility challenge about contrast (#19711)
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
Cryotechnic 80e80a4c8b Word Correction (#29689)
* Word Correction

Some words were missing, making the sentence sound grammatically incorrect.

* fix: removed the word its
2019-02-10 07:51:00 -08:00
Naveen f6f58d3228 Remove unwanted comma (#26050) 2019-02-10 07:33:56 -08:00