Commit Graph

571 Commits (ff53235efd2af9213baa8fb89cc3f0894d94d8a6)

Author SHA1 Message Date
Alex 06311a56f6 Fixed the code formatting for readability (#25831)
I fixed the code formatting for readability. Made the spacing easier to see so updates and changes could be made more easily.
2019-02-25 21:03:32 +01:00
lolabarri 0a228ab8e8 Update build-a-tribute-page.spanish.md (#23321)
Modified user history number 7, so it has the same format as the others. Also modified last line, which was too informal compared with the rest of the article
2019-02-25 20:37:02 +01:00
riodajs ca24e4bca2 Update traduction from some words (#23314) 2019-02-25 20:34:56 +01:00
Nellie ff23e94e25 Update add-elements-within-your-bootstrap-wells.russian.md (#28969)
Fixed Russian translation in add-elements-within-your-bootstrap-wells.english.md.
2019-02-25 21:58:59 +04:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
NITIN BISHT f224bbc62f fix: seed code doesn't match description [arabic] (#35382) 2019-02-24 16:29:51 -06:00
Adam 36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00
Ahmed Elbessfy 61a5707ba7 Edit Description (#34329)
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
NITIN BISHT a9e4e88cbe fix: seed code doesn't match description [russian] (#35384) 2019-02-24 09:59:49 -06:00
NITIN BISHT 1fd4177354 Fix/seed code does not match description chinese (#35381)
* fix: seed code doesn't match description [english]

* fix: seed code doesn't match description [chinese]
2019-02-24 09:08:10 -06:00
NITIN BISHT b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
NITIN BISHT 815cb03f2b fix: seed code doesn't match description [portuguese] (#35383) 2019-02-24 08:26:33 -06:00
riodajs d341c16aae Add some words (#23297)
like "uncomment" to "borrando etiquetas de comentarios"
2019-02-24 14:26:49 +01:00
riodajs 83ff4a53e7 Change some words conjugations. (#23261) 2019-02-24 13:46:29 +01:00
riodajs a5e5e1de50 Changet text "Usted especifique" to "tú especificas" (#23226) 2019-02-24 13:46:04 +01:00
Edwin J. Munguia 803836db66 Translated remaining English text into Spanish (#23132) 2019-02-24 12:54:56 +01:00
Santiago 4f1f4238c2 Small Consisteny Fixes (#34107)
Consistency with the 'tu' way of refering to you.
Translated the html code part to spanish
2019-02-24 12:53:46 +01:00
Diego Arias García f1efc85ccb Fixed Translation Errors (#22754) 2019-02-24 12:07:59 +01:00
Diego Arias García 1ee9f6223c Grammar Errors fixed (#22749) 2019-02-24 12:00:56 +01:00
NITIN BISHT c9628f0296 fix: seed code doesn't match description [spanish] (#35385) 2019-02-24 13:47:08 +05:30
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Carlos Pulido e7718db53e Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.spanish.md (#31200) 2019-02-23 23:49:23 +01:00
Chad a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Randell Dawson bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Octabond 603585e39e Update tests and challenge seeds (#25588)
Update tests and challenge seeds with spanish instructions
2019-02-22 20:05:09 +01:00
Lewis Horwood 9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
Beau Carnes 2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00
Ignacio Garcia a21e287b00 Translated commented section of Solución (#22746) 2019-02-22 18:48:57 +01:00
Rodolfo b032399525 Update create-a-bulleted-unordered-list.spanish.md (#22712)
Added a "de" connector to correct translation
2019-02-22 18:44:56 +01:00
Rodolfo 1d1064c83b Update check-radio-buttons-and-checkboxes-by-default.spanish.md (#22710)
Removed instance of snippet that was present 2 consecutive times in a sentence (and in the english version is only one time)
2019-02-22 18:44:15 +01:00
Rodolfo 8a2481282e Update add-placeholder-text-to-a-text-field.spanish.md (#22704)
Removed instance of snippet that was present 2 consecutive times in a sentence (and in the english version is only one time)
2019-02-22 18:42:44 +01:00
TristanSeabrook ce2b46926f removed ungrammatical apostrophe (#35355)
changed "it's" to "its"
2019-02-22 03:14:30 -08:00
TristanSeabrook d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook 7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson 37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
olga1blinova 3b6f0f8ef4 Translation improvements. (#28491) 2019-02-21 15:22:42 +04:00
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694)
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Breno Xavier acab326f8a Fix text to follow portuguese language syntax (#19077)
Change the positions of some words to be in accordance with the syntax rules of the Portuguese language.
2019-02-20 11:14:53 -03:00
Andrey Leontev e68e75639c fix syntax and lexical errors in ES6 1-4 les (#26726)
* fix syntax and lexical errors

* fix syntax errors  in Create an Export Fallback

* fix syntax and lexical errors in Template Literals

* fix syntax and lexical errors in es6 const declare

* Improved 'Russian' translation
2019-02-20 12:56:36 +04:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648)
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00