From 46054afd223466ee0c04b6dec0b7139eb0f26041 Mon Sep 17 00:00:00 2001
From: RazCrimson <52282402+RazCrimson@users.noreply.github.com>
Date: Sun, 8 Sep 2024 12:49:23 +0530
Subject: [PATCH] chg: globals - json lib preference: orjson > ujson > json

---
 glances/globals.py             | 28 +++++++++++++++++++++-------
 glances/plugins/ip/__init__.py |  6 ++----
 2 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/glances/globals.py b/glances/globals.py
index b9e2767b..86e4f6b2 100644
--- a/glances/globals.py
+++ b/glances/globals.py
@@ -16,6 +16,7 @@
 import base64
 import errno
 import functools
+import importlib
 import os
 import platform
 import queue
@@ -36,15 +37,28 @@ from xmlrpc.server import SimpleXMLRPCRequestHandler, SimpleXMLRPCServer
 
 from defusedxml.xmlrpc import monkey_patch
 
-# Optionally use orjson if available
-try:
-    import orjson as json
-except ImportError:
-    import json
-
 # Correct issue #1025 by monkey path the xmlrpc lib
 monkey_patch()
 
+# Prefer faster libs for JSON (de)serialization
+# Preference Order: orjson > ujson > json (builtin)
+try:
+    import orjson as json
+
+    json.dumps = functools.partial(json.dumps, option=json.OPT_NON_STR_KEYS)
+except ImportError:
+    # Need to log info but importing logger will cause cyclic imports
+    pass
+
+try:
+    import ujson as json
+except ImportError:
+    # Need to log info but importing logger will cause cyclic imports
+    pass
+
+if 'json' not in globals():
+    import json
+
 ##############
 # GLOBALS VARS
 ##############
@@ -303,7 +317,7 @@ def urlopen_auth(url, username, password):
     return urlopen(
         Request(
             url,
-            headers={'Authorization': 'Basic ' + base64.b64encode((f'{username}:{password}').encode()).decode()},
+            headers={'Authorization': 'Basic ' + base64.b64encode(f'{username}:{password}'.encode()).decode()},
         )
     )
 
diff --git a/glances/plugins/ip/__init__.py b/glances/plugins/ip/__init__.py
index 62a95658..3a66d702 100644
--- a/glances/plugins/ip/__init__.py
+++ b/glances/plugins/ip/__init__.py
@@ -10,9 +10,7 @@
 
 import threading
 
-from orjson import loads
-
-from glances.globals import queue, urlopen_auth
+from glances.globals import json_loads, queue, urlopen_auth
 from glances.logger import logger
 from glances.plugins.plugin.model import GlancesPluginModel
 from glances.timer import Timer, getTimeSinceLastUpdate
@@ -245,7 +243,7 @@ class PublicIpInfo:
             queue_target.put(None)
         else:
             try:
-                queue_target.put(loads(response))
+                queue_target.put(json_loads(response))
             except (ValueError, KeyError) as e:
                 logger.debug(f"IP plugin - Cannot load public IP information from {url} ({e})")
                 queue_target.put(None)