mirror of https://github.com/nicolargo/glances
Lint the code
parent
917f01a830
commit
82bbd00b6c
2
Makefile
2
Makefile
|
@ -49,7 +49,7 @@ test: venv-upgrade venv-dev-upgrade ## Run unit tests
|
|||
|
||||
format: venv-dev-upgrade ## Format the code
|
||||
@git ls-files '*.py' | xargs ./venv/bin/python -m autopep8 --in-place --jobs 0 --global-config=.flake8
|
||||
@git ls-files '*.py' | xargs ./venv/bin/python -m autoflake --in-place --jobs 0 --remove-all-unused-imports --remove-unused-variables --remove-duplicate-keys
|
||||
@git ls-files '*.py' | xargs ./venv/bin/python -m autoflake --in-place --remove-all-unused-imports --remove-unused-variables --remove-duplicate-keys --exclude="compat.py"
|
||||
./venv/bin/python -m black ./glances --exclude outputs/static
|
||||
|
||||
flake8: venv-dev-upgrade ## Run flake8 linter.
|
||||
|
|
18
docs/conf.py
18
docs/conf.py
|
@ -12,6 +12,7 @@
|
|||
# All configuration values have a default; values that are commented out
|
||||
# serve to show the default.
|
||||
|
||||
from glances import __version__
|
||||
import sys
|
||||
import os
|
||||
from datetime import datetime
|
||||
|
@ -24,7 +25,6 @@ from datetime import datetime
|
|||
# Insert Glances' path into the system.
|
||||
sys.path.insert(0, os.path.abspath('..'))
|
||||
|
||||
from glances import __version__
|
||||
|
||||
# -- General configuration ------------------------------------------------
|
||||
|
||||
|
@ -223,17 +223,17 @@ htmlhelp_basename = 'Glancesdoc'
|
|||
# -- Options for LaTeX output ---------------------------------------------
|
||||
|
||||
latex_elements = {
|
||||
# The paper size ('letterpaper' or 'a4paper').
|
||||
#'papersize': 'letterpaper',
|
||||
# The paper size ('letterpaper' or 'a4paper').
|
||||
# 'papersize': 'letterpaper',
|
||||
|
||||
# The font size ('10pt', '11pt' or '12pt').
|
||||
#'pointsize': '10pt',
|
||||
# The font size ('10pt', '11pt' or '12pt').
|
||||
# 'pointsize': '10pt',
|
||||
|
||||
# Additional stuff for the LaTeX preamble.
|
||||
#'preamble': '',
|
||||
# Additional stuff for the LaTeX preamble.
|
||||
# 'preamble': '',
|
||||
|
||||
# Latex figure (float) alignment
|
||||
#'figure_align': 'htbp',
|
||||
# Latex figure (float) alignment
|
||||
# 'figure_align': 'htbp',
|
||||
}
|
||||
|
||||
# Grouping the document tree into LaTeX files. List of tuples
|
||||
|
|
|
@ -22,7 +22,7 @@ The return string is a string with one or more line (\n between lines).
|
|||
If the *one_line* var is true then the AMP will be displayed in one line.
|
||||
"""
|
||||
|
||||
from glances.compat import u, b, n, nativestr
|
||||
from glances.compat import u
|
||||
from glances.timer import Timer
|
||||
from glances.logger import logger
|
||||
|
||||
|
|
|
@ -15,7 +15,6 @@ from numbers import Number
|
|||
|
||||
from glances.logger import logger
|
||||
from glances.exports.glances_export import GlancesExport
|
||||
from glances.compat import iteritems
|
||||
|
||||
from cassandra.auth import PlainTextAuthProvider
|
||||
from cassandra.cluster import Cluster
|
||||
|
@ -77,7 +76,7 @@ class Export(GlancesExport):
|
|||
# Keyspace
|
||||
try:
|
||||
session.set_keyspace(self.keyspace)
|
||||
except InvalidRequest as e:
|
||||
except InvalidRequest:
|
||||
logger.info("Create keyspace {} on the Cassandra cluster".format(self.keyspace))
|
||||
c = "CREATE KEYSPACE %s WITH replication = { 'class': 'SimpleStrategy', 'replication_factor': '%s' }" % (
|
||||
self.keyspace,
|
||||
|
|
|
@ -62,7 +62,7 @@ class Export(GlancesExport):
|
|||
|
||||
try:
|
||||
s[self.db]
|
||||
except Exception as e:
|
||||
except Exception:
|
||||
# Database did not exist
|
||||
# Create it...
|
||||
s.create(self.db)
|
||||
|
|
|
@ -16,7 +16,6 @@ from glances.logger import logger
|
|||
from glances.exports.glances_export import GlancesExport
|
||||
|
||||
from elasticsearch import Elasticsearch, helpers
|
||||
from elasticsearch import __version__ as elk_version
|
||||
|
||||
|
||||
class Export(GlancesExport):
|
||||
|
|
|
@ -51,7 +51,7 @@ class Export(GlancesExport):
|
|||
# Check if output folder is writeable
|
||||
try:
|
||||
tempfile.TemporaryFile(dir=self.path)
|
||||
except OSError as e:
|
||||
except OSError:
|
||||
logger.critical("Graph output folder {} is not writeable".format(self.path))
|
||||
sys.exit(2)
|
||||
|
||||
|
|
|
@ -12,12 +12,10 @@
|
|||
import sys
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.compat import iteritems
|
||||
from glances.exports.glances_export import GlancesExport
|
||||
|
||||
from kafka import KafkaProducer
|
||||
import json
|
||||
import codecs
|
||||
|
||||
|
||||
class Export(GlancesExport):
|
||||
|
|
|
@ -9,7 +9,6 @@
|
|||
|
||||
"""RESTful interface class."""
|
||||
|
||||
import sys
|
||||
|
||||
from glances.compat import listkeys
|
||||
from glances.logger import logger
|
||||
|
|
|
@ -10,7 +10,6 @@
|
|||
"""Riemann interface class."""
|
||||
|
||||
import socket
|
||||
import sys
|
||||
from numbers import Number
|
||||
|
||||
from glances.compat import range
|
||||
|
|
|
@ -9,7 +9,6 @@
|
|||
|
||||
"""Statsd interface class."""
|
||||
|
||||
import sys
|
||||
from numbers import Number
|
||||
|
||||
from glances.compat import range
|
||||
|
|
|
@ -17,7 +17,6 @@ import tempfile
|
|||
import logging
|
||||
import logging.config
|
||||
|
||||
from glances.globals import BSD, LINUX, MACOS, SUNOS, WINDOWS, WSL
|
||||
from glances.globals import safe_makedirs
|
||||
|
||||
# Choose the good place for the log file (see issue #1575)
|
||||
|
|
|
@ -198,7 +198,6 @@ class GlancesBottle(object):
|
|||
|
||||
def end(self):
|
||||
"""End the bottle."""
|
||||
pass
|
||||
|
||||
def _index(self, refresh_time=None):
|
||||
"""Bottle callback for index.html (/) file."""
|
||||
|
|
|
@ -1231,15 +1231,11 @@ class GlancesCursesStandalone(_GlancesCurses):
|
|||
|
||||
"""Class for the Glances curse standalone."""
|
||||
|
||||
pass
|
||||
|
||||
|
||||
class GlancesCursesClient(_GlancesCurses):
|
||||
|
||||
"""Class for the Glances curse client."""
|
||||
|
||||
pass
|
||||
|
||||
|
||||
class GlancesTextbox(Textbox, object):
|
||||
def __init__(self, *args, **kwargs):
|
||||
|
|
|
@ -9,7 +9,6 @@
|
|||
|
||||
"""Curses browser interface class ."""
|
||||
|
||||
import sys
|
||||
import math
|
||||
import curses
|
||||
from glances.outputs.glances_curses import _GlancesCurses
|
||||
|
|
|
@ -12,7 +12,6 @@
|
|||
from __future__ import unicode_literals
|
||||
from __future__ import division
|
||||
import sys
|
||||
from math import modf
|
||||
from glances.logger import logger
|
||||
from glances.compat import nativestr
|
||||
|
||||
|
|
|
@ -11,7 +11,6 @@
|
|||
|
||||
import time
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.compat import printandflush
|
||||
|
||||
|
||||
|
|
|
@ -81,7 +81,7 @@ class GlancesStdoutIssue(object):
|
|||
try:
|
||||
# Update the stats
|
||||
stats._plugins[plugin].update()
|
||||
except Exception as e:
|
||||
except Exception:
|
||||
pass
|
||||
|
||||
time.sleep(3)
|
||||
|
|
|
@ -11,7 +11,6 @@
|
|||
|
||||
import time
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.compat import printandflush
|
||||
|
||||
|
||||
|
|
|
@ -11,7 +11,6 @@
|
|||
|
||||
from datetime import datetime
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.events import glances_events
|
||||
from glances.thresholds import glances_thresholds
|
||||
|
||||
|
|
|
@ -9,7 +9,6 @@
|
|||
|
||||
"""CPU plugin."""
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.timer import getTimeSinceLastUpdate
|
||||
from glances.compat import iterkeys
|
||||
from glances.cpu_percent import cpu_percent
|
||||
|
|
|
@ -13,7 +13,6 @@ from __future__ import unicode_literals
|
|||
from glances.compat import nativestr, n
|
||||
from glances.timer import getTimeSinceLastUpdate
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
from glances.logger import logger
|
||||
|
||||
import psutil
|
||||
|
||||
|
|
|
@ -15,7 +15,6 @@ import numbers
|
|||
from glances.compat import nativestr
|
||||
from glances.folder_list import FolderList as glancesFolderList
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
from glances.logger import logger
|
||||
|
||||
|
||||
class Plugin(GlancesPlugin):
|
||||
|
|
|
@ -36,11 +36,9 @@ class Plugin(GlancesPlugin):
|
|||
|
||||
def reset(self):
|
||||
"""No stats. It is just a plugin to display the help."""
|
||||
pass
|
||||
|
||||
def update(self):
|
||||
"""No stats. It is just a plugin to display the help."""
|
||||
pass
|
||||
|
||||
def generate_view_data(self):
|
||||
"""Generate the views."""
|
||||
|
|
|
@ -12,7 +12,7 @@
|
|||
import threading
|
||||
from json import loads
|
||||
|
||||
from glances.compat import iterkeys, urlopen, queue, urlopen_auth
|
||||
from glances.compat import queue, urlopen, urlopen_auth
|
||||
from glances.logger import logger
|
||||
from glances.timer import Timer, getTimeSinceLastUpdate
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
|
|
|
@ -9,7 +9,6 @@
|
|||
|
||||
"""Virtual memory plugin."""
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.compat import iterkeys
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
|
||||
|
|
|
@ -19,7 +19,7 @@ import numbers
|
|||
from glances.globals import WINDOWS, MACOS, BSD
|
||||
from glances.ports_list import GlancesPortsList
|
||||
from glances.web_list import GlancesWebList
|
||||
from glances.timer import Timer, Counter
|
||||
from glances.timer import Counter
|
||||
from glances.compat import bool_type
|
||||
from glances.logger import logger
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
|
|
|
@ -10,7 +10,6 @@
|
|||
"""Quicklook plugin."""
|
||||
|
||||
from glances.cpu_percent import cpu_percent
|
||||
from glances.logger import logger
|
||||
from glances.outputs.glances_bars import Bar
|
||||
from glances.outputs.glances_sparklines import Sparkline
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
|
|
|
@ -14,7 +14,6 @@ import platform
|
|||
import re
|
||||
from io import open
|
||||
|
||||
from glances.logger import logger
|
||||
from glances.compat import iteritems
|
||||
from glances.plugins.glances_plugin import GlancesPlugin
|
||||
|
||||
|
|
|
@ -90,11 +90,9 @@ class Plugin(GlancesPlugin):
|
|||
except InterfaceError as e:
|
||||
# Not a Wifi interface
|
||||
logger.debug("WIFI plugin: Scan InterfaceError ({})".format(e))
|
||||
pass
|
||||
except Exception as e:
|
||||
# Other error
|
||||
logger.debug("WIFI plugin: Can not grab cell stats ({})".format(e))
|
||||
pass
|
||||
else:
|
||||
for wifi_cell in wifi_cells:
|
||||
hotspot = {
|
||||
|
|
|
@ -15,7 +15,7 @@ import sys
|
|||
from base64 import b64decode
|
||||
|
||||
from glances import __version__
|
||||
from glances.compat import SimpleXMLRPCRequestHandler, SimpleXMLRPCServer, Server
|
||||
from glances.compat import SimpleXMLRPCRequestHandler, SimpleXMLRPCServer
|
||||
from glances.autodiscover import GlancesAutoDiscoverClient
|
||||
from glances.logger import logger
|
||||
from glances.stats_server import GlancesStatsServer
|
||||
|
|
2
setup.py
2
setup.py
|
@ -68,7 +68,7 @@ def get_install_extras_require():
|
|||
'sparklines': ['sparklines'],
|
||||
'web': ['bottle', 'requests'],
|
||||
'wifi': ['wifi']
|
||||
#'gpu' and 'sensors' ==> See bellow
|
||||
# 'gpu' and 'sensors' ==> See bellow
|
||||
}
|
||||
if PY3:
|
||||
extras_require['export'].append('influxdb-client')
|
||||
|
|
|
@ -30,7 +30,7 @@ from glances.secure import secure_popen
|
|||
from glances.compat import PY3
|
||||
|
||||
if PY3:
|
||||
from tracemalloc import Snapshot
|
||||
pass
|
||||
|
||||
# Global variables
|
||||
# =================
|
||||
|
|
Loading…
Reference in New Issue