From 17a09f114ae498c5a8aea36f39a16ac9717f9441 Mon Sep 17 00:00:00 2001 From: Gabriel Horner Date: Tue, 8 Feb 2022 11:14:08 -0500 Subject: [PATCH] Remove last bits of with-context Follow up to 982eba9396f7e92ab8604bfc7e770933ba7cf1f9 --- .clj-kondo/config.edn | 1 - src/main/frontend/components/block.cljs | 2 -- src/main/frontend/components/sidebar.cljs | 1 - 3 files changed, 4 deletions(-) diff --git a/.clj-kondo/config.edn b/.clj-kondo/config.edn index 39c614791..9898279b0 100644 --- a/.clj-kondo/config.edn +++ b/.clj-kondo/config.edn @@ -22,7 +22,6 @@ garden.def/defstyles clojure.core/def garden.def/defkeyframes clojure.core/def rum.core/defcc rum.core/defc - rum.core/with-context clojure.core/doseq rum.core/defcontext clojure.core/def clojure.test.check.clojure-test/defspec clojure.core/def clojure.test.check.properties/for-all clojure.core/for diff --git a/src/main/frontend/components/block.cljs b/src/main/frontend/components/block.cljs index 8d8eed59f..620f6f0a9 100644 --- a/src/main/frontend/components/block.cljs +++ b/src/main/frontend/components/block.cljs @@ -62,8 +62,6 @@ [frontend.components.query-table :as query-table] [frontend.mobile.util :as mobile-util])) -;; TODO: remove rum/with-context because it'll make reactive queries not working - (defn safe-read-string ([s] (safe-read-string s true)) diff --git a/src/main/frontend/components/sidebar.cljs b/src/main/frontend/components/sidebar.cljs index 64fed1b2e..f1d87ca17 100644 --- a/src/main/frontend/components/sidebar.cljs +++ b/src/main/frontend/components/sidebar.cljs @@ -424,7 +424,6 @@ (rum/defc help-button < rum/reactive [] (when-not (state/sub :ui/sidebar-open?) - ;; TODO: remove with-context usage [:div.cp__sidebar-help-btn {:title (t :help-shortcut-title) :on-click (fn []