fix: show blank page error to user instead of silent failure

also fix outdated lint
pull/11491/head
Gabriel Horner 2024-08-27 17:11:34 -04:00
parent dd224b32c5
commit 7a96fc0e32
2 changed files with 6 additions and 3 deletions

View File

@ -263,7 +263,11 @@
m* (if (and db-based? page-title-changed?) m* (if (and db-based? page-title-changed?)
(let [page-name (common-util/page-name-sanity-lc (:block/title m*))] (let [page-name (common-util/page-name-sanity-lc (:block/title m*))]
(when (string/blank? page-name) (when (string/blank? page-name)
(throw (ex-info "Page title shouldn't be blank" m*))) (throw (ex-info "Page title can't be blank"
{:type :notification
:payload {:message "Page title can't be blank"
:type :error}
:node m*})))
(assoc m* :block/name page-name)) (assoc m* :block/name page-name))
m*) m*)
m (cond-> m* m (cond-> m*

View File

@ -16,7 +16,7 @@
"electron.db" "electron.db"
"frontend.handler.db-based." "frontend.handler.db-based."
"frontend.worker.handler.page.db-based" "frontend.worker.handler.page.db-based"
"frontend.components.property" "frontend.components.property-v2" "frontend.components.class" "frontend.components.property" "frontend.components.class"
"frontend.components.db-based" "frontend.components.objects"])) "frontend.components.db-based" "frontend.components.objects"]))
(def file-graph-ns (def file-graph-ns
@ -38,7 +38,6 @@
"src/main/frontend/worker/handler/page/db_based" "src/main/frontend/worker/handler/page/db_based"
"src/main/frontend/components/class.cljs" "src/main/frontend/components/class.cljs"
"src/main/frontend/components/property.cljs" "src/main/frontend/components/property.cljs"
"src/main/frontend/components/property/config.cljs"
"src/main/frontend/components/property" "src/main/frontend/components/property"
"src/main/frontend/components/objects.cljs" "src/main/frontend/components/objects.cljs"
"src/main/frontend/components/db_based" "src/main/frontend/components/db_based"