From a3ffeb867e0d41debcded8832ba2dee423c4cc65 Mon Sep 17 00:00:00 2001
From: anoffvu <an@an.vu>
Date: Tue, 17 Nov 2020 16:57:56 -0800
Subject: [PATCH] README github env variables clarification

---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index fd89baf5b..180f7ffe0 100644
--- a/README.md
+++ b/README.md
@@ -76,7 +76,7 @@ If you are on Windows, use the [Windows setup](#windows-setup) below.
 
 Follow the guide at <https://docs.github.com/en/free-pro-team@latest/developers/apps/creating-a-github-app>, where the user authorization "Callback URL" should be `http://localhost:3000/auth/github`.
 
-Remember to download the `private-key.pem` which will be used for the next step.
+Remember to download the `private-key.pem` which will be used for the next step. Also take note of your `App ID`, `Client ID`, and your newly generated `Client Secret` for use in step 4.
 
 ### 3. Set up PostgreSQL
 
@@ -90,7 +90,7 @@ export JWT_SECRET="xxxxxxxxxxxxxxxxxxxx"
 export COOKIE_SECRET="xxxxxxxxxxxxxxxxxxxx"
 export DATABASE_URL="postgres://localhost:5432/logseq"
 export GITHUB_APP2_ID="78728"
-export GITHUB_APP2_KEY="xxxxxxxxxxxxxxxxxxxx"
+export GITHUB_APP2_KEY="xxxxxxxxxxxxxxxxxxxx" #Your Github App's Client ID
 export GITHUB_APP2_SECRET="xxxxxxxxxxxxxxxxxxxx"
 # Replace your-code-directory and your-app.private-key.pem with yours
 export GITHUB_APP_PEM="/your-code-directory/your-app.private-key.pem"