From bf0e838e966582723324b9c3459c1cd1a597c368 Mon Sep 17 00:00:00 2001 From: Tienson Qin Date: Thu, 1 Aug 2024 11:14:44 +0800 Subject: [PATCH] fix: can't edit :default cells when its value is the placeholder --- src/main/frontend/components/property/value.cljs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/frontend/components/property/value.cljs b/src/main/frontend/components/property/value.cljs index 927f59aec..03dfd6404 100644 --- a/src/main/frontend/components/property/value.cljs +++ b/src/main/frontend/components/property/value.cljs @@ -536,8 +536,11 @@ [block property value-block opts] (let [multiple-values? (db-property/many? property) block-container (state/get-component :block/container) - blocks-container (state/get-component :block/blocks-container)] - (if value-block + blocks-container (state/get-component :block/blocks-container) + value-block (if (and (coll? value-block) (every? de/entity? value-block)) + (set (remove #(= (:db/ident %) :logseq.property/empty-placeholder) value-block)) + value-block)] + (if (seq value-block) [:div.property-block-container.content.w-full (let [config {:id (str (if multiple-values? (:block/uuid block) @@ -848,7 +851,6 @@ schema (:block/schema property) type (some-> schema (get :type :default)) multiple-values? (db-property/many? property) - empty-value? (= :logseq.property/empty-placeholder v) v (cond (and multiple-values? (or (set? v) (and (coll? v) (empty? v)) (nil? v))) v @@ -858,6 +860,7 @@ (first v) :else v) + empty-value? (= :logseq.property/empty-placeholder (:db/ident (first v))) closed-values? (seq (:property/closed-values property)) value-cp [:div.property-value-inner {:data-type type