Finally no need to worry about parent-left conflicts and broken chain.
With :block/order, we only need to re-compute new orders for siblings
with same order (it can happens if there're bugs in our code, or
updates from rtc), but it doesn't break UI.
Another huge potential benefit after discussing with Zhiyuan is:
Ee might be able to simplify both RTC and undo/redo, currently, we
need to handle each new op for both of them, with recently
refactorings like properties being db attributes, :block/order
is a string instead of a ref, we can handle most property value
conflicts using last-write-wins, and others (e.g. :block/parent,
property with :default type) specifically.
I haven't fixed the issues of using :block/left in RTC and undo/redo,
because we might change both soon.
graph-parser is primarily a file graph dep that is maintained separately
from db graphs. We want to move as many namespaces out of it as
possible. Also moved differing count assertions to
their respective tests
- file graph wasn't creating built in pages
- 3 places where db graphs were incorrectly using file graph built in
page names
- file graphs creating default pages with incorrect format
Also fixed db-and-file-graphs-separate lint and moved gp-property tests
that should be moved since their source code has moved from frontend
to gp-property
- remove sqlite-db/close! as its not used and didn't make sense to be
used in other electron ns
- remove sqlite-db/connections atom as its not needed
- remove read-graph as its not necessary
- rename cli.persist-graph as its primary purpose has changed
- update effected scripts
Fixes#9346 and fixes#5926.
Also fixes case where relative paths for unsupported paths were creating
pages per directory e.g. `deps/graph-parser/yarn.lock` created deps and
graph-parser pages
dev: graph parser IoC hook
test: use test db for diff-merge tests
fix: ci lint
dev: refactoring post block-parsing process
feat: diff-merge 2 way merge integration
fix: key namespace of uuid in fix-duplicated-id
fix: duplicated uuid ci
* fix: fragment urls for audio player
* fix: add Support for url queries and fragments to extension detection
* feat: add tests for extraction of file extension
Co-authored-by: Gabriel Horner <gabriel@logseq.com>
Also:
- Move test to a more appropriate ns - model-test isn't for testing
higher level parse file behavior
- Delete model fns that are no longer used
- Fix tests which had incorrect target-page-content and were no longer
testing retractAttribute
- Add options to cli ns for related nbb reuse
- Light cleanup of block deletion
Gabriel Horner
Tienson Qin
Andelf
Junyi Du
sallto
Brooks Rady