Gabriel Horner
32ca012635
enhance: pretty print + colorize query script by default
2024-05-23 14:58:55 -04:00
Gabriel Horner
0fc01b94a3
fix: tests
2024-05-23 09:45:38 -04:00
Gabriel Horner
26cf70f6cf
fix: update schema and remove unused :name in :icon key
2024-05-23 09:45:38 -04:00
Tienson Qin
c118271fdd
refactor: property position support left/right/below
...
Removed the limitation that only properties with closed values can
have custom positions.
2024-05-23 20:48:04 +08:00
Tienson Qin
1cfc426486
enhance: properties ux
...
1. add icons to priorities
2. hide task properties so that blocks are not collapsable
3. block positions support end of block
2024-05-23 17:18:23 +08:00
Tienson Qin
c862ad0d10
refactor: db/transact! as outliner op
...
The benefits:
1. all db transactions from the UI thread can be described in outliner
ops now.
2. batch undo/redo
2024-05-23 05:16:51 +08:00
Gabriel Horner
8de74ce654
fix: lint for large var
2024-05-22 17:03:00 -04:00
Gabriel Horner
ceb3681cfe
fix: nbb scripts updates :block/refs the same as app
...
nbb was only handling path-refs previously. Can remove hacky
managing of refs in create-graph. Still a TODO to fix schema graph
lazy loading bug. Related to LOG-2819
2024-05-22 16:51:50 -04:00
Gabriel Horner
67ff14038a
enhance: add :config option to schema graph
...
also fix outliner lints
2024-05-22 13:37:40 -04:00
Tienson Qin
d298567737
fix: wrong arguments for delete-blocks
2024-05-23 00:35:22 +08:00
Tienson Qin
f218732b17
fix: property path-refs
...
1. :block/refs support to page properties
2. don't add built-in properties to refs
3. don't add current block or parents' other properties to :default blocks
2024-05-22 23:30:00 +08:00
Gabriel Horner
8b12e7f136
fix: property refs not calculating for file graphs
...
Fixes a bug where clicking a TODO in a file graph resulted in an error.
Bring back file graph implementation accidentally taken out in
d31b8cd5ae
.
Also fixes related test
2024-05-22 10:42:44 -04:00
Gabriel Horner
04e71a9a23
Bump datascript for nbb-logseq
2024-05-22 09:37:16 -04:00
Gabriel Horner
50698c190d
fix: update db's nbb.edn to match deps.edn
...
Looks like we forgot to add malli to deps.edn awhile back
2024-05-22 08:53:13 -04:00
Tienson Qin
5b99610212
fix: use trigger-id instead of target
...
Because target might already be unmounted
2024-05-22 20:49:44 +08:00
Tienson Qin
b4bfd5cc9a
chore: use clj-fractional-indexing
2024-05-22 15:21:35 +08:00
Tienson Qin
f944dd2de9
fix: can't add existing :many property
2024-05-22 07:55:18 +08:00
Gabriel Horner
cfe22e4acc
fix: lints
2024-05-21 16:14:05 -04:00
Gabriel Horner
c9b579ae01
fix: placeholder valid for a :many property
2024-05-21 16:09:40 -04:00
Tienson Qin
e49acf8256
feat: add property :object type
2024-05-21 23:30:54 +08:00
Gabriel Horner
fd5b90596b
chore: remove nonexistent fix-tx
2024-05-21 11:00:11 -04:00
Tienson Qin
67bd6c6da3
fix: build refs for either pages or tagged blocks (objects)
2024-05-21 21:05:02 +08:00
Tienson Qin
8d959a7c8b
chore: bump datascript
2024-05-21 20:51:22 +08:00
Tienson Qin
db8d0c53df
fix: datascript upsert db/ident
2024-05-21 19:29:21 +08:00
Tienson Qin
d31b8cd5ae
fix: add property named blocks values to :block/refs
...
related to LOG-2819
2024-05-21 16:35:39 +08:00
charlie
685b78e2a0
fix(ux): invalid action for the block selection context menus
2024-05-21 11:26:59 +08:00
Tienson Qin
ee35854498
fix: delete property value block when it's not used by other blocks
2024-05-21 07:49:33 +08:00
Gabriel Horner
33832f7941
fix: property names with invalid idents display an error notification
...
instead of silently failing in console. E.g. `123` as a property name
2024-05-20 17:21:56 -04:00
Gabriel Horner
fa4b47d16b
fix: property value names in developer cmd
...
and in readable-properties fn
2024-05-20 16:20:31 -04:00
Gabriel Horner
92299347da
chore: rename class ident to match name
...
Root is also a better name than base
2024-05-20 15:55:40 -04:00
Gabriel Horner
0cfc90e0ef
fix: remove :string property type as :default
...
does everything it used to do. Also remove component behavior specific to :string
2024-05-20 11:46:10 -04:00
Gabriel Horner
c5911a571b
fix: loading of classes for script-generated graphs
...
Lazy loading of refs for classes isn't supported in the UI yet so
no need to self-inflect this. Also can move schema graph from :string
to :default usage now
2024-05-20 10:45:27 -04:00
Gabriel Horner
47ed035d42
tweak schema as properties always have :type
2024-05-20 09:29:05 -04:00
Tienson Qin
3b975d2fad
enhance: show properties configuration for classes in the sidebar
2024-05-20 18:11:14 +08:00
Tienson Qin
29de339fa1
enhance: don't show date picker for one value
...
Also, set hint background color when hovering property value
2024-05-20 15:31:55 +08:00
Tienson Qin
e34af3412e
enhance: delay creating new property until type specified
2024-05-20 13:07:21 +08:00
Tienson Qin
4a681d7193
fix: lazy load page/block embeds
2024-05-18 08:20:34 +08:00
Tienson Qin
1c88d7cb00
fix: can't convert ref-type to non-ref (checkbox)
2024-05-18 06:39:47 +08:00
Gabriel Horner
efab7f403e
chore: Remove unnecessary catch and rethrow for notification
...
Just encode notification in original exception to make conversion
as reusable as possible. Also make properties readable with :original-name
as they are case sensitive
2024-05-17 17:25:53 -04:00
Gabriel Horner
a17ed389e8
fix: can't delete a closed value being used
...
fixes LOG-3102
2024-05-17 15:37:52 -04:00
Gabriel Horner
4907f0eb74
fix: task related commands e.g. /Doing
...
Was broken by adding property ref value support to batch-set-property
2024-05-17 12:40:09 -04:00
Gabriel Horner
05b96d53fa
fix: display notification when trying to delete built-in choice
2024-05-17 11:07:53 -04:00
Tienson Qin
a50177096e
chore: remove debug
2024-05-17 21:00:57 +08:00
charlie
3e37fb6b4a
fix: typo
2024-05-17 11:25:10 +08:00
Tienson Qin
db721ee3f6
enhance: clear selection before closing popup
2024-05-17 11:15:15 +08:00
Gabriel Horner
3fdaf0474f
fix: can't add a class schema or page property
...
Removed related unused upsert property code. This became unused with #11311 .
Also fixed new page property not moving focus to property value
2024-05-16 17:47:49 -04:00
Gabriel Horner
35e6ad120d
chore: rename pdf specific properties to logseq.property.pdf
...
also remove deleted property ns
2024-05-16 15:27:24 -04:00
Gabriel Horner
d37df950fa
fix: property rules now work with property ref values
...
Also remove use of :string properties in tests
2024-05-16 15:05:37 -04:00
Gabriel Horner
43dfdbe0ae
fix: convert remaining built-in :string props to :default
2024-05-16 11:22:09 -04:00
rcmerci
a12a0d3d30
refactor(rtc): support refactored update-op, update local db
2024-05-16 19:47:49 +08:00
Gabriel Horner
8921767b69
fix: batch-set-property working with property value refs
...
Fixed batch-setting background-color. With this fix was then able
to migrate order-list-type to use :default. Also cleaned up
outdated assumptions in batch fn
2024-05-15 17:37:57 -04:00
Gabriel Horner
e50d3eff21
fix: setting block properties with raw value
...
With this fix able to convert 2 built-ins to :default. Also cleaned
up set-block-property! which had outdated assumptions
2024-05-15 16:10:02 -04:00
Gabriel Horner
2117245b28
fix: fetching built-in property values
...
Fixes :number properties like hl-stamp and hl-page which returned
refs instead of actual values. This will also fix it for
future usage of built-in :default props. Also fixed a db test
2024-05-15 12:23:14 -04:00
Gabriel Horner
980c88b60d
fix: remove table v2 properties
...
Finish removal started by 82a1a18762
.
Still need names in exporter so they aren't incorrectly imported
into db graphs
2024-05-15 10:25:31 -04:00
Gabriel Horner
ad9dc70b9c
fix: finish removing table v2 from shui dep
...
Followup to 82a1a18762
.
Copied more useful intro from shui-graph into README
2024-05-15 10:25:31 -04:00
Gabriel Horner
a70499bd8c
fix: remove schema hack now that it's been fixed
2024-05-15 10:25:31 -04:00
Tienson Qin
244de2187e
fix: quit batch tx mode even with errors
...
Also, throw errors and send notifications for apply-outliner-ops
2024-05-15 22:19:06 +08:00
Tienson Qin
a689266931
fix: don't persist :block.temp/fully-loaded?
2024-05-15 20:41:17 +08:00
Tienson Qin
114c0524fa
fix: handle situations when datom entity has gone or children exists
2024-05-15 10:34:34 +08:00
Tienson Qin
a5a7a781eb
fix: keep the last repeated datom (different value) in batch tx
2024-05-15 07:54:31 +08:00
Gabriel Horner
c554627041
fix: outliner lints
...
While fixing large vars, fixed needless circular dependency between
create-property-text-block and set-block-property
2024-05-14 15:11:29 -04:00
Gabriel Horner
0238aff2ba
fix: replace uses of :string closed with :default closed
...
and remove :string from closed possibilities
2024-05-14 10:34:54 -04:00
Gabriel Horner
4a7dab2763
fix: can't add or update closed values
2024-05-14 09:29:00 -04:00
Gabriel Horner
45bb11d28d
fix: db tests and :op typo
2024-05-13 17:05:32 -04:00
Gabriel Horner
a2a951ddcb
fix: switching to another number closed value
...
The bug was creating a new block each time a switch was made
because existing closed values didn't have a created-from-property
2024-05-13 13:23:02 -04:00
Gabriel Horner
e55927086f
fix: creating :number and :url closed values from config
...
Also add schema hack for fully-loaded being persisted. Also
add :default property examples to example properties graph now that it's
possible
2024-05-13 12:33:31 -04:00
Tienson Qin
ce4cad2cc7
Refactor/move property handler to outliner dep ( #11311 )
...
The end goal is to get rid of `db/transact!` and send outliner ops to
the db worker.
Currently, some property ops are async, set-block-property! will also
need to be async because when setting a non-ref value (e.g. a number
str "2"), we need to query whether a block with the value exists, this
unfortunately, will be an async query, so we're risking turning more
functions to async in the future which makes it hard to reason about
the implementation.
2024-05-13 18:16:21 +08:00
charlie
061700c6b1
enhance(ui): WIP optimization for the shui popup related fundamental components
2024-05-11 15:14:21 +08:00
Gabriel Horner
fcf6ebd0e4
fix: page properties for :default, :number and :url
...
Also fix page property example in properties graph and removed
unused branches in validation
2024-05-10 16:40:42 -04:00
Gabriel Horner
64786bb258
fix: create :number and :url properties from scripts
2024-05-10 15:19:10 -04:00
Tienson Qin
11c902eb1e
refactor: make all user-facing property types refs
2024-05-10 18:03:07 +08:00
Tienson Qin
4a9aa50a7d
refactor: use :string type only for internal properties
2024-05-10 11:22:28 +08:00
Gabriel Horner
70d92c8f7a
fix: pdf related properties for db graphs
...
Added to new property ns as file and file-path are too generic to be top-level.
Also fixed bugs in page creation
2024-05-09 13:38:31 -04:00
Gabriel Horner
123cb8fc42
fix: cleanup property tuple validation
...
Had an unnecessary entity refetch. Also move ui assumptions about :many
validation to ui as this needlessly limits what :many could store
2024-05-09 10:57:18 -04:00
Gabriel Horner
161c5c8565
Merge branch 'master' into feat/db
2024-05-09 08:41:40 -04:00
Tienson Qin
45e5cde3f9
fix: slow popup
2024-05-09 17:24:07 +08:00
Tienson Qin
339883800d
fix: property tuple validation
2024-05-09 16:29:55 +08:00
charlie
e9b430b1b0
enhance(ui): refactor the shui-related codes
2024-05-09 12:46:52 +08:00
Tienson Qin
61db29ceba
Remove [:block/schema :cardinality]
...
Uses :db/cardinality instead.
2024-05-09 11:24:46 +08:00
Tienson Qin
bccf999853
fix: tests
2024-05-09 08:51:49 +08:00
Tienson Qin
45f14d4b76
refactor: property/schema.properties
...
Replace [:block/schema :properties] with ref type property/schema.properties.
This commit also introduces :logseq.class/base so that all the other
classes will be its children.
2024-05-09 08:29:11 +08:00
Tienson Qin
bb5a3364e6
fix: outdent property child block replaces its parent
...
Fixes LOG-3141
2024-05-09 04:36:14 +08:00
Tienson Qin
5013d34c2f
chore: cleanup :block/_left usage
2024-05-09 04:36:14 +08:00
Tienson Qin
d6ffd16799
fix: can't move blocks up
...
Fixes LOG-3140
2024-05-09 04:36:14 +08:00
Gabriel Horner
00e153e866
fix: closed value :number can also be float
2024-05-08 15:23:57 -04:00
Gabriel Horner
949d676f02
fix: number closed value not saved as its original value
...
A :number closed value saved as a string is problematic for a couple
reasons:
* Not storing a number by the user's intended value means a loss of any
numeric functionality the property provides. Basic things like sorting
by the numeric property don't work. This has caused us problems in the
past and we invented hacky workarounds like logseq.query/nlp-date to
compensate for this
* Creates inconsistency in how numbers are saved as non-closed values
are not saved as string. This affects not only the validation layer
but also creates bugs when querying for these property values as the
querying interface is inconsistent
2024-05-08 13:49:22 -04:00
Gabriel Horner
298c37ffc7
fix: lints + schema key which shouldn't have been removed
2024-05-08 12:31:08 -04:00
Gabriel Horner
22f15a3fb3
fix: validating closed value ents
...
Also fix closed value membership not being checked from CLI
2024-05-08 11:47:45 -04:00
rcmerci
f69094713f
enhance: move missionary-util to src/main/frontend/common/
2024-05-08 21:56:52 +08:00
Andelf
da78593eb1
fix(sync): cannot delete some nested files
...
Close #11278
2024-05-08 16:42:41 +08:00
Gabriel Horner
be9237d101
refactor: move rules deps usage into helper fn
...
Dries up task dependency that was copied in query-dsl
2024-05-07 22:11:27 -04:00
Gabriel Horner
489e7f3422
fix: :default-queries for db graphs
...
closes LOG-3042. Moved :default-queries to default-config as this allows
for any future fix to automatically update for a user. There's also a
breaking change with this config key from :block/journal? so moving this
to default-config makes the migration easier e.g. just tell users to
remove the config key
2024-05-07 18:03:50 -04:00
Tienson Qin
89afdcdd7b
fix: outliner core tests
2024-05-08 01:29:23 +08:00
Tienson Qin
976e5c2f6b
fix: generate n keys for fractional index
2024-05-08 00:37:17 +08:00
Tienson Qin
1cb0896e3b
refactor: remove [:block/schema :values]
...
Some changes:
1. use :block/closed-value-property instead to record which property
this value entity belongs to.
2. use :block/content instead of [:block/schema :value].
3. :page and :date have been removed from closed-value-property-types
because there could be a page/date that's a closed value for multiple
properties, we have no idea what's the `:block/order` for a specific
property.
2024-05-07 23:33:04 +08:00
Gabriel Horner
ead9f30f1b
fix: typing hashtag sets heading
...
also remove unused var
2024-05-07 10:53:32 -04:00
Tienson Qin
4e32a5042a
fix: reset *max-key when loading graph
2024-05-07 21:52:56 +08:00
Tienson Qin
308c3bcd17
fix: reset max key when generate-n-keys-between
2024-05-07 20:07:06 +08:00
Tienson Qin
ee0d89ad85
refactor: replace [:block/schema :value] with :property/schema.value
2024-05-07 17:26:56 +08:00
Gabriel Horner
4c3fc530b9
fix: task rule and filter for db graphs
...
Part of LOG-3042
2024-05-06 16:55:45 -04:00