* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* Minor rephrasing of the lesson's description
Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.
* Corrections to conform to style guide
1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.
* Moved challenge instruction to Instructions section
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Correct seed code errors
Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.
* Add single quotes to correct new assertion statements
* Fix incorrect usage of splice
Changed the parameters passed to bookList.splice in the remove function
* Remove extraneous tests
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md
* fix(challenges): Update challenge text and assertion test
* fix(challenges): update assert test regex
* fix(challenges): update regex, fix inline comment in code example
* fix: corrected regex
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update create-a-text-field.english.md
* fix: change language tag and remove wrong comment
* Sample solution for the file
I have updated the sample solution for the challenge seed code.
* Update add-images-to-your-website.english.md
formatted ```html tags
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".
Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
* Update create-a-queue-class.english.md
* Modify test for dequeue method to check for FIFO
The test first `enqueue`'s two elements and checks for the `dequeue` method to return the element at `0`th index.
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
Co-authored-by: Paul Gamble <pgamble@gmail.com>
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* Sample solution for the challenge seed code
I have updated the sample solution for the challenge seed code.
* Update headline-with-the-h2-element.english.md
Removed //solution required
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* Add the solution
* Update divide-one-decimal-by-another-with-javascript.english.md
The solution was not passing. Change should pass now.
* Update divide-one-decimal-by-another-with-javascript.english.md
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* fix: merges 3 set challenges into 1
* fix: changed function to class syntax
* fix: simplified instructions
* fix: changed the example
* style: minor formatting changes
* style: formatted solution
* fix: formatting
* feat(interview-prep): Added Rosetta problem
* Update sort-an-array-of-composite-structures.md
* feat(interview-prep): Added meta data
* feat(interview-prep): Added Bogosort Meta Data
* Added whitespace to the tests
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
Closes #XXXXX
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
* added explanation of private variable naming convention
* Added "Note:" to the front of the explanation
* Added solution
* Moved "Note:" to it's own line and made it bold
* fix: moved note block at the bottom
Thank you for your pull request.
I am closing this pull request. Please add links and other details to the challenge’s corresponding guide article instead.
If you think I’m wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.
@MP7373
(?=\D*\d) is looking for a non-number to precede a number. If '12Three' was passed in to test, it would not match though it matches the stated criteria of 5 character minimum length and two consecutive numbers.
* Translate challenge subtitles and example challenge text to Spanish
* Corrected errors in syntax and punctuation
* Multiple corrections of it/s to its plus other grammar corrections
* Correction and added paragraph to CSS Flex article
* Corrected my own typo
* Corrected capitalization, American spellings and typos
* Update compare-scopes-of-the-var-and-let-keywords.english.md
* Updated line
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Format the document
* Fix line for Example
Bolded Example is inline with description. Added new line so that Example will have its own line (right before the actual example)
* Add line break after Description
* Fixing typo: Implement the Serialization of a Passport User
Fixing typo in "Implement the Serialization of a Passport User" curriculum page under "Advanced Node and Express" topic
* Fix typo in 'logging a user out' page
Fixing typo in 'logging a user out' page
* Added missing space
* Added missing period in add-borders-around-your-elements.md
* Added missing space in adjust-the-padding-of-an-element.english.md
I was doing this challenge and noticed that there wasn't a space after "transform:scale(2)" in the description which is inconsistent with the other challenges so I changed it to "transform: scale(2)"
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
* added note about UpperCamelCase for ES6 classes
proposed note in issue #17864
* added note as a new heading
changed from note as a sentence to note as a heading plus the actual note
* added <code> around SpaceShuttle
* removed markdown and added <strong> tag
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
* fix: removed all ​ from tests verbiage
* fix: added single quote to start text string
* remove single quote from text line
* fix: removed the hidden chars in the testStrings
* fix: removed hidden chars from testString section
* fix: removed hidden chars form testString part
* fix: removed hidden chars from testString part
* fix: removed hidden chars from testString part
I did not understand the original lesson of "through" vs "to" upon first reading.
Later reading the code below it started to make sense... but I added a bit more to the explanation.
* Clarification of the declaration order overriding
Previous text was talking about an override but it may also confuse readers that the override was done in the order of the listing of class names inside the h1.
I also added an extra case to better clarify the situation.
* Small change mentioning the order of declaration
Missed an order of declaration emphasis on my previous commit, adding it on this one.
* feat: Update intro to currying
- Add solutions
- Add ES6 examples
* feat: Add solution to FP mutations
* feat: Add solution to function-programming map
- Add solutions, both vanilla and ES6 arrow functions
- Add JSON.stringify to console.log, makes it easier to see what the resulting output is rather than showing
e.g. [object, object, object]
* update: used the contributor's ES6 solution
Contributor originally had a non-ES6 solution and an ES6 solution. I removed the non-ES6 solution.
A test that featured nested arrays just happens to work, but nested arrays will not be removed if they’re duplicates by the current solution of this challenge. See issue #18265
* Fix type on OOP as requested on issue #18091
fix:
numLegs: 2 to numLegs: 4
on challenge:
Remember to Set the Constructor Property when Changing the Prototype
* Update remember-to-set-the-constructor-property-when-changing-the-prototype.english.md
* User Flow: Information, Articles, Youtube update
Explanation on what is User Flow with youtube videos and articles for reference and/or resource.
* Update of UX Design article
Update the article with more information and more links to articles and books.
* Product Design: Info, Articles, Youtube update
Explanation on what is Product Design with youtube videos and articles for reference and/or resource.
* Update description of Retina Display
As reported in issue #18129, there is a lack of explanation on what a retina display is and some users find it difficult to understand what they are doing exactly, so I added a short explanation on what a High-Resolution Display is and what a Retina Display is.