* Modify if statement
Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.
* Add test
New test checks that if num is 0, an empty string is returned
* Fix test
Fixing errors in newly proposed test that checks that empty string is returned when num is 0
* Modify intermediate solution
Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)
* fix: removed unnecessary assert message arguments
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
Fixes#35793
I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?
Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu>
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge
* Fix for issue #35665
Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md
Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>
* fix: added missing ) for assert statement
* Update description of tests pig-latin.english.md
The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md
Co-Authored-By: beansprout <christinegierer@gmail.com>
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
Varun
Natalie Cardot
Tom
Randell Dawson
Matt Schlosser
Deanna Tran
Randell Dawson
Oliver Eyton-Williams
RIHANE ZAKARIA
Aly Pilkons
BSi
Guayo Mena
Manish Giri
Kristofer Koishigawa
Илья
Amy Lam
lucassorenson
Lipis
Justin Hilliard
seanlaing
Hrishit Prasad Biswas
Christine Gierer
Aditya
Vikas KM
Hugo
Timur
Chuck Adams
grets311
Jade Michael Thornton
lasjorg
NITIN BISHT
Lauren Van Sloun