Commit Graph

167 Commits (4438eb0f331c8f5646935ce26f2202392e69154a)

Author SHA1 Message Date
lasjorg 494687f75e fix: correct inconsistency in formatting (#34721)
* fix: correct inconsistency in formatting

* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
Randell Dawson f6d07f37d7 fix: created more flexible test (#35325) 2019-03-08 11:07:50 -06:00
Lewis Horwood 38c99d7ff5 Simplify challenge wording (#25120)
* Simplify challenge wording

* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price 27a59c5418 fix: reworded text messages (#27072) 2019-03-06 18:30:58 -05:00
Akshay Tiwari 6d24b879f2 Update catch-mixed-usage-of-single-and-double-quotes.english.md (#35532) 2019-03-07 01:04:12 +05:30
Aashis kumar 960811e31f Solution to specify-exact-number-of-matches.english JavaScript Challenge (#34757)
* Update specify-exact-number-of-matches.english.md

Added an explanation to the working code too

* fix: removed i flag and comments
2019-03-05 13:12:55 -05:00
Randell Dawson 8e5b99b8ca fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367)
* fix: prevent 5th test from allowing invalid code

* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
Ihor Allin 6222b86133 Update understand-the-hazards-of-using-imperative-code.english.md (#35052)
Moved instructions into correct section.
2019-03-04 09:24:54 -06:00
Randell Dawson 99c7f28530 fix: remove <code> tags around word queue (#35393) 2019-03-04 09:12:29 -06:00
Luane 9440cca69f Added example Input/Output to challenge (#34738)
* Added example Input/Output to challenge

Input/Output example will make it clear what the challenge is asking the camper to do.

* Formatting changes made to file

* Made minor changes in formatting

Added <code> tag to single line code.

* Formatting update

* Added requested formatting changes

* Refactored sentence and removed earlier example
2019-03-02 02:26:23 -05:00
Christopher McCormack 421c097f17 feat: cleaned up grammar and formatting (#35364) 2019-03-02 00:25:09 +05:30
hilliarj 6cd3466f0b fix(curriculum): Find Characters with Lazy Matching (#35454)
* fix(curriculum): Find Characters with Lazy Matching

* Update PR

Note is moved in the Description section and not the Instructions section
2019-02-28 13:33:07 -08:00
Ruchika Sharma 25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Niraj Nandish 769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Pete 41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
Aditya 665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Lewis Horwood 9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
TristanSeabrook d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook 7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson 37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Aashis kumar 80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Kirill Malev bca4d896cc Added solution to reuse-patterns-using-capture-groups.english.md (#35144)
* Update reuse-patterns-using-capture-groups.english.md

* included whole solution
2019-02-16 19:10:03 -08:00
Christopher Szczechowicz 994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
BurnhamG a825708e3e Correct seed code errors (#32355)
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
2019-02-14 13:24:38 -08:00
Beau Carnes 409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Valeriy 99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
Kirill Malev 661d10412f Added solution to remove-whitespace-from-start-and-end.english.md (#35145)
* Update remove-whitespace-from-start-and-end.english.md

* includes whole solution now
2019-02-12 09:34:52 -08:00
Aashis kumar b2e514d39f A better solution to finders-keepers.english.md (#34759)
* Update finders-keepers.english.md

A better approach to finder's keepers problem

* A better appoach to solve finders-keepers (JS)

Fixed travis bug

* fix: indented solution code
2019-02-10 20:13:48 -08:00
lasjorg 9341aadb5b Fix/remove property references and update tests (#35109)
* fix(challenges): Update challenge text and assertion test

* fix(challenges): update assert test regex

* fix(challenges): update regex, fix inline comment in code example

* fix: corrected regex
2019-02-09 00:47:53 -05:00
Julien Galibois Sauvageau e8b7b2eb6f Fixed typo (#34848)
Original wording: getHachedEggCount
New wording: getHatchedEggCount
2019-02-08 13:59:04 -08:00
Aditya 85eca8ef36 [fix]: Object Oriented Programming: Inherit Behaviors from a Supertype (#35063)
* fix: revert semicolon check

* fix: test name
2019-02-06 08:23:47 +03:00
Dom Coleman 9a4e13954a Tests for OOP: Inherit Behaviors from a Supertype (#34938)
* Tests for OOP: Inherit Behaviors from a Supertype

Fixes issue #34905

* fix: make test inclusive
2019-02-05 20:44:53 +03:00
Luane f2c3d635ef Added solution to challenge "Regular Expressions: Match Characters th… (#34668)
* Added solution to challenge "Regular Expressions: Match Characters that Occur Zero or More Times"

* fix: removed necessary brackets
2019-02-05 08:03:19 -08:00
Chelsea Marie Hicks 8d7bd3906c Grammar change and readability of example (#30507) 2019-02-05 21:14:05 +05:30
John Sprunger 7ae6577cda Change for second test case (#34785)
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".

Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
2019-02-05 21:07:17 +05:30
rupali317 42bf229f59 fix: modified the test case such that the variable is a local scope o… (#34959)
* fix: modified the test case such that the variable is a local scope of the function

* fix: make test inclusive
2019-02-05 09:40:58 +03:00
Pepijnk12 ab4367a751 Update URL for 404 error (#35042)
* Update URL for 404 error

* fix: correct url
2019-02-04 13:34:47 +03:00
The Coding Aviator 90a9df1a5d Fixed problem with regex in es6 import challenge (#19718)
import-a-default-export.english.md: support both main quoting styles
2019-02-03 18:07:55 +01:00
Paul Gamble fabd45e1b4 Revert "Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)" (#34949)
This reverts commit 23096f7ed6.
2019-01-31 10:39:39 -08:00
Casey Bennington 7f9cbe982b Add the solution (#28899)
* Add the solution

* Update divide-one-decimal-by-another-with-javascript.english.md

The solution was not passing. Change should pass now.

* Update divide-one-decimal-by-another-with-javascript.english.md


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:10:44 -05:00
Casey Bennington d2286fc3b5 Added solution (#28907)
LGTM!
2019-01-25 10:17:46 -05:00
Alan Price 1a6e1e57cc Added solution (#27077) 2019-01-24 15:36:57 -05:00
Joe Erickson 6a777a9b16 Add solution to find more than one challenge (#27476) 2019-01-24 15:29:23 -05:00
Joe Erickson 13b3e3fa9b Add solution to match whitespace problem (#27470)
* Add solution to match whitespace problem

* fix: corrected case of countWhiteSpace on line 61
2019-01-24 15:23:07 -05:00
Alan Price 23096f7ed6 Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)
* added solution for challenge

* removed function from seed and solution
2019-01-24 14:24:27 -05:00
buhidar 589257cf02 Typo fix on line 11 (#34922) 2019-01-21 19:06:10 -08:00
The Coding Aviator ca2d01a81c feat(curriculum): add grouping characters challenge and guide (#34875)
Added new challenge for mixed grouping of characters
2019-01-17 22:08:46 +01:00
Valeriy S 9b75c1965a fix(curriculum): replace window by self for js challenges 2019-01-16 10:45:39 +00:00
Alan Price 37d98f1123 Challenge - ES6: Write Arrow Functions with Parameters - Expanded description (#25997)
* Reworded and expanded the description

* renamed the function in the multiple param example
2019-01-09 11:00:16 +00:00
Nhat Khanh e5756ae1d6 [Guide] Functional Programming: Sort an Array Alphabetically using the sort Method. Fixes and enhancements. (#34678) 2018-12-21 22:50:52 +05:30
Alan Price d36922c496 Added solution (#27127) 2018-12-15 12:41:12 +05:30
Ashish Singh ffce49d024 fixing typo for one of the challenges in es6 section for issue #34578 (#34579)
* fixing typo on UI

* changed tes string

* updated changes for issue #34578
2018-12-15 11:56:12 +05:30
Aditya 56ded4174c [Fix] Object Oriented Programming: Remember to Set the Constructor Property when Changing the Prototype (#34569) 2018-12-14 19:59:35 +09:00
Adrian Skar 0af7ebad6d [Curriculum] ES6: Prevent object mutation; fix minor typos (#34650) 2018-12-12 13:32:28 +00:00
Aditya 4145efc467 [fix] Test for Pass Arguments to Avoid External Dependence in a Function (#34522)
* feat: test works for => fns, added solution

* fix: moved solution
2018-12-04 20:50:19 +09:00
Alan Price 40f152ba15 Challenge - ES6: Use getters and setters to Control Access to an Object - Added solution and explanation of private variable naming convention (#24362)
* added explanation of private variable naming convention

* Added "Note:" to the front of the explanation

* Added solution

* Moved "Note:" to it's own line and made it bold

* fix: moved note block at the bottom
2018-12-03 19:10:09 +05:30
Ben Brown 929e0db633 fix(challenge): use-the-conditional-ternary-operator (#19535) 2018-12-03 14:19:57 +05:30
Ariel 2f23fb544d Fixes minor typo (#34326)
"should not be be" changed to "should not be"
2018-11-29 02:28:48 +05:30
Aditya 254897c372 fix: fixed the test and added solution 2018-11-27 19:52:49 +09:00
Abhishek Kakade f4f5ce4b85 fix: updated challenges text (#34458) 2018-11-27 02:05:14 +05:30
Aditya a489ac9df8 fix(curriculum): Use the reduce Method to Analyze Data (#34315) 2018-11-22 20:14:31 +03:00
Aditya 8d593a1256 fix(curriculum): Create Strings using Template Literals (#34296) 2018-11-22 19:51:51 +03:00
Aditya d9c6a13741 [Tests] ES6: Use Destructuring Assignment with the Rest Operator (#34303) 2018-11-22 22:27:16 +09:00
Mike Perry Yeboah Attara 74a5c8d15a Fix inconsistent formatting of the welcomeToBooleans function (#34373)
fix the inconsistency in the formatting of the function and also fix issue #34367
2018-11-18 22:05:08 +05:30
Kenford20 7304bdc0af Update description of pig-latin algorithm (#21235) 2018-11-12 16:13:49 +09:00
Greg Brewton 7a1256df79 Minor clarification (#34250)
(?=\D*\d) is looking for a non-number to precede a number. If '12Three' was passed in to test, it would not match though it matches the stated criteria of 5 character minimum length and two consecutive numbers.
2018-11-10 10:33:01 +05:30
mail-liam 86be0947b5 Updated tests for 'Iterate through an array with a for loop' to ES6 (#19722) 2018-11-08 22:02:21 +09:00
Prabhat Kumar Sahu fa4117ae85 Solution write-higher-order-arrow-functions.english.md (#18772) 2018-11-07 20:37:01 +09:00
Carol W 54074a790c fix: add additional tests for Regular Expression challenge (#18696)
fix(curriculum): add additional tests and solution for Restrict Possible Usernames challenge
2018-11-06 16:21:26 +03:00
The Coding Aviator f4ff1d961d Corrected wording in es6 challenge (#19946)
* Update compare-scopes-of-the-var-and-let-keywords.english.md

* Updated line

Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>

* Format the document
2018-11-05 12:58:36 -05:00
Eric Kao 8b21132cac Fix line for Example (#20713)
* Fix line for Example

Bolded Example is inline with description. Added new line so that Example will have its own line (right before the actual example)

* Add line break after Description
2018-11-04 07:18:50 +05:30
Martin Payne b63711fd83 Changed "match all the upper and lower a" to "match all the upper and lowercase a" (#34171)
This is just a simple grammar fix but I feel like upper and lowercase a reads better so it's worth making this change.
2018-11-03 07:21:39 +05:30
Shreyas BS 55686d7197 Updated grammar (#20541) 2018-10-30 22:58:51 -05:00
The Coding Aviator b1da17a309 Update refactor-global-variables-out-of-functions.english.md (#19751) 2018-10-28 10:33:12 +07:00
Valeriy S 0aa6881508 test(curriculum): test suites must fail on the initial contents 2018-10-28 03:16:22 +05:30
Bannon Tanner 088b0ec458 added note about UpperCamelCase for ES6 classes (#26979)
* added note about UpperCamelCase for ES6 classes

proposed note in issue #17864

* added note as a new heading

changed from note as a sentence to note as a heading plus the actual note

* added <code> around SpaceShuttle

* removed markdown and added <strong> tag
2018-10-24 23:28:15 +05:30
Utkarsh Raj Singh 02206a2123 Modified the sort function (#25978)
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
2018-10-23 04:01:24 +05:30
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Randell Dawson 65686b44e5 fix: removed all hidden chars from tests verbiage (#19674)
* fix: removed all &#8203; from tests verbiage

* fix: added single quote to start text string

* remove single quote from text line

* fix: removed the hidden chars in the testStrings

* fix: removed hidden chars from testString section

* fix: removed hidden chars form testString part

* fix: removed hidden chars from testString part

* fix: removed hidden chars from testString part
2018-10-20 17:58:26 +05:30
Prabhat Kumar Sahu d7810f6ab4 Update use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md 2018-10-17 21:40:37 +09:00
Prabhat Kumar Sahu c9a8b38ed3 Update use-destructuring-assignment-to-assign-variables-from-objects.english.md 2018-10-17 21:35:21 +09:00
Prabhat Kumar Sahu 6f09033346 Update use-the-spread-operator-to-evaluate-arrays-in-place.english.md 2018-10-17 21:31:51 +09:00
Prabhat Kumar Sahu 1a2843934f Update write-arrow-functions-with-parameters.english.md 2018-10-17 21:03:53 +09:00
Prabhat Kumar Sahu 393489565e Update use-arrow-functions-to-write-concise-anonymous-functions.english.md 2018-10-17 21:01:40 +09:00
greggubarev 345dfd6dad Added </code> to test text (#19498) 2018-10-16 15:28:33 +01:00
greggubarev d644a2f494 Add solution (#19228)
Add solution (https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/regular-expressions/match-characters-that-occur-one-or-more-times)
2018-10-16 13:56:45 +05:30
Prabhat Kumar Sahu e5ebcec171 Update declare-a-read-only-variable-with-the-const-keyword.english.md 2018-10-16 15:52:06 +09:00
Prabhat Kumar Sahu 9f98cdce3b Solution prevent-object-mutation.english.md (#18767)
* Update prevent-object-mutation.english.md

* Improved JavaScript style
2018-10-15 21:04:52 -03:00
Prabhat Kumar Sahu b13e23037c Solution mutate-an-array-declared-with-const.english.md (#18759)
* Update mutate-an-array-declared-with-const.english.md

* Improved JavaScript style
2018-10-15 20:54:43 -03:00
Prabhat Kumar Sahu 1e3804889e Solution compare-scopes-of-the-var-and-let-keywords.english.md (#18756)
* Update compare-scopes-of-the-var-and-let-keywords.english.md

* Improved JavaScript style
2018-10-15 20:51:56 -03:00
Prabhat Kumar Sahu 7d0212dfb8 Solution explore-differences-between-the-var-and-let-keywords.english.md (#18752)
* Update explore-differences-between-the-var-and-let-keywords.english.md

* Improve JavaScript style
2018-10-15 20:50:04 -03:00