Commit Graph

486 Commits (4c7ba02af1e8d82e61534d7564b3a291a057df71)

Author SHA1 Message Date
abfipes db1a92611a
fix(curriculum): repair of a small logical underdevelopment (#43116)
* repair of a small logical underdevelopment 

a> b is false if a == b

* Apply suggestions (fix small typo )

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-05 14:54:32 +02:00
Julius Lee a34921a5b3
fix(curriculum): add additional test case to fix hard code issue (#43086)
* fix: added additional matrix1 test case for different arguments to fix hard code issue #43050

* fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages

* Revert "fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages"

This reverts commit bbbb1c7cbc.

* fix: only simplify and reduce to 1 test case using zeroArray(4,3), reverted internationalization

* fix: removed unused matrix1 from seed and solution

* update: for better wording of the added test case suggested

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-02 12:37:50 -05:00
awu43 24250d278e
feat(curriculum): rewrite capture groups description 2021-07-22 17:37:50 +02:00
awu43 b84e74ad42
fix(curriculum): improve lazy matching test regex (#42882) 2021-07-16 15:31:19 +01:00
Innocent V.I ac2fe62eef
fixed create-decimal-numbers-with-javascript challenge external link (#42801) 2021-07-09 09:02:47 -05:00
Braxton Excell 6631e51113
fix(curriculum): update object keys referenced in instructions to match provided object (#42613)
* Update referenced object keys for clarity

Because each movie object has both `Rated` and `imdbRating` key/value pairs, simply referencing `rating` could be confusing to campers. IMO explicitly referencing the keys by name (`Title` and `imdbRating`) removes ambiguity in the non-important part of this challenge and helps campers focus on learning about `.map()`.

* other references and tests

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

* reverse previous changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-28 16:25:33 +02:00
dogfood654 e5505cbe7b
fix(curriculum): minor indentation for readability (#42451)
* Fixed minor indentation for readability

* amended to 2 indentation
2021-06-16 14:35:34 +01:00
awu43 ae0d34359a
fix(curriculum): stop false positives in test for array hard coding (#42461)
* Fixed test regex to avoid false matches

* Changed regex to only match values in globalArray

* Revert non-English changes
2021-06-15 10:35:35 -05:00
Ilenia 08fc4014c7
fix(curriculum): Removing genitive from inside backticks and backticks from word own (#42466)
* inherit-behaviors-from-a-supertype put genitive outside backticks

* override-inherited-methods genitive outside backticks

* reset-an-inherited-constructor-property genitive outside backticks

* use-prototype-properties-to-reduce-duplicate-code genitive outisde backticks

* use-prototype-properties-to-reduce-duplicate-code own without backticks

* removing genitive by rephrasing

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-14 17:52:28 +02:00
Ilenia ce3ccc47d4
fix(curriculum): remove unnecessary backticks (#42458) 2021-06-12 20:53:45 +02:00
zoembrown ca2f024aec
fix(curriculum): fixed typo in challenge (#42456) 2021-06-12 17:37:17 +02:00
Ilenia 28add4712a
Remove backticks from around data types to ease translations (#42403) 2021-06-08 14:03:16 +05:30
Rebekah Koon 5a3d22e76b
fix(curriculum): changing Charles -> Ada in JavaScript challenge descriptions (#42280)
* changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing firstName value from Ada to Augusta in javascript lesson
2021-05-29 21:33:21 +05:30
etlioglu 8b73920487
fix(curriculum): add items using splice verbiage
"The second entry of `12` is removed" is changed to "The second occurrence of `12` is removed". I believe the phrase "second entry" might create confusion as the readers might think of the second entry of the array rather than the second occurrence of the array element 12.
2021-05-24 13:33:25 -07:00
alirezaghey 777c508f82
fix(curriculum): small english improvement (#42173)
* fix(curriculum): small english improvement

* fix(curriculum): small english improvement

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2021-05-18 14:42:05 -07:00
Sem Bauke f3e8a0f0c2
fix(curriculum): clarify Check if an Object has a Property (#42156)
* fix: clarify Check if an Object has a Property

* fix: give extra clarity on object checking
2021-05-18 20:36:53 +04:00
alirezaghey 7fb1b142e3
fix(curriculum): small english improvement (#42167) 2021-05-17 15:53:15 -05:00
alirezaghey cbb7afd5b8
fix(curriculum): correct link text (#42143)
* Small language improvement

The correct term is assignment operator.

* Small language improvement

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2021-05-15 17:10:19 +02:00
alirezaghey 79e799feb5
fix(curriculum): scoping variables language improvement (#42135) 2021-05-14 09:02:54 -07:00
Niraj Nandish d820b2a0cd
fix(curriculum): Update wording of test in 'Add Methods After Inheritance' (#42112)
* fix: Update wording of test in 'Add Methods After Inheritance'

* fix(curriculum): Correct grammar of test description

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-05-12 11:25:05 -07:00
Sem Bauke 9c28a2300a
fix(curriculum): look for inlined filter function (#41953) 2021-04-30 20:55:16 +01:00
Evgeny Klimenchenko db369fbed1
fix(client): remove JS comments from user code for tests (#41873)
* Removes comments in js challanges by default

* fix local-scope-and-functions test regex

* fix all languages

* revert language changes

* removed unnecessary removeJSComments from challenges

* fix challanges in other languages

* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
Jeremy L Thompson 6ae186a8cf
fix(curriculum): record collection challenge - variable names shouldn't be keywords (#41904)
* style - update record collection challenge, variables shouldn't be name after keywords

* minor - typo fix

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 21:51:41 +02:00
Kyle Holmberg 02f232caf4
fix(curriculum): add additional test to telephone regex challenge (#41852) 2021-04-18 21:36:09 +01:00
Shaun Hamilton 4171277dc9
fix(curriculum): clarify instructions for ouput (#41839) 2021-04-16 20:33:58 +02:00
Karen Blacktopp 422bded413
fix: remove quotation marks from 'Hi World' in Instructions (#41837) 2021-04-16 10:36:59 +02:00
Sem Bauke 21c8500f94
fix(curriculum): prevent submitting array instead of string (#41720)
* fix(curriculum) prevent users from submitting an array instead of string

* use strict equality instead of new test

* Add suggestions from Tom

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-04-09 07:34:55 -05:00
Emer Conghaile fe95d5bca2
fix(curriculum): Remove unnecessary comments (#41777)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Remove unnecessary comment
2021-04-08 10:59:25 -07:00
Emer Conghaile 87b0e5bb7a
fix(curriculum): Remove unnecessary comments (#41781)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Update the hints section
2021-04-08 10:49:47 -07:00
Emer Conghaile c4ba0c692f
fix(curriculum): Remove unnecessary comments (#41776)
* Remove unnecessary comments

* Remove last comment, change instruction wording
2021-04-08 10:46:39 -07:00
Emer Conghaile 591a534701
Remove unnecessary comments (#41775)
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
2021-04-08 09:40:34 -07:00
Emer Conghaile a9a68fa498
fix(curriculum): Remove unnecessary comments (#41774)
* fix: Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Add empty line
2021-04-08 09:36:05 -07:00
Saurabh Kumar singh 617f7b07e9
Update iterate-through-an-array-with-a-for-loop (#41742)
* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

Add space around minus for better readablilty.

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop.md
2021-04-08 09:56:49 -05:00
Akib Maredia 523997c33b
fix: Mr.Page's firstname to Elliot (#41744) 2021-04-05 08:49:12 +02:00
Nicholas Carrigan (he/him) 7d83a6b65d
fix(curriculum): verbiage (#41732)
* fix(curriculum): verbiage

Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.

* fix: Shaun's arrays have elements

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-03 23:00:15 +02:00
Sem Bauke e75685f803
fix(curriculum): change tests to allow more solutions (#41703)
* fix(curriculum) only allow  new object to be the second value in array

* fix(curriculum) remove direct array index notation

* Apply suggestions from Shaun

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-03-31 14:24:20 -07:00
Rafael D. Hernandez 37e8d0b757
fix/ownProps (#41686)
related issue:#4114
2021-03-31 13:48:37 +05:30
Nicholas Carrigan (he/him) e1ea77412b
chore(i18n,curriculum): updates (#41689)
Apply typo fixes and formatting changes based on feedback from
internationalisation process.
2021-03-31 13:48:01 +05:30
Rafael D. Hernandez c962c0c8e5
fix: wrap own properties and not just own (#41614)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-27 07:59:44 -06:00
Emer Conghaile e5b4ae17a0
fix: Simplify wording to make more sense (#41586)
* fix: Simplify wording to make more sense

I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

I think that this variation sounds better than what I originally wrote.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-25 22:18:51 +00:00
Randell Dawson b5ed2619eb
fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
CoolBlueDesigns fd5e6eebfb
fix(curriculum): add blank like to seed code 2021-03-22 16:18:15 +00:00
Randell Dawson e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge (#41538)
* fix: improve test to allow function call anywhere

* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
Arjun Yadav 3f1cd6eb33
fixed the grammar of the description (#41531) 2021-03-19 06:55:21 -06:00
Kelvin Sánchez 35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Nicholas Carrigan (he/him) c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
Nicholas Carrigan (he/him) 77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
Andrew Cen 65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him) 7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson 33356e403a
fix(learn): Use backticks around back slash character (#41254) 2021-02-25 16:34:40 +05:30