08fc4014c7
fix(curriculum): Removing genitive from inside backticks and backticks from word own ( #42466 )
...
* inherit-behaviors-from-a-supertype put genitive outside backticks
* override-inherited-methods genitive outside backticks
* reset-an-inherited-constructor-property genitive outside backticks
* use-prototype-properties-to-reduce-duplicate-code genitive outisde backticks
* use-prototype-properties-to-reduce-duplicate-code own without backticks
* removing genitive by rephrasing
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-14 17:52:28 +02:00
d820b2a0cd
fix(curriculum): Update wording of test in 'Add Methods After Inheritance' ( #42112 )
...
* fix: Update wording of test in 'Add Methods After Inheritance'
* fix(curriculum): Correct grammar of test description
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-05-12 11:25:05 -07:00
37e8d0b757
fix/ownProps ( #41686 )
...
related issue:#4114
2021-03-31 13:48:37 +05:30
c962c0c8e5
fix: wrap own properties and not just own ( #41614 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-27 07:59:44 -06:00
b5ed2619eb
fix: replace inline code blocks ( #41576 )
2021-03-26 02:37:48 +05:30
65cc800689
fix: add blank lines on empty seeds ( #41348 )
2021-03-03 13:14:28 -08:00
7117919d36
chore(learn): audit javascript algorithms and data structures ( #41092 )
...
* chore(learn): audit basic algorithm scripting
* chore(learn): audit basic data structures
* chore(learn): audit basic javascript
* chore(learn): audit debugging
* chore(learn): audit es6
* chore(learn): audit functional programming
* chore(learn): audit intermidate algorithms
* chore(learn): audit js projects
* chore(learn): audit object oriented programming
* chore(learn): audit regex
* fix(learn): remove stray .
* fix(learn): string to code
* fix(learn): missed some
* fix(learn): clarify strings
Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.
* fix: apply suggestions - thanks Randy! :)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: non-suggestion comments
* chore(learn): remove comments from codes
Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: revert crowdin fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: Apply suggestions from code review
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* chore: change voice
* fix: Christopher Nolan
* fix: expressions would evaluate
* fix: will -> would
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: to work to push
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
f2b1d7b147
fix(challenge): Assert arrays contain expected values ( #40693 )
2021-01-21 10:52:52 -08:00
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
a050de56bb
Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife ( #39347 )
...
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.
* Second Test will now pass the test
* Escape One Parenthese
* Update Regex to be more structured
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Missing regex ending literal
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
2b60f3e61e
fixed arrow function with no curly braces failing IIFE test ( #38544 )
...
* fixed arrow function with no curly braces failing IIFE test
* added iife 2nd test fix and 3 new solutions
2020-04-20 11:04:28 +02:00
a282c24bf4
fix (curriculum): added console output checks for the inheritance challenge ( #38360 )
...
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 ( #38267 )
...
* fix: consolidate comments
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 ( #38258 )
...
* fix: consolidate/remove comments
* fix: remove => from comment
* fix: reverted changes to add same changes to another PR
* fix: removed 'the' from sentence
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: removed 'the' from the sentence
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 ( #38259 )
2020-03-03 10:18:30 +03:00
8af54eb272
fix(curriculum): Technical language correction ( #37812 )
...
Technically, the prototype is not cloned; it is merely referenced.
2019-12-04 21:01:49 +00:00
2c15bcbb43
fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures ( #37761 )
...
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
c1b3588e59
Basic JS challenge: use-prototype-properties link added ( #37802 )
...
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
2019-11-25 13:02:21 -06:00
5ea745d61f
fix(curriculum): English punctuation correction ( #37811 )
2019-11-22 06:35:10 -08:00
1fc71e6969
Update create-a-basic-javascript-object.english.md ( #37810 )
...
small spelling correction (everyday -> every day)
2019-11-22 06:34:34 -08:00
bfa5c26288
fix: use dfn instead of code tag ( #36640 )
...
* Use dfn tags
* remove misused <dfn> tags
* Revert "remove misused <dfn> tags"
This reverts commit b24968a968
2019-10-27 12:45:37 -04:00
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
d0d8282f86
fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections ( #36457 )
...
* fix: remove double quoted assert msg arg - responsive
* fix: remove double quoted assert msg arg - js
* fix: remove double quoted assert msg arg - libraries
* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
1fa0dcb1e1
fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 04 ( #36404 )
...
* fix: rm assert msg OOP
* fix: rm assert msg regular expressions
2019-07-24 11:32:04 +02:00
7d4dc382b4
fix(curriculum): format challenge markdown as per linting rules ( #36326 )
...
* fix: Format challenge markdown according to linting rules
* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
db1b435775
Fix spelling ( #36111 )
...
"hachedEgg" -> "hatchedEgg"
2019-05-22 17:42:44 -05:00
39c43dbe8a
Alter instructions ( #36099 )
...
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
05f73ca409
fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures ( #35992 )
...
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
88a5d46ccb
fix(challenge): add support for IIFE arrow function ( #35573 )
...
* fix(challenge): add support for IIFE arrow function
* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
228d873dd3
Fix: remove quote from challenge where not needed [english] ( #35493 )
2019-03-19 15:04:03 +05:30
9051ad2eb5
Fixed bug allowing versions of Object.keys method and hard coding of ownProps array ( #35021 )
...
* fix: disallow variants of Object.keys method
* fix: added new test to help prevent hardcoding array
* fix: refactored regex
2019-03-17 18:47:41 -04:00
494687f75e
fix: correct inconsistency in formatting ( #34721 )
...
* fix: correct inconsistency in formatting
* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
665c9cb47f
fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object ( #34675 )
...
* fix: typos
* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
9341aadb5b
Fix/remove property references and update tests ( #35109 )
...
* fix(challenges): Update challenge text and assertion test
* fix(challenges): update assert test regex
* fix(challenges): update regex, fix inline comment in code example
* fix: corrected regex
2019-02-09 00:47:53 -05:00
e8b7b2eb6f
Fixed typo ( #34848 )
...
Original wording: getHachedEggCount
New wording: getHatchedEggCount
2019-02-08 13:59:04 -08:00
85eca8ef36
[fix]: Object Oriented Programming: Inherit Behaviors from a Supertype ( #35063 )
...
* fix: revert semicolon check
* fix: test name
2019-02-06 08:23:47 +03:00
9a4e13954a
Tests for OOP: Inherit Behaviors from a Supertype ( #34938 )
...
* Tests for OOP: Inherit Behaviors from a Supertype
Fixes issue #34905
* fix: make test inclusive
2019-02-05 20:44:53 +03:00
7ae6577cda
Change for second test case ( #34785 )
...
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".
Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
2019-02-05 21:07:17 +05:30
56ded4174c
[Fix] Object Oriented Programming: Remember to Set the Constructor Property when Changing the Prototype ( #34569 )
2018-12-14 19:59:35 +09:00
79d9012432
fix(curriculum): quotes in tests ( #18828 )
...
* fix(curriculum): tests quotes
* fix(curriculum): fill seed-teardown
* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
abc6c3c208
Fix typo on OOP challenge ( #18616 )
...
* Fix type on OOP as requested on issue #18091
fix:
numLegs: 2 to numLegs: 4
on challenge:
Remember to Set the Constructor Property when Changing the Prototype
* Update remember-to-set-the-constructor-property-when-changing-the-prototype.english.md
2018-10-14 04:34:41 +05:30
ee9f6b2d72
chore(meta): Move challenge meta to challenges root
2018-10-11 02:15:05 +05:30
0d5fec5e21
Fixed typo issue in Iterate Over All Properties
2018-10-09 02:54:25 +05:30
a859035023
fix(challenge-md): Fix quotes that failed in the transform
2018-10-08 11:38:26 +05:30
Ilenia
Niraj Nandish
Rafael D. Hernandez
Randell Dawson
Andrew Cen
Nicholas Carrigan (he/him)
Lasse Jørgensen
Oliver Eyton-Williams
Joshua Pelealu
piouson
Hassaan Pasha
Tom
Waldo Luis Ribeiro
Kiara Barias
SomeDer
Randell Dawson
Natalie Cardot
NITIN BISHT
Aditya
Julien Galibois Sauvageau
Dom Coleman
John Sprunger
Valeriy
jefferson2z
Bouncey
Lauren Van Sloun