Commit Graph

25048 Commits (5ca2d2467a167541f21260f77552597627239939)

Author SHA1 Message Date
Tom 5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
bitrixtoday 07b74ab70b Improved translate russian language (#37647) 2019-11-15 22:36:52 +05:30
Randell Dawson 39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699)
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-15 10:14:54 -06:00
HoJeong Im 1fb202b742 fix(curriculum) - Add class box in json apis and ajax (#37725)
* Add class box in json apis and ajax

* Remove .box in id & add .box in seed code
2019-11-15 08:56:28 +01:00
Oliver Eyton-Williams 687c4fdb98 fix(client): add cache-busting hashes to chunks (#37746)
* fix(client): add cache-busting hashes to chunks

* fix: create cache-busting names for the workers

Prior to this PR the first webpack compilation gave the workers static
names.  This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.

In order for Gatsby to find them, the names are added to the
config directory.
2019-11-15 01:43:44 +05:30
Kiara Barias c4dc0b297f Switch statement example updated (#37757)
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
Oliver Eyton-Williams 2d647b1638 fix: reword devops guide (#37759) 2019-11-14 23:58:45 +05:30
Oliver Eyton-Williams c5d4bedda5 feat: add accessibility toggle
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip.  The mode now persists
between challenges.

If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
2019-11-14 22:17:13 +05:30
Oliver Eyton-Williams 265e383705 fix: allow username submission after failure
If the server rejects a username submission, the submit button became
stuck as disabled.  This ensures that new (valid) input will unlock the
button.
2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams e1236a0c15 refactor: use validate util in client 2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams e77408827a feat: add server-side username validation 2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams 7500c370b6 refactor: create common validation function 2019-11-14 22:16:24 +05:30
Randell Dawson 55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715)
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
Rohit Ambre 376b42637a Updated file names required in the challenge (#37737)
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
2019-11-11 22:04:38 -05:00
Quincy Larson e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
allison-strandberg 2c5453e3bd Clarify instructions (#37735)
Closes #37734
2019-11-11 16:48:51 +01:00
Subash Iglesias 385287838e fix(curriculum) - fixed function keyword not misspelled in debugging guide (#37711)
* [ FIXES ] - fixed function keyword not misspelled

* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added comment back into example code
2019-11-11 07:37:11 -06:00
Tom 6ff5e52b2d Improve viewport unit readability (#36673)
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
2019-11-11 10:24:02 +01:00
Matheus Genteluci 67e0f33a89 feat: Add Solution to handle click event - English (#37069) 2019-11-11 09:19:28 +01:00
Marco Valero f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description (#37730)
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
jotagarciaz 84d683940a docs: improving spanish translations (#37593) 2019-11-10 10:42:27 -08:00
Eunjeong Park fb551cb23c Improve Korean translation and change wording (#36973)
* Fix typo in CONTRIBUTING.md

Remove spacebar and enable markdown

* Retranslate CONTRIBUTING.md in Korean

- Retranslate CONTRIBUTING.md (updated version) in Korean
- Correct an error in translation
- Make expressions more clear and friendly

* Change wording to more friendly one
2019-11-10 04:34:58 -08:00
Tristan Michael Lawrence 5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
anthonyjvoss 7639306a20 doc: improved readability and added port validation (#37614)
Provided updates for better overall readability.  Added a section for validating whether port 3000 is already in use on Windows and MacOS.
2019-11-10 04:29:30 -08:00
Loic Beylot c5098e9fc9 docs: fix a few typos in French guidelines (#37628)
* Fix a few typos

One missing s for a plural word and a few missing spaces.

* Fix one typo
2019-11-10 04:27:33 -08:00
jasonranney 26e857b6ab fix: update JavaScript capitalization (#37466) 2019-11-10 04:24:34 -08:00
lasjorg e1a1ed5c12 fix(client): use JSON.stringify replacer function for NaN (#37684) 2019-11-10 04:17:18 -08:00
Kirankumar Ambati 32954923e1 fix: Read-Search-Ask link on Frontend-Libraries projects (#37710) 2019-11-10 04:16:18 -08:00
Daniel Veazey 9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726)
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
2019-11-09 18:13:10 -05:00
Mrugesh Mohapatra 8107106915 fix(donate): quick patch for auth 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra 139f8fcb1b chore: remove poweredByStripe asset 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra 4cd5542489 feat(donate): two col layout checkout page 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra 7a4e84d163 chore(donate): remove donate page tests
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.

We sould be adding comprehensive tests to the components instead.
2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra 83ac3c5f95 chore(donate): remove unused donate modal wiring
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.

The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
2019-11-09 11:39:29 -08:00
imgbot[bot] a36e0d8351 [ImgBot] Optimize images (#37723)
*Total -- 50.98kb -> 38.49kb (24.51%)

/client/src/assets/images/square_puck.png -- 25.51kb -> 13.31kb (47.81%)
/client/src/assets/images/freeCodeCamp-404.svg -- 25.47kb -> 25.17kb (1.17%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2019-11-09 01:33:48 -08:00
Ahmad Abdolsaheb ccd135f268 feat: update logo (#37716)
* feat: update logo

* fix: adjust logo height
2019-11-09 01:31:49 -08:00
David Carlson bdae7343bb escaped backslash character on line 22 (#37721)
Previously only showed empty parentheses.
2019-11-08 23:25:48 -05:00
David Carlson 00914be3e8 Removed text about prior knowledge (#37722)
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
2019-11-08 22:03:44 -05:00
Abdelrahman Ashraf 94532f98db refactor(tests): enzyme => react-testing-library (#37712)
* refactor: 💡 rewrite enzyme tests in react-testing-library

* fix: 🐛 remove enzyme imports from frame-runner.js

* chore: 🤖 install and add enzyme imports to frame-runner.js back
2019-11-08 16:50:25 +05:30
Randell Dawson 5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00
Louisa 2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
Alex Parra 647945f4ac fix: duplicated 'use' in set-up-passport.english.md (#37134) 2019-11-07 18:42:34 +01:00
Randell Dawson 18891bf3ff feat(curriculum): download solution as non-json text file (#37681)
* feat: download solution as non-json text file

* fix: added missing end of line character

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-07 16:11:57 +05:30
Daniel Veazey 7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
Kiara Barias 3119da3ec5 Changes to "Iterate with JavaScript While Loops - English" challenge description (#37683)
* Update iterate-with-javascript-while-loops.english.md

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-while-loops.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 13:26:44 -05:00
PartyLich a52b5b4ebb feat: rewrite Iterate with JavaScript While Loops challenge (#37697)
* feat: rewrite Iterate with JavaScript While Loops challenge

Previous example in the challenge description was the exact code
that challenge instructions say to implement. Change the challenge to
differentiate from the example.

resolve freeCodeCamp/freeCodeCamp#37694

* fix: update iterate with javascript while loops solution

* refactor: improve iterate with js while loops challenge wording

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 12:51:59 -05:00
Kishore Devaraj 06277c8436 fix(client): Improve client validation accessibility (#37459) 2019-11-06 19:43:58 +05:30
Nirvin M 699ffc5593 fix(client): reduce height of the alert banner (#37497) 2019-11-05 21:23:35 +05:30
mrugesh 9be55a3737
docs: update i18n f.a.q about docs and curriculum 2019-11-05 20:54:38 +05:30
mrugesh cc16f68d0c
docs: update i18n f.a.q about curriculum (#37692) 2019-11-05 20:47:41 +05:30