* fix: correct test and add solution
I also changed the seed to report the results of an easier example to
the user, since just evaluating the function mostly wastes time.
* fix: use a better solution
* fix: credit original author
* Correct ProjectEuler:002 definition and tests
From projecteuler.net:
By considering the terms in the Fibonacci sequence whose values do not exceed four million, find the sum of the even-valued terms.
Correct: take all f(n) where f(n) <= 4,000,000 and f(n) is even
Incorrect: take all f(n) where n <= 4,000,000 and f(n) is even
* Incorporate PR review suggestios to ProjectEuler 002
Reword the problem statement
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* fix: update to clarify new boilerplates used
Updating challenge text to make it more clear that learners need to switch to new boilerplate
* fix: improved wording to clarify new boilerplates used
Updating challenge text to be consistent and make it clear where learners are to switch to new boilerplate
Incorporating suggestions from PR #38124
* fix: Correct paths in English exercises by prefixing "/" before "learn"
* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
* Move the comment on line 71 to its own line
The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.
* Update line 71 comment per @manish-giri suggestion
Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
Either improved the algorithm or reduced the difficulty for the slowest
tests. All these pass with testProtectTimeout = 500, so should be safe
on most machines with the current timeout of 2500.
* Added href to empty <a> tag in social auth implementation II
* corrected typos in authentication with socketIO challenge
* corrected typo as suggested
Co-Authored-By: Eric Leung <eric@erictleung.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
* Update escape-sequences-in-strings.english.md
Fixed minor grammar issue in list item 1 of the description section.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* refactor: replace trivial regex capture group challenge
Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.
resolves#17645
* test: validate at least 3 capture groups were used
Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* refactor: more meaningful variable name
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* test: add parenthesized substring test
* test: ensure 3 uses of substring replacement
* refactor: reword instructions
* fix: minor grammar fix
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* refactor: elaborate wording in test
* fix: corrected test and added solution
* fix: redefine hash
* fix: use defined hash
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: sum all primes description
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: simplify challenge without using reduce
* fix: prevent user from adding new elements to sum to 10
* fix: add from
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* Added new test case '8pass99' for positive and negative lookahead
* Changed the pwRegex to reflect the new solution
* Updated the pwRegex to reflect the latest solution as on forum
* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).
In this commit I fix the space-evenly issues to some extent.
I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.
There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: remove unnecessary backslash
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: simplified text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: added period
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: use singular of verb
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed punctuation
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: reworded test text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
* fix: broken Read-search-ask link now point to correct url
* fix: changed link to original forum link with more views
* fix: changed http links to correct version
* fix: link in help modal
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* Switch statement example updated
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity
* fix: use getComputedStyle intead of regex
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
* Improve viewport unit readability
Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
* edited description to be a little more clear on how to access elements in an array through indeces
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
* feat: rewrite Iterate with JavaScript While Loops challenge
Previous example in the challenge description was the exact code
that challenge instructions say to implement. Change the challenge to
differentiate from the example.
resolvefreeCodeCamp/freeCodeCamp#37694
* fix: update iterate with javascript while loops solution
* refactor: improve iterate with js while loops challenge wording
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Fixed a typo in Specify How Fonts Degrade.
'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.
Instead of "'-->!'.", it should be "'-->'."
* Made text wording consistent for the test instructions.
* Changed "To begin with," to "To begin," and fixed a minor typo.
If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.
Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
* Added hyphen to "coopted" on Line 17
Added a hyphen to the word"coopted" to correct it to "co-opted" on Line 17.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* add solution to a challenge
add solution to the challenge: add-a-description-to-your-package-json
* add comment to all backend challenges
The comment expllains that these challenges don't need a solution.
* update test wording for undefined fn returns, bring code out of after test section and check that the function does what it says it does (rather than just checking the result), update seed, example, and solution
* Fix solution
* Update description
* Add test for this.setState function syntax
* Update toggle element instructions
* Fix simple-counter solutions
* Fix bind-this challenge seed and solution
* Fix && challenge seed and solution
* Fix ternary challenge seed and solution
* Use the function form -> Pass a function
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Mention "passing a function" instead of "alternative form"
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Rephrase explanation
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* clarify why functions should be used
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Improve tests
* Fix \s escaping in []
* Improve regex
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Add test for `this`
* Use block code
* Update bind-this challenge
* Fix last part of instructions
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403
* bugfix: temperature is not a function
* Add link to boilerplate Glitch file
The boilerplate link is hard to see in the previous "introduction" page. I was using the old Glitch project link, and was confused.
When I googled for a solution, it was clear than others had also been quite confused. I believe this additional instruction will help many people.
* Direct people back to introduction page
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Remove unnecessary indentation
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Remove spaces on empty line
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Remove spaces on empty line
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Add empty line to fix markdown link
Markdown link needs a blank line to render correctly
* fix: add extra line to prevent linting error
* fix/remove-bullet-points
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Tom <tmondloch01@gmail.com>
* Squashed the removal of the before test section
* fix: changed blockquote triple backtick syntax
* fix: removed recursion explanation
* fix: changed meta title and thru to through
* fix: capitalize "after" in several strings
* componentWillReceiveProps is deprecated
Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed
* Removed also `componentWillReceiveProps`
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)
* fix: corrected file path to match curriculum
* fix: renamed to newer challenge name
* fix: added solutions to articles from challenge files
* fix: added missing .english to file name
* fix: added missing title to guide article
* fix: correct solution for guide article
* fix: replaced stub with hint
* fix: added space in Hint headers
* fix: added solution to guide article
* fix: added solution to guide article
* test: replaced stub with hint and solution
* fix: add Problem number: to title
* fix: changed generatorexponential to correct name
* fix: renamed knight's tour to knights-tour
* fix: updated guide article
* fix: added a recursion challenge
* fix: changed blockquote to triple backtick syntax
* fix: added an extra line to separate code section
* fix: renamed challenge and improved verbiage
* fix: added full path to challenge
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: improved wording
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added closing )
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added missing comma and the word at
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added missing text for test case
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added note regarding startNum and endNum being same
* fix: wrapped parameter names with code tags
* fix(challenge): rename challenge, change fields to properties, fix test
* fix(challenge): update challenge name in meta.json
* fix(challenge): update test and assertion message
* fix(challenge): update second assert message
* fix(challenge): remove the word Person from text
* fix: Improved grammar
Replaced 'middlewares' to 'middleware functions'. Middleware is an uncountable noun, just like 'software'. No such word as 'softwares'
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* fix: add test for input closing tag
* fix: add condintion to final syntax test
This wil test if there's any character after the input tag that isn't a white space
* fix/tests+remove-not-needed-text
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Added solution for English/Data-Visualization/Hover-tod3-element
* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element
* fix: added extra line to prevent linting errors
* added bubbleSort solution
* added insertionSort
* fixed spacing in bubbleSort
* added selectionSort
* added a test
* Fixed a reference to the array with the wrong array name in the solution
* fix: added extra lines to avoid linting errors
* fix: added comments back into seed
* Solution for add-elements-at-a-specific-index-in-a-linked-list.english.md
* Solution check-if-an-element-is-present-in-a-binary-search-tree.english.md
* Solution for remove-elements-from-a-linked-list-by-index.english.md
* change indent level to 2 space for each level
* change indent level to 2 space
* change indent level to 2 space
* delete unnecessary new lines
* keep the same seed format , and delete unnecessary new lines
* delete unnecessary new lines
* fix: added review suggestions
* fix: Added link and code tags
* fix: added new test and corrected solution
* fix: corrected test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: allow last element to be removed
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Modify if statement
Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.
* Add test
New test checks that if num is 0, an empty string is returned
* Fix test
Fixing errors in newly proposed test that checks that empty string is returned when num is 0
* Modify intermediate solution
Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)
* fix: removed unnecessary assert message arguments
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: convert data visualization
* fix: reverted to blockquote
* fix: changed js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: cleaned up code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: converted blockquotes
* fix: revert to blockquote
* fix: changed js to http
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: converted blockquotes
* fix: added extra line before triple backtick syntax
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected misc issues
* fix: properly closed em element
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Fix "ReferenceError: url is not defined" in challenge
I fix the challenge because issue #14002
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍
I modified and verify the tests according the new assessment.
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
Minor typo: `<code>` to `</code>`
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
new declared as const
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
* fix: Moved instruction to proper place and removed assert text
* Add suggestion about making note strong
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
* Expand instructions for Chai Assertion challenges
* Seperate instructions/descriptions and remove some quotes
* Add detail to descriptions in truthiness and isOk challenges
* Update formatting in instructions
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
Fixes#35793
I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?
Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
* fix(challenge): check for li and specify elements accepting text
* fix(challenge): revert text
* fix(challenge): remove word added by mistake
* fix(challenge): update test, cleanup assertion text
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
* feat: add solution for font-awesome icon challenge
* feat: add solution to add all button icons challenge
* feat: add solution to add ids to bootstrap elements challenge
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu>
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge
* Fix for issue #35665
Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md
Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>
* fix: added missing ) for assert statement
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Update description of tests pig-latin.english.md
The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md
Co-Authored-By: beansprout <christinegierer@gmail.com>
* fix: update tests for difference on two sets
* fix: update tests for difference on two sets - fix quotes
* fix: reverted testString and reworded text
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed:
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort
This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.
Closes#34776
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* Make link text more descriptive
Make link text more descriptive for improved accessibility.
* Add mention of MDN to link description
As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Adjust link wording
Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
* Update challenge descriptions with code tags
Updates multiple challanges in the category: Information Security with
HelmetJS
* Fix(wording): security with helmetjs
Co-Authored-By: jneidel <github@jneidel.com>
* fix: reformatted code and moved instructions
* fix: replaced code with blockquotes
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/install-and-set-up-mongoose.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: made a few recommended changes of text
* fix: moved </blockquote> to new line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: removed extra space
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added the word The before code tag section
* fix: Formatting for Zig Zag Matrix challenge
* Remove non-breaking spaces and replace them with normal spaces
* Update zig-zag-matrix.english.md
* Move instructions to instructions section from description
* Update zig-zag-matrix.english.md
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
Hi,
I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".
Theo
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
* Basic gramatical changes
Corrected a few typos to improve the wording
* commit suggested changes
Improve line 9 from "before" to "earlier"
Revert line 14
* Added example Input/Output to challenge
Input/Output example will make it clear what the challenge is asking the camper to do.
* Formatting changes made to file
* Made minor changes in formatting
Added <code> tag to single line code.
* Formatting update
* Added requested formatting changes
* Refactored sentence and removed earlier example
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* fix(coding): uncomment destructuring test and add solution
the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.
* fix: corrected partial solution to full
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* Added description to help understand challenge
I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
Looks good!
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
True, that makes sense..
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
* fix: update text of Write Higher Order Arrow to be more instructive
* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR
* fix: further changes to PR
* fix: checkout old head. Merge later commit with older commits
* fix: add MDN links to arrow-functions guide
* fix: re-add removed log and change working in guide wording
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Yep
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Removing unneeded line for clarity
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* Minor rephrasing of the lesson's description
Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.
* Corrections to conform to style guide
1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.
* Moved challenge instruction to Instructions section
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Correct seed code errors
Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.
* Add single quotes to correct new assertion statements
* Fix incorrect usage of splice
Changed the parameters passed to bookList.splice in the remove function
* Remove extraneous tests
Oliver Eyton-Williams
Prakash Kumar
Prayag
kundan kumar
Hassaan Pasha
srdubya
Ashraf Nazar
Josh Soref
Sidtharthan A N
Kristofer Koishigawa
Kiara Barias
Shubham Shah
David Lau
Tom Monks
PHILIP OBIORAH
Nick Black
Obba Paschal
rsapkf
Dylan Cutler
Randell Dawson
Ezekiel Oladejo
Bojan Cvjetkovic
Perrottarichard
ML
M B
Ronald van der Bergh
Tom
TAKAHASHI Shuuji
Randell Dawson
Andree Amaro Gonzalez
Rohit Ambre
Nikolas Broman
Gregory Gubarev
lasjorg
Sean Coleman
Arthur
John A Maloney
classicmatsuo
Christoph Deil
Waldo Luis Ribeiro
Wocanilo
Tim dinia
Stryyder
mikemorr
Divyanshu
ibqu
Lowell Hamilton
Mo Zargham
Jefferson Oliveira
Marco Valero
HoJeong Im
Quincy Larson
allison-strandberg
Tom
Matheus Genteluci
Tristan Michael Lawrence
Daniel Veazey
David Carlson
Louisa
Alex Parra
Ananda Umamil
Roberto Ruccia
Beau Carnes
SomeDer
Rajat Hans
Ahmad Shahzad
Omar Dabour
csteacher1
burrowsdt
gmal1
Ambar Mutha
mrugesh
Chayanon Tonsai
Bhanu Pratap Singh Rathore
shrobbins
jasonranney
Johnny Zabala
nemogoc
Ent Wickler
sybiljasmine
Kaitlin
Ezgi Kaysı Kesler
Jasper Pilgrim
Huyen Nguyen
Sahil Bondre
Lauren Van Sloun
Ai-Lyn Tang
rns350
Tiago Salema
happyhappyyay
joelzehring
enrider
Ashrith Reddy
moT01
Greg Fletcher
Saad Monem
organicdude
Fabricio Asfora Lira
Prashanth Ashok Ramkumar
Michał Kozłowski
Steven Failla
Stan Choi
Andrew Zaw
Daniel Simeonov
Tina Wang
leodaher
adamthahir
Mahesh Jaganiya
anthonykyi
RIHANE ZAKARIA
Ugur Yilmaz
Weibin Luo
Siddhant Shekhar
Courtney Landau
Val Lipat
Natalie Cardot
Varun
Ahmad Abdolsaheb
Kyle Cheung
Matt Schlosser
Courtney
Yoelvis Jiménez
duytrinhvn
Kyle Scheuerlein
Deanna Tran
The Coding Aviator
Manish Giri
Valeriy
Aly Pilkons
Ian Effendi
BSi
Fordco
Catalina
ranched
Astrid
Benjamin Herrchen
Paul Gamble
Aditi Joshi
Guayo Mena
chaomt
Илья
Dana Ottaviani
Jonathan Lawrence
Amy Lam
lucassorenson
Lipis
NITIN BISHT
Avahe Kellenberger
Justin Hilliard
seanlaing
Hrishit Prasad Biswas
Jean Jordaan
Christine Gierer
Zebulan Stanphill
Aditya
Vikas KM
rupali317
Carol W
Chuck Adams
Hugo
Timur
grets311
Shashank Bairy R
Edwin van Meerendonk
Jade Michael Thornton
Yuran Pereira
Roberto Beltran
kevindelsh
Gökhan Gurbetoğlu
Nathan Lakritz
Greg Brewton
Ron Sogueco
Sumer Patel
Vedrana_R
Jonathan Neidel
Bannon Tanner
Lewis Horwood
Alan Price
Akshay Tiwari
Aashis kumar
nik
Dan B
Ihor Allin
Theodoros Gkortsilas
Jasmeet Singh
Travis Fantina
Luane
Christopher McCormack
Alan Nguy
hilliarj
Ruchika Sharma
Greg Smith
Niraj Nandish
Pete
Héctor Estéllez
geeseyj
Adam
Ahmed Elbessfy
Chris Del
Chad
TristanSeabrook
Almaz Kunpeissov
Fordco
Lee
Riyaad Azad
Nelson Wu
Melkisedek Hamakali
Kirill Malev
Leo
Christopher Szczechowicz
Eunice Brackett
Dovid Majowka
Zach
Josh
Anas Salam
gokulsg
Howard T. Chiam
edu san
JustinBen-Tzioni
BurnhamG