* Modify if statement
Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.
* Add test
New test checks that if num is 0, an empty string is returned
* Fix test
Fixing errors in newly proposed test that checks that empty string is returned when num is 0
* Modify intermediate solution
Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)
* fix: removed unnecessary assert message arguments
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: convert data visualization
* fix: reverted to blockquote
* fix: changed js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: cleaned up code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: converted blockquotes
* fix: revert to blockquote
* fix: changed js to http
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: converted blockquotes
* fix: added extra line before triple backtick syntax
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected misc issues
* fix: properly closed em element
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Fix "ReferenceError: url is not defined" in challenge
I fix the challenge because issue #14002
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍
I modified and verify the tests according the new assessment.
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
Minor typo: `<code>` to `</code>`
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
new declared as const
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
* fix: Moved instruction to proper place and removed assert text
* Add suggestion about making note strong
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
* Expand instructions for Chai Assertion challenges
* Seperate instructions/descriptions and remove some quotes
* Add detail to descriptions in truthiness and isOk challenges
* Update formatting in instructions
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
Fixes#35793
I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?
Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
* fix(challenge): check for li and specify elements accepting text
* fix(challenge): revert text
* fix(challenge): remove word added by mistake
* fix(challenge): update test, cleanup assertion text
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
* feat: add solution for font-awesome icon challenge
* feat: add solution to add all button icons challenge
* feat: add solution to add ids to bootstrap elements challenge
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu>
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge
* Fix for issue #35665
Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md
Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>
* fix: added missing ) for assert statement
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Update description of tests pig-latin.english.md
The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md
Co-Authored-By: beansprout <christinegierer@gmail.com>
* fix: update tests for difference on two sets
* fix: update tests for difference on two sets - fix quotes
* fix: reverted testString and reworded text
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed:
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort
This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.
Closes#34776
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* Make link text more descriptive
Make link text more descriptive for improved accessibility.
* Add mention of MDN to link description
As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Adjust link wording
Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
* Update challenge descriptions with code tags
Updates multiple challanges in the category: Information Security with
HelmetJS
* Fix(wording): security with helmetjs
Co-Authored-By: jneidel <github@jneidel.com>
* fix: reformatted code and moved instructions
* fix: replaced code with blockquotes
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/install-and-set-up-mongoose.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: made a few recommended changes of text
* fix: moved </blockquote> to new line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: removed extra space
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added the word The before code tag section
* fix: Formatting for Zig Zag Matrix challenge
* Remove non-breaking spaces and replace them with normal spaces
* Update zig-zag-matrix.english.md
* Move instructions to instructions section from description
* Update zig-zag-matrix.english.md
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
Hi,
I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".
Theo
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
* Basic gramatical changes
Corrected a few typos to improve the wording
* commit suggested changes
Improve line 9 from "before" to "earlier"
Revert line 14
* Added example Input/Output to challenge
Input/Output example will make it clear what the challenge is asking the camper to do.
* Formatting changes made to file
* Made minor changes in formatting
Added <code> tag to single line code.
* Formatting update
* Added requested formatting changes
* Refactored sentence and removed earlier example
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* fix(coding): uncomment destructuring test and add solution
the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.
* fix: corrected partial solution to full
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* Added description to help understand challenge
I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
Looks good!
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md
True, that makes sense..
Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
* fix: update text of Write Higher Order Arrow to be more instructive
* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR
* fix: further changes to PR
* fix: checkout old head. Merge later commit with older commits
* fix: add MDN links to arrow-functions guide
* fix: re-add removed log and change working in guide wording
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Yep
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Removing unneeded line for clarity
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* Minor rephrasing of the lesson's description
Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.
* Corrections to conform to style guide
1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.
* Moved challenge instruction to Instructions section
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Correct seed code errors
Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.
* Add single quotes to correct new assertion statements
* Fix incorrect usage of splice
Changed the parameters passed to bookList.splice in the remove function
* Remove extraneous tests
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md
* fix(challenges): Update challenge text and assertion test
* fix(challenges): update assert test regex
* fix(challenges): update regex, fix inline comment in code example
* fix: corrected regex
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update create-a-text-field.english.md
* fix: change language tag and remove wrong comment
* Sample solution for the file
I have updated the sample solution for the challenge seed code.
* Update add-images-to-your-website.english.md
formatted ```html tags
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".
Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
* Update create-a-queue-class.english.md
* Modify test for dequeue method to check for FIFO
The test first `enqueue`'s two elements and checks for the `dequeue` method to return the element at `0`th index.
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
Co-authored-by: Paul Gamble <pgamble@gmail.com>
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* Sample solution for the challenge seed code
I have updated the sample solution for the challenge seed code.
* Update headline-with-the-h2-element.english.md
Removed //solution required
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* Add the solution
* Update divide-one-decimal-by-another-with-javascript.english.md
The solution was not passing. Change should pass now.
* Update divide-one-decimal-by-another-with-javascript.english.md
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* fix: merges 3 set challenges into 1
* fix: changed function to class syntax
* fix: simplified instructions
* fix: changed the example
* style: minor formatting changes
* style: formatted solution
* fix: formatting
* feat(interview-prep): Added Rosetta problem
* Update sort-an-array-of-composite-structures.md
* feat(interview-prep): Added meta data
* feat(interview-prep): Added Bogosort Meta Data
* Added whitespace to the tests
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
Closes #XXXXX
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
* added explanation of private variable naming convention
* Added "Note:" to the front of the explanation
* Added solution
* Moved "Note:" to it's own line and made it bold
* fix: moved note block at the bottom
Thank you for your pull request.
I am closing this pull request. Please add links and other details to the challenge’s corresponding guide article instead.
If you think I’m wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.
@MP7373
(?=\D*\d) is looking for a non-number to precede a number. If '12Three' was passed in to test, it would not match though it matches the stated criteria of 5 character minimum length and two consecutive numbers.
* Translate challenge subtitles and example challenge text to Spanish
* Corrected errors in syntax and punctuation
* Multiple corrections of it/s to its plus other grammar corrections
* Correction and added paragraph to CSS Flex article
* Corrected my own typo
* Corrected capitalization, American spellings and typos
* Update compare-scopes-of-the-var-and-let-keywords.english.md
* Updated line
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Format the document
* Fix line for Example
Bolded Example is inline with description. Added new line so that Example will have its own line (right before the actual example)
* Add line break after Description
* Fixing typo: Implement the Serialization of a Passport User
Fixing typo in "Implement the Serialization of a Passport User" curriculum page under "Advanced Node and Express" topic
* Fix typo in 'logging a user out' page
Fixing typo in 'logging a user out' page
* Added missing space
* Added missing period in add-borders-around-your-elements.md
* Added missing space in adjust-the-padding-of-an-element.english.md
I was doing this challenge and noticed that there wasn't a space after "transform:scale(2)" in the description which is inconsistent with the other challenges so I changed it to "transform: scale(2)"
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
* added note about UpperCamelCase for ES6 classes
proposed note in issue #17864
* added note as a new heading
changed from note as a sentence to note as a heading plus the actual note
* added <code> around SpaceShuttle
* removed markdown and added <strong> tag
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
* fix: removed all ​ from tests verbiage
* fix: added single quote to start text string
* remove single quote from text line
* fix: removed the hidden chars in the testStrings
* fix: removed hidden chars from testString section
* fix: removed hidden chars form testString part
* fix: removed hidden chars from testString part
* fix: removed hidden chars from testString part
I did not understand the original lesson of "through" vs "to" upon first reading.
Later reading the code below it started to make sense... but I added a bit more to the explanation.
* Clarification of the declaration order overriding
Previous text was talking about an override but it may also confuse readers that the override was done in the order of the listing of class names inside the h1.
I also added an extra case to better clarify the situation.
* Small change mentioning the order of declaration
Missed an order of declaration emphasis on my previous commit, adding it on this one.
* feat: Update intro to currying
- Add solutions
- Add ES6 examples
* feat: Add solution to FP mutations
* feat: Add solution to function-programming map
- Add solutions, both vanilla and ES6 arrow functions
- Add JSON.stringify to console.log, makes it easier to see what the resulting output is rather than showing
e.g. [object, object, object]
* update: used the contributor's ES6 solution
Contributor originally had a non-ES6 solution and an ES6 solution. I removed the non-ES6 solution.
A test that featured nested arrays just happens to work, but nested arrays will not be removed if they’re duplicates by the current solution of this challenge. See issue #18265
* Fix type on OOP as requested on issue #18091
fix:
numLegs: 2 to numLegs: 4
on challenge:
Remember to Set the Constructor Property when Changing the Prototype
* Update remember-to-set-the-constructor-property-when-changing-the-prototype.english.md
* User Flow: Information, Articles, Youtube update
Explanation on what is User Flow with youtube videos and articles for reference and/or resource.
* Update of UX Design article
Update the article with more information and more links to articles and books.
* Product Design: Info, Articles, Youtube update
Explanation on what is Product Design with youtube videos and articles for reference and/or resource.
* Update description of Retina Display
As reported in issue #18129, there is a lack of explanation on what a retina display is and some users find it difficult to understand what they are doing exactly, so I added a short explanation on what a High-Resolution Display is and what a Retina Display is.
Varun
Natalie Cardot
Ahmad Abdolsaheb
Tom
Mahesh Jaganiya
Randell Dawson
Kyle Cheung
Matt Schlosser
Huyen Nguyen
Courtney
Yoelvis Jiménez
duytrinhvn
Kyle Scheuerlein
Deanna Tran
Randell Dawson
RIHANE ZAKARIA
Oliver Eyton-Williams
The Coding Aviator
Manish Giri
Valeriy
Tina Wang
Aly Pilkons
Ian Effendi
BSi
Fordco
Catalina
ranched
Astrid
Beau Carnes
Benjamin Herrchen
Paul Gamble
Aditi Joshi
Guayo Mena
lasjorg
chaomt
Roberto Ruccia
Kristofer Koishigawa
Илья
Dana Ottaviani
Jonathan Lawrence
Amy Lam
lucassorenson
Lipis
NITIN BISHT
Avahe Kellenberger
Justin Hilliard
seanlaing
Hrishit Prasad Biswas
Jean Jordaan
Christine Gierer
Zebulan Stanphill
Aditya
Vikas KM
rupali317
Carol W
Chuck Adams
Hugo
Bhanu Pratap Singh Rathore
Timur
grets311
Shashank Bairy R
Edwin van Meerendonk
Jade Michael Thornton
Yuran Pereira
Roberto Beltran
kevindelsh
Gökhan Gurbetoğlu
Nathan Lakritz
Greg Brewton
Ron Sogueco
Sumer Patel
Lauren Van Sloun
Vedrana_R
Jonathan Neidel
Bannon Tanner
Lewis Horwood
Alan Price
Akshay Tiwari
Aashis kumar
nik
Dan B
Ihor Allin
Theodoros Gkortsilas
Jasmeet Singh
Travis Fantina
Luane
Christopher McCormack
Alan Nguy
hilliarj
Ruchika Sharma
Greg Smith
Niraj Nandish
Pete
Héctor Estéllez
geeseyj
Adam
Ahmed Elbessfy
Chris Del
Chad
TristanSeabrook
Almaz Kunpeissov
Fordco
Lee
Riyaad Azad
Nelson Wu
Melkisedek Hamakali
Kirill Malev
Leo
Christopher Szczechowicz
Eunice Brackett
Dovid Majowka
Zach
Josh
Anas Salam
gokulsg
Howard T. Chiam
edu san
JustinBen-Tzioni
BurnhamG
lmilliken
SGokul1
Steven Torrence
Cryotechnic
Naveen
Julien Galibois Sauvageau
Aditi Joshi
coderlyn
Dom Coleman
Chelsea Marie Hicks
John Sprunger
Ali Ahmed
Tammy
Pepijnk12
Aculisme
Brittany Sarenpa
Walter Woodward
Tracey Bushman
Nelson Sandoval
Oleksii Pudlo
Mike Short
Zach Carroll
Casey Bennington
lucielchoi707
Joe Erickson
buhidar
Rohan Mohammad
Abhishek Kakade
Quincy Larson
Emanuele Antonelli
Nhat Khanh
Ashish Singh
Adrian Skar
Konstantinos Lyrakis
Ismael Casimpan
Billy Phillips
Lxsthorne
Ben Brown
Ariel
Anuj Jindal
Martin Payne
Mike Perry Yeboah Attara
Tomer Ben-Rachel
Kenford20
mail-liam
S.Hale
Prabhat Kumar Sahu
Dennis Wolfers
Eric Kao
Prakhar Yadav
c-stu
amgusain
Shreyas BS
MackenzieThomasDevelopment
Mrugesh Mohapatra
Hoang Huy Phi
Utkarsh Raj Singh
Todd Chaffee
greggubarev
petern
Jonathan Grah
Ryan Bowlen
johngeesey
Franklin Wang
jefferson2z
Martin
Bouncey
Jared
halcyondays22
Camille Hagenbourger
Derek Kim
Lauren Van Sloun
petergrainger