* fix: general bugs
- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.
* feat: some tests
* feat: tests 6-20
Add tests for steps 6-20.
* feat: tests 21-30
Add tests for steps 21 through 30.
* feat: tests 31-40
Add tests for steps 31 through 40.
* feat: tests 41-50
Add tests for steps 41 through 50.
* feat: tests 51-60
Add tests for steps 51 through 60.
* feat: tests 61-70
Add tests for steps 61 through 70.
* feat: tests 71-80
Add tests for steps 71 through 80.
* feat: steps 81-92
Add tests for steps 81 through 92.
* feat: align dashed names
Align the dashed names with the titles and file names.
* fix: apply gikf's suggestions
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* fix: manual review suggestions
Apply gikf's other suggestions.
* feat: more thorough testing
When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.
* feat: optional semi colons
Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?
* chore: apply review suggestions
Apply review suggestions from gikf
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* chore: apply suggestions from code review
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* feat: review suggestions
Apply Ahmad's review suggestions.
* chore: additional suggestions
Manual application of Ahmad's review suggestions.
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* chore: apply suggestions from code review
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* chore: apply shaun's review suggestions
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* feat: add clarification
Add a bit of text clarifying the file switch in the editor.
* chore: replace URLs
Replace the tinyurls with our self-hosted CDN images.
* feat: new CSS tests
Re-write CSS tests with new parser.
* fix: grammar
Apply Shaun's grammar reviews.
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: optional chaining
* chore: apply suggestions from code review
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: apply reviews manually
* chore: getStyle update
Replace getStyleDeclaration with getStyle.
* fix: resolve test issue
* chore: remove jQuery :(
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: apply suggestions from code review
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* fix: recognize background-image as correct (#42738)
The page mentioned in #42738 before would not accept background-image and background, now it should.
* fix: CI build error
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
* fix(curriculum): use mediaText in CSSHelp
prevent selection of style elements with class or media attributes
this should avoid picking up some browser extensions
* fix(curriculum): look for possible www. link in regex
* Add suggestions from Nick
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix(curriculum) regex compatibility issue for Safari
* fix: escape the dot parameter in regex
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* Added missing period
On line 24, just before "Note that in your CSS..." a period was missing.
* Removed single quotes and added a missing period
On line 24, just before "Note that in your CSS..." there is a missing period.
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
* chore(learn): audit files for crowdin
Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: remove quotes from code
Removes instances of quoted code blocks, or code blocked quotes.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: additional uncaught quote-codes
Thanks Oliver :)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: so many quotes
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: missing punctuation
Noted in a Crowdin comment.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: remove more quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* feat(curriculum): add extension tests for css-flexbox curriculum modules
* apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: reorder tests
Moves the test that asserts the presence of the follow button to the
top of the order.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Nicholas Carrigan (he/him)
Tom
Shaun Hamilton
Lorem Ispum
Devesh Rane
Stephan Düsterhöft
Seth Falco
impirios
Sem Bauke
sjc5
EboranBokaj
GDAD3
Ritesh Arora
Glitchy-Tozier
Evgeny Klimenchenko
Jonathan
Hassaan Pasha
Randell Dawson
pandacoder7
Emer Conghaile
Ricardo Passos
Ilenia
Keith
Guilherme Dias Simões
Luis H. Ball Jr
Evan Boehs
Mukesh Gurpude