* fix: strip-comments-from-css
* fix: added challenge referenced in issue
* fix: added call to function removeCssComments
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Related to PR #38040
This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).
In this commit I fix the space-evenly issues to some extent.
I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.
There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* fix: broken Read-search-ask link now point to correct url
* fix: changed link to original forum link with more views
* fix: changed http links to correct version
* fix: link in help modal
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity
* fix: use getComputedStyle intead of regex
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* Improve viewport unit readability
Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
* Fixed a typo in Specify How Fonts Degrade.
'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.
Instead of "'-->!'.", it should be "'-->'."
* Made text wording consistent for the test instructions.
* Changed "To begin with," to "To begin," and fixed a minor typo.
If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.
Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
* fix: add test for input closing tag
* fix: add condintion to final syntax test
This wil test if there's any character after the input tag that isn't a white space
* fix/tests+remove-not-needed-text
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md