SomeDer
01c8554adc
03-render-conditionally-from-props: use const ( #36551 )
2019-08-12 18:17:39 +05:30
SomeDer
4ff5e6eff6
Add code tag to test in extract-state-logic-to-redux ( #36553 )
2019-08-12 10:50:13 +02:00
Randell Dawson
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
Randell Dawson
a53d992613
fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 01 ( #36408 )
...
* fix: removed assert msg argument
* fix: removed more assert msg args
* fix: removed assert msg missed
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: correct indentation
2019-07-25 08:53:37 +02:00
Randell Dawson
f2df76c099
fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 ( #36409 )
...
* fix: removed assert msg argument
* fix: removed more assert msg args
* fix: removed more assert msg args
2019-07-24 13:07:46 +01:00
Randell Dawson
d0d8282f86
fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections ( #36457 )
...
* fix: remove double quoted assert msg arg - responsive
* fix: remove double quoted assert msg arg - js
* fix: remove double quoted assert msg arg - libraries
* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Oliver Eyton-Williams
7d4dc382b4
fix(curriculum): format challenge markdown as per linting rules ( #36326 )
...
* fix: Format challenge markdown according to linting rules
* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
Randell Dawson
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
Tiago Salema
e561953827
Removed deprecated lifecycle methods ( #35895 )
...
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
Randell Dawson
933350c148
fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries ( #35994 )
...
* fix: converted blockquotes for react/redux
* fix: converted blockquotes for sass
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:01:32 -05:00
Kyle Scheuerlein
3b5fbe3edb
Improve formatting of Challenge Seed ( #35854 )
2019-05-08 18:32:01 -05:00
Tom
4f73b5a7f3
Fix/manage state locally tests ( #35980 )
...
* fix/manage-state-locally-test
* fix/update-test-words
* fix/update-test
2019-05-08 10:17:54 -04:00
Manish Giri
b579317e11
fix(curriculum): Add solutions to Bootstrap challenges ( #35789 )
...
* fix(curriculum): Add solutions to Bootstrap challenges
2019-05-02 11:24:38 +02:00
Randell Dawson
f51f262104
fix(curriculum): Increased starting font size to fix a bug on Chrome browser for Sass Apply a Style Until a Condition is Met with @while challenge ( #35935 )
...
* fix: increased starting font size for Chrome
* fix: slight verbiage change
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix/remove-extra-space
2019-05-01 09:08:38 -05:00
Oliver Eyton-Williams
e3529a8449
fix: Add solutions for Sass challenges ( #35777 )
2019-04-30 18:55:22 -05:00
The Coding Aviator
a2a278e937
fix: Moved instruction to proper place and removed assert text in Font Awesome challenges ( #35928 )
...
* fix: Moved instruction to proper place and removed assert text
* Add suggestion about making note strong
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
2019-04-29 15:51:03 +02:00
Manish Giri
1015f1ec6e
fix(curriculum): Add solution to jQuery challenges ( #35776 )
2019-04-28 12:28:47 -07:00
Tina Wang
bc986a4728
Moved font-awesome challenges to Font Awesome v5.8.1 ( #35813 )
...
* update font awesome challenge to font awesome 5
* v5 syntax changed
2019-04-28 15:00:27 +05:30
Benjamin Herrchen
20f71fd22e
correct usage of Math.random() to give equal 50/50 results ( #35840 )
...
* Update render-conditionally-from-props.english.md
* Update render-conditionally-from-props.english.md
2019-04-13 18:06:01 -04:00
lasjorg
394ae3d1ce
fix(challenge): check for li and specify elements accepting text ( #35193 )
...
* fix(challenge): check for li and specify elements accepting text
* fix(challenge): revert text
* fix(challenge): remove word added by mistake
* fix(challenge): update test, cleanup assertion text
2019-04-10 20:52:37 +05:30
chaomt
216e10e2b7
fix: A testing bug in FCC's React Simple Counter Challenge ( #35715 )
2019-04-03 22:24:05 -05:00
Dana Ottaviani
c08f3785cb
Add solutions to Bootstrap challenges ( #35710 )
...
* feat: add solution for font-awesome icon challenge
* feat: add solution to add all button icons challenge
* feat: add solution to add ids to bootstrap elements challenge
2019-03-30 23:20:01 -07:00
Jonathan Lawrence
f743c675c7
Grammar fix ( #35711 )
...
I was going through the Bootstrap lessons and found this. Very small change, I know, but I believe it's important.
2019-03-31 11:30:37 +05:30
Dana Ottaviani
73b4f8c41d
fix: add solution to Bootstrap challenge ( #35650 )
2019-03-24 10:28:07 -07:00
Randell Dawson
4d1d89b1c7
fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge ( #35320 )
...
* fix: only allow valid jsx comments in div elem
* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams
e7bc4bd014
fix: Allow trailing commas to be used in challenge ( #35585 )
...
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
2019-03-18 09:56:46 -07:00
Roberto Beltran
fb8dcd4dbc
Make link text more descriptive ( #35218 )
...
* Make link text more descriptive
Make link text more descriptive for improved accessibility.
* Add mention of MDN to link description
As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Adjust link wording
Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
2019-03-17 16:47:30 -04:00
kevindelsh
64faca718b
Changed the definition of stateful components ( #34837 )
...
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
2019-03-16 19:25:46 +01:00
Randell Dawson
92208f7c23
[Fix] Modified regex to allow spaces in one of the tests for challenge Apply a Style Until a Condition is Met with @while ( #35100 )
...
* fix: modified regex to allow spaces
* fix: added additional \s* after 1
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-03-06 03:05:52 -05:00
kevindelsh
259eec5ab5
Sass import doesn't need file extension ( #34802 )
...
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
2019-03-04 09:35:07 -06:00
Theodoros Gkortsilas
cd501ee4c5
change wording: React component -> class component ( #34692 )
...
Hi,
I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".
Theo
2019-03-04 01:47:28 -05:00
Shashank Bairy R
a0b79252d3
fix:removed bug in front end lib random quote project ( #35477 )
2019-03-01 11:09:00 -06:00
Ahmed Elbessfy
61a5707ba7
Edit Description ( #34329 )
...
* Edit Description
Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.
* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md
Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
TristanSeabrook
ce2b46926f
removed ungrammatical apostrophe ( #35355 )
...
changed "it's" to "its"
2019-02-22 03:14:30 -08:00
Niraj Nandish
cb35d49a21
fix(challenges): Fix broken links in English challenges ( #35125 )
2019-02-21 17:58:31 -05:00
Theodoros Gkortsilas
a17b123510
Added curly brackets to comment in JSX element ( #34694 )
...
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
Aditya
46be1e2ed1
fix: React: Give Sibling Elements a Unique Key Attribute ( #34648 )
...
* feat: added additional test
Added additional test, formatted description and updated instructions and solution
* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
Randell Dawson
aa621a20b5
fix: removed unecessary guideUrl from frontmatter
2019-02-19 11:34:27 +03:00
kevindelsh
93c8badfeb
Minor rephrasing of the lesson's description ( #34787 )
...
* Minor rephrasing of the lesson's description
Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.
* Corrections to conform to style guide
1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.
* Moved challenge instruction to Instructions section
2019-02-18 00:43:47 +05:30
Luane
2f9d7a7492
Added solution to challenge ( #34838 )
...
Solution for challenge "Bootstrap: Use the Bootstrap Grid to Put Elements Side By Side".
2019-02-15 09:39:36 -08:00
Steven Torrence
06b3b078a6
Fixed comment closing tag to match comment opening tag spacing and be symmetrical ( #35136 )
2019-02-10 14:29:12 -08:00
Aditi Joshi
8b47ed264b
Fix/update challenges for sass ( #35031 )
...
* style: button color change
* Revert "style: button color change"
This reverts commit 64574a49b7
.
* fix: update sass challenge - description
* fix: challenge for sass
2019-02-08 13:11:05 -07:00
coderlyn
4fe2558f99
Edit text string to have the correct case ( #34366 )
...
Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test
2019-02-05 18:51:13 -08:00
Valeriy
63d0a2682f
fix: remove unused vars from the test execution scope
2019-01-14 13:44:54 +00:00
Valeriy S
0e621175ad
fix(curriculum): remove SASS from requirements
2018-12-07 12:43:13 +00:00
Tomer Ben-Rachel
cd783c32da
Adding link to React documentation ( #32635 )
...
* Adding link to React documentation
* Modified link to fit github markdown
* Update use-proptypes-to-define-the-props-you-expect.english.md
2018-11-16 11:55:56 -05:00
zcarroll4
4cec01a21c
Bootstrap Page with H3 Element ( #32139 )
...
fix(curriculum): added solution for Bootstrap Page with H3 Element
2018-11-06 16:09:14 +03:00
zcarroll4
85c9fe0a48
Added Bootstrap Styled Button ( #32140 )
...
fix(curriculum): added Bootstrap Styled Button solution
2018-11-06 15:24:48 +03:00
mail-liam
7f4b440f64
Fix typo in test. Colors -> classes ( #21108 )
2018-11-05 16:23:01 -05:00
The Coding Aviator
ebf96cb0b2
Added info about deprecated React method in curriculum ( #19930 )
...
* Update use-the-lifecycle-method-componentwillmount.english.md
* Added correction to deprecation timeline and updated link
2018-10-27 19:49:49 -07:00
Valeriy
591309550b
test(curriculum): check tests against solutions ( #27716 )
2018-10-24 16:45:00 +05:30
Valeriy
e099d6486d
fix: test curriculum challenges ( #24180 )
2018-10-23 18:51:53 +05:30
Paul Gamble
c8aed97e48
Added solution to this challenge. ( #25470 )
2018-10-23 17:46:30 +05:30
Valeriy
79d9012432
fix(curriculum): quotes in tests ( #18828 )
...
* fix(curriculum): tests quotes
* fix(curriculum): fill seed-teardown
* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Paul Gamble
030e673e6a
Update use-for-to-create-a-sass-loop.english.md ( #23815 )
...
I did not understand the original lesson of "through" vs "to" upon first reading.
Later reading the code below it started to make sense... but I added a bit more to the explanation.
2018-10-20 15:08:39 +05:30
Bouncey
ee9f6b2d72
chore(meta): Move challenge meta to challenges root
2018-10-11 02:15:05 +05:30
Derek Kim
6fb3b0503e
Fix for #18214
2018-10-09 10:54:53 +01:00
Beau Carnes
46d8d61776
docs: update guide url
2018-10-08 11:02:25 -04:00
petergrainger
e0e8ab8409
fix: clarify test text in line with test functionality
2018-10-08 11:38:29 +01:00
Bouncey
a859035023
fix(challenge-md): Fix quotes that failed in the transform
2018-10-08 11:38:26 +05:30
Bouncey
8f39bc1288
chore(curriculum): Remove files in wrong format
2018-10-05 15:58:12 +01:00