Chipiwiny94
c49aee9edc
Minor gramatical changes ( #36947 )
...
I added some pronoums and articles that were missing on the traslation of the lesson.
2019-12-20 22:52:49 +05:30
LeoGuilherme
f3dcbb485b
Translation fix on several lines ( #36909 )
...
Changes made for the page in portuguese to be more like the original in English
2019-12-20 22:52:09 +05:30
LeoGuilherme
743c30edcf
Translation fix on line 10 ( #36907 )
...
Changed some words for better translation in portuguese.
2019-12-20 22:51:00 +05:30
LeoGuilherme
4e509dca58
Translation fix in /make-typography-responsive.portuguese.md ( #36902 )
...
* Translation fix
Changed the term "portas de visualização" back to "viewport", because it is a technical term, and when translated it loses its meaning
* Changes in the blockquote tag
The code inside the blockquote tag was translated to portuguese, but code shouldn't be translated because then it doesn't work, so I changed it to the same code of the English version of the challenge.
Also, I changed "A Camper Cat" to "O Camper Cat" in the line 13 because on other pages Camper Cat is referred as male, so it makes more sense to use the article "O" in portuguese.
2019-12-20 22:50:37 +05:30
Irina Serdiuk
e095df348b
russian translation fix on curriculum challenge: description a… ( #37079 )
...
* russian translation
* Update create-a-block-element-bootstrap-button.russian.md
2019-12-20 20:54:36 +05:30
Irina Serdiuk
e1a4c8f1ae
russian translation fix on curriculum challenge: description a… ( #37077 )
2019-12-20 20:54:22 +05:30
Veronika Krukovich
df155231e4
fix challenges translation into russian ( #36889 )
2019-12-20 20:54:02 +05:30
Veronika Krukovich
df0df97949
fix challenges translation into russian ( #36888 )
2019-12-20 20:53:15 +05:30
Veronika Krukovich
872b7e1dbb
fix challenges translation into russian ( #36887 )
2019-12-20 20:53:01 +05:30
Veronika Krukovich
525cdcd475
fix challenges translation into russian ( #36886 )
...
* fix challenges translation into russian
* Fix spelling center in russian
2019-12-20 20:52:47 +05:30
RichardLimSpring
6ee9f23514
fix(i18n): Minor Chinese Translation Fix & Add Solution ( #36868 )
...
- Replace a few terms with more proper terms
- Rephrase 2nd paragraph for clearer meaning
- Add Solution
2019-12-20 20:52:00 +05:30
RichardLimSpring
f68e7bd5cd
fix(i18n): chinese - minor language fixes and add solution ( #36867 )
...
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
2019-12-20 20:50:46 +05:30
Oliver Eyton-Williams
01b37f664f
fix: stop user code after 100ms of execution ( #37841 )
...
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2019-12-20 19:28:17 +05:30
Randell Dawson
5609a1303e
fix: corrected tests for 3 challenges ( #37948 )
2019-12-19 11:26:50 +01:00
lasjorg
8cca639450
fix(challenge): check inline styles on elements, add solution ( #37756 )
2019-12-16 16:18:29 +01:00
Sean Coleman
203c9823e8
Fixed minor grammar issue in escape-sequences-in-strings.english.md ( #37940 )
...
* Update escape-sequences-in-strings.english.md
Fixed minor grammar issue in list item 1 of the description section.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
Arthur
616d96f612
refactor: update trivial regex capture group find and replace challenge ( #37768 )
...
* refactor: replace trivial regex capture group challenge
Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.
resolves #17645
* test: validate at least 3 capture groups were used
Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex )
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* refactor: more meaningful variable name
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* test: add parenthesized substring test
* test: ensure 3 uses of substring replacement
* refactor: reword instructions
* fix: minor grammar fix
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* refactor: elaborate wording in test
2019-12-14 16:41:47 -05:00
John A Maloney
c935d21f84
Fixed bad capture group in regex ( #37575 )
2019-12-13 22:16:30 -06:00
Randell Dawson
85e7fe45d5
fix(curriculum): use object.assign to prevent overwriting prototypes if user uses class instead of function ( #37648 )
...
* fix: use object.assign to prevent overwriting when using class
* fix: remove non-used isBinarySearchTree method
2019-12-13 15:04:05 -06:00
lasjorg
63b9be8faf
fix(challenge): account for browser zoom, add note to challenge (for width challenge) ( #37688 )
...
* fix(challenge): account for browser zoom, add note to challenge
* fix(challenge): use regex for width assert
* fix(challenge): remove note
* fix(challenge): revert to initial PR code
* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
classicmatsuo
33cec6b6f2
fix: updated instructions for install-and-set-up-mongoose ( #37908 )
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Kevin Matsuo <kmatsuo@ARDs-MacBook-Pro-2.local>
2019-12-13 16:23:11 +05:30
Randell Dawson
44ff327a38
fix(curriculum): make test more flexible for ( #37902 )
...
* make test more robust
* fix: changed test to ignore extra spaces in html
* Revert "make test more robust"
This reverts commit 89718eb5e5
.
2019-12-11 23:20:19 -05:00
Randell Dawson
cb3524ee31
fix: simplify challenge testString ( #37826 )
2019-12-07 15:47:08 -05:00
Randell Dawson
623c08cbfa
fix: removed semi-colon from regex ( #37881 )
2019-12-07 15:02:42 -05:00
Christoph Deil
dc5c0c7f82
Fix minor grammar issue in override-styles-in-subsequent-css.english.md ( #37871 )
2019-12-04 14:32:55 -08:00
Waldo Luis Ribeiro
8af54eb272
fix(curriculum): Technical language correction ( #37812 )
...
Technically, the prototype is not cloned; it is merely referenced.
2019-12-04 21:01:49 +00:00
Eze Rodriguez
68d0a15dbd
Update jump-straight-to-the-content-using-the-main-element.spanish.md ( #37253 )
...
Fixed to communicate the intended instructions correctly in Spanish.
2019-12-03 00:46:03 -08:00
nico-alvarez-eu
71b5918b01
Minor Spanish grammar fixes ( #36862 )
2019-12-03 00:37:38 -08:00
Chipiwiny94
bda0259c36
Made grammatical changes ( #36948 )
...
Grammar changes have been made to make proper use of "tu", as it was mixed with the formal person "Usted"
2019-12-03 00:34:10 -08:00
Luis Ignacio Collantes
975e59cd03
Fix grammar errors ( #37119 )
2019-12-03 00:32:22 -08:00
Randell Dawson
984a530905
fix(curriculum): added extra mongoose options to prevent log warnings ( #37693 )
...
* fix: added extra mongoose options to prevent log warnings
2019-12-03 13:12:27 +09:00
Randell Dawson
dd2fb28ee0
fix: make tests more robust ( #37830 )
2019-12-02 18:42:32 -05:00
Randell Dawson
a68e3ef39d
fix: change rating to ratings ( #37863 )
2019-12-02 17:25:11 -05:00
Randell Dawson
7454719334
fix(curriculum): Improved Use Recursion to Create a Countdown challenge ( #37548 )
...
* fix: improved recursive challenge
* fix: rewording of two challenges
* fix: add code tags
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-12-02 17:58:07 +01:00
Randell Dawson
a6766127cc
fix(curriculum): corrected test and added solution for Create a Hash table challenge ( #37582 )
...
* fix: corrected test and added solution
* fix: redefine hash
* fix: use defined hash
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-02 17:23:56 +01:00
Randell Dawson
d39dd970b6
fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge ( #37838 )
...
* fix: use regex to avoid diff in browsers
* fix: improve regex
2019-12-02 20:50:34 +05:30
Tom
9866d2f241
fix: grid column and grid row tests ( #37736 )
...
* fix: grid column and grid row tests
* fix: test text verbiage
* fix: add solution to pass build error
* fix: make test more readable
2019-12-01 10:02:24 +05:30
Randell Dawson
aac1c58374
fix(curriculum): make last test more robust for Uncomment HTML challenge ( #37843 )
...
* fix: correct last test
* fix: remove forgotten console.log
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-30 23:09:48 -05:00
Randell Dawson
58ca8ddf2a
fix: correct function name in test text ( #37839 )
2019-11-30 18:30:10 -05:00
Tom
da99033b77
fix: sum all primes description ( #37750 )
...
* fix: sum all primes description
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-30 16:33:37 -06:00
Wocanilo
cabfd25b40
MODIFIED convert-json-data-to-html to warn about XSS attacks (english) ( #37036 )
...
* MODIFIED convert-json-data-to-html to warn about XSS attacks (english)
* Forgotten newline in convert-json-data-to-html
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: suggested changes
* fix: added commas
2019-11-30 12:52:59 -06:00
Tim dinia
c331b12413
fix(curriculum): correct typo in nest one array within another array challenge instruction ( #37851 )
2019-11-29 10:07:51 +01:00
gloriaabreualves
dee5216eb3
fix text in portuguese ( #37509 )
...
Fix text in portuguese.
2019-11-28 17:13:18 -08:00
Randell Dawson
08bbd893d3
fix: switched order of first two bst challenges ( #37675 )
2019-11-27 12:12:58 +01:00
Randell Dawson
2c15bcbb43
fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures ( #37761 )
...
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
Randell Dawson
b7949087e3
fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges ( #37709 )
...
* fix: improve verbiage and add examples to challenges
* fix: condensed map method wording
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: remove leading space
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: improved verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened reduce challenge verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shorten verbiage related to reduce 2nd parameter
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened filter verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix; added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: improved verbiage of map method
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened reduce verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: correct map method verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added word array
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added missing comma
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: changed u to sumOfAges
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: created one sentence out of many
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* fix: changed to on each iteration
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: fixed verbiage in filter and map challenges
2019-11-27 07:33:09 +05:30
Stryyder
58444af093
very minor grammar fix ( #37840 )
2019-11-26 15:53:18 -08:00
Randell Dawson
ba415184f6
fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce ( #37829 )
...
* fix: simplify challenge without using reduce
* fix: prevent user from adding new elements to sum to 10
* fix: add from
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-26 15:14:44 -05:00
lasjorg
ba927090fe
fix(challenge): account for browser zoom, add note to challenge (for height challenge) ( #37687 )
...
* fix(challenge): account for browser zoom, add note to challenge
* fix(challenge): use regex for height assert
* fix(challenge): remove note
* fix(challenge): revert to initial PR code
2019-11-25 19:40:21 -08:00
Randell Dawson
98bb2c1085
fix: added new test case to prevent invalid regex ( #37769 )
2019-11-25 20:25:24 -05:00