Commit Graph

770 Commits (d331ad1fcd8988eb416bb9bf830b356cbca69a39)

Author SHA1 Message Date
Jean Jordaan 33edc072b9 Use the correct element name in <code> blocks, gloss it seperately (#35616)
* Update link-to-external-pages-with-anchor-elements.english.md

If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.

* Change md to html

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.

* Revert "Don't mark up 'anchor' as code"

This reverts commit 50c6a3a7c9.

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.
2019-03-25 10:50:33 -05:00
Christine Gierer 6d9ce1c85c Update description of tests pig-latin.english.md where too vague (#35499)
* Update description of tests pig-latin.english.md

The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md

Co-Authored-By: beansprout <christinegierer@gmail.com>
2019-03-25 08:02:18 -07:00
Zebulan Stanphill 6a9f459a42 Fix missing "currentNode" variable declaration in data structures linked list challenges (English) (#35638)
* Fix missing variable declaration in data structures challenges (English)

* Fix duplicate currentNode var declaration.
2019-03-25 15:53:38 +01:00
Aditya 9cca21f57f [Fix] Removed unnecessary IIFEs from ES6 challenges (#34538)
* feat: removed IIFE and added solution

* feat: updated challenges seed, test and solution

* style: removed semicolon

* feat: updated seed and solution

* feat: updated challenges seed and solution

* feat: updated test, seed and solution

* fix: added seed code to solution

* fix: removed function and added solution

* fix: removed makeClass function and fixed solution

* style: removed excessive semicolons

* Fixed spacing for note in instructions section

* fix: removed assert messages and used const

* fix: regex fails correctly now
2019-03-25 09:19:34 -05:00
lasjorg 98e68d04be feat(curriculum): Add challenge on using the value attribute (#35301)
* feat(curriculum): Add challenge on using the value attribute

fix(challenge): update file name and add comma

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Apply suggestions from code review

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
Dana Ottaviani 73b4f8c41d fix: add solution to Bootstrap challenge (#35650) 2019-03-24 10:28:07 -07:00
Vikas KM 9e36ff87bb changes to no validate comment (#34810)
* changes to no validate comment 

Added single line comment check for regex to not validate.

* fix: corrected regex

* fix: changed + to *
2019-03-23 15:27:42 -04:00
rupali317 bc72c86dc6 fix: updated the note sections for responsive web design english (#35528) 2019-03-22 15:02:12 +01:00
Carol W 6d43682397 fix: update tests for difference on two sets (#34664)
* fix: update tests for difference on two sets

* fix: update tests for difference on two sets - fix quotes

* fix: reverted testString and reworded text
2019-03-22 11:40:06 +01:00
JaceFrio 86ec0cf8dd Forgotten Updates of English Parts to Portuguese (#21215)
Some of the bold words hadn’t been translated from “User Story” to “História do Usuário”, capitalized the word "Usuário" for consistency.
2019-03-21 21:01:30 -03:00
Chuck Adams a09bb2ea1d log set as Array.from(set) (#35646) 2019-03-21 21:15:45 +05:30
Hugo 739f4a8850 fix: Update test for ES6 challenge (#34300)
* fix: es6 challenge test

* delete console.log
2019-03-21 10:50:30 +01:00
Kristofer Koishigawa 3e51ced41b fix(challenges): Remove duplicate Rosetta Code sorting problems (#35547)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed: 
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort

This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.

Closes #34776
2019-03-21 13:05:02 +05:30
Bhanu Pratap Singh Rathore 79394d141f feat(interview-prep): Converting and transferring Rosetta problems (#35487)
* feat(interview-prep): Converting and transferring Rosetta problems

* feat(interview-prep): Fixing challenges

* fix(challenges): Added code tags

* Update knight's-tour.md

Moved text to instructions section and fixed a small typo.

* feat(interview-prep): Update description of Knight's tour

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(interview-prep): Update description of Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(inteview-prep): Kaprekar numbers description

Added <code> tags.

* fix(interview-prep): Update description Kaprekar Numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* fix(interview-prep): Added code tags Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>
2019-03-21 11:52:35 +05:30
Timur cab064a183 Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions (#34345)
* Fix tests

- fix original log() method restoration

- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md

allow function calling without semicolon

Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
2019-03-21 11:50:23 +05:30
Chuck Adams 4b2219b01d close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions (#35537) 2019-03-20 22:02:21 +01:00
lolabarri 781a166878 Translated sections' titles (#35597)
The titles of the sections were still in English. Also, I have deleted one "s" from a ver form
2019-03-20 17:46:58 +01:00
Zebulan Stanphill 1a7afb287a Fix missing variable declaration in data structures challenges (Spanish) (#35641) 2019-03-20 17:44:33 +01:00
grets311 2219a9a8dd Update positive-and-negative-lookahead.english.md (#34582)
Update solution from w{5} to w{6} as exercise is to match at greater than 5 characters long.
2019-03-20 15:58:09 +01:00
Shashank Bairy R f313c094cb fix: clarify how to create multiple box shadows (Issue: #35534) (#35555)
* fix: clarify how to create multiple box shadows

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md

<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.

Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
2019-03-20 15:32:53 +01:00
Edwin van Meerendonk 5f894a3231 A solution was missing (#35552)
My solution
2019-03-20 15:17:00 +01:00
Jade Michael Thornton d5861edc84 add more specific tests for username regex challenge (#34655)
* add more specific tests for username regex challenge

* fix: removed unnecessary test
2019-03-19 15:21:30 -07:00
lasjorg 88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
Yuran Pereira 39b597f1c2 Corrected grammatical mistake (#35631)
From: "The version numbers themselves not should be changed"
To: "The version numbers themselves should not be changed"
2019-03-19 11:24:48 -04:00
NITIN BISHT 228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Randell Dawson 4d1d89b1c7 fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge (#35320)
* fix: only allow valid jsx comments in div elem

* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams e7bc4bd014 fix: Allow trailing commas to be used in challenge (#35585)
* fix: Allow trailing commas to be used in challenge

* fix: use regex to simplify challenge tests

* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
2019-03-18 09:56:46 -07:00
The Coding Aviator 17715a795e fix(formatting): Zhang-Suen | Rosetta Code (#35472)
* fix(formatting): Move challenge instructions to instruction section

* Fix table and list

* fix(curriculum): Zhangsuen

* fix(curriculum): add bold tags

* Fix typo in instructions
2019-03-18 17:19:02 +09:00
Matheus Genteluci 117e198b1e Return largest numbers in array - Portuguese (#34515)
* Return largest numbers in array - Portuguese

added solution

* Add invocation to the solution
2019-03-18 08:30:41 +01:00
Randell Dawson 9051ad2eb5 Fixed bug allowing versions of Object.keys method and hard coding of ownProps array (#35021)
* fix: disallow variants of Object.keys method

* fix: added new test to help prevent hardcoding array

* fix: refactored regex
2019-03-17 18:47:41 -04:00
Roberto Beltran fb8dcd4dbc Make link text more descriptive (#35218)
* Make link text more descriptive

Make link text more descriptive for improved accessibility.

* Add mention of MDN to link description

As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Adjust link wording

Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
2019-03-17 16:47:30 -04:00
Matheus Genteluci 222948d5ac Reverse a String - Portuguese (#34513)
* Reverse a String - Portuguese

* Add invocation

Co-Authored-By: MGenteluci <mgenteluci97@gmail.com>
2019-03-16 21:30:58 +01:00
Pavel 452fd54e3c Added russian translate to clone-an-element-using-jquery (#33296) 2019-03-16 21:18:28 +01:00
lucielchoi707 0afb7cd800 add solution (#28407) 2019-03-16 21:10:33 +01:00
lucielchoi707 a2ee27a17f add solution (#28341) 2019-03-16 21:08:51 +01:00
Assil 0cf2863b5c Update set-the-font-family-of-an-element.arabic.md (#30526) 2019-03-16 21:04:37 +01:00
lucielchoi707 996883be6c add solution (#28386) 2019-03-16 20:57:39 +01:00
Matheus Genteluci 7a0864d716 Repeat a String Repeat a String - Portuguese (#34581)
Solution added to .md
2019-03-16 20:48:46 +01:00
Bruno Nash 55e7b07eb2 Fixes the CSS blockquote auto-translation (#28991) 2019-03-16 20:41:47 +01:00
Bruno Nash bf0b86557f Fixes the CSS blockquote auto-translation (#28988) 2019-03-16 20:41:28 +01:00
Bruno Nash 347d52519d Fixes the CSS blockquote auto-translation (#28986) 2019-03-16 20:40:57 +01:00
Bruno Nash c3d0bef539 Fixes CSS auto-translation (#28983) 2019-03-16 20:40:31 +01:00
Bruno Nash 5842c09452 Fixes CSS auto-translation (#28982) 2019-03-16 20:39:39 +01:00
Bruno Nash efc8a760f0 Fixes CSS auto-translation (#28974) 2019-03-16 20:39:04 +01:00
Bruno Nash 4669a34554 Fixes CSS auto-translation (#28966) 2019-03-16 20:38:26 +01:00
Bruno Nash fce845e5de Fixes auto-translation of 'width' (#28961) 2019-03-16 20:37:58 +01:00
Bruno Nash 6eb00e6b4e Fixes auto-translation of 'color: red' (#28959) 2019-03-16 20:37:35 +01:00
Bruno Nash 05a77e6e97 Fixes auto-translation of 'height' (#28956) 2019-03-16 20:37:14 +01:00
Bruno Nash d238e6e1cb Fixes auto-translation for 'auto' (#28955)
Also, fixes the spelling of 'container'
2019-03-16 20:36:48 +01:00
Bruno Nash 198b38f2fc Fixes 'grid-area: cabeçalho' (#28952)
Fixes 'grid-area: cabeçalho' => 'grid-area: header'
Also fixes the spelling of 'container'
2019-03-16 20:36:20 +01:00