Commit Graph

252 Commits (e202b917d62137e7b1b35ef0136e520b35ff6d99)

Author SHA1 Message Date
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694)
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648)
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Dana Ottaviani 9562bf0baa Solution to implementing an accessible date picker (#35262)
* feat: add challenge solution

* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Aditi Joshi 2e388035ca Fix/update challenges for basic html and html5 (#35234)
* fix: challenge for basic html and html5 - test

* Delete use-if-and-else-to-add-logic-to-your-styles.english.md

* fix: Resolving merge conflict

* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
Riyaad Azad 2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
The Coding Aviator 54264157ee Added more clarification on how to use z-index (#34934)
* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md
2019-02-18 00:46:14 +05:30
kevindelsh 93c8badfeb Minor rephrasing of the lesson's description (#34787)
* Minor rephrasing of the lesson's description

Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.

* Corrections to conform to style guide

1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.

* Moved challenge instruction to Instructions section
2019-02-18 00:43:47 +05:30
Bannon Tanner 4734ff4154 nest anchor within paragraph instructions modification (#26441)
* modified wording to be more clear

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear

* fix: removed change not needed
2019-02-17 23:54:13 +05:30
Aashis kumar 80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Nelson Wu 6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
Gökhan Gurbetoğlu 16eb18954e Small change: remove unintentional whitespace (#34418)
On other challenges, only the affected places would have a placeholder whitespace, if there is one. Removed the unnecessary ones from this challenge.
2019-02-17 04:52:52 -05:00
Melkisedek Hamakali a0c00de32b Use correct spelling of navigable (#34817) 2019-02-17 01:52:19 -08:00
Almaz Kunpeissov 79af29dd2b Adding code styling to property value. (#34463)
Adding <code> styling for property value infinite in the ## Instructions.
2019-02-16 22:02:33 -08:00
Kirill Malev bca4d896cc Added solution to reuse-patterns-using-capture-groups.english.md (#35144)
* Update reuse-patterns-using-capture-groups.english.md

* included whole solution
2019-02-16 19:10:03 -08:00
Oliver Eyton-Williams ba9e45023d fix: make border radius challenge Firefox compatible (#35009)
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
2019-02-16 17:17:11 +00:00
Leo db63a354ee Deleted comma and removed first person (#35034) 2019-02-16 08:50:46 -08:00
The Coding Aviator 99ac0b6938 Update use-grid-area-without-creating-an-areas-template.english.md (#34852) 2019-02-16 20:52:20 +05:30
Christopher Szczechowicz 994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
Eunice Brackett 21f5427c14 Media query solution for Responsive Web Design (#33991)
* Media query solution for Responsive Web Design

This is in response to the required solution for the challenge solution section.

* fix: solution
2019-02-16 19:13:54 +05:30
Randell Dawson 9c3145ea49 fix: improved the grammar and readability (#35133) 2019-02-16 18:02:35 +05:30
Dana Ottaviani bad8846e04 feat: add solution to accessibility challenge (#35131) 2019-02-16 18:00:42 +05:30
Dovid Majowka 16ef2639c0 Updated wrong guideUrl to correct one (#35066)
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md

* Use standard link for guide URLs

* fix: corrected guideUrl

* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
Zach 2fea8d89f4 Update add-columns-with-grid-template-columns.english.md (#33544)
Fixed wording order for 'each' when asking to set column width.
2019-02-15 17:40:32 -08:00
Josh 4fc2bdd2a1 Update use-the-tilde-character-to-always-use-the-latest-patch-version-of-a-dependency.en.md (#34871)
Grammatical change.
2019-02-15 15:15:37 -08:00
Anas Salam ec9fffb222 solution to Challenge ID:bad87fee1348bd9aedd08835 (#33391)
* solution to Challenge ID:bad87fee1348bd9aedd08835

solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default

* fix: solution
2019-02-15 11:19:03 -08:00
Greg Brewton 7687f26c56 Information correction (#28582)
Eliminated the line  (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
2019-02-15 14:13:32 -05:00
gokulsg 63c5a94321 Expected solution for the challenge seed code (#32532)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
2019-02-15 12:48:30 -05:00
Luane 2f9d7a7492 Added solution to challenge (#34838)
Solution for challenge "Bootstrap: Use the Bootstrap Grid to Put Elements Side By Side".
2019-02-15 09:39:36 -08:00
Yoelvis Jiménez 0655abf800 Typo: I replaced nesesary by necessary (#34884)
* Typo: I replaced nesesary by necesary

Minor typo. I replaced nesesary by necesary.

* Fix nesesary to necessary
2019-02-15 00:40:17 -08:00
Howard T. Chiam c08ba2f654 Empty line not needed. (#34812) 2019-02-15 00:32:40 -08:00
edu san 0a330e65f9 Correct a typo in pairwise.english.md (#34375)
The word "indice" does not exist in English. The singular form of "indices" is "index".
2019-02-14 18:00:22 -08:00
JustinBen-Tzioni ba0d4fb15f Improved grammar and message (#28795)
* Improved grammar and message

* Update import-a-google-font.english.md
2019-02-14 13:38:58 -08:00
BurnhamG a825708e3e Correct seed code errors (#32355)
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
2019-02-14 13:24:38 -08:00
lmilliken 6989c4bc99 updated quotes (#34356) 2019-02-14 13:09:09 -08:00
JustinBen-Tzioni 7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
gokulsg 2b91676e72 Expected solution for the challenge seed code (#32523)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution section syntax
2019-02-14 14:35:21 -05:00
SGokul1 08b9c3c7fb I have updated the solution for this file. (#31749)
* I have updated the solution for this file.

I have added the expected output of the  challenge seed code.

* Update add-a-submit-button-to-a-form.english.md

Placed solution in ```html tags

* Update add-a-submit-button-to-a-form.english.md
2019-02-14 11:28:40 -08:00
Beau Carnes 133d6e5231 fix: update .en.md to .english.md (#35149) 2019-02-14 23:09:19 +05:30
Beau Carnes 409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Valeriy 99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
Kirill Malev 661d10412f Added solution to remove-whitespace-from-start-and-end.english.md (#35145)
* Update remove-whitespace-from-start-and-end.english.md

* includes whole solution now
2019-02-12 09:34:52 -08:00
gokulsg 60c93a8300 Expected solution for the challenge seed code (#32522)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution syntax
2019-02-12 08:19:56 -08:00
Lipis 86b8cee810 Replace Github with GitHub (#34971) 2019-02-12 00:46:34 -08:00
gokulsg a589042f88 Expected solution for the challenge seed code (#32537)
I have updated the expected output for the challenge seed code.
2019-02-11 23:45:55 -08:00
Niraj Nandish e7424de4ef fix(challenge): typo error (#30359) 2019-02-11 22:05:09 -08:00
Bannon Tanner b24f606847 added example to make description clear (#26492)
Added example in the description for understanding that the width of the element is still set using the width property in CSS.
fixes issue #17617
2019-02-11 18:28:07 -08:00