Commit Graph

252 Commits (e202b917d62137e7b1b35ef0136e520b35ff6d99)

Author SHA1 Message Date
Aashis kumar b2e514d39f A better solution to finders-keepers.english.md (#34759)
* Update finders-keepers.english.md

A better approach to finder's keepers problem

* A better appoach to solve finders-keepers (JS)

Fixed travis bug

* fix: indented solution code
2019-02-10 20:13:48 -08:00
Steven Torrence 06b3b078a6 Fixed comment closing tag to match comment opening tag spacing and be symmetrical (#35136) 2019-02-10 14:29:12 -08:00
The Coding Aviator 9c881dcc6e Fixed issue with accessibility challenge about contrast (#19711)
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
Cryotechnic 80e80a4c8b Word Correction (#29689)
* Word Correction

Some words were missing, making the sentence sound grammatically incorrect.

* fix: removed the word its
2019-02-10 07:51:00 -08:00
Naveen f6f58d3228 Remove unwanted comma (#26050) 2019-02-10 07:33:56 -08:00
lasjorg 9341aadb5b Fix/remove property references and update tests (#35109)
* fix(challenges): Update challenge text and assertion test

* fix(challenges): update assert test regex

* fix(challenges): update regex, fix inline comment in code example

* fix: corrected regex
2019-02-09 00:47:53 -05:00
Julien Galibois Sauvageau e8b7b2eb6f Fixed typo (#34848)
Original wording: getHachedEggCount
New wording: getHatchedEggCount
2019-02-08 13:59:04 -08:00
Aditi Joshi 8b47ed264b Fix/update challenges for sass (#35031)
* style: button color change

* Revert "style: button color change"

This reverts commit 64574a49b7.

* fix: update sass challenge - description

* fix: challenge for sass
2019-02-08 13:11:05 -07:00
Mahesh Jaganiya d11bb33f56 Fixed Typo (#35098) 2019-02-07 22:52:14 -08:00
Kristofer Koishigawa 84e28bd0f0 fix(challenges): update required links for d3 challenges (#34477) 2019-02-08 09:37:46 +03:00
The Coding Aviator 536fe28162 Update get-json-with-the-javascript-xmlhttprequest-method.english.md (#34408) 2019-02-06 07:51:59 -06:00
Aditya 85eca8ef36 [fix]: Object Oriented Programming: Inherit Behaviors from a Supertype (#35063)
* fix: revert semicolon check

* fix: test name
2019-02-06 08:23:47 +03:00
coderlyn 4fe2558f99 Edit text string to have the correct case (#34366)
Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test
2019-02-05 18:51:13 -08:00
gokulsg cc659a9a2d Expected solution for the challenge seed code (#32530)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update create-a-text-field.english.md

* fix: change language tag and remove wrong comment
2019-02-05 18:33:30 -08:00
SGokul1 098c622fc6 Sample solution for the file (#31770)
* Sample solution for the file

I have updated the sample solution for the challenge seed code.

* Update add-images-to-your-website.english.md

formatted ```html tags
2019-02-05 18:31:31 -08:00
Dom Coleman 9a4e13954a Tests for OOP: Inherit Behaviors from a Supertype (#34938)
* Tests for OOP: Inherit Behaviors from a Supertype

Fixes issue #34905

* fix: make test inclusive
2019-02-05 20:44:53 +03:00
Luane f2c3d635ef Added solution to challenge "Regular Expressions: Match Characters th… (#34668)
* Added solution to challenge "Regular Expressions: Match Characters that Occur Zero or More Times"

* fix: removed necessary brackets
2019-02-05 08:03:19 -08:00
Chelsea Marie Hicks 8d7bd3906c Grammar change and readability of example (#30507) 2019-02-05 21:14:05 +05:30
John Sprunger 7ae6577cda Change for second test case (#34785)
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".

Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
2019-02-05 21:07:17 +05:30
Ali Ahmed 9999a8c9bc Modify test for dequeue method to check for FIFO (#34981)
* Update create-a-queue-class.english.md

* Modify test for dequeue method to check for FIFO

The test first `enqueue`'s two elements and checks for the `dequeue` method to return the element at `0`th index.
2019-02-05 12:44:52 +03:00
rupali317 42bf229f59 fix: modified the test case such that the variable is a local scope o… (#34959)
* fix: modified the test case such that the variable is a local scope of the function

* fix: make test inclusive
2019-02-05 09:40:58 +03:00
Tammy 9e4583b1f3 fix: change video url for clockwise-notation challenge (#35013) 2019-02-04 16:29:26 +03:00
Leo 16bca6e24a Closes #34988: "Clicking on link in the code preview opens up the web page within the web page" (#34995) 2019-02-04 15:57:49 +03:00
Pepijnk12 ab4367a751 Update URL for 404 error (#35042)
* Update URL for 404 error

* fix: correct url
2019-02-04 13:34:47 +03:00
Oliver Eyton-Williams 693047d5c6 fix: "Applied Visual Design: Adjust the Hover State of an Anchor Tag" now accepts more ways of writing 'blue' (#34939)
* fix: test now accepts more ways of writing 'blue'

* fix: include test for rgb
2019-02-04 12:22:30 +03:00
The Coding Aviator 90a9df1a5d Fixed problem with regex in es6 import challenge (#19718)
import-a-default-export.english.md: support both main quoting styles
2019-02-03 18:07:55 +01:00
Aculisme a455b601dc Update implement-merge-sort.english.md (#29007) 2019-02-03 09:14:01 +04:00
Brittany Sarenpa b56462c5ee Fixed grammar (#28571)
Changed 4th sentence to be more readable, it was slightly confusing with the comma.
2019-02-02 22:19:01 +04:00
Bannon Tanner a3c917ee62 changed position data to make correct values pass (#26987)
Closes: #17996
2019-02-02 21:49:36 +04:00
Adam a2fd37d767 Small spelling error. (#34512)
Changed word "moongose" to "mongoose".
2019-01-31 20:51:21 -08:00
Walter Woodward 7ccd4dacf5 typo (#34340)
present tense `build` changed to proper passed tense `built`
2019-01-31 20:48:51 -08:00
Timur 8fa32c52fc Fixes #13774 (#34801)
* Fixes #13774

* del redundant group in test ereg
2019-01-31 12:55:10 -08:00
Paul Gamble fabd45e1b4 Revert "Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)" (#34949)
This reverts commit 23096f7ed6.
2019-01-31 10:39:39 -08:00
Bhanu Pratap Singh Rathore 8584637254 feat(interview-prep): Transfering Rosetta problems from Curriculum (#34822) 2019-01-30 17:11:15 +09:00
Tracey Bushman b730b67e1a fix(curriculum): replace data urls with CDN urls for D3 projects (#34964)
* fix(curriculum): replace data urls with CDN urls for D3 projects

* fix(curriculum): data urls --languages

* fix(curriculum): stray old url
2019-01-29 03:41:02 +05:30
Leo 47857d9fcb Deleted wrong comma (#34979) 2019-01-28 08:33:11 -08:00
Leo 721cbba477 Deleted an unneccessary comma (#34976) 2019-01-28 08:28:11 -08:00
Leo 7f31aa807c Deleted comma (#34987) 2019-01-28 08:18:42 -08:00
Nelson Sandoval a284b296fc fix: Capitalize test text for Cascading CSS variables (#34910) 2019-01-27 18:11:49 -07:00
Oleksii Pudlo fef2ed3c11 Fixed description of wrap-reverse option of flex-wrap property (#28513)
from "bottom-to-top" to "right-to-left" for row values
from "right-to-left" to "bottom-to-top" for column values
2019-01-26 10:06:43 -08:00
Mike Short 088acf45d9 Typo: Edited Math for finding parent node (#34647) 2019-01-26 21:09:28 +09:00
Dan B ce63de866c Update depth-first-search.english.md (#34856)
Fixed formatting for the solution to increase readability. It was previously difficult to see since the code was all one line
2019-01-25 23:12:45 -05:00
Dana Ottaviani 9cd1610839 Add solution to css-flexbox challenge (#34253)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 12:13:07 -05:00
Zach Carroll de03d3f112 Solution to Comment out H1 and p tag, but not H2 element. (#32125)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:53:30 -05:00
SGokul1 6b6b33092b Sample solution for the challenge seed code (#31929)
* Sample solution for the challenge seed code

I have updated the sample solution for the challenge seed code.

* Update headline-with-the-h2-element.english.md

Removed //solution required


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:19:27 -05:00
Casey Bennington 7f9cbe982b Add the solution (#28899)
* Add the solution

* Update divide-one-decimal-by-another-with-javascript.english.md

The solution was not passing. Change should pass now.

* Update divide-one-decimal-by-another-with-javascript.english.md


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:10:44 -05:00
Casey Bennington d2286fc3b5 Added solution (#28907)
LGTM!
2019-01-25 10:17:46 -05:00
Casey Bennington 0351df1c24 Added solution to the uncomment-html-english-challenge (#28868)
LGTM!
2019-01-24 16:03:03 -05:00
lucielchoi707 2fea28aca8 add solution (#28406)
LGTM!
2019-01-24 15:57:09 -05:00
Alan Price 1a6e1e57cc Added solution (#27077) 2019-01-24 15:36:57 -05:00
Joe Erickson 6a777a9b16 Add solution to find more than one challenge (#27476) 2019-01-24 15:29:23 -05:00
Joe Erickson 13b3e3fa9b Add solution to match whitespace problem (#27470)
* Add solution to match whitespace problem

* fix: corrected case of countWhiteSpace on line 61
2019-01-24 15:23:07 -05:00
Alan Price 23096f7ed6 Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)
* added solution for challenge

* removed function from seed and solution
2019-01-24 14:24:27 -05:00
buhidar 589257cf02 Typo fix on line 11 (#34922) 2019-01-21 19:06:10 -08:00
Rohan Mohammad 39e36a1702 Project Euler: Problem 2: Even Fibonacci Numbers - fiboEvenSum(10) sh… (#34722) 2019-01-19 18:50:53 +09:00
Abhishek Kakade 7dac2fc086 Merges 3 Set Challenges (#34717)
* fix: merges 3 set challenges into 1

* fix: changed function to class syntax

* fix: simplified instructions

* fix: changed the example

* style: minor formatting changes

* style: formatted solution

* fix: formatting
2019-01-19 14:17:07 +05:30
Quincy Larson d006696c85 Correct two mixed up Scrimba links (#34892) 2019-01-18 03:27:01 +05:30
The Coding Aviator ca2d01a81c feat(curriculum): add grouping characters challenge and guide (#34875)
Added new challenge for mixed grouping of characters
2019-01-17 22:08:46 +01:00
Bannon Tanner e3df17b8f5 Update learn-about-tertiary-colors.md (#26027)
Fixes issue #18179
Fixed wording to be more clear about which color model was being used
2019-01-17 07:56:22 +07:00
Valeriy S 9b75c1965a fix(curriculum): replace window by self for js challenges 2019-01-16 10:45:39 +00:00
Valeriy 63d0a2682f fix: remove unused vars from the test execution scope 2019-01-14 13:44:54 +00:00
Alan Price 37d98f1123 Challenge - ES6: Write Arrow Functions with Parameters - Expanded description (#25997)
* Reworded and expanded the description

* renamed the function in the multiple param example
2019-01-09 11:00:16 +00:00
Bhanu Pratap Singh Rathore c820cdab80 feat(interview-prep): Adding Rosetta Code problems (#34710) 2018-12-30 22:35:56 +09:00
Emanuele Antonelli 91e7833bd4 fix: update take-home/twitch challenge description for new twitch api (#34744) 2018-12-28 22:34:05 +08:00
Nhat Khanh e5756ae1d6 [Guide] Functional Programming: Sort an Array Alphabetically using the sort Method. Fixes and enhancements. (#34678) 2018-12-21 22:50:52 +05:30
Bhanu Pratap Singh Rathore 4d55a04e21 feat(interview-prep): Adding Rosetta Code problems (#34634) 2018-12-18 21:16:11 +09:00
Aditya eae4363b76 fix(curriculum): Perform a Union on Two Sets (#34607) 2018-12-17 00:38:35 +09:00
Alan Price d36922c496 Added solution (#27127) 2018-12-15 12:41:12 +05:30
Ashish Singh ffce49d024 fixing typo for one of the challenges in es6 section for issue #34578 (#34579)
* fixing typo on UI

* changed tes string

* updated changes for issue #34578
2018-12-15 11:56:12 +05:30
Aditya 56ded4174c [Fix] Object Oriented Programming: Remember to Set the Constructor Property when Changing the Prototype (#34569) 2018-12-14 19:59:35 +09:00
Adrian Skar 0af7ebad6d [Curriculum] ES6: Prevent object mutation; fix minor typos (#34650) 2018-12-12 13:32:28 +00:00
Bhanu Pratap Singh Rathore ebf472f5f3 feat(interview-prep): Added Rosetta problem (#31093)
* feat(interview-prep): Added Rosetta problem

* Update sort-an-array-of-composite-structures.md

* feat(interview-prep): Added meta data

* feat(interview-prep): Added Bogosort Meta Data

* Added whitespace to the tests
2018-12-10 16:03:31 +09:00
Bhanu Pratap Singh Rathore 67cf2b3c0e feat(interview-prep): Porting Rosetta Problem: Sort Disjoint (#31105)
* feat(interview-prep): Porting Rosetta Problem: Sort Disjoint

* feat(interview-prep): Fixes

* feat(interview-prep): FIxed indent and solution

* Added whitespace to the tests
2018-12-10 16:03:04 +09:00
Bhanu Pratap Singh Rathore bfd84cdefc feat(interview-prep): Porting Rosetta Problem: Sort stability (#31119) 2018-12-10 16:02:43 +09:00
Bhanu Pratap Singh Rathore 8a30bf5705 feat(interview-prep): Porting Rosetta Problem: Sort custom (#31160) 2018-12-10 16:02:20 +09:00
Bhanu Pratap Singh Rathore 381973d870 feat(interview-prep): Porting Rosetta Problem: Bead Sort (#31173) 2018-12-10 15:51:36 +09:00
Bhanu Pratap Singh Rathore 515d884342 feat(interview-prep): Porting Rosetta Problem: Bogosort (#31178) 2018-12-10 15:44:18 +09:00
Valeriy S 0e621175ad fix(curriculum): remove SASS from requirements 2018-12-07 12:43:13 +00:00
Luane 5de9f32c06 Solution added to exercise 'Use the s tag to strikethrough text ' (#34526)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

Closes #XXXXX
2018-12-06 15:03:20 +00:00
Konstantinos Lyrakis 505f077052 Minor grammatical error (#34565) 2018-12-05 18:20:07 -08:00
Kristofer Koishigawa 62059eeb3b fix(challenges): YAMLException warning (#34544) 2018-12-05 20:52:41 +05:30
The Coding Aviator 9f5fbe9af4 Fixes issue with background-color and background being interpreted differently (#34275) 2018-12-05 15:22:58 +09:00
Ismael Casimpan cffe1be295 Grammar consistency fix. (#24228)
Entire article is using "isn't" so the "wasn't" seems out of place. I'm just following https://english.stackexchange.com/questions/283758/proper-use-of-was-vs-is
2018-12-04 16:12:48 +00:00
Billy Phillips 355878e921 Update feat: added instructions in meet-the-node-console.en.md (#34530)
* Update meet-the-node-console.en.md

* Update meet-the-node-console.en.md
2018-12-04 20:43:10 +05:30
The Coding Aviator 29297f48c9 Fixed issue about tag capitalization (#34276) 2018-12-04 23:16:30 +09:00
Aditya 4145efc467 [fix] Test for Pass Arguments to Avoid External Dependence in a Function (#34522)
* feat: test works for => fns, added solution

* fix: moved solution
2018-12-04 20:50:19 +09:00
Lxsthorne 786cda2627 Add challenge solution
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.

<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX
2018-12-03 23:10:41 +00:00
Alan Price 40f152ba15 Challenge - ES6: Use getters and setters to Control Access to an Object - Added solution and explanation of private variable naming convention (#24362)
* added explanation of private variable naming convention

* Added "Note:" to the front of the explanation

* Added solution

* Moved "Note:" to it's own line and made it bold

* fix: moved note block at the bottom
2018-12-03 19:10:09 +05:30
Ben Brown 929e0db633 fix(challenge): use-the-conditional-ternary-operator (#19535) 2018-12-03 14:19:57 +05:30
The Coding Aviator 5cc3e97c86 [Fixed Bug] Data Visualization with D3: Learn About SVG in D3 (#27022) 2018-12-03 12:44:30 +09:00
Aditya 9a315e237a Data Structures: Remove from a Set (#34493)
* fix: solution and moved instructions

* feat: added solution

* fix: added code elements
2018-12-01 11:46:02 -07:00
Ariel 2f23fb544d Fixes minor typo (#34326)
"should not be be" changed to "should not be"
2018-11-29 02:28:48 +05:30
Aditya 254897c372 fix: fixed the test and added solution 2018-11-27 19:52:49 +09:00
Abhishek Kakade f4f5ce4b85 fix: updated challenges text (#34458) 2018-11-27 02:05:14 +05:30
Aditya c3155c4f5b [Guide] Data Structures: Create a Set Class (#34434)
* feat: added solution

* fix: solution

* fix: changed expression to be be more readable

* fix: formatting
2018-11-25 10:56:33 -07:00
Anuj Jindal bdbf83e5a2 added 01-responsive-web-design/basic-css/ (#22531)
I have added use rgb-to-mix-color
2018-11-25 10:20:27 -07:00
Aditya a489ac9df8 fix(curriculum): Use the reduce Method to Analyze Data (#34315) 2018-11-22 20:14:31 +03:00
Aditya 8d593a1256 fix(curriculum): Create Strings using Template Literals (#34296) 2018-11-22 19:51:51 +03:00
Aditya d9c6a13741 [Tests] ES6: Use Destructuring Assignment with the Rest Operator (#34303) 2018-11-22 22:27:16 +09:00
Martin Payne d98be1be7c added (do not include the period) to address common mistake (#34381)
Thank you for your pull request.

I am closing this pull request. Please add links and other details to the challenge’s corresponding guide article instead.

If you think I’m wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.

@MP7373
2018-11-19 14:22:13 +08:00