Commit Graph

454 Commits (545b8a6f34dd40a90221c0a502dfb765d5d5a3f4)

Author SHA1 Message Date
Natalie Cardot 545b8a6f34 Modify if statement (#36088)
* Modify if statement

Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.

* Add test 

New test checks that if num is 0, an empty string is returned

* Fix test 

Fixing errors in newly proposed test that checks that empty string is returned when num is 0

* Modify intermediate solution

Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)

* fix: removed unnecessary assert message arguments
2019-05-20 21:08:20 -04:00
Natalie Cardot 39c43dbe8a Alter instructions (#36099)
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
Ahmad Abdolsaheb 8b4fb5a452 fix: imgur to s3 for various files without conflict (#36057) 2019-05-20 23:58:20 +05:30
Tom 21118bc26a fix/regex-lower-number-of-matches (#36004)
* fix/regex-lower-number-of-matches

* fix/update-guide

* fix/convert-blockquote-to-backticks
2019-05-17 23:53:00 +01:00
Mahesh Jaganiya e877d9c7d5 Semantic versioning required (#36074)
Node build fails for "1.2"
2019-05-17 09:07:16 -07:00
Randell Dawson 05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Randell Dawson 4b4762716c fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section (#35954)
* fix: reworded and moved challenge

* fix: removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix; removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: reworded sentence

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-15 11:12:17 -05:00
Kyle Cheung 937dc23b5d fixed typos in custom css-variable challenge #36038 (#36041)
* fixed typos in custom css-variable challenge

* fix: Remove extra line
2019-05-14 20:31:03 +07:00
Randell Dawson dd6011b2cc fix(curriculum): Convert blockquote elements to triple backtick syntax for Data Visualization (#35995)
* fix: convert data visualization

* fix: reverted to blockquote

* fix: changed js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: cleaned up code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:04:05 -05:00
Randell Dawson 933350c148 fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries (#35994)
* fix: converted blockquotes for react/redux

* fix: converted blockquotes for sass

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:01:32 -05:00
Randell Dawson 4dbd496b49 fix(curriculum): Convert blockquote elements to triple backtick syntax for Apis And Microservices (#35996)
* fix: converted blockquotes

* fix: revert to blockquote

* fix: changed js to http

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: reverted back to blockquote

* fix: reverted back to blockquote

* fix: reverted back to blockquote
2019-05-14 07:00:06 -05:00
Randell Dawson 46411ca1cd fix(curriculum): Convert blockquote elements to triple backtick syntax for Information Security And Quality Assurance (#35997)
* fix: converted blockquotes

* fix: added extra line before triple backtick syntax

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected misc issues

* fix: properly closed em element

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 06:58:09 -05:00
Randell Dawson df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993)
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Matt Schlosser 08c4807b09 Added missing `</code>` in test text string (#36040) 2019-05-14 10:06:55 +02:00
Huyen Nguyen 791e589c93 Remove tag characters (#36037) 2019-05-14 00:14:16 +05:30
Courtney 860cc14894 fix to spelling error "instantiated" (#36032)
* fix to spelling error

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/set-up-the-environment.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-13 10:00:07 -05:00
Tom fc547999fd fix/record-collection (#36002)
* fix/record-collection

* fix/remove-old-assert-messages

* fix/attempt-to-fix-build-error

* fix/attempt-to-fix-build-error

* fix/change-verbiage-and-tidy-up

* fix/remove-brackets-in-regex
2019-05-12 23:45:18 -04:00
Randell Dawson 48884f3a4a fix: changed to h4 > s in selector (#36023) 2019-05-11 19:09:08 -05:00
Randell Dawson 7437145bb4 fix: improved existing tests (#35801) 2019-05-09 09:01:50 -04:00
Yoelvis Jiménez fdb49ba89a Fix "ReferenceError: url is not defined" in challenge (#35415)
* Fix "ReferenceError: url is not defined" in challenge

I fix the challenge because issue #14002 
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by  @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍 
I modified and verify the tests according the new assessment.

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

Minor typo: `<code>` to `</code>`

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

new declared as const

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
duytrinhvn 534824e232 Fix spelling error (#35925)
* Fix spelling error

* fix: changed be conformed to conform
2019-05-08 19:54:32 -05:00
Kyle Scheuerlein 3b5fbe3edb Improve formatting of Challenge Seed (#35854) 2019-05-08 18:32:01 -05:00
Deanna Tran 338d7ee8a7 Change "rest operator" to say "rest parameter" in challenges and guide (#35496)
* change es6 challenges rest operator to param

* fix rest parameter typos

* change rest operator to parameter in guide

* fix casing

* change rest operator to rest parameter in guide

* change rest operator to rest parameter in curriculum

* remove extra whitespace

* remove whitespaces

* remove whitespace

* fix: removed arabic file

* fix: removed chinese file
2019-05-08 16:30:24 +02:00
Tom 4f73b5a7f3 Fix/manage state locally tests (#35980)
* fix/manage-state-locally-test

* fix/update-test-words

* fix/update-test
2019-05-08 10:17:54 -04:00
Tom 93e5554615 fix: added semi-colon not in original code
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-07 10:43:43 -07:00
Randell Dawson 5cfff58c7b fix: added all js to end of 3 backticks 2019-05-07 10:43:43 -07:00
Randell Dawson 5cf039e5fd fix: performed first conversions 2019-05-07 10:43:43 -07:00
Randell Dawson 1cb6092dd9 fix: performed first conversions 2019-05-07 10:43:43 -07:00
RIHANE ZAKARIA a40451feaa Define the Head and Body of an HTML Document for challenge solution (#35826)
* Define the Head and Body of an HTML Document for challenge solution

* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
Oliver Eyton-Williams cde8035b79 fix: add test for and slight rewrite to hazards of imperative (#35331)
* fix: add test for and slight rewrite to hazards of imperative

* fix: Resolve merge conflict

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: Make the only mistake in seed the use of splice
2019-05-06 07:27:38 -05:00
Randell Dawson a092c76688 fix: added 22 missing solutions (#35747) 2019-05-03 12:05:26 +02:00
The Coding Aviator 79b5749c57 curriculum: Change pre and code to blockquote in Advanced Node and Express challenges (#35713)
* curriculum: Change pre and code to blockquote in Advanced Node and Express challenge
2019-05-02 12:19:07 +02:00
Manish Giri b579317e11 fix(curriculum): Add solutions to Bootstrap challenges (#35789)
* fix(curriculum): Add solutions to Bootstrap challenges
2019-05-02 11:24:38 +02:00
Valeriy 5edaee4269 fix(curriculum): throws is not defined 2019-05-02 01:01:00 -07:00
Randell Dawson f51f262104 fix(curriculum): Increased starting font size to fix a bug on Chrome browser for Sass Apply a Style Until a Condition is Met with @while challenge (#35935)
* fix: increased starting font size for Chrome

* fix: slight verbiage change

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-extra-space
2019-05-01 09:08:38 -05:00
Randell Dawson 409aa30b0a fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge (#35893)
* fix: use calculated space for test

* fix: reworded comment

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: changed After Test to Before Test

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-01 14:08:35 +05:30
Randell Dawson 365ce2ddc7 fix(curriculum): Added test and corrected solution for Restrict Possible Usernames challenge (#35847)
* fix: added test and corrected solution

* fix: removed redundant regex

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-30 20:40:38 -05:00
Randell Dawson 3bff4151cf fix: rewrote challenge instructions and tests (#35899) 2019-04-30 20:19:06 -05:00
Randell Dawson 7d7a1127a7 fix: remove comments before tests (#35906) 2019-04-30 19:26:07 -05:00
Randell Dawson 66398a9300 fix(curriculum): Improved the tests for Find the length of a String challenge (#35940)
* fix: split tests into two requests

* fix: removed typeof number check

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove unneeded After Test section
2019-04-30 19:12:22 -05:00
Oliver Eyton-Williams e3529a8449 fix: Add solutions for Sass challenges (#35777) 2019-04-30 18:55:22 -05:00
RIHANE ZAKARIA 6630b2be7a bug fix / test of Spread Operator javascript challenge / english (#35856)
* bug fix test with the Spread Operator

* test of Spread Operator javascript challenge / english / change test and add a helper function
2019-04-30 18:37:26 -05:00
The Coding Aviator a2a278e937 fix: Moved instruction to proper place and removed assert text in Font Awesome challenges (#35928)
* fix: Moved instruction to proper place and removed assert text

* Add suggestion about making note strong

Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
2019-04-29 15:51:03 +02:00
Manish Giri 1015f1ec6e fix(curriculum): Add solution to jQuery challenges (#35776) 2019-04-28 12:28:47 -07:00
Huyen Nguyen 5b32e98c4a fix(curriculum): Add solutions to Applied Visual Design challenges (#35815)
* fix: add solutions to Applied Visual Design challenges

* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
Tina Wang bc986a4728 Moved font-awesome challenges to Font Awesome v5.8.1 (#35813)
* update font awesome challenge to font awesome 5

* v5 syntax changed
2019-04-28 15:00:27 +05:30
Randell Dawson 102c2b829a fix: added 15 missing solutions (#35745) 2019-04-28 14:31:14 +05:30
Aly Pilkons dae22c95c3 Edit Instructions Text To Make Goal Clearer (#35887)
* Edit Instructions Text To Make Goal Clearer

The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.

* Updated commit based on comments
2019-04-26 18:33:04 +05:30
Ian Effendi cf86246866 fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 (#35809)
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
BSi f8555c2f8b Added the semicolon in the example provided (#35898) 2019-04-23 19:26:50 -04:00