Commit Graph

454 Commits (545b8a6f34dd40a90221c0a502dfb765d5d5a3f4)

Author SHA1 Message Date
Randell Dawson 8e5b99b8ca fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367)
* fix: prevent 5th test from allowing invalid code

* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
The Coding Aviator 081284c2d3 fix: Formatting for Zig Zag Matrix challenge (#35403)
* fix: Formatting for Zig Zag Matrix challenge

* Remove non-breaking spaces and replace them with normal spaces

* Update zig-zag-matrix.english.md

* Move instructions to instructions section from description

* Update zig-zag-matrix.english.md
2019-03-05 11:57:57 +05:30
The Coding Aviator 8bac073687 fix(formatting): Zeckendorf challenge | Rosetta code (#35474)
* fix(formatting): Zeckendorf challenge | Rosetta code

* Update zeckendorf-number-representation.english.md
2019-03-05 11:51:56 +05:30
Randell Dawson b7fee2848c fix(curriculum): Corrected test which allowed wrong solution to pass (#35394)
* fix: corret-wrong-checks-in-test

* fix: improved robustness of test

* fix: added a full working solution for challenge

* fix: added && to asssert
2019-03-04 12:33:02 -06:00
kevindelsh 259eec5ab5 Sass import doesn't need file extension (#34802)
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
2019-03-04 09:35:07 -06:00
Ihor Allin 6222b86133 Update understand-the-hazards-of-using-imperative-code.english.md (#35052)
Moved instructions into correct section.
2019-03-04 09:24:54 -06:00
Randell Dawson 99c7f28530 fix: remove <code> tags around word queue (#35393) 2019-03-04 09:12:29 -06:00
Theodoros Gkortsilas cd501ee4c5 change wording: React component -> class component (#34692)
Hi,

I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".

Theo
2019-03-04 01:47:28 -05:00
Randell Dawson 6db2e12e9e fix: Removed unnecessary note from instructions (#35502) 2019-03-03 23:56:22 -06:00
Jasmeet Singh 5ba54685a8 Update 'union' to 'subset' in Tests. (#34788) 2019-03-04 00:06:54 -05:00
lasjorg 25ea44edf5 fix(challenge): allow new line in linear-gradient formatting (#35435)
* fix(challenge): allow new line in linear-gradient formatting

* fix(challenge): update test with suggested changes

* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
Travis Fantina f40c83cae6 Basic gramatical changes (#34587)
* Basic gramatical changes

Corrected a few typos to improve the wording

* commit suggested changes

Improve line 9 from "before" to "earlier"
Revert line 14
2019-03-04 00:03:49 +05:30
Tom 3d0b5c55ea fix:reformat-npm-section (#35422) 2019-03-04 00:00:44 +05:30
The Coding Aviator 49cc719af8 fix(formatting): Information Security with HelmetJS challenges (#35419)
* fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Hetmet JS challenges

fix(formatting): Hetmet JS challenges

* fix(curriculum): Remove hr

* fix(formatting): Helmet JS

* Change code to blockquote

* fix: indented code in blockquotes
2019-03-03 09:07:37 -08:00
Luane 9440cca69f Added example Input/Output to challenge (#34738)
* Added example Input/Output to challenge

Input/Output example will make it clear what the challenge is asking the camper to do.

* Formatting changes made to file

* Made minor changes in formatting

Added <code> tag to single line code.

* Formatting update

* Added requested formatting changes

* Refactored sentence and removed earlier example
2019-03-02 02:26:23 -05:00
Dana Ottaviani 3d1fd805e6 feat: add solution to accessibility challenge (#35484) 2019-03-01 20:03:38 -05:00
Christopher McCormack 421c097f17 feat: cleaned up grammar and formatting (#35364) 2019-03-02 00:25:09 +05:30
Alan Nguy 1957b1f636 fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. (#35177)
* fix: added test case for empty li elements

* fix: added error message in test case of empty li elements.

* fix: corrected error in test case.

* fix: added valid working solution

* fix: migrated test case to challenge: create-an-ordered-list (working solution included)

* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
Shashank Bairy R a0b79252d3 fix:removed bug in front end lib random quote project (#35477) 2019-03-01 11:09:00 -06:00
hilliarj 6cd3466f0b fix(curriculum): Find Characters with Lazy Matching (#35454)
* fix(curriculum): Find Characters with Lazy Matching

* Update PR

Note is moved in the Description section and not the Instructions section
2019-02-28 13:33:07 -08:00
Ruchika Sharma 25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Greg Smith 1779971cff Fix typos in MongoDB lessons and clarify some language (#35020)
* docs: typos and change some language for clarity

* fix: typo regression

* fix: added the word is
2019-02-27 13:41:19 -06:00
Niraj Nandish 769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Pete 41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
kevindelsh e40909b055 Corrected minor spelling error (#34750)
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson ab456a9a94 fix: changed js to html in solution section (#35414) 2019-02-25 22:50:58 -05:00
Aditya 665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
Paul Gamble 0c652e3ace feat: curriculum-basic-html-form-element-solution (#34956) 2019-02-25 22:23:08 -05:00
The Coding Aviator cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00
Dana Ottaviani 30fd0aa78e fix: add solution for accessibility challenge (#35366) 2019-02-25 21:58:35 -05:00
Héctor Estéllez fd1a19d956 Add indentation spaces to example code (#35047) 2019-02-25 18:49:42 -06:00
Bannon Tanner fe07433d0e fixed typo with instructions and preview (#26088)
* fixed typo with instructions and preview

Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes #18034

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md

suggested change by @thecodingaviator

Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>

* possible fix for solution

* apply my suggestioned changes
2019-02-25 15:50:00 -08:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
Adam 36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00
Ahmed Elbessfy 61a5707ba7 Edit Description (#34329)
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
NITIN BISHT b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Chad a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Randell Dawson bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Lewis Horwood 9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
Beau Carnes 2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00
TristanSeabrook ce2b46926f removed ungrammatical apostrophe (#35355)
changed "it's" to "its"
2019-02-22 03:14:30 -08:00
TristanSeabrook d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook 7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson 37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694)
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648)
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Dana Ottaviani 9562bf0baa Solution to implementing an accessible date picker (#35262)
* feat: add challenge solution

* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Aditi Joshi 2e388035ca Fix/update challenges for basic html and html5 (#35234)
* fix: challenge for basic html and html5 - test

* Delete use-if-and-else-to-add-logic-to-your-styles.english.md

* fix: Resolving merge conflict

* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
Riyaad Azad 2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
The Coding Aviator 54264157ee Added more clarification on how to use z-index (#34934)
* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md
2019-02-18 00:46:14 +05:30
kevindelsh 93c8badfeb Minor rephrasing of the lesson's description (#34787)
* Minor rephrasing of the lesson's description

Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.

* Corrections to conform to style guide

1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.

* Moved challenge instruction to Instructions section
2019-02-18 00:43:47 +05:30
Bannon Tanner 4734ff4154 nest anchor within paragraph instructions modification (#26441)
* modified wording to be more clear

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear

* fix: removed change not needed
2019-02-17 23:54:13 +05:30
Aashis kumar 80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Nelson Wu 6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
Gökhan Gurbetoğlu 16eb18954e Small change: remove unintentional whitespace (#34418)
On other challenges, only the affected places would have a placeholder whitespace, if there is one. Removed the unnecessary ones from this challenge.
2019-02-17 04:52:52 -05:00
Melkisedek Hamakali a0c00de32b Use correct spelling of navigable (#34817) 2019-02-17 01:52:19 -08:00
Almaz Kunpeissov 79af29dd2b Adding code styling to property value. (#34463)
Adding <code> styling for property value infinite in the ## Instructions.
2019-02-16 22:02:33 -08:00
Kirill Malev bca4d896cc Added solution to reuse-patterns-using-capture-groups.english.md (#35144)
* Update reuse-patterns-using-capture-groups.english.md

* included whole solution
2019-02-16 19:10:03 -08:00
Oliver Eyton-Williams ba9e45023d fix: make border radius challenge Firefox compatible (#35009)
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
2019-02-16 17:17:11 +00:00
Leo db63a354ee Deleted comma and removed first person (#35034) 2019-02-16 08:50:46 -08:00
The Coding Aviator 99ac0b6938 Update use-grid-area-without-creating-an-areas-template.english.md (#34852) 2019-02-16 20:52:20 +05:30
Christopher Szczechowicz 994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
Eunice Brackett 21f5427c14 Media query solution for Responsive Web Design (#33991)
* Media query solution for Responsive Web Design

This is in response to the required solution for the challenge solution section.

* fix: solution
2019-02-16 19:13:54 +05:30
Randell Dawson 9c3145ea49 fix: improved the grammar and readability (#35133) 2019-02-16 18:02:35 +05:30
Dana Ottaviani bad8846e04 feat: add solution to accessibility challenge (#35131) 2019-02-16 18:00:42 +05:30
Dovid Majowka 16ef2639c0 Updated wrong guideUrl to correct one (#35066)
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md

* Use standard link for guide URLs

* fix: corrected guideUrl

* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
Zach 2fea8d89f4 Update add-columns-with-grid-template-columns.english.md (#33544)
Fixed wording order for 'each' when asking to set column width.
2019-02-15 17:40:32 -08:00
Josh 4fc2bdd2a1 Update use-the-tilde-character-to-always-use-the-latest-patch-version-of-a-dependency.en.md (#34871)
Grammatical change.
2019-02-15 15:15:37 -08:00
Anas Salam ec9fffb222 solution to Challenge ID:bad87fee1348bd9aedd08835 (#33391)
* solution to Challenge ID:bad87fee1348bd9aedd08835

solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default

* fix: solution
2019-02-15 11:19:03 -08:00
Greg Brewton 7687f26c56 Information correction (#28582)
Eliminated the line  (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
2019-02-15 14:13:32 -05:00
gokulsg 63c5a94321 Expected solution for the challenge seed code (#32532)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
2019-02-15 12:48:30 -05:00
Luane 2f9d7a7492 Added solution to challenge (#34838)
Solution for challenge "Bootstrap: Use the Bootstrap Grid to Put Elements Side By Side".
2019-02-15 09:39:36 -08:00
Yoelvis Jiménez 0655abf800 Typo: I replaced nesesary by necessary (#34884)
* Typo: I replaced nesesary by necesary

Minor typo. I replaced nesesary by necesary.

* Fix nesesary to necessary
2019-02-15 00:40:17 -08:00
Howard T. Chiam c08ba2f654 Empty line not needed. (#34812) 2019-02-15 00:32:40 -08:00
edu san 0a330e65f9 Correct a typo in pairwise.english.md (#34375)
The word "indice" does not exist in English. The singular form of "indices" is "index".
2019-02-14 18:00:22 -08:00
JustinBen-Tzioni ba0d4fb15f Improved grammar and message (#28795)
* Improved grammar and message

* Update import-a-google-font.english.md
2019-02-14 13:38:58 -08:00
BurnhamG a825708e3e Correct seed code errors (#32355)
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
2019-02-14 13:24:38 -08:00
lmilliken 6989c4bc99 updated quotes (#34356) 2019-02-14 13:09:09 -08:00
JustinBen-Tzioni 7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
gokulsg 2b91676e72 Expected solution for the challenge seed code (#32523)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution section syntax
2019-02-14 14:35:21 -05:00
SGokul1 08b9c3c7fb I have updated the solution for this file. (#31749)
* I have updated the solution for this file.

I have added the expected output of the  challenge seed code.

* Update add-a-submit-button-to-a-form.english.md

Placed solution in ```html tags

* Update add-a-submit-button-to-a-form.english.md
2019-02-14 11:28:40 -08:00
Beau Carnes 133d6e5231 fix: update .en.md to .english.md (#35149) 2019-02-14 23:09:19 +05:30
Beau Carnes 409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Valeriy 99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
Kirill Malev 661d10412f Added solution to remove-whitespace-from-start-and-end.english.md (#35145)
* Update remove-whitespace-from-start-and-end.english.md

* includes whole solution now
2019-02-12 09:34:52 -08:00
gokulsg 60c93a8300 Expected solution for the challenge seed code (#32522)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution syntax
2019-02-12 08:19:56 -08:00
Lipis 86b8cee810 Replace Github with GitHub (#34971) 2019-02-12 00:46:34 -08:00
gokulsg a589042f88 Expected solution for the challenge seed code (#32537)
I have updated the expected output for the challenge seed code.
2019-02-11 23:45:55 -08:00
Niraj Nandish e7424de4ef fix(challenge): typo error (#30359) 2019-02-11 22:05:09 -08:00
Bannon Tanner b24f606847 added example to make description clear (#26492)
Added example in the description for understanding that the width of the element is still set using the width property in CSS.
fixes issue #17617
2019-02-11 18:28:07 -08:00
Aashis kumar b2e514d39f A better solution to finders-keepers.english.md (#34759)
* Update finders-keepers.english.md

A better approach to finder's keepers problem

* A better appoach to solve finders-keepers (JS)

Fixed travis bug

* fix: indented solution code
2019-02-10 20:13:48 -08:00
Steven Torrence 06b3b078a6 Fixed comment closing tag to match comment opening tag spacing and be symmetrical (#35136) 2019-02-10 14:29:12 -08:00
The Coding Aviator 9c881dcc6e Fixed issue with accessibility challenge about contrast (#19711)
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
Cryotechnic 80e80a4c8b Word Correction (#29689)
* Word Correction

Some words were missing, making the sentence sound grammatically incorrect.

* fix: removed the word its
2019-02-10 07:51:00 -08:00
Naveen f6f58d3228 Remove unwanted comma (#26050) 2019-02-10 07:33:56 -08:00
lasjorg 9341aadb5b Fix/remove property references and update tests (#35109)
* fix(challenges): Update challenge text and assertion test

* fix(challenges): update assert test regex

* fix(challenges): update regex, fix inline comment in code example

* fix: corrected regex
2019-02-09 00:47:53 -05:00
Julien Galibois Sauvageau e8b7b2eb6f Fixed typo (#34848)
Original wording: getHachedEggCount
New wording: getHatchedEggCount
2019-02-08 13:59:04 -08:00
Aditi Joshi 8b47ed264b Fix/update challenges for sass (#35031)
* style: button color change

* Revert "style: button color change"

This reverts commit 64574a49b7.

* fix: update sass challenge - description

* fix: challenge for sass
2019-02-08 13:11:05 -07:00
Mahesh Jaganiya d11bb33f56 Fixed Typo (#35098) 2019-02-07 22:52:14 -08:00
Kristofer Koishigawa 84e28bd0f0 fix(challenges): update required links for d3 challenges (#34477) 2019-02-08 09:37:46 +03:00
The Coding Aviator 536fe28162 Update get-json-with-the-javascript-xmlhttprequest-method.english.md (#34408) 2019-02-06 07:51:59 -06:00
Aditya 85eca8ef36 [fix]: Object Oriented Programming: Inherit Behaviors from a Supertype (#35063)
* fix: revert semicolon check

* fix: test name
2019-02-06 08:23:47 +03:00
coderlyn 4fe2558f99 Edit text string to have the correct case (#34366)
Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test
2019-02-05 18:51:13 -08:00
gokulsg cc659a9a2d Expected solution for the challenge seed code (#32530)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update create-a-text-field.english.md

* fix: change language tag and remove wrong comment
2019-02-05 18:33:30 -08:00
SGokul1 098c622fc6 Sample solution for the file (#31770)
* Sample solution for the file

I have updated the sample solution for the challenge seed code.

* Update add-images-to-your-website.english.md

formatted ```html tags
2019-02-05 18:31:31 -08:00
Dom Coleman 9a4e13954a Tests for OOP: Inherit Behaviors from a Supertype (#34938)
* Tests for OOP: Inherit Behaviors from a Supertype

Fixes issue #34905

* fix: make test inclusive
2019-02-05 20:44:53 +03:00
Luane f2c3d635ef Added solution to challenge "Regular Expressions: Match Characters th… (#34668)
* Added solution to challenge "Regular Expressions: Match Characters that Occur Zero or More Times"

* fix: removed necessary brackets
2019-02-05 08:03:19 -08:00
Chelsea Marie Hicks 8d7bd3906c Grammar change and readability of example (#30507) 2019-02-05 21:14:05 +05:30
John Sprunger 7ae6577cda Change for second test case (#34785)
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".

Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
2019-02-05 21:07:17 +05:30
Ali Ahmed 9999a8c9bc Modify test for dequeue method to check for FIFO (#34981)
* Update create-a-queue-class.english.md

* Modify test for dequeue method to check for FIFO

The test first `enqueue`'s two elements and checks for the `dequeue` method to return the element at `0`th index.
2019-02-05 12:44:52 +03:00
rupali317 42bf229f59 fix: modified the test case such that the variable is a local scope o… (#34959)
* fix: modified the test case such that the variable is a local scope of the function

* fix: make test inclusive
2019-02-05 09:40:58 +03:00
Tammy 9e4583b1f3 fix: change video url for clockwise-notation challenge (#35013) 2019-02-04 16:29:26 +03:00
Leo 16bca6e24a Closes #34988: "Clicking on link in the code preview opens up the web page within the web page" (#34995) 2019-02-04 15:57:49 +03:00
Pepijnk12 ab4367a751 Update URL for 404 error (#35042)
* Update URL for 404 error

* fix: correct url
2019-02-04 13:34:47 +03:00
Oliver Eyton-Williams 693047d5c6 fix: "Applied Visual Design: Adjust the Hover State of an Anchor Tag" now accepts more ways of writing 'blue' (#34939)
* fix: test now accepts more ways of writing 'blue'

* fix: include test for rgb
2019-02-04 12:22:30 +03:00
The Coding Aviator 90a9df1a5d Fixed problem with regex in es6 import challenge (#19718)
import-a-default-export.english.md: support both main quoting styles
2019-02-03 18:07:55 +01:00
Aculisme a455b601dc Update implement-merge-sort.english.md (#29007) 2019-02-03 09:14:01 +04:00
Brittany Sarenpa b56462c5ee Fixed grammar (#28571)
Changed 4th sentence to be more readable, it was slightly confusing with the comma.
2019-02-02 22:19:01 +04:00
Bannon Tanner a3c917ee62 changed position data to make correct values pass (#26987)
Closes: #17996
2019-02-02 21:49:36 +04:00
Adam a2fd37d767 Small spelling error. (#34512)
Changed word "moongose" to "mongoose".
2019-01-31 20:51:21 -08:00
Walter Woodward 7ccd4dacf5 typo (#34340)
present tense `build` changed to proper passed tense `built`
2019-01-31 20:48:51 -08:00
Timur 8fa32c52fc Fixes #13774 (#34801)
* Fixes #13774

* del redundant group in test ereg
2019-01-31 12:55:10 -08:00
Paul Gamble fabd45e1b4 Revert "Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)" (#34949)
This reverts commit 23096f7ed6.
2019-01-31 10:39:39 -08:00
Bhanu Pratap Singh Rathore 8584637254 feat(interview-prep): Transfering Rosetta problems from Curriculum (#34822) 2019-01-30 17:11:15 +09:00
Tracey Bushman b730b67e1a fix(curriculum): replace data urls with CDN urls for D3 projects (#34964)
* fix(curriculum): replace data urls with CDN urls for D3 projects

* fix(curriculum): data urls --languages

* fix(curriculum): stray old url
2019-01-29 03:41:02 +05:30
Leo 47857d9fcb Deleted wrong comma (#34979) 2019-01-28 08:33:11 -08:00
Leo 721cbba477 Deleted an unneccessary comma (#34976) 2019-01-28 08:28:11 -08:00
Leo 7f31aa807c Deleted comma (#34987) 2019-01-28 08:18:42 -08:00
Nelson Sandoval a284b296fc fix: Capitalize test text for Cascading CSS variables (#34910) 2019-01-27 18:11:49 -07:00
Oleksii Pudlo fef2ed3c11 Fixed description of wrap-reverse option of flex-wrap property (#28513)
from "bottom-to-top" to "right-to-left" for row values
from "right-to-left" to "bottom-to-top" for column values
2019-01-26 10:06:43 -08:00
Mike Short 088acf45d9 Typo: Edited Math for finding parent node (#34647) 2019-01-26 21:09:28 +09:00
Dan B ce63de866c Update depth-first-search.english.md (#34856)
Fixed formatting for the solution to increase readability. It was previously difficult to see since the code was all one line
2019-01-25 23:12:45 -05:00
Dana Ottaviani 9cd1610839 Add solution to css-flexbox challenge (#34253)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 12:13:07 -05:00
Zach Carroll de03d3f112 Solution to Comment out H1 and p tag, but not H2 element. (#32125)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:53:30 -05:00
SGokul1 6b6b33092b Sample solution for the challenge seed code (#31929)
* Sample solution for the challenge seed code

I have updated the sample solution for the challenge seed code.

* Update headline-with-the-h2-element.english.md

Removed //solution required


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:19:27 -05:00
Casey Bennington 7f9cbe982b Add the solution (#28899)
* Add the solution

* Update divide-one-decimal-by-another-with-javascript.english.md

The solution was not passing. Change should pass now.

* Update divide-one-decimal-by-another-with-javascript.english.md


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:10:44 -05:00
Casey Bennington d2286fc3b5 Added solution (#28907)
LGTM!
2019-01-25 10:17:46 -05:00
Casey Bennington 0351df1c24 Added solution to the uncomment-html-english-challenge (#28868)
LGTM!
2019-01-24 16:03:03 -05:00
lucielchoi707 2fea28aca8 add solution (#28406)
LGTM!
2019-01-24 15:57:09 -05:00
Alan Price 1a6e1e57cc Added solution (#27077) 2019-01-24 15:36:57 -05:00
Joe Erickson 6a777a9b16 Add solution to find more than one challenge (#27476) 2019-01-24 15:29:23 -05:00
Joe Erickson 13b3e3fa9b Add solution to match whitespace problem (#27470)
* Add solution to match whitespace problem

* fix: corrected case of countWhiteSpace on line 61
2019-01-24 15:23:07 -05:00
Alan Price 23096f7ed6 Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)
* added solution for challenge

* removed function from seed and solution
2019-01-24 14:24:27 -05:00
buhidar 589257cf02 Typo fix on line 11 (#34922) 2019-01-21 19:06:10 -08:00
Rohan Mohammad 39e36a1702 Project Euler: Problem 2: Even Fibonacci Numbers - fiboEvenSum(10) sh… (#34722) 2019-01-19 18:50:53 +09:00
Abhishek Kakade 7dac2fc086 Merges 3 Set Challenges (#34717)
* fix: merges 3 set challenges into 1

* fix: changed function to class syntax

* fix: simplified instructions

* fix: changed the example

* style: minor formatting changes

* style: formatted solution

* fix: formatting
2019-01-19 14:17:07 +05:30
Quincy Larson d006696c85 Correct two mixed up Scrimba links (#34892) 2019-01-18 03:27:01 +05:30
The Coding Aviator ca2d01a81c feat(curriculum): add grouping characters challenge and guide (#34875)
Added new challenge for mixed grouping of characters
2019-01-17 22:08:46 +01:00
Bannon Tanner e3df17b8f5 Update learn-about-tertiary-colors.md (#26027)
Fixes issue #18179
Fixed wording to be more clear about which color model was being used
2019-01-17 07:56:22 +07:00
Valeriy S 9b75c1965a fix(curriculum): replace window by self for js challenges 2019-01-16 10:45:39 +00:00
Valeriy 63d0a2682f fix: remove unused vars from the test execution scope 2019-01-14 13:44:54 +00:00
Alan Price 37d98f1123 Challenge - ES6: Write Arrow Functions with Parameters - Expanded description (#25997)
* Reworded and expanded the description

* renamed the function in the multiple param example
2019-01-09 11:00:16 +00:00
Bhanu Pratap Singh Rathore c820cdab80 feat(interview-prep): Adding Rosetta Code problems (#34710) 2018-12-30 22:35:56 +09:00
Emanuele Antonelli 91e7833bd4 fix: update take-home/twitch challenge description for new twitch api (#34744) 2018-12-28 22:34:05 +08:00
Nhat Khanh e5756ae1d6 [Guide] Functional Programming: Sort an Array Alphabetically using the sort Method. Fixes and enhancements. (#34678) 2018-12-21 22:50:52 +05:30
Bhanu Pratap Singh Rathore 4d55a04e21 feat(interview-prep): Adding Rosetta Code problems (#34634) 2018-12-18 21:16:11 +09:00
Aditya eae4363b76 fix(curriculum): Perform a Union on Two Sets (#34607) 2018-12-17 00:38:35 +09:00
Alan Price d36922c496 Added solution (#27127) 2018-12-15 12:41:12 +05:30
Ashish Singh ffce49d024 fixing typo for one of the challenges in es6 section for issue #34578 (#34579)
* fixing typo on UI

* changed tes string

* updated changes for issue #34578
2018-12-15 11:56:12 +05:30
Aditya 56ded4174c [Fix] Object Oriented Programming: Remember to Set the Constructor Property when Changing the Prototype (#34569) 2018-12-14 19:59:35 +09:00
Adrian Skar 0af7ebad6d [Curriculum] ES6: Prevent object mutation; fix minor typos (#34650) 2018-12-12 13:32:28 +00:00
Bhanu Pratap Singh Rathore ebf472f5f3 feat(interview-prep): Added Rosetta problem (#31093)
* feat(interview-prep): Added Rosetta problem

* Update sort-an-array-of-composite-structures.md

* feat(interview-prep): Added meta data

* feat(interview-prep): Added Bogosort Meta Data

* Added whitespace to the tests
2018-12-10 16:03:31 +09:00
Bhanu Pratap Singh Rathore 67cf2b3c0e feat(interview-prep): Porting Rosetta Problem: Sort Disjoint (#31105)
* feat(interview-prep): Porting Rosetta Problem: Sort Disjoint

* feat(interview-prep): Fixes

* feat(interview-prep): FIxed indent and solution

* Added whitespace to the tests
2018-12-10 16:03:04 +09:00
Bhanu Pratap Singh Rathore bfd84cdefc feat(interview-prep): Porting Rosetta Problem: Sort stability (#31119) 2018-12-10 16:02:43 +09:00
Bhanu Pratap Singh Rathore 8a30bf5705 feat(interview-prep): Porting Rosetta Problem: Sort custom (#31160) 2018-12-10 16:02:20 +09:00
Bhanu Pratap Singh Rathore 381973d870 feat(interview-prep): Porting Rosetta Problem: Bead Sort (#31173) 2018-12-10 15:51:36 +09:00
Bhanu Pratap Singh Rathore 515d884342 feat(interview-prep): Porting Rosetta Problem: Bogosort (#31178) 2018-12-10 15:44:18 +09:00
Valeriy S 0e621175ad fix(curriculum): remove SASS from requirements 2018-12-07 12:43:13 +00:00
Luane 5de9f32c06 Solution added to exercise 'Use the s tag to strikethrough text ' (#34526)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

Closes #XXXXX
2018-12-06 15:03:20 +00:00
Konstantinos Lyrakis 505f077052 Minor grammatical error (#34565) 2018-12-05 18:20:07 -08:00
Kristofer Koishigawa 62059eeb3b fix(challenges): YAMLException warning (#34544) 2018-12-05 20:52:41 +05:30
The Coding Aviator 9f5fbe9af4 Fixes issue with background-color and background being interpreted differently (#34275) 2018-12-05 15:22:58 +09:00
Ismael Casimpan cffe1be295 Grammar consistency fix. (#24228)
Entire article is using "isn't" so the "wasn't" seems out of place. I'm just following https://english.stackexchange.com/questions/283758/proper-use-of-was-vs-is
2018-12-04 16:12:48 +00:00
Billy Phillips 355878e921 Update feat: added instructions in meet-the-node-console.en.md (#34530)
* Update meet-the-node-console.en.md

* Update meet-the-node-console.en.md
2018-12-04 20:43:10 +05:30
The Coding Aviator 29297f48c9 Fixed issue about tag capitalization (#34276) 2018-12-04 23:16:30 +09:00
Aditya 4145efc467 [fix] Test for Pass Arguments to Avoid External Dependence in a Function (#34522)
* feat: test works for => fns, added solution

* fix: moved solution
2018-12-04 20:50:19 +09:00
Lxsthorne 786cda2627 Add challenge solution
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.

<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX
2018-12-03 23:10:41 +00:00
Alan Price 40f152ba15 Challenge - ES6: Use getters and setters to Control Access to an Object - Added solution and explanation of private variable naming convention (#24362)
* added explanation of private variable naming convention

* Added "Note:" to the front of the explanation

* Added solution

* Moved "Note:" to it's own line and made it bold

* fix: moved note block at the bottom
2018-12-03 19:10:09 +05:30
Ben Brown 929e0db633 fix(challenge): use-the-conditional-ternary-operator (#19535) 2018-12-03 14:19:57 +05:30
The Coding Aviator 5cc3e97c86 [Fixed Bug] Data Visualization with D3: Learn About SVG in D3 (#27022) 2018-12-03 12:44:30 +09:00
Aditya 9a315e237a Data Structures: Remove from a Set (#34493)
* fix: solution and moved instructions

* feat: added solution

* fix: added code elements
2018-12-01 11:46:02 -07:00
Ariel 2f23fb544d Fixes minor typo (#34326)
"should not be be" changed to "should not be"
2018-11-29 02:28:48 +05:30
Aditya 254897c372 fix: fixed the test and added solution 2018-11-27 19:52:49 +09:00
Abhishek Kakade f4f5ce4b85 fix: updated challenges text (#34458) 2018-11-27 02:05:14 +05:30
Aditya c3155c4f5b [Guide] Data Structures: Create a Set Class (#34434)
* feat: added solution

* fix: solution

* fix: changed expression to be be more readable

* fix: formatting
2018-11-25 10:56:33 -07:00
Anuj Jindal bdbf83e5a2 added 01-responsive-web-design/basic-css/ (#22531)
I have added use rgb-to-mix-color
2018-11-25 10:20:27 -07:00
Aditya a489ac9df8 fix(curriculum): Use the reduce Method to Analyze Data (#34315) 2018-11-22 20:14:31 +03:00
Aditya 8d593a1256 fix(curriculum): Create Strings using Template Literals (#34296) 2018-11-22 19:51:51 +03:00