Commit Graph

454 Commits (545b8a6f34dd40a90221c0a502dfb765d5d5a3f4)

Author SHA1 Message Date
Dana Ottaviani 73b4f8c41d fix: add solution to Bootstrap challenge (#35650) 2019-03-24 10:28:07 -07:00
Vikas KM 9e36ff87bb changes to no validate comment (#34810)
* changes to no validate comment 

Added single line comment check for regex to not validate.

* fix: corrected regex

* fix: changed + to *
2019-03-23 15:27:42 -04:00
rupali317 bc72c86dc6 fix: updated the note sections for responsive web design english (#35528) 2019-03-22 15:02:12 +01:00
Carol W 6d43682397 fix: update tests for difference on two sets (#34664)
* fix: update tests for difference on two sets

* fix: update tests for difference on two sets - fix quotes

* fix: reverted testString and reworded text
2019-03-22 11:40:06 +01:00
Chuck Adams a09bb2ea1d log set as Array.from(set) (#35646) 2019-03-21 21:15:45 +05:30
Hugo 739f4a8850 fix: Update test for ES6 challenge (#34300)
* fix: es6 challenge test

* delete console.log
2019-03-21 10:50:30 +01:00
Kristofer Koishigawa 3e51ced41b fix(challenges): Remove duplicate Rosetta Code sorting problems (#35547)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed: 
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort

This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.

Closes #34776
2019-03-21 13:05:02 +05:30
Bhanu Pratap Singh Rathore 79394d141f feat(interview-prep): Converting and transferring Rosetta problems (#35487)
* feat(interview-prep): Converting and transferring Rosetta problems

* feat(interview-prep): Fixing challenges

* fix(challenges): Added code tags

* Update knight's-tour.md

Moved text to instructions section and fixed a small typo.

* feat(interview-prep): Update description of Knight's tour

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(interview-prep): Update description of Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(inteview-prep): Kaprekar numbers description

Added <code> tags.

* fix(interview-prep): Update description Kaprekar Numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* fix(interview-prep): Added code tags Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>
2019-03-21 11:52:35 +05:30
Timur cab064a183 Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions (#34345)
* Fix tests

- fix original log() method restoration

- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md

allow function calling without semicolon

Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
2019-03-21 11:50:23 +05:30
Chuck Adams 4b2219b01d close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions (#35537) 2019-03-20 22:02:21 +01:00
grets311 2219a9a8dd Update positive-and-negative-lookahead.english.md (#34582)
Update solution from w{5} to w{6} as exercise is to match at greater than 5 characters long.
2019-03-20 15:58:09 +01:00
Shashank Bairy R f313c094cb fix: clarify how to create multiple box shadows (Issue: #35534) (#35555)
* fix: clarify how to create multiple box shadows

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md

<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.

Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
2019-03-20 15:32:53 +01:00
Edwin van Meerendonk 5f894a3231 A solution was missing (#35552)
My solution
2019-03-20 15:17:00 +01:00
Jade Michael Thornton d5861edc84 add more specific tests for username regex challenge (#34655)
* add more specific tests for username regex challenge

* fix: removed unnecessary test
2019-03-19 15:21:30 -07:00
lasjorg 88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
Yuran Pereira 39b597f1c2 Corrected grammatical mistake (#35631)
From: "The version numbers themselves not should be changed"
To: "The version numbers themselves should not be changed"
2019-03-19 11:24:48 -04:00
NITIN BISHT 228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Randell Dawson 4d1d89b1c7 fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge (#35320)
* fix: only allow valid jsx comments in div elem

* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams e7bc4bd014 fix: Allow trailing commas to be used in challenge (#35585)
* fix: Allow trailing commas to be used in challenge

* fix: use regex to simplify challenge tests

* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
2019-03-18 09:56:46 -07:00
The Coding Aviator 17715a795e fix(formatting): Zhang-Suen | Rosetta Code (#35472)
* fix(formatting): Move challenge instructions to instruction section

* Fix table and list

* fix(curriculum): Zhangsuen

* fix(curriculum): add bold tags

* Fix typo in instructions
2019-03-18 17:19:02 +09:00
Randell Dawson 9051ad2eb5 Fixed bug allowing versions of Object.keys method and hard coding of ownProps array (#35021)
* fix: disallow variants of Object.keys method

* fix: added new test to help prevent hardcoding array

* fix: refactored regex
2019-03-17 18:47:41 -04:00
Roberto Beltran fb8dcd4dbc Make link text more descriptive (#35218)
* Make link text more descriptive

Make link text more descriptive for improved accessibility.

* Add mention of MDN to link description

As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Adjust link wording

Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
2019-03-17 16:47:30 -04:00
kevindelsh 64faca718b Changed the definition of stateful components (#34837)
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
2019-03-16 19:25:46 +01:00
Gökhan Gurbetoğlu 3b0a75e648 Add default value for justify-content (#34419)
According to the standard, the default value for justify-content if it is not specified is flex-start.
Source: https://www.w3schools.com/cssref/css3_pr_justify-content.asp
2019-03-14 07:14:21 -07:00
Nathan Lakritz c31d1e2de9 Add semicolon to inline CSS (#34737) 2019-03-14 01:08:25 +05:30
Greg Brewton 0b3415b2fa Clarifies definitions and adds missing definition (#28591)
Corrects incomplete definitions of space-between space-around values and adds definition of space-evenly value
2019-03-13 11:10:37 -07:00
Ron Sogueco 748212f99c fix: Test fails with comments (#35079)
* fix: Test fails with comments

* fix: Account for last line of code

* fix: false positive for padding clockwise notation

* fix: false positive for commented blue-box class

* fix: use same assertion as #35342

* fix: update Solution section

* fix: update last test for margin/padding challenges
2019-03-13 13:54:59 -04:00
Sumer Patel 4f22235cc6 fix: broken tests in add-axes-to-a-visualization-challenge-in-d3 (Issue: #35554) (#35577) 2019-03-13 13:53:02 +05:30
Lauren Van Sloun ef86d7bd61 Fixed typo in JavaScript curriculum (#34820)
* Fixed typo in JavaScript curriculum

* Added missing period at end of sentence
2019-03-12 15:05:22 -07:00
Vedrana_R 0ffdae1093 Fixed interpunction in the introduction paragraph (#32157)
* Fixed interpunction in the introduction paragraph

* fix: made suggested change
2019-03-12 14:53:17 -07:00
lasjorg 494687f75e fix: correct inconsistency in formatting (#34721)
* fix: correct inconsistency in formatting

* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
Dana Ottaviani 0a2aa3dcfa feat: add solution to accessibility challenge (#35553)
* feat: add solution to accessibility challenge

* Remove space before closing `time` tag

Co-Authored-By: Dana94 <dana.ottaviani@gmail.com>
2019-03-10 11:09:57 -07:00
Jonathan Neidel 95aacb6c02 Update challenge descriptions with code tags (#35539)
* Update challenge descriptions with code tags

Updates multiple challanges in the category: Information Security with
HelmetJS

* Fix(wording): security with helmetjs

Co-Authored-By: jneidel <github@jneidel.com>
2019-03-10 08:21:12 -07:00
Randell Dawson 49db42ba2b fix(curriculum) Replace <code> with <blockquote>for code sections (#35442)
* fix: reformatted code and moved instructions

* fix: replaced code with blockquotes

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/install-and-set-up-mongoose.english.md

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: made a few recommended changes of text

* fix: moved </blockquote> to new line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: removed extra space

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added the word The before code tag section
2019-03-09 08:49:19 -06:00
Randell Dawson f6d07f37d7 fix: created more flexible test (#35325) 2019-03-08 11:07:50 -06:00
Bannon Tanner 9ebaa10eea added clarification in test text (#26458)
* added clarification in test text

fix to issue #17490

* moved the note from the test text to description

* fix: updated note sytnax
2019-03-08 14:01:47 +05:30
The Coding Aviator 8069923feb 24 Game: Move instruction to instructions section 2019-03-08 15:53:02 +09:00
The Coding Aviator 084ba9c782 fix(formatting): Minor changes in 24 Game challenge 2019-03-08 15:53:02 +09:00
The Coding Aviator f8061bcb56 Fixed formatting of the 24 Game | Rosetta challenge 2019-03-08 15:53:02 +09:00
Lewis Horwood 38c99d7ff5 Simplify challenge wording (#25120)
* Simplify challenge wording

* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price 27a59c5418 fix: reworded text messages (#27072) 2019-03-06 18:30:58 -05:00
Tom dce5bceb85 fix/reformat-basic-node-express-challenges (#35424)
* fix/reformat-basic-node-express-challenges

* add semi-colon

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-json-on-a-specific-route.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-json-on-a-specific-route.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/get-query-parameter-input-from-the-client.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/get-route-parameter-input-from-the-client.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-an-html-file.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/start-a-working-express-server.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/start-a-working-express-server.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md

Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com>
2019-03-06 18:20:17 -05:00
Oliver Eyton-Williams 51fcc8e509 fix: Improve formatting for Pascal's triangle challenge (#35531) 2019-03-07 01:55:37 +05:30
Akshay Tiwari 6d24b879f2 Update catch-mixed-usage-of-single-and-double-quotes.english.md (#35532) 2019-03-07 01:04:12 +05:30
Randell Dawson 92208f7c23 [Fix] Modified regex to allow spaces in one of the tests for challenge Apply a Style Until a Condition is Met with @while (#35100)
* fix: modified regex to allow spaces

* fix: added additional \s* after 1

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-03-06 03:05:52 -05:00
Aashis kumar 960811e31f Solution to specify-exact-number-of-matches.english JavaScript Challenge (#34757)
* Update specify-exact-number-of-matches.english.md

Added an explanation to the working code too

* fix: removed i flag and comments
2019-03-05 13:12:55 -05:00
nik 304d36ab47 fix(challenge): decrease opacity testString (#34711) 2019-03-05 12:11:27 -05:00
Dan B 73e6e13243 Update find-the-minimum-and-maximum-value-in-a-binary-search-tree.english.md (#35057)
Added solution which has been tested and confirmed to pass all tests
2019-03-05 08:44:59 -06:00
Dan B 8bb76a4eb6 Update insert-an-element-into-a-max-heap.english.md (#34989)
Added solution to problem
2019-03-05 08:41:56 -06:00
Dan B 28aecb41f8 Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md (#35006)
Added working solution to the problem
2019-03-05 08:37:57 -06:00
Randell Dawson 8e5b99b8ca fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367)
* fix: prevent 5th test from allowing invalid code

* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
The Coding Aviator 081284c2d3 fix: Formatting for Zig Zag Matrix challenge (#35403)
* fix: Formatting for Zig Zag Matrix challenge

* Remove non-breaking spaces and replace them with normal spaces

* Update zig-zag-matrix.english.md

* Move instructions to instructions section from description

* Update zig-zag-matrix.english.md
2019-03-05 11:57:57 +05:30
The Coding Aviator 8bac073687 fix(formatting): Zeckendorf challenge | Rosetta code (#35474)
* fix(formatting): Zeckendorf challenge | Rosetta code

* Update zeckendorf-number-representation.english.md
2019-03-05 11:51:56 +05:30
Randell Dawson b7fee2848c fix(curriculum): Corrected test which allowed wrong solution to pass (#35394)
* fix: corret-wrong-checks-in-test

* fix: improved robustness of test

* fix: added a full working solution for challenge

* fix: added && to asssert
2019-03-04 12:33:02 -06:00
kevindelsh 259eec5ab5 Sass import doesn't need file extension (#34802)
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
2019-03-04 09:35:07 -06:00
Ihor Allin 6222b86133 Update understand-the-hazards-of-using-imperative-code.english.md (#35052)
Moved instructions into correct section.
2019-03-04 09:24:54 -06:00
Randell Dawson 99c7f28530 fix: remove <code> tags around word queue (#35393) 2019-03-04 09:12:29 -06:00
Theodoros Gkortsilas cd501ee4c5 change wording: React component -> class component (#34692)
Hi,

I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".

Theo
2019-03-04 01:47:28 -05:00
Randell Dawson 6db2e12e9e fix: Removed unnecessary note from instructions (#35502) 2019-03-03 23:56:22 -06:00
Jasmeet Singh 5ba54685a8 Update 'union' to 'subset' in Tests. (#34788) 2019-03-04 00:06:54 -05:00
lasjorg 25ea44edf5 fix(challenge): allow new line in linear-gradient formatting (#35435)
* fix(challenge): allow new line in linear-gradient formatting

* fix(challenge): update test with suggested changes

* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
Travis Fantina f40c83cae6 Basic gramatical changes (#34587)
* Basic gramatical changes

Corrected a few typos to improve the wording

* commit suggested changes

Improve line 9 from "before" to "earlier"
Revert line 14
2019-03-04 00:03:49 +05:30
Tom 3d0b5c55ea fix:reformat-npm-section (#35422) 2019-03-04 00:00:44 +05:30
The Coding Aviator 49cc719af8 fix(formatting): Information Security with HelmetJS challenges (#35419)
* fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Information Security with HelmetJS challenges

fix(formatting): Hetmet JS challenges

fix(formatting): Hetmet JS challenges

* fix(curriculum): Remove hr

* fix(formatting): Helmet JS

* Change code to blockquote

* fix: indented code in blockquotes
2019-03-03 09:07:37 -08:00
Luane 9440cca69f Added example Input/Output to challenge (#34738)
* Added example Input/Output to challenge

Input/Output example will make it clear what the challenge is asking the camper to do.

* Formatting changes made to file

* Made minor changes in formatting

Added <code> tag to single line code.

* Formatting update

* Added requested formatting changes

* Refactored sentence and removed earlier example
2019-03-02 02:26:23 -05:00
Dana Ottaviani 3d1fd805e6 feat: add solution to accessibility challenge (#35484) 2019-03-01 20:03:38 -05:00
Christopher McCormack 421c097f17 feat: cleaned up grammar and formatting (#35364) 2019-03-02 00:25:09 +05:30
Alan Nguy 1957b1f636 fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. (#35177)
* fix: added test case for empty li elements

* fix: added error message in test case of empty li elements.

* fix: corrected error in test case.

* fix: added valid working solution

* fix: migrated test case to challenge: create-an-ordered-list (working solution included)

* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
Shashank Bairy R a0b79252d3 fix:removed bug in front end lib random quote project (#35477) 2019-03-01 11:09:00 -06:00
hilliarj 6cd3466f0b fix(curriculum): Find Characters with Lazy Matching (#35454)
* fix(curriculum): Find Characters with Lazy Matching

* Update PR

Note is moved in the Description section and not the Instructions section
2019-02-28 13:33:07 -08:00
Ruchika Sharma 25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Greg Smith 1779971cff Fix typos in MongoDB lessons and clarify some language (#35020)
* docs: typos and change some language for clarity

* fix: typo regression

* fix: added the word is
2019-02-27 13:41:19 -06:00
Niraj Nandish 769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Pete 41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
kevindelsh e40909b055 Corrected minor spelling error (#34750)
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson ab456a9a94 fix: changed js to html in solution section (#35414) 2019-02-25 22:50:58 -05:00
Aditya 665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
Paul Gamble 0c652e3ace feat: curriculum-basic-html-form-element-solution (#34956) 2019-02-25 22:23:08 -05:00
The Coding Aviator cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00
Dana Ottaviani 30fd0aa78e fix: add solution for accessibility challenge (#35366) 2019-02-25 21:58:35 -05:00
Héctor Estéllez fd1a19d956 Add indentation spaces to example code (#35047) 2019-02-25 18:49:42 -06:00
Bannon Tanner fe07433d0e fixed typo with instructions and preview (#26088)
* fixed typo with instructions and preview

Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes #18034

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md

suggested change by @thecodingaviator

Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>

* possible fix for solution

* apply my suggestioned changes
2019-02-25 15:50:00 -08:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
Adam 36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00
Ahmed Elbessfy 61a5707ba7 Edit Description (#34329)
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
NITIN BISHT b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Chad a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Randell Dawson bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Lewis Horwood 9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
Beau Carnes 2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00
TristanSeabrook ce2b46926f removed ungrammatical apostrophe (#35355)
changed "it's" to "its"
2019-02-22 03:14:30 -08:00
TristanSeabrook d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook 7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson 37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694)
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648)
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Dana Ottaviani 9562bf0baa Solution to implementing an accessible date picker (#35262)
* feat: add challenge solution

* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Aditi Joshi 2e388035ca Fix/update challenges for basic html and html5 (#35234)
* fix: challenge for basic html and html5 - test

* Delete use-if-and-else-to-add-logic-to-your-styles.english.md

* fix: Resolving merge conflict

* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
Riyaad Azad 2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
The Coding Aviator 54264157ee Added more clarification on how to use z-index (#34934)
* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md
2019-02-18 00:46:14 +05:30
kevindelsh 93c8badfeb Minor rephrasing of the lesson's description (#34787)
* Minor rephrasing of the lesson's description

Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.

* Corrections to conform to style guide

1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.

* Moved challenge instruction to Instructions section
2019-02-18 00:43:47 +05:30
Bannon Tanner 4734ff4154 nest anchor within paragraph instructions modification (#26441)
* modified wording to be more clear

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear

* fix: removed change not needed
2019-02-17 23:54:13 +05:30
Aashis kumar 80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Nelson Wu 6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
Gökhan Gurbetoğlu 16eb18954e Small change: remove unintentional whitespace (#34418)
On other challenges, only the affected places would have a placeholder whitespace, if there is one. Removed the unnecessary ones from this challenge.
2019-02-17 04:52:52 -05:00
Melkisedek Hamakali a0c00de32b Use correct spelling of navigable (#34817) 2019-02-17 01:52:19 -08:00
Almaz Kunpeissov 79af29dd2b Adding code styling to property value. (#34463)
Adding <code> styling for property value infinite in the ## Instructions.
2019-02-16 22:02:33 -08:00
Kirill Malev bca4d896cc Added solution to reuse-patterns-using-capture-groups.english.md (#35144)
* Update reuse-patterns-using-capture-groups.english.md

* included whole solution
2019-02-16 19:10:03 -08:00
Oliver Eyton-Williams ba9e45023d fix: make border radius challenge Firefox compatible (#35009)
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
2019-02-16 17:17:11 +00:00
Leo db63a354ee Deleted comma and removed first person (#35034) 2019-02-16 08:50:46 -08:00
The Coding Aviator 99ac0b6938 Update use-grid-area-without-creating-an-areas-template.english.md (#34852) 2019-02-16 20:52:20 +05:30
Christopher Szczechowicz 994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
Eunice Brackett 21f5427c14 Media query solution for Responsive Web Design (#33991)
* Media query solution for Responsive Web Design

This is in response to the required solution for the challenge solution section.

* fix: solution
2019-02-16 19:13:54 +05:30
Randell Dawson 9c3145ea49 fix: improved the grammar and readability (#35133) 2019-02-16 18:02:35 +05:30
Dana Ottaviani bad8846e04 feat: add solution to accessibility challenge (#35131) 2019-02-16 18:00:42 +05:30
Dovid Majowka 16ef2639c0 Updated wrong guideUrl to correct one (#35066)
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md

* Use standard link for guide URLs

* fix: corrected guideUrl

* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
Zach 2fea8d89f4 Update add-columns-with-grid-template-columns.english.md (#33544)
Fixed wording order for 'each' when asking to set column width.
2019-02-15 17:40:32 -08:00
Josh 4fc2bdd2a1 Update use-the-tilde-character-to-always-use-the-latest-patch-version-of-a-dependency.en.md (#34871)
Grammatical change.
2019-02-15 15:15:37 -08:00
Anas Salam ec9fffb222 solution to Challenge ID:bad87fee1348bd9aedd08835 (#33391)
* solution to Challenge ID:bad87fee1348bd9aedd08835

solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default

* fix: solution
2019-02-15 11:19:03 -08:00
Greg Brewton 7687f26c56 Information correction (#28582)
Eliminated the line  (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
2019-02-15 14:13:32 -05:00
gokulsg 63c5a94321 Expected solution for the challenge seed code (#32532)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
2019-02-15 12:48:30 -05:00
Luane 2f9d7a7492 Added solution to challenge (#34838)
Solution for challenge "Bootstrap: Use the Bootstrap Grid to Put Elements Side By Side".
2019-02-15 09:39:36 -08:00
Yoelvis Jiménez 0655abf800 Typo: I replaced nesesary by necessary (#34884)
* Typo: I replaced nesesary by necesary

Minor typo. I replaced nesesary by necesary.

* Fix nesesary to necessary
2019-02-15 00:40:17 -08:00
Howard T. Chiam c08ba2f654 Empty line not needed. (#34812) 2019-02-15 00:32:40 -08:00
edu san 0a330e65f9 Correct a typo in pairwise.english.md (#34375)
The word "indice" does not exist in English. The singular form of "indices" is "index".
2019-02-14 18:00:22 -08:00
JustinBen-Tzioni ba0d4fb15f Improved grammar and message (#28795)
* Improved grammar and message

* Update import-a-google-font.english.md
2019-02-14 13:38:58 -08:00
BurnhamG a825708e3e Correct seed code errors (#32355)
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
2019-02-14 13:24:38 -08:00
lmilliken 6989c4bc99 updated quotes (#34356) 2019-02-14 13:09:09 -08:00
JustinBen-Tzioni 7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
gokulsg 2b91676e72 Expected solution for the challenge seed code (#32523)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution section syntax
2019-02-14 14:35:21 -05:00
SGokul1 08b9c3c7fb I have updated the solution for this file. (#31749)
* I have updated the solution for this file.

I have added the expected output of the  challenge seed code.

* Update add-a-submit-button-to-a-form.english.md

Placed solution in ```html tags

* Update add-a-submit-button-to-a-form.english.md
2019-02-14 11:28:40 -08:00
Beau Carnes 133d6e5231 fix: update .en.md to .english.md (#35149) 2019-02-14 23:09:19 +05:30
Beau Carnes 409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Valeriy 99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
Kirill Malev 661d10412f Added solution to remove-whitespace-from-start-and-end.english.md (#35145)
* Update remove-whitespace-from-start-and-end.english.md

* includes whole solution now
2019-02-12 09:34:52 -08:00
gokulsg 60c93a8300 Expected solution for the challenge seed code (#32522)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* fix: corrected solution syntax
2019-02-12 08:19:56 -08:00
Lipis 86b8cee810 Replace Github with GitHub (#34971) 2019-02-12 00:46:34 -08:00
gokulsg a589042f88 Expected solution for the challenge seed code (#32537)
I have updated the expected output for the challenge seed code.
2019-02-11 23:45:55 -08:00