Igor Hideki Trindade
94712af264
Fix portuguese translations on curriculum challenge ( #37050 )
2020-02-27 15:37:28 +05:30
Sanket Kogekar
1a87f1f7c0
add: solution to project euler problem 20 ( #38257 )
...
* add: solution to project euler problem 20
* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md
Accidentally added last line. Calling function is unnecessary in solution.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* right place for starting braces
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* moved starting brace to previous line.
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-26 14:22:40 -05:00
Prakash Kumar
c9d8c2a73c
fix(learn): typo in Serialization of a User Object ( #38262 )
2020-02-26 15:07:32 +05:30
Vincent Shury
b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md ( #38247 )
...
* Update access-multi-dimensional-arrays-with-indexes.english.md
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0
fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned ( #38105 )
...
* fix: added test to validate new array is returned
* fix: changed text to reflect changed test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Tom
a09ffadd5a
fix: responsive image challenge ( #37934 )
...
* fix: responve image challenge
* fix: bad solution
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams
b0f1fa4b96
fix: make recursion challenge more intuitive ( #37399 )
2020-02-20 21:36:33 +05:30
Oliver Eyton-Williams
a27992a8b6
fix: transpile import() for testing in node
2020-02-20 19:52:23 +05:30
Igor Snitkin
dc7092ecd1
(fix learn): Update description to accommodate tests ( #38224 )
2020-02-19 00:13:34 +05:30
lasjorg
9a5ae756ac
fix(challenge): check inline style for color ( #38211 )
...
* fix(challenge): check inline style for color
* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
Oliver Eyton-Williams
f84173866a
fix: make frankenSplice tests more robust ( #38225 )
2020-02-18 21:24:24 +05:30
Prakash Kumar
c730f4aef4
Update hash-and-compare-passwords-synchronously.english.md ( #38226 )
2020-02-18 09:28:38 +01:00
Prayag
701bbc2ae9
added solution to d3 challenge add-labels-to-d3-elements ( #38208 )
2020-02-13 20:59:16 +05:30
Sofya Kholodkova
c61c8c0474
update russian localization ( #37259 )
2020-02-13 12:02:36 +04:00
Sofya Kholodkova
7c186f3a50
Update russian localization ( #37258 )
2020-02-13 12:02:03 +04:00
Sofya Kholodkova
5d4fb2a39b
Update russian localization ( #37257 )
2020-02-13 11:55:03 +04:00
Sofya Kholodkova
3fec01a28d
Update russian localization ( #37256 )
2020-02-13 11:52:46 +04:00
kundan kumar
971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… ( #38191 )
2020-02-13 02:41:36 +05:30
Hassaan Pasha
2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… ( #38199 )
2020-02-12 20:47:24 +05:30
srdubya
3fd336d3e9
fix(learn): correcting Hash Table Lookup Efficiency ( #38130 )
...
A hash table provide a lookup of O(1), not O(n).
2020-02-12 12:27:47 +05:30
Hassaan Pasha
0498e27902
fix: added white space checks including newlines to ensure pro… ( #38166 )
...
* fix: added white space checks including newlines to ensure proper validation of trim method
* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Ashraf Nazar
5feabd762c
fix: Add tests to check lazy matching is applied and that the string "h1" is not matched ( #38193 )
2020-02-11 10:17:51 -06:00
ZhichengChen
81e751d88b
fix(i18n): update Chinese translation of css grid ( #37924 )
2020-02-11 22:39:15 +09:00
ZhichengChen
e873b388da
fix(i18n): update Chinese translation of css flexbox ( #37923 )
2020-02-11 22:32:25 +09:00
ZhichengChen
c0d5d6ad4f
fix(i18n): update Chinese translation of responsive web design princi… ( #37922 )
2020-02-11 22:30:05 +09:00
ZhichengChen
3c743574f6
fix(i18n): update Chinese translation of applied accessibility ( #37920 )
2020-02-11 18:06:41 +09:00
ZhichengChen
5eed674c3a
fix(i18n): update Chinese translation of applied visual design ( #37918 )
2020-02-11 16:46:34 +09:00
Zhicheng Chen
4f32fedb8e
fix(i18n): update review suggestion
2020-02-11 15:42:42 +09:00
Zhicheng Chen
8c1834badb
fix(i18n): update chinese translation of basic css
2020-02-11 15:42:42 +09:00
Sherman
85164b3cd9
Fixed formatting and typos
2020-02-11 15:35:21 +09:00
Sherman
450f691926
Fixed formatting and typos
2020-02-11 15:24:55 +09:00
Sherman
b292a10a8e
Cleaned link formatting and typos
2020-02-11 15:17:40 +09:00
Wocanilo
f1cbf0f6bd
fix(learn): warn about XSS in convert JSON to HTML ( #37037 )
...
Co-authored-by: RedOpsMe <57320352+RedOpsMe@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-02-10 20:24:19 +05:30
Hassaan Pasha
80ba943ca3
fix: fixed regex for validating newlines in for loops ( #38180 )
2020-02-09 18:43:43 -06:00
Josh Soref
004b99bf8f
chore: fix typos in spelling ( #38100 )
...
* spelling: accidentally
* spelling: announce
* spelling: assembly
* spelling: avoid
* spelling: backend
* spelling: because
* spelling: claimed
* spelling: candidate
* spelling: certification
* spelling: certified
* spelling: challenge
* spelling: circular
* spelling: it isn't
* spelling: coins
* spelling: combination
* spelling: compliant
* spelling: containers
* spelling: concise
* spelling: deprecated
* spelling: development
* spelling: donor
* spelling: error
* spelling: everything
* spelling: exceed
* spelling: exist
* spelling: falsy
* spelling: faulty
* spelling: forward
* spelling: handle
* spelling: indicates
* spelling: initial
* spelling: integers
* spelling: issealed
* spelling: javascript
* spelling: length
* spelling: maximum
* spelling: minimum
* spelling: mutable
* spelling: notifier
* spelling: coordinate
* spelling: passport
* spelling: perform
* spelling: permuter
* spelling: placeholder
* spelling: progressively
* spelling: semantic
* spelling: submission
* spelling: submit
* spelling: translations
* spelling: turquoise
* spelling: visualization
* spelling: without
* spelling: registration
* spelling: representation
2020-02-08 23:59:10 +05:30
Oliver Eyton-Williams
a7075a579c
Fix: Problem 39: Integer right triangles ( #38145 )
...
* fix: correct test and add solution
I also changed the seed to report the results of an easier example to
the user, since just evaluating the function mostly wastes time.
* fix: use a better solution
* fix: credit original author
2020-02-08 21:09:32 +05:30
Sidtharthan A N
8cf64f2539
ProjectEuler | Update Problem statement of 002 to match projecteuler.net ( #38101 )
...
* Correct ProjectEuler:002 definition and tests
From projecteuler.net:
By considering the terms in the Fibonacci sequence whose values do not exceed four million, find the sum of the even-valued terms.
Correct: take all f(n) where f(n) <= 4,000,000 and f(n) is even
Incorrect: take all f(n) where n <= 4,000,000 and f(n) is even
* Incorporate PR review suggestios to ProjectEuler 002
Reword the problem statement
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-02-07 10:09:35 -06:00
Kristofer Koishigawa
4ef445c543
feat: add styles for markdown tables and convert some HTML tables to markdown ( #38126 )
2020-02-07 09:47:35 +01:00
Kiara Barias
afd467f5dc
Removes RSA links from English challenges ( #37869 )
...
* RSA links deleted from challenges
* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
Shubham Shah
bef738f0d4
modfied tests and made correction in solution ( #38023 )
2020-02-06 20:31:03 -05:00
David Lau
f3a386982a
Misspelling fix, add colon. ( #38169 )
2020-02-06 09:46:44 +01:00
Tom Monks
cccad94754
fix(learn): updated challenge text to clarify when to start using new boilerplates ( #38124 )
...
* fix: update to clarify new boilerplates used
Updating challenge text to make it more clear that learners need to switch to new boilerplate
* fix: improved wording to clarify new boilerplates used
Updating challenge text to be consistent and make it clear where learners are to switch to new boilerplate
Incorporating suggestions from PR #38124
2020-02-05 21:15:53 -06:00
Hassaan Pasha
d89eae392f
fix: adding test to check if flat or flatMap method was used in the steamroller challenge ( #38158 )
...
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge
* Addressed comments and acknowledged suggestions
2020-02-04 17:00:33 -05:00
PHILIP OBIORAH
66e5cf0051
fix(curriclum): modified add images to your website ( #38155 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-04 20:12:53 +05:30
Nick Black
6a4b42c4ec
Update to make instructions more clear ( #38068 )
...
The instructions on the exercise following this specify 'behind the scenes' which sounds more clear than 'in the background'.
2020-02-04 10:54:02 +03:00
Obba Paschal
8b692560e8
Fix: (Rosetta-Code) Correct the Test suite and make expression clearer ( #38102 )
...
* Fix: Correct the Test suite and make expression clearer
* Update 24-game.english.md
2020-02-04 07:08:32 +05:30
rsapkf
cfbb3f64c4
Change variable declaration from `var` to `let` in description ( #38150 )
2020-02-02 15:29:03 -06:00
Dylan Cutler
15d5824795
Change n pounds to n pence in Project Euler problem 31 ( #38144 )
2020-01-31 15:23:15 +01:00
Randell Dawson
2f39dd07d6
fix: removed part of user story
2020-01-29 14:05:39 +09:00
Ezekiel Oladejo
7453131461
Apply proper formatting on Note paragraph ( #38120 )
2020-01-26 17:31:51 -06:00
Ashraf Nazar
fda7fb174e
fix: Correct paths in English exercises by prefixing "/" before "learn" ( #38099 )
...
* fix: Correct paths in English exercises by prefixing "/" before "learn"
* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
Gregory
fe29ec4209
Added Russian translate ( #37539 )
2020-01-24 10:30:03 +04:00
Gregory
60bf902ec8
Better russian translate ( #37540 )
2020-01-24 09:48:11 +04:00
Gregory
decc6043c2
Better russian language ( #37541 )
2020-01-24 09:46:48 +04:00
Gregory
dd9485f27c
Better russian language ( #37542 )
2020-01-24 09:45:53 +04:00
Ashraf Nazar
1159a8dcaf
fix: Add edge case for mixed grouping of characters exercise, where "Frank Roosevelt" returns false ( #38097 )
2020-01-22 15:58:47 +05:30
Bojan Cvjetkovic
10bd00309a
Added solution to this exercise ( #38074 )
...
* Added solution to this exercise
* fix: changed js to html
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-22 00:00:06 +05:30
Khalid Almufti
46e2a1b262
Improve Arabic translation ( #36960 )
2020-01-21 21:25:16 +03:00
Perrottarichard
bc470325d0
Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md ( #38092 )
...
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
2020-01-21 08:25:10 -06:00
Ahmad Abdolsaheb
64286b4f13
fix: add closing section tag ( #38094 )
2020-01-21 16:45:31 +03:00
Khalid Almufti
10a2b06bae
Improve Arabic translation/fix code blockk ( #36961 )
2020-01-21 16:41:05 +03:00
Khalid Almufti
78a1bc3a1c
Fix code block ( #36962 )
2020-01-21 16:35:16 +03:00
Khalid Almufti
3cc810e387
Improve translations/code block fix ( #36964 )
2020-01-21 16:30:56 +03:00
Aseel
bcaec00958
Translate discerption to Arabic ( #37650 )
...
* Translate discerption to Arabic
* Translate description and instructions to Arabic
2020-01-21 16:21:47 +03:00
Ahmad Abdolsaheb
db652a6e8a
Revert "Translate description section to Arabic ( #37652 )" ( #38093 )
...
This reverts commit de1ab3dc65
.
2020-01-21 16:20:04 +03:00
Aseel
de1ab3dc65
Translate description section to Arabic ( #37652 )
2020-01-21 16:03:24 +03:00
Nick Black
c408cb9c1a
Removed typo from Instructions ( #38066 )
...
* Removed typo from Instructions
Removed the word 'with' which doesn't belong.
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-15 08:18:58 +05:30
ML
d824c77012
Move the comment on line 71 to its own line ( #38036 )
...
* Move the comment on line 71 to its own line
The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.
* Update line 71 comment per @manish-giri suggestion
Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
2020-01-15 08:17:34 +05:30
Nick Black
27b4deae36
Update run-functional-tests-on-api-endpoints-using-chai-http-ii.english.md ( #38065 )
...
Corrected typos.
2020-01-14 21:18:17 +05:30
Prakash Kumar
e925e854f1
Update delete-one-document-using-model.findbyidandremove.english.md ( #38041 )
2020-01-11 07:10:51 -08:00
SadCaterpillar
ca592d98b0
Improved Russian translation ( #37608 )
2020-01-10 09:48:22 +04:00
SadCaterpillar
7080757a57
Improved Russian translation ( #37609 )
2020-01-10 09:31:20 +04:00
M B
7f6a653c28
fix: update react lesson link (remove 404) ( #38031 )
...
* Update lesson link (remove 404)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-09 17:29:50 +01:00
Ronald van der Bergh
fd36d6db37
fixed typo, "is" changed to "in" ( #38032 )
2020-01-08 18:58:31 -08:00
Tom
86127a24f7
fix: add tests for header parser microservice project ( #37187 )
...
* fix: add tests for header parser microservice project
* fix: make test more robust
* fix: make text use 'should'
2020-01-08 12:31:19 -08:00
TAKAHASHI Shuuji
e65c47c6ba
fix: Wrap codes with <code> tags in css-flexbox challenge. ( #38025 )
2020-01-08 15:18:48 +03:00
Randell Dawson
a70e15c0a7
fix: allow-space-in-destructuring-regex ( #37997 )
2020-01-07 17:22:15 +01:00
TAKAHASHI Shuuji
81fe7678c1
Wrap `column` with <code> tags. ( #38020 )
2020-01-07 14:15:03 +01:00
Randell Dawson
6809578044
fix: change starting font-size ( #37981 )
2020-01-07 13:39:06 +03:00
JURAMOUSE
9ed588c9fa
Russian translate ( #37543 )
2020-01-05 15:59:09 +04:00
Khraks Mamtsov
c87eb4026b
Improve russian translation ( #37619 )
2020-01-05 15:58:21 +04:00
Lidiya
c4d0c92d72
Improved RU translate ( #37641 )
2020-01-05 15:54:21 +04:00
Lidiya
27172adf5e
Improved RU translate ( #37642 )
2020-01-05 15:53:42 +04:00
Lidiya
d1eeb51817
Improved RU translate ( #37643 )
2020-01-05 15:53:09 +04:00
Andree Amaro Gonzalez
0a0cbead58
fix(learn): Fixed tests for the create a hash table challenge ( #37870 )
...
* fix: update create hash table's tests
* fix: update the way lookup method is declared to enable the use of this.collection in it
2020-01-03 11:18:40 +01:00
Oliver Eyton-Williams
e4a229187e
fix: speed up tests
...
Either improved the algorithm or reduced the difficulty for the slowest
tests. All these pass with testProtectTimeout = 500, so should be safe
on most machines with the current timeout of 2500.
2020-01-03 11:41:52 +05:30
Tom
1b06bb29f0
fix: allow g flag on regex ( #37941 )
2020-01-02 18:24:07 -07:00
Tom
0adfc79c7a
fix: fixed position challenge ( #37945 )
2020-01-02 17:41:36 -07:00
Rohit Ambre
fe1c6b24ab
Added href to empty <a> tag in social auth implementation II ( #38002 )
...
* Added href to empty <a> tag in social auth implementation II
* corrected typos in authentication with socketIO challenge
* corrected typo as suggested
Co-Authored-By: Eric Leung <eric@erictleung.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
2020-01-02 17:36:15 -07:00
Nikolas Broman
d07c85151b
Fix typo (remove duplicate word 'should') ( #37998 )
2019-12-31 08:50:46 -08:00
Randell Dawson
1f98af5841
fix: used assert.deepEqual to compare arrays ( #37959 )
2019-12-31 13:33:04 +05:30
Shubham Shah
3cc0395964
added a test to challenge:falsy-bouncer ( #37973 )
...
* added a test to challenge:falsy-bouncer
* modified tests of challenge:falsy-bouncer
2019-12-29 17:17:17 -06:00
dependabot[bot]
20d34da130
chore(deps): bump handlebars from 4.1.2 to 4.5.3 in /curriculum ( #37992 )
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.1.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: null <49699333+dependabot[bot]@users.noreply.github.com>
2019-12-27 22:14:32 +05:30
ZhichengChen
3857e8d779
fix(i18n): update Chinese translation of basic html and html5 ( #37911 )
...
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2019-12-26 17:35:59 +05:30
gmal1
f6c2edcf19
Clean up code block, correct variable name ( #37245 )
...
* Update code block
* Update curriculum/challenges/russian/06-information-security-and-quality-assurance/advanced-node-and-express/announce-new-users.russian.md
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-12-24 09:30:37 -08:00
gmal1
1240e1b90b
Revert translation of proper nouns, clean up code block ( #37250 )
2019-12-24 13:30:25 +04:00
gmal1
83744b161a
Clean up code block, fix inconsistent spelling ( #37249 )
2019-12-24 13:29:04 +04:00
Khraks Mamtsov
78e4ef9631
Improve russian translation ( #37620 )
2019-12-24 09:32:51 +04:00
Huyen Nguyen
b2d3ff7420
fix(curriculum): Portuguese challenge tests ( #37283 )
2019-12-23 23:01:58 +05:30
Gregory Gubarev
8bd2fb8bc5
fix(i18n): delete duplicate text in test desc ( #37975 )
2019-12-23 20:47:10 +05:30
bitrixtoday
19352442ce
Improved translate russian language ( #37644 )
2019-12-23 10:48:39 +04:00
bitrixtoday
53924482fa
Improved translate russian language ( #37645 )
2019-12-23 10:48:14 +04:00
bitrixtoday
2a587fc8ad
Improved translate russian language ( #37646 )
2019-12-23 10:47:51 +04:00
JURAMOUSE
5dfb6b5de0
russian improvment translate ( #37547 )
2019-12-23 10:47:24 +04:00
JURAMOUSE
14342ac3d4
russian translate ( #37544 )
2019-12-23 10:46:49 +04:00
JURAMOUSE
868fbb0726
russian translate ( #37546 )
2019-12-23 10:46:03 +04:00
ZhichengChen
add8af389e
fix(i18n): update Chinese translation of responsive web design projects ( #37925 )
...
* fix(i18n): update chinese translation of responsive web design projects
* fix(i18n): update review suggestion
* fix(i18n): update review suggestion
* fix(i18n): update review suggestion
2019-12-22 12:24:13 -08:00
Sherman
438435cd89
Fixed formatting, typos and updated Glitch URLs ( #37290 )
2019-12-22 11:59:33 -08:00
Sebastián
da38c969b2
Fix(curriculum): Added Spanish translations and corrected grammar issues ( #37799 )
...
* Fix(curriculum): Added Spanish translations and corrected grammar issues
* Fixed typos and added Spanish translations
Co-authored-by: sebastiansaenz <52339334+sebastiansaenz@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-22 11:49:25 -08:00
Darío Fernández
98edb4675c
Update standardize-times-with-the-html5-datetime-attribute.spanish.md ( #37402 )
...
I improved the grammar of the sentence, now is more understandable.
2019-12-22 11:40:58 -08:00
Eze Rodriguez
61b0b7318a
Fixed incorrect automated spanish translation ( #37254 )
...
Ordered and replaced words so the instruction make sense in spanish
2019-12-22 11:33:29 -08:00
juliane nagao
c6d28b209f
fix: portuguese translation for explore-differences-between-the-var-and-let-keywords.portuguese.md ( #37821 )
...
* fix: portuguese translation
* fix: update translation
* fix: removed English sentence
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-22 11:32:21 -08:00
Abdullah
b31fce700d
Improve arabic translation for the challenge descriptions in the APIs… ( #37592 )
...
* Improve arabic translation for the challenge descriptions in the APIs-Microservices projects
* fix: updated to new Glitch link
* fix: updated Glitch url
* fix: updated Glitch url
* fix: updated Glitch url
* fix: updated Glitch url
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-22 11:21:42 -08:00
Oliver Eyton-Williams
e5abfa15ad
Revert "fix: stop user code after 100ms of execution" ( #37965 )
...
This reverts commit 01b37f664f
.
2019-12-21 11:09:32 +05:30
Chipiwiny94
c49aee9edc
Minor gramatical changes ( #36947 )
...
I added some pronoums and articles that were missing on the traslation of the lesson.
2019-12-20 22:52:49 +05:30
LeoGuilherme
f3dcbb485b
Translation fix on several lines ( #36909 )
...
Changes made for the page in portuguese to be more like the original in English
2019-12-20 22:52:09 +05:30
LeoGuilherme
743c30edcf
Translation fix on line 10 ( #36907 )
...
Changed some words for better translation in portuguese.
2019-12-20 22:51:00 +05:30
LeoGuilherme
4e509dca58
Translation fix in /make-typography-responsive.portuguese.md ( #36902 )
...
* Translation fix
Changed the term "portas de visualização" back to "viewport", because it is a technical term, and when translated it loses its meaning
* Changes in the blockquote tag
The code inside the blockquote tag was translated to portuguese, but code shouldn't be translated because then it doesn't work, so I changed it to the same code of the English version of the challenge.
Also, I changed "A Camper Cat" to "O Camper Cat" in the line 13 because on other pages Camper Cat is referred as male, so it makes more sense to use the article "O" in portuguese.
2019-12-20 22:50:37 +05:30
Irina Serdiuk
e095df348b
russian translation fix on curriculum challenge: description a… ( #37079 )
...
* russian translation
* Update create-a-block-element-bootstrap-button.russian.md
2019-12-20 20:54:36 +05:30
Irina Serdiuk
e1a4c8f1ae
russian translation fix on curriculum challenge: description a… ( #37077 )
2019-12-20 20:54:22 +05:30
Veronika Krukovich
df155231e4
fix challenges translation into russian ( #36889 )
2019-12-20 20:54:02 +05:30
Veronika Krukovich
df0df97949
fix challenges translation into russian ( #36888 )
2019-12-20 20:53:15 +05:30
Veronika Krukovich
872b7e1dbb
fix challenges translation into russian ( #36887 )
2019-12-20 20:53:01 +05:30
Veronika Krukovich
525cdcd475
fix challenges translation into russian ( #36886 )
...
* fix challenges translation into russian
* Fix spelling center in russian
2019-12-20 20:52:47 +05:30
RichardLimSpring
6ee9f23514
fix(i18n): Minor Chinese Translation Fix & Add Solution ( #36868 )
...
- Replace a few terms with more proper terms
- Rephrase 2nd paragraph for clearer meaning
- Add Solution
2019-12-20 20:52:00 +05:30
RichardLimSpring
f68e7bd5cd
fix(i18n): chinese - minor language fixes and add solution ( #36867 )
...
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
2019-12-20 20:50:46 +05:30
Oliver Eyton-Williams
01b37f664f
fix: stop user code after 100ms of execution ( #37841 )
...
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2019-12-20 19:28:17 +05:30
Randell Dawson
5609a1303e
fix: corrected tests for 3 challenges ( #37948 )
2019-12-19 11:26:50 +01:00
lasjorg
8cca639450
fix(challenge): check inline styles on elements, add solution ( #37756 )
2019-12-16 16:18:29 +01:00
Sean Coleman
203c9823e8
Fixed minor grammar issue in escape-sequences-in-strings.english.md ( #37940 )
...
* Update escape-sequences-in-strings.english.md
Fixed minor grammar issue in list item 1 of the description section.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
Arthur
616d96f612
refactor: update trivial regex capture group find and replace challenge ( #37768 )
...
* refactor: replace trivial regex capture group challenge
Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.
resolves #17645
* test: validate at least 3 capture groups were used
Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex )
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* refactor: more meaningful variable name
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* test: add parenthesized substring test
* test: ensure 3 uses of substring replacement
* refactor: reword instructions
* fix: minor grammar fix
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* refactor: elaborate wording in test
2019-12-14 16:41:47 -05:00
John A Maloney
c935d21f84
Fixed bad capture group in regex ( #37575 )
2019-12-13 22:16:30 -06:00
Randell Dawson
85e7fe45d5
fix(curriculum): use object.assign to prevent overwriting prototypes if user uses class instead of function ( #37648 )
...
* fix: use object.assign to prevent overwriting when using class
* fix: remove non-used isBinarySearchTree method
2019-12-13 15:04:05 -06:00
lasjorg
63b9be8faf
fix(challenge): account for browser zoom, add note to challenge (for width challenge) ( #37688 )
...
* fix(challenge): account for browser zoom, add note to challenge
* fix(challenge): use regex for width assert
* fix(challenge): remove note
* fix(challenge): revert to initial PR code
* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
classicmatsuo
33cec6b6f2
fix: updated instructions for install-and-set-up-mongoose ( #37908 )
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Kevin Matsuo <kmatsuo@ARDs-MacBook-Pro-2.local>
2019-12-13 16:23:11 +05:30
Randell Dawson
44ff327a38
fix(curriculum): make test more flexible for ( #37902 )
...
* make test more robust
* fix: changed test to ignore extra spaces in html
* Revert "make test more robust"
This reverts commit 89718eb5e5
.
2019-12-11 23:20:19 -05:00
Randell Dawson
cb3524ee31
fix: simplify challenge testString ( #37826 )
2019-12-07 15:47:08 -05:00
Randell Dawson
623c08cbfa
fix: removed semi-colon from regex ( #37881 )
2019-12-07 15:02:42 -05:00
Christoph Deil
dc5c0c7f82
Fix minor grammar issue in override-styles-in-subsequent-css.english.md ( #37871 )
2019-12-04 14:32:55 -08:00
Waldo Luis Ribeiro
8af54eb272
fix(curriculum): Technical language correction ( #37812 )
...
Technically, the prototype is not cloned; it is merely referenced.
2019-12-04 21:01:49 +00:00
Eze Rodriguez
68d0a15dbd
Update jump-straight-to-the-content-using-the-main-element.spanish.md ( #37253 )
...
Fixed to communicate the intended instructions correctly in Spanish.
2019-12-03 00:46:03 -08:00
nico-alvarez-eu
71b5918b01
Minor Spanish grammar fixes ( #36862 )
2019-12-03 00:37:38 -08:00
Chipiwiny94
bda0259c36
Made grammatical changes ( #36948 )
...
Grammar changes have been made to make proper use of "tu", as it was mixed with the formal person "Usted"
2019-12-03 00:34:10 -08:00
Luis Ignacio Collantes
975e59cd03
Fix grammar errors ( #37119 )
2019-12-03 00:32:22 -08:00
Randell Dawson
984a530905
fix(curriculum): added extra mongoose options to prevent log warnings ( #37693 )
...
* fix: added extra mongoose options to prevent log warnings
2019-12-03 13:12:27 +09:00
Randell Dawson
dd2fb28ee0
fix: make tests more robust ( #37830 )
2019-12-02 18:42:32 -05:00
Randell Dawson
a68e3ef39d
fix: change rating to ratings ( #37863 )
2019-12-02 17:25:11 -05:00
Randell Dawson
7454719334
fix(curriculum): Improved Use Recursion to Create a Countdown challenge ( #37548 )
...
* fix: improved recursive challenge
* fix: rewording of two challenges
* fix: add code tags
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-12-02 17:58:07 +01:00
Randell Dawson
a6766127cc
fix(curriculum): corrected test and added solution for Create a Hash table challenge ( #37582 )
...
* fix: corrected test and added solution
* fix: redefine hash
* fix: use defined hash
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-02 17:23:56 +01:00
Randell Dawson
d39dd970b6
fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge ( #37838 )
...
* fix: use regex to avoid diff in browsers
* fix: improve regex
2019-12-02 20:50:34 +05:30
Tom
9866d2f241
fix: grid column and grid row tests ( #37736 )
...
* fix: grid column and grid row tests
* fix: test text verbiage
* fix: add solution to pass build error
* fix: make test more readable
2019-12-01 10:02:24 +05:30
Randell Dawson
aac1c58374
fix(curriculum): make last test more robust for Uncomment HTML challenge ( #37843 )
...
* fix: correct last test
* fix: remove forgotten console.log
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-30 23:09:48 -05:00
Randell Dawson
58ca8ddf2a
fix: correct function name in test text ( #37839 )
2019-11-30 18:30:10 -05:00
Tom
da99033b77
fix: sum all primes description ( #37750 )
...
* fix: sum all primes description
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-30 16:33:37 -06:00
Wocanilo
cabfd25b40
MODIFIED convert-json-data-to-html to warn about XSS attacks (english) ( #37036 )
...
* MODIFIED convert-json-data-to-html to warn about XSS attacks (english)
* Forgotten newline in convert-json-data-to-html
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: suggested changes
* fix: added commas
2019-11-30 12:52:59 -06:00
Tim dinia
c331b12413
fix(curriculum): correct typo in nest one array within another array challenge instruction ( #37851 )
2019-11-29 10:07:51 +01:00
gloriaabreualves
dee5216eb3
fix text in portuguese ( #37509 )
...
Fix text in portuguese.
2019-11-28 17:13:18 -08:00
Randell Dawson
08bbd893d3
fix: switched order of first two bst challenges ( #37675 )
2019-11-27 12:12:58 +01:00
Randell Dawson
2c15bcbb43
fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures ( #37761 )
...
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
Randell Dawson
b7949087e3
fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges ( #37709 )
...
* fix: improve verbiage and add examples to challenges
* fix: condensed map method wording
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: remove leading space
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: improved verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened reduce challenge verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shorten verbiage related to reduce 2nd parameter
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened filter verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix; added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: improved verbiage of map method
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: shortened reduce verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: correct map method verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added word array
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added missing comma
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: changed u to sumOfAges
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: created one sentence out of many
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* fix: changed to on each iteration
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: fixed verbiage in filter and map challenges
2019-11-27 07:33:09 +05:30
Stryyder
58444af093
very minor grammar fix ( #37840 )
2019-11-26 15:53:18 -08:00
Randell Dawson
ba415184f6
fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce ( #37829 )
...
* fix: simplify challenge without using reduce
* fix: prevent user from adding new elements to sum to 10
* fix: add from
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-26 15:14:44 -05:00
lasjorg
ba927090fe
fix(challenge): account for browser zoom, add note to challenge (for height challenge) ( #37687 )
...
* fix(challenge): account for browser zoom, add note to challenge
* fix(challenge): use regex for height assert
* fix(challenge): remove note
* fix(challenge): revert to initial PR code
2019-11-25 19:40:21 -08:00
Randell Dawson
98bb2c1085
fix: added new test case to prevent invalid regex ( #37769 )
2019-11-25 20:25:24 -05:00
Kiara Barias
c1b3588e59
Basic JS challenge: use-prototype-properties link added ( #37802 )
...
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
2019-11-25 13:02:21 -06:00
Randell Dawson
4fbe02abba
fix(curriculum): Added necessary variable declarations for JSON APIs and Ajax challenges ( #37535 )
...
* fix: added necessary variable declarations
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: deleted unnecessary file
* fix: corrected some spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: indented code sections
2019-11-25 12:21:17 -06:00
mikemorr
62e1464eb7
change "given" to "adding" (Was: change "given" to "giving") ( #37823 )
...
* change "given" to "giving"
* change to "adding" as suggested
As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
2019-11-25 08:14:08 -08:00
Divyanshu
a987245e18
Added new test cases and corrected the solution for positive and negative lookahead for ensuring that strings beginning with numbers are not accepted ( #37485 )
...
* Added new test case '8pass99' for positive and negative lookahead
* Changed the pwRegex to reflect the new solution
* Updated the pwRegex to reflect the latest solution as on forum
* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
2019-11-24 17:11:20 -05:00
Waldo Luis Ribeiro
deb24f77b6
fix(curriculum): English editing ( #37814 )
...
* fix(curriculum): English editing
* fix(curriculum): English editing
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* Update use-class-syntax-to-define-a-constructor-function.english.md
2019-11-24 16:38:30 -05:00
Randell Dawson
dc1b59070e
fix: use arrow function syntax ( #37818 )
2019-11-24 02:37:11 -05:00
Waldo Luis Ribeiro
0c22313760
fix(curriculum): English editing ( #37815 )
...
* fix(curriculum): English editing
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-23 18:37:36 -05:00
Waldo Luis Ribeiro
70f736fe07
fix(curriculum): English editing ( #37816 )
2019-11-23 17:28:56 -05:00
Waldo Luis Ribeiro
5ea745d61f
fix(curriculum): English punctuation correction ( #37811 )
2019-11-22 06:35:10 -08:00
Waldo Luis Ribeiro
1fc71e6969
Update create-a-basic-javascript-object.english.md ( #37810 )
...
small spelling correction (everyday -> every day)
2019-11-22 06:34:34 -08:00
Randell Dawson
6fc32ab9b6
fix(curriculum): changed test text to use should for Front End Libraries ( #37762 )
...
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-22 13:44:40 +01:00
ibqu
9706bc47ff
Work on the space-evenly option for flexbox justify-content ( #37797 )
...
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).
In this commit I fix the space-evenly issues to some extent.
I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.
There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
2019-11-21 12:46:46 -05:00
Randell Dawson
c25916c9a2
fix(curriculum): changed test text to use should for Coding Interview Prep - part 2 of 2 ( #37766 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-20 10:01:31 -05:00
Randell Dawson
9cd57105af
fix(curriculum): changed test text to use should for Information Security and Quality Assurance ( #37763 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: remove unnecessary backslash
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: simplified text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: added period
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-20 09:58:14 -05:00
Randell Dawson
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-11-20 20:15:19 +05:30
Randell Dawson
c25fa49b5b
fix(curriculum): changed test text to use should for Coding Interview Prep - part 1 of 2 ( #37765 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: use singular of verb
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed punctuation
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: reworded test text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-19 20:13:45 -05:00
Lowell Hamilton
301d03df7b
Update add-font-awesome-icons-to-all-of-our-buttons.english.md ( #37668 )
...
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
2019-11-19 20:12:15 -05:00
Mo Zargham
437ba8b103
fix(curriculum): Read-search-ask link now point to correct url as noted in the issue ( #37753 )
...
* fix: broken Read-search-ask link now point to correct url
* fix: changed link to original forum link with more views
* fix: changed http links to correct version
* fix: link in help modal
2019-11-19 19:54:48 -05:00
Jefferson Oliveira
6921c3fecc
updates text for the location of the button ( #37764 )
...
fixes the text describing the location of the logs button, due to the new design of the glitch.com website
2019-11-19 10:54:14 -06:00
Arthur
890ce894cc
fix: correct typos in incidence matrix instruction ( #37779 )
2019-11-18 16:34:23 -08:00
Lowell Hamilton
73943994ff
Update add-font-awesome-icons-to-our-buttons.english.md ( #37667 )
...
Correct typo in instructions -- says to add the "fa" class instead of the "fas" class.
2019-11-17 07:55:39 -08:00
Marco Valero
fc1a923dd5
Made description of logical operator under "or operator" challenge a little more intuitive. ( #37772 )
...
* Update comparisons-with-the-logical-or-operator.english.md
* Update comparisons-with-the-logical-or-operator.english.md
* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
Tom
5ca2d2467a
fix: make help button use subforum topics ( #37741 )
...
* fix: make help button use subforum topics
* fix: add test to check that block exists
Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: improve error message
* Update curriculum/test/test-challenges.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
bitrixtoday
07b74ab70b
Improved translate russian language ( #37647 )
2019-11-15 22:36:52 +05:30
Randell Dawson
39df6a2b56
fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute ( #37699 )
...
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-15 10:14:54 -06:00
HoJeong Im
1fb202b742
fix(curriculum) - Add class box in json apis and ajax ( #37725 )
...
* Add class box in json apis and ajax
* Remove .box in id & add .box in seed code
2019-11-15 08:56:28 +01:00
Oliver Eyton-Williams
687c4fdb98
fix(client): add cache-busting hashes to chunks ( #37746 )
...
* fix(client): add cache-busting hashes to chunks
* fix: create cache-busting names for the workers
Prior to this PR the first webpack compilation gave the workers static
names. This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.
In order for Gatsby to find them, the names are added to the
config directory.
2019-11-15 01:43:44 +05:30
Kiara Barias
c4dc0b297f
Switch statement example updated ( #37757 )
...
* Switch statement example updated
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
Randell Dawson
55f95c2f74
fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value ( #37715 )
...
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity
* fix: use getComputedStyle intead of regex
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
Rohit Ambre
376b42637a
Updated file names required in the challenge ( #37737 )
...
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
2019-11-11 22:04:38 -05:00
Quincy Larson
e169779805
fix: update twitter image URL ( #37739 )
2019-11-12 02:32:17 +05:30
allison-strandberg
2c5453e3bd
Clarify instructions ( #37735 )
...
Closes #37734
2019-11-11 16:48:51 +01:00
Tom
6ff5e52b2d
Improve viewport unit readability ( #36673 )
...
* Improve viewport unit readability
Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
2019-11-11 10:24:02 +01:00
Matheus Genteluci
67e0f33a89
feat: Add Solution to handle click event - English ( #37069 )
2019-11-11 09:19:28 +01:00
Marco Valero
f3ee4f85ae
Changes to "access-array-data-with-indexes.english" challenge description ( #37730 )
...
* edited description to be a little more clear on how to access elements in an array through indeces
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
Tristan Michael Lawrence
5296d5c731
fix: removed trailing spaces, fixed a typo ( #37572 )
...
* removed trailing spaces, fixed a typo
* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00